Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-03 Thread Carl Eugen Hoyos
> Kieran Kunhya obe.tv> writes: > > > In general you should not be probing if there are > > descriptors because the descriptors are designed to > > make the codec detection unambiguous. > > I thought it should be exactly the other way around > if the probing returns a sufficiently high score: >

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-03 Thread Carl Eugen Hoyos
Kieran Kunhya obe.tv> writes: > In general you should not be probing if there are > descriptors because the descriptors are designed to > make the codec detection unambiguous. I thought it should be exactly the other way around if the probing returns a sufficiently high score: http://samples.

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-03 Thread Kieran Kunhya
My question is not really about testcases etc but more why you decided to not include the other descriptor types. I guess I can send a patch to fix that. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-02 Thread Michael Niedermayer
On Wed, Sep 03, 2014 at 04:24:29AM +0200, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 02:37:48AM +0100, Kieran Kunhya wrote: > > On 3 September 2014 01:40, Michael Niedermayer wrote: > > > On Wed, Sep 03, 2014 at 12:59:53AM +0100, Kieran Kunhya wrote: > > >> Patch not sent to ML so couldn

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-02 Thread Michael Niedermayer
On Wed, Sep 03, 2014 at 02:37:48AM +0100, Kieran Kunhya wrote: > On 3 September 2014 01:40, Michael Niedermayer wrote: > > On Wed, Sep 03, 2014 at 12:59:53AM +0100, Kieran Kunhya wrote: > >> Patch not sent to ML so couldn't review: > >> > >> Why have you only changed the code to favour DESC_types

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-02 Thread Kieran Kunhya
On 3 September 2014 01:40, Michael Niedermayer wrote: > On Wed, Sep 03, 2014 at 12:59:53AM +0100, Kieran Kunhya wrote: >> Patch not sent to ML so couldn't review: >> >> Why have you only changed the code to favour DESC_types and not other types? > > because thats what was needed to fix Ticket3766,

Re: [FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-02 Thread Michael Niedermayer
On Wed, Sep 03, 2014 at 12:59:53AM +0100, Kieran Kunhya wrote: > Patch not sent to ML so couldn't review: > > Why have you only changed the code to favour DESC_types and not other types? because thats what was needed to fix Ticket3766, which was what the commit tried to do. We might want to chan

[FFmpeg-devel] Patch: 42507534977e2108e397a381357ee2db209475f6

2014-09-02 Thread Kieran Kunhya
Patch not sent to ML so couldn't review: Why have you only changed the code to favour DESC_types and not other types? Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel