Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-11-11 Thread James Almer
On 11/11/2018 7:20 PM, James Almer wrote: > On 11/8/2018 6:31 PM, Martin Vignali wrote: >> Le dim. 28 oct. 2018 à 12:59, Martin Vignali a >> écrit : >> >>> Thanks for the comments >>> >>> New patch in attach >>> >>> - Change the options, to only authorized few value in prores frame (based >>> on r

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-11-11 Thread James Almer
On 11/8/2018 6:31 PM, Martin Vignali wrote: > Le dim. 28 oct. 2018 à 12:59, Martin Vignali a > écrit : > >> Thanks for the comments >> >> New patch in attach >> >> - Change the options, to only authorized few value in prores frame (based >> on rdd36). >> - Change option name to match setparams fi

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-11-08 Thread Martin Vignali
Le dim. 28 oct. 2018 à 12:59, Martin Vignali a écrit : > Thanks for the comments > > New patch in attach > > - Change the options, to only authorized few value in prores frame (based > on rdd36). > - Change option name to match setparams filter > - Include intreadwrite instead of bytestream > - D

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-28 Thread Martin Vignali
Thanks for the comments New patch in attach - Change the options, to only authorized few value in prores frame (based on rdd36). - Change option name to match setparams filter - Include intreadwrite instead of bytestream - Do not modify the property if set to -1 - Move av_packet_make_writable at

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-27 Thread James Almer
On 10/24/2018 5:25 PM, Martin Vignali wrote: > New patch in attach > > 001 : remove dead comment, add av_packet_make_writable > 002 : change the test to use md5 and didn't use ffprobe. Also change color > property > > I will try to add prores to cbs later. Any tips for this ? Grab one of the sim

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-24 Thread Martin Vignali
New patch in attach 001 : remove dead comment, add av_packet_make_writable 002 : change the test to use md5 and didn't use ffprobe. Also change color property I will try to add prores to cbs later. Any tips for this ? Martin 0002-fate-prores_metadata_bsf-add-test-for-setting-color.patch Descri

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread Mark Thompson
On 22/10/18 21:53, Martin Vignali wrote: > From 312b153d2b92012cacd8a189d34738de9bdfa615 Mon Sep 17 00:00:00 2001 > From: Martin Vignali > Date: Mon, 22 Oct 2018 22:46:05 +0200 > Subject: [PATCH 1/2] avcodec : add prores_metadata bsf for set the color > property of each prores file > > --- > d

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread James Almer
On 10/22/2018 6:44 PM, Martin Vignali wrote: >> >> Could you look into adding ProRes bitstream parsing support to the CBS >> framework? It would be ideal for a filter like this. >> >> Hello, > > The only metadata, which seems to have an interest to be edited (color > property), is at the start of

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread Martin Vignali
> > Could you look into adding ProRes bitstream parsing support to the CBS > framework? It would be ideal for a filter like this. > > Hello, The only metadata, which seems to have an interest to be edited (color property), is at the start of every prores frame, no need to go deeper to edit these t

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread James Almer
On 10/20/2018 9:32 AM, Martin Vignali wrote: > Hello, > > Patch in attach add a bsf filter to set color property of a prores frame > > Can be used, to set all frames of prores file to the same value > (avoid color shift on some frame depending of the software used to decode > the file) > or fix t

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread Martin Vignali
> > fails on mips qemu > > Thanks for testing. New patch in attach, 001 : unchanged 002 : limit frame entries for ffprobe part, in order to not have pix_fmt in the output. Martin 0001-avcodec-add-prores_metadata-bsf-for-set-the-color.patch Description: Binary data 0002-fate-prores_metadata_bs

Re: [FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-22 Thread Michael Niedermayer
On Sat, Oct 20, 2018 at 02:32:20PM +0200, Martin Vignali wrote: > Hello, > > Patch in attach add a bsf filter to set color property of a prores frame > > Can be used, to set all frames of prores file to the same value > (avoid color shift on some frame depending of the software used to decode > t

[FFmpeg-devel] avcodec : add prores_metadata bsf and fate test

2018-10-20 Thread Martin Vignali
Hello, Patch in attach add a bsf filter to set color property of a prores frame Can be used, to set all frames of prores file to the same value (avoid color shift on some frame depending of the software used to decode the file) or fix the value, for file created with incorrect metadata. Martin