Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread wm4
On Thu, 3 Dec 2015 08:26:21 +0100 Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > > There was no reason AFAIK for making AV_CRC_24_IEEE 12. > > The reason was to leave room for the fork to add its own new constants > without causing ABI

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > Except that nobody actually did that. It was a thing that was tried > once, went bust, but somehow it was kept. Stop making statements about things you do not know. You were not behind all Debian and Gentoo users' back at the time, nor did you have

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > Too small sample size, One is enough to refute "nobody". > I never even doubted that it worked at the beginning Then stop bitching, because it is exactly what this discussion is abut: it DID work, it DID make users' life easier. It no longer

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Ganesh Ajjanagadde
On Thu, Dec 3, 2015 at 2:26 AM, Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : >> There was no reason AFAIK for making AV_CRC_24_IEEE 12. > > The reason was to leave room for the fork to add its own new constants > without causing ABI

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Clément Bœsch
On Thu, Dec 03, 2015 at 10:08:50AM +0100, wm4 wrote: > On Thu, 3 Dec 2015 09:17:22 +0100 > Nicolas George wrote: > > > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > > You could just append them to the end, like all new constants. > > > > That does not prevent ABI

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > You could just append them to the end, like all new constants. That does not prevent ABI incompatibilities. > But someone preferred to make life harder and worse for everyone by > trying to keep the FFmpeg ABI somewhat compatible to Libav Please

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Paul B Mahol
On 12/3/15, Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, wm4 a ecrit : >> Too small sample size, > > One is enough to refute "nobody". > >> I never even doubted that it worked at the beginning > > Then stop bitching, because it is exactly what this discussion is abut:

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread wm4
On Thu, 3 Dec 2015 09:17:22 +0100 Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > You could just append them to the end, like all new constants. > > That does not prevent ABI incompatibilities. It removes the need for such hacks. > > But someone

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread wm4
On Thu, 3 Dec 2015 11:02:38 +0100 Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > Except that nobody actually did that. It was a thing that was tried > > once, went bust, but somehow it was kept. > > Stop making statements about things you do not

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > So the goal is not to make it simple to write application code in a way > that will be ABI compatible with newer FFmpeg minor releases? Stop being a caricature. The goal was to be ABI-compatible with the fork. Considering the hostile stance of the

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread wm4
On Thu, 3 Dec 2015 10:19:16 +0100 Nicolas George wrote: > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > So the goal is not to make it simple to write application code in a way > > that will be ABI compatible with newer FFmpeg minor releases? > > Stop being a caricature.

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-02 Thread Nicolas George
Le tridi 13 frimaire, an CCXXIV, Ganesh Ajjanagadde a écrit : > There was no reason AFAIK for making AV_CRC_24_IEEE 12. The reason was to leave room for the fork to add its own new constants without causing ABI incompatibilities. Regards, -- Nicolas George signature.asc Description: