Re: [FFmpeg-devel] ffserver jpg patch

2015-05-11 Thread wm4
On Sun, 10 May 2015 22:31:27 -0600 ill wrote: > It applies for me. > Konsole output > $ patch -p1 patching file ffserver.c > patching file ffserver_config.c > patching file ffserver_config.h > Hunk #1 succeeded at 79 with fuzz 1. > patching file libavformat/allformats.c > patching file libavfor

Re: [FFmpeg-devel] [PATCH] avformat/subtitles: Use size_t for len

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 07:30:53AM +0200, Clément Bœsch wrote: > On Sun, May 10, 2015 at 03:38:40PM +0200, Michael Niedermayer wrote: > > string length could theoretically be larger than int > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/subtitles.c |4 ++-- > > libavform

Re: [FFmpeg-devel] [PATCH] fate: Test pullup and fieldmatch with 5 instead of 1 frame

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 07:34:11AM +0200, Clément Bœsch wrote: > On Mon, May 11, 2015 at 12:44:14AM +0200, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > tests/fate-run.sh|3 ++- > > tests/fate/filter-video.mak |4 ++-- >

Re: [FFmpeg-devel] [PATCH 1/2] configure: disabled -mips64 option for loongson and remove redundant flags

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 12:38:46PM +0800, 周晓勇 wrote: > From 9837274dcee5e1900160901cf28d883246a7ecfb Mon Sep 17 00:00:00 2001 > From: Zhou Xiaoyong > Date: Mon, 11 May 2015 03:28:52 -0400 > Subject: [PATCH 1/2] configure: disabled -mips64 option for loongson and > remove redundant flags > > 1.Op

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread Nicolas George
Le duodi 22 floréal, an CCXXIII, James Almer a écrit : > If this is meant to solve the whole debate from the "Tell users about > -use_absolute_path" thread, then i think it's a bit overkill. "Set > to " is generic enough that works in any situation, be > it for API user or ffmpeg.c, and could be u

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread wm4
On Mon, 11 May 2015 13:17:16 +0200 Nicolas George wrote: > Le duodi 22 floréal, an CCXXIII, James Almer a écrit : > > If this is meant to solve the whole debate from the "Tell users about > > -use_absolute_path" thread, then i think it's a bit overkill. "Set > > to " is generic enough that works

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread Nicolas George
Le duodi 22 floréal, an CCXXIII, wm4 a écrit : > This doesn't work because the log callback is process-global. There may > be multiple independent ffmpeg users in the same process. Please do not pollute the discussion with a completely unrelated issue. Regards, -- Nicolas George signature.a

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 02:26:24AM -0300, James Almer wrote: > On 10/05/15 10:18 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/opt.c | 32 > > libavutil/opt.h | 21 + > > 2 files changed, 53 ins

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread Clément Bœsch
On Mon, May 11, 2015 at 02:16:15PM +0200, Michael Niedermayer wrote: > On Mon, May 11, 2015 at 02:26:24AM -0300, James Almer wrote: > > On 10/05/15 10:18 PM, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavutil/opt.c | 32

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: optimize mpegvideo decoder for Loongson-3 v1

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 12:41:51PM +0800, 周晓勇 wrote: > From 3d5a9d0d38c96d6b6ec51b082102f3a231b5b881 Mon Sep 17 00:00:00 2001 > From: ZhouXiaoyong > Date: Mon, 11 May 2015 09:27:00 +0800 > Subject: [PATCH 2/2] avcodec: optimize mpegvideo decoder for Loongson-3 v1 > > Signed-off-by: ZhouXiaoyong

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread Nicolas George
Le duodi 22 floréal, an CCXXIII, Clement Boesch a écrit : > > also the message may originate from a libavcodec used by another lib > > instead of the user application > > > > I think the average user would benefit from having the option dispayed > > with a exactly useable as is syntax > > I suppo

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread wm4
On Mon, 11 May 2015 15:43:18 +0200 Nicolas George wrote: > The issue that lead to this discussion is the tip of the iceberg. Not even > that, is is just a tiny ice peak near the surface amongst dozens of similar > and more pressing issues. We are only discussing it because someone had too > much

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 03:43:18PM +0200, Nicolas George wrote: > Le duodi 22 floréal, an CCXXIII, Clement Boesch a écrit : > > > also the message may originate from a libavcodec used by another lib > > > instead of the user application > > > > > > I think the average user would benefit from havin

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread wm4
On Mon, 11 May 2015 17:06:50 +0200 Michael Niedermayer wrote: > On Mon, May 11, 2015 at 03:43:18PM +0200, Nicolas George wrote: > > Le duodi 22 floréal, an CCXXIII, Clement Boesch a écrit : > > > > also the message may originate from a libavcodec used by another lib > > > > instead of the user ap

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: use x265 Multi-library Interface to query the API

2015-05-11 Thread Derek Buitenhuis
On 5/11/2015 5:57 AM, Gopu Govindaswamy wrote: > Thanks for review, Do i need to send a new patch or this patch itself can > move into ffmpeg repo? I fixed and pushed it. I was out of the country for a few days, hence the delay. - Derek ___ ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] avformat: add callback for opening further files

2015-05-11 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/avformat.h |6 ++ libavformat/utils.c|1 + 2 files changed, 7 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 339ff52..2e840a7 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -

[FFmpeg-devel] [PATCH 2/2] avformat/mov: Use open_cb() if set

2015-05-11 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 0f63d22..02de755 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2602,6 +2602,11 @@ static void mov

Re: [FFmpeg-devel] [PATCH 1/2] avformat: add callback for opening further files

2015-05-11 Thread wm4
On Mon, 11 May 2015 17:55:57 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/avformat.h |6 ++ > libavformat/utils.c|1 + > 2 files changed, 7 insertions(+) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 339ff5

[FFmpeg-devel] [PATCH] id3v2: catch avio_read errors in check_tag

2015-05-11 Thread Andreas Cadhalpun
Since len is an unsigned int, the comparison is currently treated as unsigned and thus ignores all errors from avio_read. Thus cast len to int, which is unproblematic, because at that point len is between 0 and 4. This fixes 'Conditional jump or move depends on uninitialised value' valgrind warni

Re: [FFmpeg-devel] [PATCH] id3v2: catch avio_read errors in check_tag

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 08:07:49PM +0200, Andreas Cadhalpun wrote: > Since len is an unsigned int, the comparison is currently treated as > unsigned and thus ignores all errors from avio_read. > > Thus cast len to int, which is unproblematic, because at that point len > is between 0 and 4. > > Th

Re: [FFmpeg-devel] [PATCH 1/2] avformat: add callback for opening further files

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 06:12:25PM +0200, wm4 wrote: > On Mon, 11 May 2015 17:55:57 +0200 > Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/avformat.h |6 ++ > > libavformat/utils.c|1 + > > 2 files changed, 7 insertions(+) > > > > di

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Use open_cb() if set

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 05:55:58PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 1/4] avutil: add av_format_option_for_user() callback system

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 03:18:16AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/opt.c | 32 > libavutil/opt.h | 21 + > 2 files changed, 53 insertions(+) The open_cb() patch reduces the need for

[FFmpeg-devel] [PATCH] examples/demuxing_decoding: use correct size of video_dst_data[0]

2015-05-11 Thread Andreas Cadhalpun
Currently video_dst_bufsize is used, which is set to the return value of av_image_alloc, but this is the combined size of all planes. Only the first plane is written in fwrite. The size of the first plane is the product of video_dst_linesize[0] and height. This fixes 'Syscall param write(buf) poi

Re: [FFmpeg-devel] [PATCH] examples/demuxing_decoding: use correct size of video_dst_data[0]

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 11:34:32PM +0200, Andreas Cadhalpun wrote: > Currently video_dst_bufsize is used, which is set to the return value > of av_image_alloc, but this is the combined size of all planes. > Only the first plane is written in fwrite. > > The size of the first plane is the product o

Re: [FFmpeg-devel] [PATCH] ff_h[yc]scale_fast_mmext always clobbers %rbx

2015-05-11 Thread Nick Lewycky
On 8 May 2015 at 14:28, Michael Niedermayer wrote: > On Fri, May 08, 2015 at 12:43:20PM -0700, Nick Lewycky wrote: > > On 8 May 2015 at 12:06, Michael Niedermayer wrote: > > > > > On Fri, May 08, 2015 at 10:50:49AM -0700, Nick Lewycky wrote: > > > > On 6 May 2015 at 18:03, Michael Niedermayer >

Re: [FFmpeg-devel] ffserver jpg patch

2015-05-11 Thread ill
That is what I sent. It is the same file. I have run the git format-patch -1 on this as well, not that the command seems to do anything to the patch file itself. On Sun, 10 May 2015 22:31:27 -0600 ill wrote: It applies for me. Konsole output $ patch -p1 You are supposed to send this patc

Re: [FFmpeg-devel] [PATCH] ff_h[yc]scale_fast_mmext always clobbers %rbx

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 03:55:40PM -0700, Nick Lewycky wrote: > On 8 May 2015 at 14:28, Michael Niedermayer wrote: > > > On Fri, May 08, 2015 at 12:43:20PM -0700, Nick Lewycky wrote: > > > On 8 May 2015 at 12:06, Michael Niedermayer wrote: > > > > > > > On Fri, May 08, 2015 at 10:50:49AM -0700,

Re: [FFmpeg-devel] ffserver jpg patch

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 05:02:34PM -0600, ill wrote: > That is what I sent. It is the same file. I have run the git > format-patch -1 on this as well, not that the command seems to do > anything to the patch file itself. you would have to attach the file generated by git format-patch also you of c

Re: [FFmpeg-devel] ffserver jpg patch

2015-05-11 Thread ill
I attached the file made by Konsole output git commit -p and then the format patch command. I wrote that caligula person as the author because he was the one who posted the modified code stuff that I used. On Mon, May 11, 2015 at 05:02:34PM -0600, ill wrote: That is what I sent. It is the sam

[FFmpeg-devel] [PATCH] lavf/img2dec: add option to disable pattern matching

2015-05-11 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/demuxers.texi | 4 libavformat/img2.h| 3 ++- libavformat/img2dec.c | 9 ++--- libavformat/version.h | 2 +- 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 3f7c45e..b7ddebb 100644 --

Re: [FFmpeg-devel] [PATCH 2/2] avcodec: optimize mpegvideo decoder for Loongson-3 v1

2015-05-11 Thread 周晓勇
> -原始邮件- > 发件人: "Michael Niedermayer" > 发送时间: 2015年5月11日 星期一 > 收件人: "FFmpeg development discussions and patches" > 抄送: > 主题: Re: [FFmpeg-devel] [PATCH 2/2] avcodec: optimize mpegvideo decoder for > Loongson-3 v1 > > On Mon, May 11, 2015 at 12:41:51PM +0800, 周晓勇 wrote: > > From 3d5a9

Re: [FFmpeg-devel] [PATCH 1/2] configure: disabled -mips64 option for loongson and remove redundant flags

2015-05-11 Thread 周晓勇
> -原始邮件- > 发件人: "Michael Niedermayer" > 发送时间: 2015年5月11日 星期一 > 收件人: "FFmpeg development discussions and patches" > 抄送: > 主题: Re: [FFmpeg-devel] [PATCH 1/2] configure: disabled -mips64 option for > loongson and remove redundant flags > > On Mon, May 11, 2015 at 12:38:46PM +0800, 周晓勇

Re: [FFmpeg-devel] [PATCH 1/2] configure: disabled -mips64 option for loongson and remove redundant flags

2015-05-11 Thread Michael Niedermayer
On Tue, May 12, 2015 at 10:32:19AM +0800, 周晓勇 wrote: > > > > > -原始邮件- > > 发件人: "Michael Niedermayer" > > 发送时间: 2015年5月11日 星期一 > > 收件人: "FFmpeg development discussions and patches" > > 抄送: > > 主题: Re: [FFmpeg-devel] [PATCH 1/2] configure: disabled -mips64 option for > > loongson and r