Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread Nicolas George
Le decadi 30 brumaire, an CCXXIV, Stefano Sabatini a écrit : > Yes, updated patch with EAGAIN (if this is fine, I'll send patches to > fix the examples). The API use seems... not good, because it is not possible, but at least ok. > In my case the EAGAIN is triggered by the flv demuxer code in >

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2015-11-20 Thread Ganesh Ajjanagadde
On Fri, Nov 20, 2015 at 9:30 AM, Ronald S. Bultje wrote: > Hi Ganesh, > > On Fri, Nov 20, 2015 at 8:42 AM, Ganesh Ajjanagadde > wrote: >> >> On Wed, Nov 18, 2015 at 8:26 AM, Ganesh Ajjanagadde >> wrote: >> > On Wed, Nov 18, 2015 at 7:31

Re: [FFmpeg-devel] [PATCH] avfilter/all: handle ff_formats_unref correctly

2015-11-20 Thread Ganesh Ajjanagadde
On Sun, Nov 15, 2015 at 7:21 PM, Ganesh Ajjanagadde wrote: > Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning > up usage of the formats API, and in particular fixed possible NULL pointer >

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/resample2: replace #define by typedef

2015-11-20 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 9:30 AM, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 08:14:15AM -0500, Ganesh Ajjanagadde wrote: >> See e.g >> https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c >> for rationale. >> >> Signed-off-by: Ganesh

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2015-11-20 Thread Ronald S. Bultje
Hi Ganesh, On Fri, Nov 20, 2015 at 8:42 AM, Ganesh Ajjanagadde wrote: > On Wed, Nov 18, 2015 at 8:26 AM, Ganesh Ajjanagadde > wrote: > > On Wed, Nov 18, 2015 at 7:31 AM, wm4 wrote: > >> On Tue, 17 Nov 2015 17:39:31 -0500 > >> Ganesh

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/lpc: replace #define by typedef

2015-11-20 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 9:29 AM, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 08:14:08AM -0500, Ganesh Ajjanagadde wrote: >> See e.g >> https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c >> for rationale. >> >> Signed-off-by: Ganesh

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2015-11-20 Thread Ganesh Ajjanagadde
On Wed, Nov 18, 2015 at 8:26 AM, Ganesh Ajjanagadde wrote: > On Wed, Nov 18, 2015 at 7:31 AM, wm4 wrote: >> On Tue, 17 Nov 2015 17:39:31 -0500 >> Ganesh Ajjanagadde wrote: >> >>> ffio_ensure_seekback can fail due to e.g ENOMEM. This

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/faanidct: replace #define by typedef

2015-11-20 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 9:29 AM, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 08:14:14AM -0500, Ganesh Ajjanagadde wrote: >> See e.g >> https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c >> for rationale. >> >> Signed-off-by: Ganesh

Re: [FFmpeg-devel] [PATCH 6/8] tests/tiny_ssim: replace #define by typedef

2015-11-20 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 9:22 AM, Ganesh Ajjanagadde wrote: > On Thu, Nov 19, 2015 at 9:19 AM, Hendrik Leppkes wrote: >> On Thu, Nov 19, 2015 at 2:50 PM, Ganesh Ajjanagadde >> wrote: >>> On Thu, Nov 19, 2015 at 8:36 AM, Ronald S.

Re: [FFmpeg-devel] [PATCH] all: use M_SQRT1_2, M_SQRT2, M_PI

2015-11-20 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 2:35 PM, Paul B Mahol wrote: > On 11/19/15, Ganesh Ajjanagadde wrote: >> On Thu, Nov 19, 2015 at 12:35 PM, Nicolas George wrote: >>> Le nonidi 29 brumaire, an CCXXIV, Derek Buitenhuis a ecrit : Paul uses FreeBSD,

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2015-11-20 Thread Ronald S. Bultje
Hi, On Fri, Nov 20, 2015 at 9:40 AM, Ganesh Ajjanagadde wrote: > On Fri, Nov 20, 2015 at 9:30 AM, Ronald S. Bultje > wrote: > > Hi Ganesh, > > > > On Fri, Nov 20, 2015 at 8:42 AM, Ganesh Ajjanagadde > > wrote: > >> > >> On Wed, Nov 18,

Re: [FFmpeg-devel] [PATCH] avfilter/WIP: add streamselect filter

2015-11-20 Thread Clément Bœsch
On Thu, Nov 19, 2015 at 06:47:07PM +0100, Nicolas George wrote: > Le nonidi 29 brumaire, an CCXXIV, Clement Boesch a écrit : > > - I always receive frames from the first input link... I suppose I need > > to write a "smart" request_frame callback, but things changed recently > > so maybe there

Re: [FFmpeg-devel] [PATCH 3/8] avcodec/ac3: replace #define by typedef

2015-11-20 Thread Ganesh Ajjanagadde
On Thu, Nov 19, 2015 at 10:55 AM, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 08:14:10AM -0500, Ganesh Ajjanagadde wrote: >> See e.g >> https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c >> for rationale. >> >> Signed-off-by: Ganesh

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2015-11-20 Thread Ganesh Ajjanagadde
On Fri, Nov 20, 2015 at 9:48 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Nov 20, 2015 at 9:40 AM, Ganesh Ajjanagadde > wrote: >> >> On Fri, Nov 20, 2015 at 9:30 AM, Ronald S. Bultje >> wrote: >> > Hi Ganesh, >> > >> > On Fri, Nov 20,

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-20 Thread Clément Bœsch
On Fri, Nov 20, 2015 at 10:36:36AM +0100, Clément Bœsch wrote: > On Fri, Nov 20, 2015 at 10:33:04AM +0100, Clément Bœsch wrote: > [...] > > > i think this doesnt support libavcodec/tpeldsp.c as used in svq3 > > > that would need a motion_xy / 3 > > > > > > i might be missing something but > > >

Re: [FFmpeg-devel] [PATCH] avcodec/h264, videotoolbox: do not return invalid frames on failure

2015-11-20 Thread wm4
On Tue, 17 Nov 2015 15:19:29 +0100 wm4 wrote: > If videotoolbox_common_end_frame failed, then the AVFrame was returned > to the API user with the dummy buffer (in AVFrame.buf[0]) still set, and > the decode call indicating success. > > These "half-set" AVFrames with dummy

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread wm4
On Fri, 20 Nov 2015 13:30:50 +0100 Stefano Sabatini wrote: > On date Wednesday 2015-11-18 15:21:15 +0100, Nicolas George encoded: > > Le septidi 27 brumaire, an CCXXIV, Stefano Sabatini a écrit : > > > Fix demuxing of files for which the demuxer returns AVERROR(EAGAIN) at >

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-20 Thread Clément Bœsch
On Fri, Nov 20, 2015 at 10:33:04AM +0100, Clément Bœsch wrote: [...] > > i think this doesnt support libavcodec/tpeldsp.c as used in svq3 > > that would need a motion_xy / 3 > > > > i might be missing something but > > > > * Motion vector > > * src_x = dst_x + motion_x / motion_scale > > *

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

2015-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2015 at 12:16:09AM +0100, Andreas Cadhalpun wrote: > On 19.11.2015 01:31, Michael Niedermayer wrote: > > On Thu, Nov 19, 2015 at 12:31:17AM +0100, Andreas Cadhalpun wrote: > >> So far so good. However, the next time sbr_dequant is called this breaks: > >> noise_facs[1][0].exp = 6 -

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/select: add support for concatdec_select option

2015-11-20 Thread Marton Balint
On Mon, 16 Nov 2015, Stefano Sabatini wrote: +@item concatdec_select +The concat demuxer can set the @var{lavf.concat.start_time} and the +@var{lavf.concat.duration} packet metadata values which are also present in the +decoded frames. + +The @var{concatdec_select} variable is -1 if the

[FFmpeg-devel] [PATCHv2 5/5] lavfi/select: add support for concatdec_select option

2015-11-20 Thread Marton Balint
This option can be used to select useful frames from an ffconcat file which is using inpoints and outpoints but where the source files are not intra frame only. Signed-off-by: Marton Balint --- doc/filters.texi | 20 libavfilter/f_select.c | 27

Re: [FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-20 Thread Clément Bœsch
On Mon, Nov 16, 2015 at 02:49:05AM +0100, Michael Niedermayer wrote: > On Thu, Nov 12, 2015 at 03:03:33PM +0100, Clément Bœsch wrote: > > --- > > libavcodec/mpegvideo.c | 36 +--- > > libavcodec/snowdec.c | 4 > > libavfilter/vf_codecview.c | 7

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread Stefano Sabatini
On date Wednesday 2015-11-18 15:21:15 +0100, Nicolas George encoded: > Le septidi 27 brumaire, an CCXXIV, Stefano Sabatini a écrit : > > Fix demuxing of files for which the demuxer returns AVERROR(EAGAIN) at > > some point. Also returns error code to the caller in case of different > > non EOF

[FFmpeg-devel] [PATCH] avutil/motion_vector: export subpel motion information

2015-11-20 Thread Clément Bœsch
--- FATE test changes because of the replacement of >>n with /(1<

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread Nicolas George
Le decadi 30 brumaire, an CCXXIV, Stefano Sabatini a écrit : > Please elaborate, what does it means that "it is not possible"? It is no longer busy-waiting, but it is still polling: ffprobe will wake up a hundred times per second waiting for network packets that may not come for several minutes

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread wm4
On Fri, 20 Nov 2015 16:44:56 +0100 Nicolas George wrote: > Le decadi 30 brumaire, an CCXXIV, Stefano Sabatini a écrit : > > Please elaborate, what does it means that "it is not possible"? > > It is no longer busy-waiting, but it is still polling: ffprobe will wake up > a

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread Nicolas George
Le decadi 30 brumaire, an CCXXIV, wm4 a écrit : > Not sure why you argue for a better API. The semantics are to block > until there's a new packet, or EOF. That's it. Did you not realize yet that blocking APIs are unsuited for any complex application? Even ffmpeg.c suffers from this, and it is

Re: [FFmpeg-devel] [PATCHv2 5/5] lavfi/select: add support for concatdec_select option

2015-11-20 Thread Stefano Sabatini
On date Friday 2015-11-20 13:54:26 +0100, Marton Balint encoded: > This option can be used to select useful frames from an ffconcat file which is > using inpoints and outpoints but where the source files are not intra frame > only. > > Signed-off-by: Marton Balint > --- >

Re: [FFmpeg-devel] [PATCH] avfilter/WIP: add streamselect filter

2015-11-20 Thread Nicolas George
Le decadi 30 brumaire, an CCXXIV, Clement Boesch a écrit : > Alright, so if I understand well, all I have to do is implement a > forwarding such as this: > > static int request_frame(AVFilterLink *outlink) > { > AVFilterContext *ctx = outlink->src; > StreamSelectContext *s = ctx->priv; >

Re: [FFmpeg-devel] [PATCH] Map description metadata to ©inf tag in .mov wrapper

2015-11-20 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 11:20:04AM -0500, Brian Wheeler wrote: > The description metadata isn't mapped to anything when the mov > wrapper is used.This patch maps description to ©inf for both > reading and writing. > The change to mov.c makes the mapping round-trip. > > Signed-off-by: Brian

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread Stefano Sabatini
On date Friday 2015-11-20 14:35:20 +0100, Nicolas George encoded: > Le decadi 30 brumaire, an CCXXIV, Stefano Sabatini a écrit : > > Yes, updated patch with EAGAIN (if this is fine, I'll send patches to > > fix the examples). > > The API use seems... not good, because it is not possible, but at

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread wm4
On Fri, 20 Nov 2015 17:09:50 +0100 Nicolas George wrote: > Le decadi 30 brumaire, an CCXXIV, wm4 a écrit : > > Not sure why you argue for a better API. The semantics are to block > > until there's a new packet, or EOF. That's it. > > Did you not realize yet that blocking APIs

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2015-11-20 Thread Ganesh Ajjanagadde
[...] On Fri, Nov 20, 2015 at 9:30 AM, Ronald S. Bultje wrote: > He pointed out that you added multiple instances of the exact same line in > the code: > > av_log(s, AV_LOG_WARNING, "ffio_ensure_seekback(): %s\n", av_err2str(ret)); > > which is both duplicate as well as

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2015-11-20 Thread Michael Niedermayer
On Tue, Nov 17, 2015 at 05:39:31PM -0500, Ganesh Ajjanagadde wrote: > ffio_ensure_seekback can fail due to e.g ENOMEM. This return value is > checked here and a diagnostic is logged. > > All usage of ffio_ensure_seekback in the codebase now has the return value > checked. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread Nicolas George
Le decadi 30 brumaire, an CCXXIV, wm4 a écrit : > Interrupt callback. Which requires polling. You are responsible for climate change and poor battery life. Seriously, go read a book on proper I/O design or ten. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2015-11-20 Thread Ronald S. Bultje
Hi, On Fri, Nov 20, 2015 at 11:39 AM, Ganesh Ajjanagadde wrote: > [...] > On Fri, Nov 20, 2015 at 9:30 AM, Ronald S. Bultje > wrote: > > He pointed out that you added multiple instances of the exact same line > in > > the code: > > > > av_log(s,

Re: [FFmpeg-devel] [PATCH 2/5] concatdec: calculate duration early if outpoint is known

2015-11-20 Thread Marton Balint
On Sat, 14 Nov 2015, Marton Balint wrote: On Fri, 13 Nov 2015, Nicolas George wrote: Le decadi 20 brumaire, an CCXXIV, Marton Balint a écrit : Signed-off-by: Marton Balint --- libavformat/concatdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH 2/3] ffserver: Use AVOption API to access ffm demuxer instead of direct access depending on ABI

2015-11-20 Thread Andreas Cadhalpun
On 20.11.2015 03:26, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > ffserver.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ffserver.c b/ffserver.c >

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread wm4
On Fri, 20 Nov 2015 18:35:33 +0100 Nicolas George wrote: > Le decadi 30 brumaire, an CCXXIV, wm4 a écrit : > > Uh what? Blocking I/O is perfectly fine, especially for something like > > a demuxer, or something that does file I/O. Just use threads. > > Just use threads... I

Re: [FFmpeg-devel] [PATCH 1/3] avformat/ffmdec: Add cleaner API for ffserver to interface without depending on internal ABI

2015-11-20 Thread Andreas Cadhalpun
On 20.11.2015 03:26, Michael Niedermayer wrote: > From: Michael Niedermayer > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffm.h |2 ++ > libavformat/ffmdec.c | 14 ++ > libavformat/version.h |2 +- > 3

Re: [FFmpeg-devel] [PATCH] AAC sequence header data setup if stream copy

2015-11-20 Thread Michael Niedermayer
On Wed, Nov 18, 2015 at 09:56:05PM +0200, Maksym Veremeyenko wrote: > On 18.11.2015 19:37, Michael Niedermayer wrote: > [...] > >the first field of the context must be a AVClass > > updated patch attached > > -- > Maksym Veremeyenko > > ffmpeg.c |1 > libavformat/flvenc.c |

Re: [FFmpeg-devel] [PATCH] ffprobe: do not exit in case the demuxer returns AVERROR(EAGAIN)

2015-11-20 Thread wm4
On Fri, 20 Nov 2015 19:00:31 +0100 Nicolas George wrote: > Le decadi 30 brumaire, an CCXXIV, wm4 a écrit : > > Interrupt callback. > > Which requires polling. I never claimed otherwise. But the topic of the discussion is whether Stefano's patch adds or fixes a bug. Even if

Re: [FFmpeg-devel] [PATCH] swscale/arm: add ff_nv{12, 21}_to_{argb, rgba, abgr, bgra}_neon

2015-11-20 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 06:29:23PM +0100, Clément Bœsch wrote: > On Thu, Nov 19, 2015 at 04:50:54PM +0100, Michael Niedermayer wrote: > > On Thu, Nov 19, 2015 at 11:48:53AM +0100, Clément Bœsch wrote: > > > From: Matthieu Bouron > > > > > > Signed-off-by: Matthieu

Re: [FFmpeg-devel] [PATCH 3/3] avformat/ffmdec: Only return EAGAIN if a server is attached

2015-11-20 Thread Andreas Cadhalpun
On 20.11.2015 03:26, Michael Niedermayer wrote: > From: Michael Niedermayer > > This should fix a infinite loop > > Signed-off-by: Michael Niedermayer > --- > libavformat/ffmdec.c |9 +++-- > 1 file changed, 7 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] avfilter/all: handle ff_formats_unref correctly

2015-11-20 Thread Michael Niedermayer
On Sun, Nov 15, 2015 at 07:21:11PM -0500, Ganesh Ajjanagadde wrote: > Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning > up usage of the formats API, and in particular fixed possible NULL pointer > dereferences. >

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix -copy_prior_start 0 with -copyts and input -ss

2015-11-20 Thread Michael Niedermayer
On Sun, Nov 01, 2015 at 08:04:25PM -0600, Rodger Combs wrote: > Also rearranged the relevant check to reduce code duplication > --- > ffmpeg.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) applied thanks PS: can this be tested in fate ? [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 3/3] avformat/ffmdec: Only return EAGAIN if a server is attached

2015-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2015 at 07:34:50PM +0100, Andreas Cadhalpun wrote: > On 20.11.2015 03:26, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > This should fix a infinite loop > > > > Signed-off-by: Michael Niedermayer > > --- > >

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/amr: replace #define by typedef

2015-11-20 Thread Michael Niedermayer
On Thu, Nov 19, 2015 at 08:14:12AM -0500, Ganesh Ajjanagadde wrote: > See e.g > https://stackoverflow.com/questions/1666353/are-typedef-and-define-the-same-in-c > for rationale. > > Signed-off-by: Ganesh Ajjanagadde > --- should be ok [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH] avfilter/all: handle ff_formats_unref correctly

2015-11-20 Thread Ganesh Ajjanagadde
On Fri, Nov 20, 2015 at 3:00 PM, Michael Niedermayer wrote: > On Sun, Nov 15, 2015 at 07:21:11PM -0500, Ganesh Ajjanagadde wrote: >> Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and >> 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning >> up usage

Re: [FFmpeg-devel] [PATCH 1/3] avformat/ffmdec: Add cleaner API for ffserver to interface without depending on internal ABI

2015-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2015 at 07:33:20PM +0100, Andreas Cadhalpun wrote: > On 20.11.2015 03:26, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/ffm.h |2 ++ > >

Re: [FFmpeg-devel] [PATCH 2/3] ffserver: Use AVOption API to access ffm demuxer instead of direct access depending on ABI

2015-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2015 at 07:34:02PM +0100, Andreas Cadhalpun wrote: > On 20.11.2015 03:26, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Signed-off-by: Michael Niedermayer > > --- > > ffserver.c |6 +++--- > > 1 file

[FFmpeg-devel] [PATCH] avfilter: add deflash filter

2015-11-20 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_deflash.c | 199 +++ 3 files changed, 201 insertions(+) create mode 100644 libavfilter/vf_deflash.c diff --git

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

2015-11-20 Thread Andreas Cadhalpun
On 20.11.2015 10:51, Michael Niedermayer wrote: > On Fri, Nov 20, 2015 at 12:16:09AM +0100, Andreas Cadhalpun wrote: >> aacsbr_template.c |8 >> 1 file changed, 8 insertions(+) >> 43ace0364265ef16eecd6ca2d9564cc9585847f7 >>

Re: [FFmpeg-devel] [PATCH v2 11/13] Remove the MIPS "generic" core in favor of "*"

2015-11-20 Thread Andreas Cadhalpun
On 18.11.2015 12:13, Vicente Olivert Riera wrote: > There is no point to have a "generic" core when we can catch all > unsupported cores with the "*" option, so remove it. > > Signed-off-by: Vicente Olivert Riera > --- > Changes v1 -> v2: > - Nothing. > > configure |

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

2015-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2015 at 08:42:09PM +0100, Andreas Cadhalpun wrote: > On 20.11.2015 10:51, Michael Niedermayer wrote: > > On Fri, Nov 20, 2015 at 12:16:09AM +0100, Andreas Cadhalpun wrote: > >> aacsbr_template.c |8 > >> 1 file changed, 8 insertions(+) > >>

Re: [FFmpeg-devel] [PATCH] avfilter/all: handle ff_formats_unref correctly

2015-11-20 Thread Michael Niedermayer
On Fri, Nov 20, 2015 at 03:07:36PM -0500, Ganesh Ajjanagadde wrote: > On Fri, Nov 20, 2015 at 3:00 PM, Michael Niedermayer wrote: > > On Sun, Nov 15, 2015 at 07:21:11PM -0500, Ganesh Ajjanagadde wrote: > >> Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > >>

Re: [FFmpeg-devel] Ffmpeg Consulting

2015-11-20 Thread Mayank Agarwal
Hi, I have good expereince in ffmpeg and multimedia domain and i am interested in that Regards Mayank On Thu, Nov 19, 2015 at 8:08 AM, d...@faceflow.com wrote: > Hi, > > I am currently working on a project in which we want to use Ffmpeg. > > I have a lot of data to handle

Re: [FFmpeg-devel] [PATCH 1/3] aacsbr_fixed: avoid division by zero in sbr_gain_calc

2015-11-20 Thread Andreas Cadhalpun
On 20.11.2015 21:51, Michael Niedermayer wrote: > On Fri, Nov 20, 2015 at 08:42:09PM +0100, Andreas Cadhalpun wrote: >> On 20.11.2015 10:51, Michael Niedermayer wrote: >>> On Fri, Nov 20, 2015 at 12:16:09AM +0100, Andreas Cadhalpun wrote: aacsbr_template.c |8 1 file

Re: [FFmpeg-devel] Error in ATRAC1 decoder?

2015-11-20 Thread Даниил Чередник
I rechecked it. The issue with test is the test uses decoded from aea sample pcm file. And it looks like this file is not correctly decoded (it is easy to see at 0.7221 sec, https://yadi.sk/i/8WBO701XkcHUv). Same place decoded by fixed version is https://yadi.sk/i/efG3lkEGkcHYE. Also I made test

Re: [FFmpeg-devel] Error in ATRAC1 decoder?

2015-11-20 Thread Michael Niedermayer
On Sat, Nov 21, 2015 at 01:24:35AM +0300, Даниил Чередник wrote: > I rechecked it. > The issue with test is the test uses decoded from aea sample pcm file. And > it looks like this file is not correctly decoded (it is easy to see at > 0.7221 sec, https://yadi.sk/i/8WBO701XkcHUv). Same place

[FFmpeg-devel] [PATCH 1/3] imgutils: Use designated initializers for AVClass

2015-11-20 Thread Timothy Gu
More readable and less breakable. --- libavutil/imgutils.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index 8956ae3..a189a50 100644 --- a/libavutil/imgutils.c +++ b/libavutil/imgutils.c @@ -236,11 +236,21 @@

Re: [FFmpeg-devel] [PATCH] configure: Add option to use gmp

2015-11-20 Thread Matt Oliver
On 19 November 2015 at 00:42, Ricardo Constantino wrote: > I previously had an option for gcrypt too but it seemed to not work > (FFmpeg crashed, iirc), so I just gave up on it. > If ffmpeg crashes when using gcrypt then thats a separate bug not related to configure. So you

[FFmpeg-devel] [PATCH 2/3] avformat/rawvideodec: Rework packet size calculation

2015-11-20 Thread Timothy Gu
Calculate packet size only once, and propagate errors earlier in the chain. Also remove use of the deprecated av_image_get_buffer_size(). --- libavformat/rawvideodec.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/libavformat/rawvideodec.c

[FFmpeg-devel] [PATCH 3/3] avformat/v210: Check width and height

2015-11-20 Thread Timothy Gu
Fixes a floating point exception when width and height are not supplied (and therefore are zero). --- libavformat/v210.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/libavformat/v210.c b/libavformat/v210.c index ab29171..7503d5d 100644 ---