Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Set A_QUICKTIME bit depth

On 01/13/2016 12:30 AM, Mats Peterson wrote: Since mkvmerge doesn't set the bit depth for A_QUICKTIME audio (as far as I know), the track->audio.bitdepth variable will be zero, and its value needs to be retrieved from the sound sample description. Also, confine the 0x to 'raw '/'twos'

Re: [FFmpeg-devel] [PATCH v2 7/9] lavc/ccaption_dec: implement musical glyph

On Tue, Jan 12, 2016 at 05:42:58PM -0800, Aman Gupta wrote: > From: Aman Gupta > > This is the most commonly used character from the special north-american > character set. All the non-standard charsets are "optional" according to > the spec, and we currently implement none of

Re: [FFmpeg-devel] [PATCH v2 8/9] lavc/ccaption_dec: implement positioning for closed captions

On Tue, Jan 12, 2016 at 05:42:59PM -0800, Aman Gupta wrote: > From: Aman Gupta > > Positioning math is based on the guidelines in > https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608 > --- > libavcodec/ccaption_dec.c | 29

Re: [FFmpeg-devel] have some major changes for nvenc support

On 1/8/16, Andrey Turkin wrote: > In my opinion this proliferation of various filters which do the same thing > in different way is a configuration headache. There's CPU filters: one for > scaling/format conversion, one for padding, one for cropping, like 5 > different

[FFmpeg-devel] [PATCH] lavc/mlpdec: report presence of Atmos substreams as a profile

--- libavcodec/avcodec.h| 2 ++ libavcodec/mlp_parser.c | 5 + libavcodec/mlpdec.c | 2 ++ libavcodec/profiles.c | 6 ++ libavcodec/profiles.h | 1 + 5 files changed, 16 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index f365775..81f1e9a 100644 ---

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

Hi Ganesh Somehow I'm missing your ffserver patches on this thread, had to check them on gmame. Probably something odd with my local filters. Commenting offline for the time being: 09/13 Its OK but actually introduces the error (- }) you fix on 10/13... clean up accordingly 11, 12 & 13 LGTM

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Set A_QUICKTIME bit depth

On 01/13/2016 08:35 AM, Mats Peterson wrote: I should add that I've limited the setting of track->audio.bitdepth to version 0 sound sample descriptions only, since as they can only contain 8- or 16-bit uncompressed data The samples can only be 8- or 16-bit uncompressed, rather.

Re: [FFmpeg-devel] [PATCH 05/13] lavfi/vf_psnr: check fclose return value

On 1/12/16, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vf_psnr.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c > index

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

On Mon, 11 Jan 2016 23:25:02 -0500 Ganesh Ajjanagadde wrote: > Some preliminary work has already been done on fclose checking. This completes > the work, modulo a few exceptions: 1. Printing warnings is completely useless unless maybe in ffmpeg.c interactive usage (if

[FFmpeg-devel] [PATCH]lavc/mjpeg2jpeg: Accept more mjpeg streams as input

Hi! I guess that attached patch fixes ticket #5151. It is the user's responsibility to know if the input stream is suitable for the bitstream filter or not. Please comment, Carl Eugen diff --git a/libavcodec/mjpeg2jpeg_bsf.c b/libavcodec/mjpeg2jpeg_bsf.c index 68640db..b29039e 100644 ---

Re: [FFmpeg-devel] [PATCH 02/13] lavfi/vf_deshake: check fclose return value

On Mon, Jan 11, 2016 at 11:25:04PM -0500, Ganesh Ajjanagadde wrote: > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/vf_deshake.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

Hi! Attached patch improves ico probing, previously mpeg-2 frames could be detected. Please comment, Carl Eugen diff --git a/libavformat/icodec.c b/libavformat/icodec.c index 22e2099..c3e87ea 100644 --- a/libavformat/icodec.c +++ b/libavformat/icodec.c @@ -44,8 +44,12 @@ typedef struct {

Re: [FFmpeg-devel] [PATCH]lavc/mjpeg2jpeg: Accept more mjpeg streams as input

On Tuesday 12 January 2016 02:16:52 pm Michael Niedermayer wrote: > On Tue, Jan 12, 2016 at 09:58:53AM +0100, Carl Eugen Hoyos wrote: > > -if (memcmp("AVI1", buf + 6, 4)) { > > -av_log(avctx, AV_LOG_ERROR, "input is not MJPEG/AVI1\n"); > > -return AVERROR_INVALIDDATA; > > +

Re: [FFmpeg-devel] [PATCH] lavf/avi: pull stream durations from index, when available

On Mon, Jan 11, 2016 at 06:41:39PM -0600, Rodger Combs wrote: > This fixes files that have an incorrect nb_frames but a valid index > --- > libavformat/avidec.c | 1 + > 1 file changed, 1 insertion(+) can you share such a file ? [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Use av_realloc() in get_qt_codec()

On Mon, Jan 11, 2016 at 07:43:29AM +0100, Mats Peterson wrote: > Use av_realloc() rather than av_malloc() when normalizing noncompliant > private data in get_qt_codec(). Based on your comments, Michael, it > seems to be OK, > and is more "elegant" in my book than using >

Re: [FFmpeg-devel] [PATCH]lavc/x264: Improve level setting

On Tuesday 12 January 2016 02:31:48 pm Michael Niedermayer wrote: > > > > +level_id = atoi(x4->level); > > > > > > this should check that teres no "tail" after the integer > > > > For which command line will this make a difference? > > I didn't find one... > > didnt try but i was

Re: [FFmpeg-devel] [PATCH]lavc/mjpeg2jpeg: Accept more mjpeg streams as input

On Tue, Jan 12, 2016 at 02:41:12PM +0100, Carl Eugen Hoyos wrote: > On Tuesday 12 January 2016 02:28:28 pm Michael Niedermayer wrote: > > On Tue, Jan 12, 2016 at 02:19:53PM +0100, Carl Eugen Hoyos wrote: > > > On Tuesday 12 January 2016 02:16:52 pm Michael Niedermayer wrote: > > > > On Tue, Jan

Re: [FFmpeg-devel] [PATCH]lavc/mjpeg2jpeg: Accept more mjpeg streams as input

On Tue, Jan 12, 2016 at 02:19:53PM +0100, Carl Eugen Hoyos wrote: > On Tuesday 12 January 2016 02:16:52 pm Michael Niedermayer wrote: > > On Tue, Jan 12, 2016 at 09:58:53AM +0100, Carl Eugen Hoyos wrote: > > > > -if (memcmp("AVI1", buf + 6, 4)) { > > > -av_log(avctx, AV_LOG_ERROR,

Re: [FFmpeg-devel] [PATCH]lavc/x264: Improve level setting

On Tue, Jan 12, 2016 at 02:10:08PM +0100, Carl Eugen Hoyos wrote: > On Tuesday 12 January 2016 01:55:30 pm Michael Niedermayer wrote: > > On Mon, Jan 11, 2016 at 10:58:55AM +0100, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > I guess that attached patch fixes the additional issue in ticket #3307.

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Use av_realloc() in get_qt_codec()

On 01/12/2016 02:32 PM, Michael Niedermayer wrote: On Mon, Jan 11, 2016 at 07:43:29AM +0100, Mats Peterson wrote: Use av_realloc() rather than av_malloc() when normalizing noncompliant private data in get_qt_codec(). Based on your comments, Michael, it seems to be OK, and is more "elegant"

Re: [FFmpeg-devel] [PATCH]lavc/mjpeg2jpeg: Accept more mjpeg streams as input

On Tue, Jan 12, 2016 at 09:58:53AM +0100, Carl Eugen Hoyos wrote: > Hi! > > I guess that attached patch fixes ticket #5151. > It is the user's responsibility to know if the input stream > is suitable for the bitstream filter or not. > > Please comment, Carl Eugen > mjpeg2jpeg_bsf.c |9

Re: [FFmpeg-devel] [PATCH]lavc/mjpeg2jpeg: Accept more mjpeg streams as input

On Tuesday 12 January 2016 02:28:28 pm Michael Niedermayer wrote: > On Tue, Jan 12, 2016 at 02:19:53PM +0100, Carl Eugen Hoyos wrote: > > On Tuesday 12 January 2016 02:16:52 pm Michael Niedermayer wrote: > > > On Tue, Jan 12, 2016 at 09:58:53AM +0100, Carl Eugen Hoyos wrote: > > > > -if

Re: [FFmpeg-devel] [PATCH] libvpxdec: fix 'ISO C90 forbids mixed declarations and code' warning

Hi, On Tue, Jan 12, 2016 at 1:43 AM, James Zern wrote: > since: > cbcc88c libvpx: Support setting color range for vp9. > > Signed-off-by: James Zern > --- > libavcodec/libvpxdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

On Tue, Jan 12, 2016 at 01:49:37PM +0100, Carl Eugen Hoyos wrote: > Hi! > > On Tuesday 12 January 2016 01:33:53 pm Carl Eugen Hoyos wrote: > > > > Attached patch improves ico probing, previously mpeg-2 frames could be > > detected. > > Wikipedia claims that planes can be 0, new patch attached. >

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

On Tue, Jan 12, 2016 at 1:18 PM, Paul B Mahol wrote: > On 1/12/16, Ganesh Ajjanagadde wrote: >> On Tue, Jan 12, 2016 at 10:29 AM, Ronald S. Bultje >> wrote: >>> Hi, >>> >>> On Tue, Jan 12, 2016 at 10:07 AM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 12.01.2016 03:26, Ronald S. Bultje wrote: > On Mon, Jan 11, 2016 at 12:06 AM, Mats Peterson < >> On 01/10/2016 11:56 AM, Andreas Cadhalpun wrote: >>> --- a/libavformat/qtpalette.c >>> +++ b/libavformat/qtpalette.c >>> @@ -48,7 +48,7 @@ int ff_get_qtpalette(int codec_id, AVIOContext *pb, >>>

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

Hi! On Tuesday 12 January 2016 01:33:53 pm Carl Eugen Hoyos wrote: > > Attached patch improves ico probing, previously mpeg-2 frames could be > detected. Wikipedia claims that planes can be 0, new patch attached. Carl Eugen diff --git a/libavformat/icodec.c b/libavformat/icodec.c index

Re: [FFmpeg-devel] [PATCH]lavc/x264: Improve level setting

On Mon, Jan 11, 2016 at 10:58:55AM +0100, Carl Eugen Hoyos wrote: > Hi! > > I guess that attached patch fixes the additional issue in ticket #3307. > > Please comment, Carl Eugen > libx264.c |2 ++ > 1 file changed, 2 insertions(+) > cea8163693a2a78b9dc2d1929082e7c76ac542ac

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: check fclose return value

On Mon, Jan 11, 2016 at 05:35:17PM -0500, Ganesh Ajjanagadde wrote: > This one may be slightly more theoretical, since the preset file is opened in > a > read-only mode. Nevertheless, it is a good idea to check its return value. > > Signed-off-by: Ganesh Ajjanagadde >

Re: [FFmpeg-devel] [PATCH]lavc/x264: Improve level setting

On Tuesday 12 January 2016 01:55:30 pm Michael Niedermayer wrote: > On Mon, Jan 11, 2016 at 10:58:55AM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > I guess that attached patch fixes the additional issue in ticket #3307. > > > > Please comment, Carl Eugen > > > > libx264.c |2 ++ > > 1 file

Re: [FFmpeg-devel] [PATCH 05/13] lavfi/vf_psnr: check fclose return value

On Tue, Jan 12, 2016 at 3:32 AM, Paul B Mahol wrote: > On 1/12/16, Ganesh Ajjanagadde wrote: >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavfilter/vf_psnr.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >>

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

On Tue, Jan 12, 2016 at 9:26 PM, compn wrote: > On Tue, 12 Jan 2016 10:44:18 -0600 > Will Kelleher wrote: > >> That said, it doesn't look like any of the previous review comments >> (which I agree with) were addressed in this second version. Let me >>

[FFmpeg-devel] [PATCH] avfilter: add spectrumsynth filter

Signed-off-by: Paul B Mahol --- doc/filters.texi| 25 +++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/vaf_spectrumsynth.c | 447 4 files changed, 474 insertions(+)

Re: [FFmpeg-devel] [PATCH v2] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

On Tue, 12 Jan 2016 10:44:18 -0600 Will Kelleher wrote: > That said, it doesn't look like any of the previous review comments > (which I agree with) were addressed in this second version. Let me > know if there is anything I can do to help. some devs made comments that

Re: [FFmpeg-devel] [PATCH] diracdec: Add slice threading to HQ profile

On Tue, Jan 12, 2016 at 01:01:24AM +, Kieran Kunhya wrote: > > diracdec.c | 38 ++ > 1 file changed, 30 insertions(+), 8 deletions(-) > 73ce8405d52477db0faa2a2b76daca698a49bff2 > 0001-diracdec-Add-slice-threading-to-HQ-profile.patch > From

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

Hi, On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde wrote: > On Tue, Jan 12, 2016 at 4:38 AM, wm4 wrote: > > This makes no sense. Even if fclose() should fail for > > whatever obscure reasons there might be, reading already worked > > without

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde > wrote: > >> On Tue, Jan 12, 2016 at 4:38 AM, wm4 wrote: >> > This makes no sense. Even if fclose() should fail

Re: [FFmpeg-devel] [PATCH]lavc/mjpeg2jpeg: Accept more mjpeg streams as input

On Tuesday 12 January 2016 03:19:24 pm Michael Niedermayer wrote: > > mjpeg2jpeg_bsf.c |5 + > > 1 file changed, 5 insertions(+) > > a261f4350cbfeefc9c011cfc93fc39e5c4f7fe7c patchmjpeg2jpgffd8.diff > > diff --git a/libavcodec/mjpeg2jpeg_bsf.c b/libavcodec/mjpeg2jpeg_bsf.c > > LGTM Patch

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

Hi, On Tue, Jan 12, 2016 at 10:07 AM, Ganesh Ajjanagadde wrote: > On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Tue, Jan 12, 2016 at 7:52 AM, Ganesh Ajjanagadde > > wrote: > > > >> On Tue, Jan 12, 2016 at

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

On Tuesday 12 January 2016 02:49:59 pm Michael Niedermayer wrote: > On Tue, Jan 12, 2016 at 01:49:37PM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > On Tuesday 12 January 2016 01:33:53 pm Carl Eugen Hoyos wrote: > > > Attached patch improves ico probing, previously mpeg-2 frames could be > > >

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

On Tue, Jan 12, 2016 at 10:29 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 12, 2016 at 10:07 AM, Ganesh Ajjanagadde > wrote: > >> On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Tue, Jan 12, 2016 at

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

On 12 January 2016 at 05:05, Timothy Gu wrote: > Are you sure you want to initialize libgcrypt unconditionally as you are > doing here? > I don't think it's unconditional. It only tries to initialize gcrypt if it's not been initialized already. >+if

Re: [FFmpeg-devel] [PATCH 02/13] lavfi/vf_deshake: check fclose return value

On Tue, Jan 12, 2016 at 10:53 AM, Tobias Rapp wrote: > On 12.01.2016 05:25, Ganesh Ajjanagadde wrote: >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavfilter/vf_deshake.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >>

Re: [FFmpeg-devel] [PATCH 02/13] lavfi/vf_deshake: check fclose return value

On 12.01.2016 05:25, Ganesh Ajjanagadde wrote: Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_deshake.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c index e7ece44..a89506b 100644 ---

Re: [FFmpeg-devel] [PATCH]lavc/mjpeg2jpeg: Accept more mjpeg streams as input

On Tue, Jan 12, 2016 at 04:18:35PM +0100, Carl Eugen Hoyos wrote: > On Tuesday 12 January 2016 03:19:24 pm Michael Niedermayer wrote: > > > mjpeg2jpeg_bsf.c |5 + > > > 1 file changed, 5 insertions(+) > > > a261f4350cbfeefc9c011cfc93fc39e5c4f7fe7c patchmjpeg2jpgffd8.diff > > > diff --git

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

On Tue, Jan 12, 2016 at 08:33:47AM -0800, Michael Bradshaw wrote: > Overall it looks good. I thought it might overflow the buffer but with > AVPROBE_PADDING_SIZE it doesn't. > > On Tue, Jan 12, 2016 at 7:09 AM, Carl Eugen Hoyos wrote: > > diff --git a/libavformat/icodec.c

[FFmpeg-devel] [PATCH 2/3] lavd: add teletext quantizer

Getting teletext right from VANC/VBI data is tricky, because the teletext clock is not synced to the video clock. Therefore we have to first measure the frequency of the teletext clock in the reconstructed signal, and then resample the original data appropriately. What I do is that I measure the

[FFmpeg-devel] [PATCH 3/3] lavd/decklink_dec: add support for teletext

Signed-off-by: Marton Balint --- doc/indevs.texi | 9 +++ libavdevice/Makefile| 2 +- libavdevice/decklink_common.h | 2 ++ libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 56 +

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/diracdec: Handle the 0 vlc case at the top of coeff_unpack_golomb()

Hi, On Tue, Jan 12, 2016 at 5:32 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > encoding changes from 17 to 20 fps decoding, right? Ronald ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/3] avcodec/diracdec: Inline svq3_get_ue_golomb() and merge the sign bit decoding into it

From: Michael Niedermayer This avoids closing and opening the bit reader Signed-off-by: Michael Niedermayer --- libavcodec/diracdec.c | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH 3/3] avcodec/diracdec: Handle the 0 vlc case at the top of coeff_unpack_golomb()

From: Michael Niedermayer encoding changes from 17 to 20 fps Signed-off-by: Michael Niedermayer --- libavcodec/diracdec.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavcodec/diracdec.c

[FFmpeg-devel] [PATCH 1/3] configure: use -ldl for decklink

Signed-off-by: Marton Balint --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 19898be..a0f2276 100755 --- a/configure +++ b/configure @@ -5189,6 +5189,8 @@ elif check_func dlopen -ldl; then ldl=-ldl fi

Re: [FFmpeg-devel] [PATCH] libvpxdec: fix 'ISO C90 forbids mixed declarations and code' warning

On Tue, Jan 12, 2016 at 5:40 AM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 12, 2016 at 1:43 AM, James Zern wrote: > >> since: >> cbcc88c libvpx: Support setting color range for vp9. >> >> Signed-off-by: James Zern >> --- >> [...] > > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/diracdec: Handle the 0 vlc case at the top of coeff_unpack_golomb()

On Tue, Jan 12, 2016 at 05:48:21PM -0500, Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 12, 2016 at 5:32 PM, Michael Niedermayer > wrote: > > > From: Michael Niedermayer > > > > encoding changes from 17 to 20 fps > > > decoding, right? yes i cant

[FFmpeg-devel] [PATCH 2/3] avcodec/diracdec: Factor +2 out of the inner loop

From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavcodec/diracdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c index fe879bb..bbe6d87 100644

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/diracdec: Inline svq3_get_ue_golomb() and merge the sign bit decoding into it

On Tue, Jan 12, 2016 at 11:32:56PM +0100, Michael Niedermayer wrote: > From: Michael Niedermayer > > This avoids closing and opening the bit reader > > Signed-off-by: Michael Niedermayer > --- > libavcodec/diracdec.c | 37

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

On 08.01.2016 15:34, foo86 wrote: > On Thu, Jan 07, 2016 at 08:17:59PM +0100, Andreas Cadhalpun wrote: >> On 03.01.2016 18:49, foo86 wrote: >>> +for (i = 0; i < s->nmixoutconfigs; i++) { >>> +for (j = 0; j < nchannels_dmix; j++) { >>> +// Mix output mask >>> +

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

On 1/12/16, Ganesh Ajjanagadde wrote: > On Tue, Jan 12, 2016 at 10:29 AM, Ronald S. Bultje > wrote: >> Hi, >> >> On Tue, Jan 12, 2016 at 10:07 AM, Ganesh Ajjanagadde >> wrote: >> >>> On Tue, Jan 12, 2016 at 9:43 AM, Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH]lavf/mpjpegdec: Do not av_log() while probing

On Tue, Jan 12, 2016 at 06:29:47PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch silences the mpjpeg probing function. > > Please comment, Carl Eugen > mpjpegdec.c |3 +++ > 1 file changed, 3 insertions(+) > acd4f042b52c6400a6aaf613b89ecad9ca3405ac patchmpjpeglog.diff should be

Re: [FFmpeg-devel] [PATCH] rtp: Fix play multiple multicast streams with the same port

ping？ On Fri, Jan 8, 2016 at 9:15 AM, Zhao Zhili wrote: > Sorry, I work hard to cross the Great Fire Wall to send this patch and > cannot send it as plaintext. > Now send it as attachment. > > On Fri, Jan 8, 2016 at 1:52 AM, Michael Niedermayer < > mich...@niedermayer.cc>

[FFmpeg-devel] [PATCH] lavu: check for overflow in av_clip_intp2_c

--- libavutil/common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/common.h b/libavutil/common.h index f3276a2..5ae2847 100644 --- a/libavutil/common.h +++ b/libavutil/common.h @@ -211,7 +211,7 @@ static av_always_inline av_const int32_t av_clipl_int32_c(int64_t

[FFmpeg-devel] [PATCH] lavf/matroskadec: Set A_QUICKTIME bit depth

Since mkvmerge doesn't set the bit depth for A_QUICKTIME audio (as far as I know), the track->audio.bitdepth variable will be zero, and its value needs to be retrieved from the sound sample description. Also, confine the 0x to 'raw '/'twos' fourcc mapping to old version 0 sound sample

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 01/12/2016 10:44 PM, Andreas Cadhalpun wrote: Why are we using stdint types for non-vector data here? Our custom has always been to used sized (stdint-style) data only for vector data (arrays etc.), and use native-sized types (e.g. unsigned, int, whatever) for scalar values. Why are we making

[FFmpeg-devel] [PATCH] dca: fix misaligned access in avpriv_dca_convert_bitstream

src and dst are only 8-bit-aligned, so accessing them as uint16_t causes SIGBUS crashes on architectures like sparc. This fixes ubsan runtime error: load of misaligned address for type 'const uint16_t', which requires 2 byte alignment Signed-off-by: Andreas Cadhalpun

[FFmpeg-devel] [PATCH v2 8/9] lavc/ccaption_dec: implement positioning for closed captions

From: Aman Gupta Positioning math is based on the guidelines in https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608 --- libavcodec/ccaption_dec.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-)

[FFmpeg-devel] [PATCH v2 5/9] lavc/ccaption_dec: implement tab offset commands

From: Aman Gupta --- libavcodec/ccaption_dec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 8c913fe..50625df 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -558,6 +558,11 @@ static

[FFmpeg-devel] [PATCH v2 3/9] fate: add test for realtime ccaption decoder

From: Aman Gupta --- tests/fate/subtitles.mak | 3 +++ tests/ref/fate/sub-cc-realtime | 42 ++ 2 files changed, 45 insertions(+) create mode 100644 tests/ref/fate/sub-cc-realtime diff --git a/tests/fate/subtitles.mak

[FFmpeg-devel] [PATCH v2 9/9] fate: update sub-cc tests for subtitle positioning

From: Aman Gupta --- tests/ref/fate/sub-cc | 4 +-- tests/ref/fate/sub-cc-realtime | 60 +- 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/tests/ref/fate/sub-cc b/tests/ref/fate/sub-cc index 0d5bc77..4cc02d1

[FFmpeg-devel] [PATCH v2 1/9] lavc/ccaption_dec: flush context on seek

From: Aman Gupta --- libavcodec/ccaption_dec.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index ca497e5..a9dfc94 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -173,6

[FFmpeg-devel] [PATCH v2 4/9] lavc/ccaption_dec: default rollup to row 10

From: Aman Gupta This ensures that captions are written towards the bottom of the screen when tuning into mid-stream. The row will be reset on the receipt of the next PAC command. Row 10 was chosen as it corresponds to the value of "0" in a PAC (see row_map in handle_pac()). ---

[FFmpeg-devel] [PATCH v2 7/9] lavc/ccaption_dec: implement musical glyph

From: Aman Gupta This is the most commonly used character from the special north-american character set. All the non-standard charsets are "optional" according to the spec, and we currently implement none of them. This commit adds support for "♪" which very popular (and has no

[FFmpeg-devel] [PATCH v2 2/9] lavc/ccaption_dec: implement real_time option

From: Aman Gupta This new mode is useful for realtime decoding of closed captions so they can be display along with mpeg2 frames. Closed caption streams contain two major types of captions: - POPON captions, which are buffered off-screen and displayed only after EOC (end of

[FFmpeg-devel] [PATCH v2 6/9] lavc/ccaption_dec: clear all unused rows during rollup

From: Aman Gupta Sometimes rollup captions can move around the screen. This fixes "ghost" captions from below the current rollup area from continuing to be captured when a rollup moves higher up on the screen. --- libavcodec/ccaption_dec.c | 8 +--- 1 file changed, 5

Re: [FFmpeg-devel] [PATCH v2 1/9] lavc/ccaption_dec: flush context on seek

On Tue, Jan 12, 2016 at 5:42 PM, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c > index

Re: [FFmpeg-devel] [PATCH 2/3] lavd: add teletext quantizer

Why not use libzvbi's slicer? It should be pretty robust with less-than-ideal signal. Regarding your code - is there a need to calculate a frequency? I did something similar a while back with VBI from TV signal and in my experience: a) this kind of frequency/phase estimation doesn't work that

Re: [FFmpeg-devel] [PATCH]lavf/icodec: Improve probe function

Overall it looks good. I thought it might overflow the buffer but with AVPROBE_PADDING_SIZE it doesn't. On Tue, Jan 12, 2016 at 7:09 AM, Carl Eugen Hoyos wrote: > diff --git a/libavformat/icodec.c b/libavformat/icodec.c > index 22e2099..9cf3dca 100644 > ---

[FFmpeg-devel] [PATCH]lavf/mpjpegdec: Do not av_log() while probing

Hi! Attached patch silences the mpjpeg probing function. Please comment, Carl Eugen diff --git a/libavformat/mpjpegdec.c b/libavformat/mpjpegdec.c index dd31f87..c9fcf47 100644 --- a/libavformat/mpjpegdec.c +++ b/libavformat/mpjpegdec.c @@ -198,6 +198,7 @@ static int