Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Michael Behrisch
Am 20.10.2016 um 04:18 schrieb Muhammad Faiz: > On 10/20/16, Michael Behrisch wrote: >> Signed-off-by: Michael Behrisch >> --- >> libavutil/log.h| 2 +- >> libavutil/pixfmt.h | 12 ++-- >> 2 files changed, 7 insertions(+), 7 deletions(-) > > If

Re: [FFmpeg-devel] [PATCH] avfilter/showcqt: add cscheme option

2016-10-20 Thread Muhammad Faiz
On 10/19/16, Muhammad Faiz wrote: > Signed-off-by: Muhammad Faiz > --- > doc/filters.texi | 5 + > libavfilter/avf_showcqt.c | 45 > ++--- > libavfilter/avf_showcqt.h | 2 ++ > 3 files changed, 41

Re: [FFmpeg-devel] [PATCH 2/3] ffprobe: report field order for video streams

2016-10-20 Thread Tobias Rapp
On 19.10.2016 23:15, Michael Niedermayer wrote: On Wed, Oct 19, 2016 at 02:35:21PM +0200, Tobias Rapp wrote: From: Rodger Combs Reviewed-by: Tobias Rapp --- doc/ffprobe.xsd | 1 + ffprobe.c

Re: [FFmpeg-devel] [PATCH v2 3/3] fate: Add MXF D10/DV25 probe tests

2016-10-20 Thread Tobias Rapp
On 19.10.2016 23:06, Michael Niedermayer wrote: On Wed, Oct 19, 2016 at 02:35:22PM +0200, Tobias Rapp wrote: Signed-off-by: Tobias Rapp --- tests/fate/mxf.mak| 19 ++- tests/ref/fate/mxf-probe-d10 | 3 +++ tests/ref/fate/mxf-probe-dv25 |

Re: [FFmpeg-devel] [PATCH]lavc/sheervideo: Increase av_get_codec_tag_string() input buffer size.

2016-10-20 Thread Carl Eugen Hoyos
2016-10-18 15:04 GMT+02:00 Carl Eugen Hoyos : > Attached patch increases the size of the input buffer for > av_get_codec_tag_string() to 32, typically used in FFmpeg. Patch applied, Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Clément Bœsch
On Thu, Oct 20, 2016 at 09:55:17AM +0200, Nicolas George wrote: > Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit : > > it's really a trivial and harmless patch. > > Which is not enough to accept it. > but the patch is perfectly fine and semantically more correct (it explicits that

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Carl Eugen Hoyos
2016-10-20 9:55 GMT+02:00 Nicolas George : > I am sure there are better uses of contributors' time than that. After many years on this list, I don't think this is a helpful approach. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avfilter/firequalizer: use zero phase kernel

2016-10-20 Thread Muhammad Faiz
On 10/19/16, Muhammad Faiz wrote: > this makes real-valued kernel > > Signed-off-by: Muhammad Faiz > --- > libavfilter/af_firequalizer.c | 26 +++--- > 1 file changed, 15 insertions(+), 11 deletions(-) applied thanks

Re: [FFmpeg-devel] [PATCH] removing comma at final enumeration items to fix pedantic warnings

2016-10-20 Thread Nicolas George
Le nonidi 29 vendémiaire, an CCXXV, Clement Boesch a écrit : > it's really a trivial and harmless patch. Which is not enough to accept it. I am sure there are better uses of contributors' time than that. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] lavf/aviobuf: add ff_get_line2() variant

2016-10-20 Thread Stefano Sabatini
On date Tuesday 2016-10-18 16:48:02 +0200, Michael Niedermayer encoded: > On Tue, Oct 18, 2016 at 01:32:12PM +0200, Stefano Sabatini wrote: [...] > > aviobuf.c | 18 +++--- > > internal.h | 14 ++ > > 2 files changed, 29 insertions(+), 3 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Add support for iec61966-2.1 (sRGB) transfer

2016-10-20 Thread Ronald S. Bultje
Hi, On Tue, Oct 18, 2016 at 3:17 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > Signed-off-by: Vittorio Giovara > --- > Special thanks to Andrew Roland for helping me figure out these numbers. > Please keep me in CC. > Vittorio > >

Re: [FFmpeg-devel] [PATCH] avformat/flvenc: do not write duration and filesize when cannot seekable

2016-10-20 Thread Michael Niedermayer
On Thu, Oct 13, 2016 at 09:16:55AM +0800, Steven Liu wrote: > 2016-10-13 4:08 GMT+08:00 Michael Niedermayer : > > > On Wed, Oct 12, 2016 at 06:11:41PM +0800, Steven Liu wrote: > > > when living stream cannot seekable, don't write duration and > > > filesize in metadata,

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: write DisplayWidth and DisplayHeight elements only if they differ from PixelWidth and PixelHeight

2016-10-20 Thread Dave Rice
Hi James, > On Oct 18, 2016, at 11:20 PM, James Almer wrote: > > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 6 -- > tests/fate/matroska.mak | 2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-20 Thread Josh de Kock
On 20/10/2016 17:06, Ronald S. Bultje wrote: --- libavfilter/vf_colorspace.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index c74fe00..f64163f 100644 --- a/libavfilter/vf_colorspace.c +++

Re: [FFmpeg-devel] [PATCH 2/3] ffprobe: report field order for video streams

2016-10-20 Thread Dave Rice
> On Oct 20, 2016, at 3:28 AM, Tobias Rapp wrote: > > On 19.10.2016 23:15, Michael Niedermayer wrote: >> On Wed, Oct 19, 2016 at 02:35:21PM +0200, Tobias Rapp wrote: >>> From: Rodger Combs >>> >>> Reviewed-by: Tobias Rapp

[FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-20 Thread Ronald S. Bultje
--- libavfilter/vf_colorspace.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c index c74fe00..f64163f 100644 --- a/libavfilter/vf_colorspace.c +++ b/libavfilter/vf_colorspace.c @@ -163,6 +163,8 @@ typedef

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Add support for iec61966-2.1 (sRGB) transfer

2016-10-20 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 03:17:26PM -0400, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Special thanks to Andrew Roland for helping me figure out these numbers. > Please keep me in CC. > Vittorio > > libavfilter/vf_colorspace.c | 3 +++ > 1 file

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-20 Thread Ronald S. Bultje
Hi, On Thu, Oct 20, 2016 at 1:08 PM, Josh de Kock wrote: > On 20/10/2016 17:06, Ronald S. Bultje wrote: > >> --- >> libavfilter/vf_colorspace.c | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/libavfilter/vf_colorspace.c

[FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-20 Thread Kagami Hiiragi
vp9_cx_iface actually allows values in range [0..2]. This fixes ticket #5894. Signed-off-by: Kagami Hiiragi --- libavcodec/libvpxenc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: write DisplayWidth and DisplayHeight elements only if they differ from PixelWidth and PixelHeight

2016-10-20 Thread Nicolas George
Le nonidi 29 vendémiaire, an CCXXV, Dave Rice a écrit : > You could also make the storage simpler by considering whether or not to > write DisplayWidth and DisplayHeight independently. For instance: > PixelWidth=720 > PixelHeight=480 > DisplayWidth=640 > DisplayHeight=480 > > could be simplified

Re: [FFmpeg-devel] [PATCH 1/4] V14 - Adding SCTE-35 CUI codec

2016-10-20 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 05:36:27PM -0700, Carlos Fernandez Sanz wrote: > From: Carlos Fernandez > > Signed-off-by: Carlos Fernandez > --- > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 6 ++ > 2 files changed, 7 insertions(+)

Re: [FFmpeg-devel] [PATCH 4/4] V14 - Correct Indentation

2016-10-20 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 05:36:30PM -0700, Carlos Fernandez Sanz wrote: > From: Carlos Fernandez > > Signed-off-by: Carlos Fernandez > --- > libavformat/hlsenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by:

Re: [FFmpeg-devel] [PATCH] aiffdec: fix division by zero

2016-10-20 Thread Andreas Cadhalpun
On 20.10.2016 02:56, Michael Niedermayer wrote: > On Wed, Oct 19, 2016 at 09:18:51PM +0200, Andreas Cadhalpun wrote: >> This is similar to commit c143a9c. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/aiffdec.c | 2 +- >> 1 file changed, 1

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-20 Thread Rostislav Pehlivanov
On 20 October 2016 at 16:31, Kagami Hiiragi wrote: > vp9_cx_iface actually allows values in range [0..2]. > This fixes ticket #5894. > > Signed-off-by: Kagami Hiiragi > --- > libavcodec/libvpxenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] rsd: limit number of channels

2016-10-20 Thread Andreas Cadhalpun
On 20.10.2016 02:04, Michael Niedermayer wrote: > On Wed, Oct 19, 2016 at 11:46:43PM +0200, Andreas Cadhalpun wrote: >> Negative values don't make sense and too large values can cause >> overflows. For AV_CODEC_ID_ADPCM_THP this leads to a too small extradata >> buffer being allocated, causing

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

2016-10-20 Thread Andreas Cadhalpun
On 20.10.2016 03:25, Michael Niedermayer wrote: > On Wed, Oct 19, 2016 at 07:30:29PM +0200, Andreas Cadhalpun wrote: >> On 19.10.2016 04:15, James Almer wrote: >>> On 10/17/2016 9:57 PM, Michael Niedermayer wrote: On Sun, Oct 16, 2016 at 09:34:50PM -0300, James Almer wrote: > Fixes

Re: [FFmpeg-devel] [PATCH 2/4] V14 - SCTE-35 extraction from mpegts

2016-10-20 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 05:36:28PM -0700, Carlos Fernandez Sanz wrote: > From: Carlos Fernandez > > Signed-off-by: Carlos Fernandez > --- > libavformat/mpegts.c | 47 +-- > 1 file changed, 45

[FFmpeg-devel] Ticket #5897. swresample. Incorrect work of swr_set_matrix() if the SwrContext was never initialized

2016-10-20 Thread v0lt r
From 55a5ec258f53fc7a4bdbea200d096bd5d46625d4 Mon Sep 17 00:00:00 2001 From: Aleksoid1978 Date: Wed, 19 Oct 2016 11:38:12 +0300 Subject: [PATCH] fix swr_set_matrix() --- libswresample/rematrix.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libswresample/rematrix.c

Re: [FFmpeg-devel] [PATCH] dcstr: fix division by zero

2016-10-20 Thread Andreas Cadhalpun
On 20.10.2016 02:59, Michael Niedermayer wrote: > On Wed, Oct 19, 2016 at 10:41:22PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/dcstr.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

[FFmpeg-devel] [PATCH] cavsdec: unref frame before referencing again

2016-10-20 Thread Andreas Cadhalpun
This fixes asserts (from commit 13aae8) in av_frame_ref and av_frame_move_ref. Signed-off-by: Andreas Cadhalpun --- libavcodec/cavsdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/cavsdec.c b/libavcodec/cavsdec.c index 70ac6f8..fed7043

[FFmpeg-devel] [PATCH] mpeg12dec: unref discarded picture from extradata

2016-10-20 Thread Andreas Cadhalpun
Otherwise another frame gets referenced into picture, triggering an assert (from commit 13aae8) in av_frame_ref. Signed-off-by: Andreas Cadhalpun --- libavcodec/mpeg12dec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mpeg12dec.c

Re: [FFmpeg-devel] [PATCH v2 0/3] Detect field_order based on video_line_map

2016-10-20 Thread Michael Niedermayer
On Wed, Oct 19, 2016 at 02:35:19PM +0200, Tobias Rapp wrote: > This patch series adds fate tests for probing MXF D10 (top field first) and > DV25 (bottom field first) file properties. Patch #2 is taken from > https://ffmpeg.org/pipermail/ffmpeg-devel/2016-October/200607.html > and has been

Re: [FFmpeg-devel] [PATCH] lavf/aviobuf: add ff_get_line2() variant

2016-10-20 Thread Michael Niedermayer
On Thu, Oct 20, 2016 at 04:05:07PM +0200, Stefano Sabatini wrote: > On date Tuesday 2016-10-18 16:48:02 +0200, Michael Niedermayer encoded: > > On Tue, Oct 18, 2016 at 01:32:12PM +0200, Stefano Sabatini wrote: > [...] > > > aviobuf.c | 18 +++--- > > > internal.h | 14

Re: [FFmpeg-devel] Ticket #5897. swresample. Incorrect work of swr_set_matrix() if the SwrContext was never initialized

2016-10-20 Thread Michael Niedermayer
On Thu, Oct 20, 2016 at 06:57:35AM +0300, v0lt r wrote: > > From 55a5ec258f53fc7a4bdbea200d096bd5d46625d4 Mon Sep 17 00:00:00 2001 > From: Aleksoid1978 is this Author name intended ? do you not want your full name in the git history for your patch ? If you want your full name, then please

Re: [FFmpeg-devel] [PATCH] dcstr: fix division by zero

2016-10-20 Thread Michael Niedermayer
On Thu, Oct 20, 2016 at 08:19:00PM +0200, Andreas Cadhalpun wrote: > On 20.10.2016 02:59, Michael Niedermayer wrote: > > On Wed, Oct 19, 2016 at 10:41:22PM +0200, Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun > >> --- > >> libavformat/dcstr.c |

Re: [FFmpeg-devel] [PATCH] aiffdec: fix division by zero

2016-10-20 Thread Michael Niedermayer
On Thu, Oct 20, 2016 at 08:11:19PM +0200, Andreas Cadhalpun wrote: > On 20.10.2016 02:56, Michael Niedermayer wrote: > > On Wed, Oct 19, 2016 at 09:18:51PM +0200, Andreas Cadhalpun wrote: > >> This is similar to commit c143a9c. > >> > >> Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: Detect field_order based on video_line_map

2016-10-20 Thread Michael Niedermayer
On Wed, Oct 19, 2016 at 02:35:20PM +0200, Tobias Rapp wrote: > Read video_line_map from MXF generic picture essence descriptor and use > it to derive the coded field order. Use field_dominance to derive the > display field order from coded field order. If field_dominance is not > available the

Re: [FFmpeg-devel] [PATCH 3/4] V13 - SCTE-35 support in hlsenc

2016-10-20 Thread Steven Liu
LGTM, Thanks Carlos Fernandez Sanz 于2016年10月19日 周三下午1:47写道: > On Sun, Oct 16, 2016 at 10:59 AM, Carlos Fernandez Sanz > wrote: > > > > All other things corrected (I think) - will send a patch soon. Thanks! > > I submitted V14 yesterday - can you

Re: [FFmpeg-devel] [PATCH 1/4] libavformat/mxfdec: export track name metadata

2016-10-20 Thread Michael Niedermayer
On Wed, Sep 21, 2016 at 01:42:06PM -0700, Mark Reid wrote: > --- > libavformat/mxfdec.c | 79 > +--- > 1 file changed, 44 insertions(+), 35 deletions(-) applied thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/4] libavformat/mxfdec: don't assume first stream index to be primary

2016-10-20 Thread Michael Niedermayer
On Wed, Sep 21, 2016 at 01:42:07PM -0700, Mark Reid wrote: > --- > libavformat/mxfdec.c | 48 > 1 file changed, 36 insertions(+), 12 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It

Re: [FFmpeg-devel] [PATCH] cavsdec: unref frame before referencing again

2016-10-20 Thread Michael Niedermayer
On Thu, Oct 20, 2016 at 10:16:17PM +0200, Andreas Cadhalpun wrote: > This fixes asserts (from commit 13aae8) in av_frame_ref and > av_frame_move_ref. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/cavsdec.c | 2 ++ > 1 file changed, 2 insertions(+)

Re: [FFmpeg-devel] [PATCH 4/4] tests/fate: add mxf metadata streams test

2016-10-20 Thread Michael Niedermayer
On Wed, Sep 21, 2016 at 01:42:09PM -0700, Mark Reid wrote: > --- > tests/fate/mxf.mak | 6 ++ > tests/ref/fate/mxf-metadata-source-ref1 | 13 + > tests/ref/fate/mxf-metadata-source-ref2 | 13 + > 3 files changed, 32 insertions(+) > create mode

Re: [FFmpeg-devel] [PATCH] mpeg12dec: unref discarded picture from extradata

2016-10-20 Thread Michael Niedermayer
On Thu, Oct 20, 2016 at 10:57:15PM +0200, Andreas Cadhalpun wrote: > Otherwise another frame gets referenced into picture, triggering an assert > (from commit 13aae8) in av_frame_ref. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/mpeg12dec.c | 1 + >

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-20 Thread James Zern
On Thu, Oct 20, 2016 at 8:31 AM, Kagami Hiiragi wrote: > vp9_cx_iface actually allows values in range [0..2]. > This fixes ticket #5894. > > Signed-off-by: Kagami Hiiragi > --- > libavcodec/libvpxenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [FFmpeg-devel] [PATCH 3/4] libavformat/mxfdec: add metadata streams for external referenced sourclips

2016-10-20 Thread Michael Niedermayer
On Wed, Sep 21, 2016 at 01:42:08PM -0700, Mark Reid wrote: > --- > libavformat/mxfdec.c | 47 --- > 1 file changed, 44 insertions(+), 3 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

2016-10-20 Thread Matt Oliver
On 15 October 2016 at 14:22, Matt Oliver wrote: > --- > configure | 3 +- > libavformat/tls_openssl.c | 163 -- > > 2 files changed, 102 insertions(+), 64 deletions(-) > > diff --git a/configure b/configure >