Re: [FFmpeg-devel] [PATCH V3] examples/hw_decode: Add a HWAccel decoding example.

2017-07-20 Thread Jun Zhao
On 2017/7/20 14:17, Steven Liu wrote: > 2017-07-20 13:29 GMT+08:00 Jun Zhao : >> V3: re-work to support the other hwaccels, just test with vaapi, >> dxva2|d3d11va|videotoolbox might work as well. >> V2: re-work with new hw decoding API. >> >>

Re: [FFmpeg-devel] [PATCH V3] examples/hw_decode: Add a HWAccel decoding example.

2017-07-20 Thread Steven Liu
2017-07-20 15:09 GMT+08:00 Jun Zhao : > > > On 2017/7/20 14:17, Steven Liu wrote: >> 2017-07-20 13:29 GMT+08:00 Jun Zhao : >>> V3: re-work to support the other hwaccels, just test with vaapi, >>> dxva2|d3d11va|videotoolbox might work as well. >>> V2:

[FFmpeg-devel] [PATCH V4] examples/hw_decode: Add a HWAccel decoding example.

2017-07-20 Thread Jun Zhao
V4: fix potential memory leak issue base on Steven Liu's review. V3: re-work to support the other hwaccels, rename from vaapi_dec.c to hw_decode.c. just test with vaapi, dxva2|d3d11va|videotoolbox might work as well. V2: re-work with new hw decoding API. From

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls fmp4 extention name bug

2017-07-20 Thread Steven Liu
ticket-id: #6541 when use hls fmp4 muxer, the extention name is not .m4s, this code can fix it. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH] fate: add tests for some video source filters

2017-07-20 Thread Tobias Rapp
Adds FATE tests for the previously untested allrgb, allyuv, rgbtestsrc, smptebars, smptehdbars and yuvtestsrc filters. Signed-off-by: Tobias Rapp --- tests/fate/filter-video.mak| 21 + tests/ref/fate/filter-allrgb | 10

Re: [FFmpeg-devel] [PATCH] vf_drawtext: support to set word spacing while drawing text. ./ffmpeg -i input -vf drawtext="word_spacing=10:textfile=1.txt:fontfile=demo.ttf" -f flv 1.flv could set word sp

2017-07-20 Thread Nicolas George
Hi. Thanks for the patch. See comments below. Le duodi 2 thermidor, an CCXXV, efren yang a écrit : > Subject: Re: [FFmpeg-devel] [PATCH] vf_drawtext: support to set word spacing > while drawing text. ./ffmpeg -i input -vf > drawtext="word_spacing=10:textfile=1.txt:fontfile=demo.ttf" -f flv

[FFmpeg-devel] 答复: [PATCH] vf_drawtext: support to set word spacing while drawing text. ./ffmpeg -i input -vf drawtext="word_spacing=10:textfile=1.txt:fontfile=demo.ttf" -f flv 1.flv could set word s

2017-07-20 Thread efren_yang
Hi, devel Thanks for reply. As you see, it is applied to every glyph. There is no space between all words in some languages, for example Chinese, Japanese and so on. So a sentence will look very compactly. I think if we could set glyph spacing, it would be more useful to adapt to more

Re: [FFmpeg-devel] [PATCH V3] examples/hw_decode: Add a HWAccel decoding example.

2017-07-20 Thread Steven Liu
2017-07-20 13:29 GMT+08:00 Jun Zhao : > V3: re-work to support the other hwaccels, just test with vaapi, > dxva2|d3d11va|videotoolbox might work as well. > V2: re-work with new hw decoding API. > > ___ > ffmpeg-devel mailing list >

[FFmpeg-devel] [PATCH] hevc: Make sure to update the current frame transfer characteristic

2017-07-20 Thread Vittorio Giovara
Otherwise the first decoded frame will still be tagged with the original transfer instead of the alternative one. Signed-off-by: Vittorio Giovara --- libavcodec/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c

[FFmpeg-devel] [PATCH] ffprobe: Print color properties from show_frames

2017-07-20 Thread Vittorio Giovara
--- ffprobe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ffprobe.c b/ffprobe.c index f6d9be0df9..412e2dadab 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2105,6 +2105,12 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,

Re: [FFmpeg-devel] [PATCH] ffprobe: Print color properties from show_frames

2017-07-20 Thread Tobias Rapp
On 20.07.2017 14:38, Vittorio Giovara wrote: --- ffprobe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ffprobe.c b/ffprobe.c index f6d9be0df9..412e2dadab 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2105,6 +2105,12 @@ static void show_frame(WriterContext *w, AVFrame *frame,

Re: [FFmpeg-devel] [PATCH] ffprobe: Print color properties from show_frames

2017-07-20 Thread Vittorio Giovara
>On 20.07.2017 14:38, Vittorio Giovara wrote: >> --- >> ffprobe.c | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/ffprobe.c b/ffprobe.c >> index f6d9be0df9..412e2dadab 100644 >> --- a/ffprobe.c >> +++ b/ffprobe.c >> @@ -2105,6 +2105,12 @@ static void show_frame(WriterContext *w,

[FFmpeg-devel] [PATCH] fix http 302 not compressed request , Ticket #6404

2017-07-20 Thread satbaby
This fixt for me redirect error: [http @ 0x65ac50] inflate return value: -3, unknown compression method after : [http @ 0x65ac50] header='HTTP/1.1 302 Moved Temporarily' From ed5195c98bafcaebbe9926b7afd1fac375f3a971 Mon Sep 17 00:00:00 2001 From: Jacek Jendrzej

Re: [FFmpeg-devel] [PATCH] vf_drawtext: support to set glyph spacing while drawing text. ./ffmpeg -i input -vf drawtext="glyph_spacing=10:textfile=1.txt:fontfile=demo.ttf" -f flv 1.flv could set glyph

2017-07-20 Thread Moritz Barsnick
On Thu, Jul 20, 2017 at 17:46:25 +0800, efren yang wrote: > Subject: [FFmpeg-devel] [PATCH] vf_drawtext: support to set glyph spacing > while drawing text. ./ffmpeg -i input -vf >drawtext="glyph_spacing=10:textfile=1.txt:fontfile=demo.ttf" -f flv > 1.flv could set glyph spacing 10

[FFmpeg-devel] [PATCH] vf_drawtext: support to set glyph spacing while drawing text. ./ffmpeg -i input -vf drawtext="glyph_spacing=10:textfile=1.txt:fontfile=demo.ttf" -f flv 1.flv could set glyph spa

2017-07-20 Thread efren yang
Signed-off-by: efren yang --- libavfilter/vf_drawtext.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 137ae5891e..c96c5a 100644 --- a/libavfilter/vf_drawtext.c +++

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls fmp4 extention name bug

2017-07-20 Thread Steven Liu
ticket-id: #6541 when use hls fmp4 muxer, the extention name is not .m4s, this code can fix it. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-20 Thread Michael Niedermayer
Hi On Wed, Jul 19, 2017 at 07:30:01PM -0700, Dale Curtis wrote: > Thanks will take a look. Is this test not part of fate? make fate passed no, we should have tests for all (fixed) tickets in fate ideally but in reality most tickets lack a corresponding test I tried both in outreachy and as well

[FFmpeg-devel] [PATCH] Add FITS Decoder

2017-07-20 Thread Paras Chadha
Signed-off-by: Paras Chadha --- Fixed an issue with RGB48 and RGBA64 images. Also simplified the RGB decoding code. Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h

Re: [FFmpeg-devel] [PATCH] Add FITS Decoder

2017-07-20 Thread Nicolas George
Hi. Le duodi 2 thermidor, an CCXXV, Paras Chadha a écrit : > +size = abs(header->bitpix) >> 3; > +size *= header->naxisn[i]; Can you explain why PCOUNT and GCOUNT are not taken into account here while they are taken into account in the demuxer? Regards, -- Nicolas George

Re: [FFmpeg-devel] tsan warning about a data race in libavcodec/h264_direct.c

2017-07-20 Thread Wan-Teh Chang
Hi Ronald, On Wed, Jul 19, 2017 at 11:50 AM, Ronald S. Bultje wrote: > Hi Wan-Teh, > > On Wed, Jul 19, 2017 at 2:31 PM, Wan-Teh Chang > wrote: > >> In libavcodec/h264_direct.c, there is already an >> await_reference_mb_row() call before the read

[FFmpeg-devel] [PATCH] avcodec/x86/cavsdsp: Delete #include "libavcodec/x86/idctdsp.h".

2017-07-20 Thread Wan-Teh Chang
This file already has #include "idctdsp.h", which is resolved to the idctdsp.h header in the directory where this file resides by compilers. Two other files in this directory, libavcodec/x86/idctdsp_init.c and libavcodec/x86/xvididct_init.c, also rely on #include "idctdsp.h" working this way.

[FFmpeg-devel] [PATCH v2] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Peter Große
Signed-off-by: Peter Große --- This depends on patch "lavfi/testsrc2: fix completely transparent alpha." The test fails without the patch "avfilter/vf_overlay: fix alpha blending when main source has an alpha channel". tests/fate/filter-video.mak | 4

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Paul B Mahol a écrit : > You should be more constructive, better go porting dualinput to framesync2, > that wasting everybodies precious time here. Keeping high standards of code quality seems to me a more important use of my time. And since you are neither my boss

[FFmpeg-devel] [PATCH] avcodec/h264: Declare the local variable decode_chroma as const.

2017-07-20 Thread Wan-Teh Chang
ff_h264_decode_mb_cabac() and ff_h264_decode_mb_cavlc() are very long functions. Declaring decode_chroma as const makes it clear the variable doesn't change after initialization. Signed-off-by: Wan-Teh Chang --- libavcodec/h264_cabac.c | 4 ++-- libavcodec/h264_cavlc.c | 4 ++--

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-20 Thread Nicolas George
Le primidi 1er thermidor, an CCXXV, Reimar Döffinger a écrit : > I am a bit unclear on the details, but my memory: > Well, they work better (only?) if the images are completely independent. > I am not sure this is entirely the case here, for example the first > image would have a different header

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Peter Große a écrit : > After some further tests, it seems swscale (used as the auto_scaler in the > test) produces slightly different output depending on whether MMX is enabled > or > not. > > When I re-add --disable-optimizations --enable-mmx --disable-stripping

Re: [FFmpeg-devel] [PATCH] ffprobe: Print color properties from show_frames

2017-07-20 Thread Tobias Rapp
On 20.07.2017 16:19, Vittorio Giovara wrote: On 20.07.2017 14:38, Vittorio Giovara wrote: --- ffprobe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ffprobe.c b/ffprobe.c index f6d9be0df9..412e2dadab 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -2105,6 +2105,12 @@ static void

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Nicolas George a écrit : > testsrc2 does not handle alpha, though, so most of the video is > transparent. I will have a look to see if it can be improved. Have a look at the attached patch. (Not complete, but working.)

[FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-20 Thread Vittorio Giovara
With and without alpha. --- Updated with fate tests. Vittorio libavutil/pixdesc.c | 51 libavutil/pixdesc.h | 5 libavutil/pixfmt.h | 7 ++ libswscale/utils.c | 4

[FFmpeg-devel] [PATCH] ffprobe: Print color properties from show_frames

2017-07-20 Thread Vittorio Giovara
--- Updated according to Tobias' review. Vittorio doc/ffprobe.xsd| 5 + ffprobe.c | 25 + tests/ref/fate/ffprobe_compact | 16 tests/ref/fate/ffprobe_csv | 16 tests/ref/fate/ffprobe_default |

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Paul B Mahol a écrit : > Assuming there are no comments. Wrong. Give me more time. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-20 Thread Paul B Mahol
On 7/20/17, Nicolas George wrote: > Le duodi 2 thermidor, an CCXXV, Paul B Mahol a ecrit : >> Assuming there are no comments. > > Wrong. Give me more time. You should be more constructive, better go porting dualinput to framesync2, that wasting everybodies precious time here.

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Nicolas George a écrit : >the attached patch. Sorry. Regards, -- Nicolas George From e50bd258ac22d5758348eafa7203f264dd98f580 Mon Sep 17 00:00:00 2001 From: Nicolas George Date: Thu, 20 Jul 2017 17:35:44 +0200 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-20 Thread Paul B Mahol
On 7/19/17, Paul B Mahol wrote: > On 7/19/17, Nicolas George wrote: >> Le primidi 1er thermidor, an CCXXV, Paul B Mahol a ecrit : >>> If you had ever write parser, you would know that this above is >>> giberish. >> >> Please enlighten us. > > Are there more

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Peter Große
On Wed, 19 Jul 2017 21:00:49 +0200 Peter Große wrote: > I was able to reproduce your checksums only after removing > > --disable-optimizations --disable-mmx --disable-stripping > > from my configure command. I thought optimizations should have no > impact on the result?!

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Tobias Rapp
On 20.07.2017 17:06, Peter Große wrote: On Wed, 19 Jul 2017 21:00:49 +0200 Peter Große wrote: I was able to reproduce your checksums only after removing --disable-optimizations --disable-mmx --disable-stripping from my configure command. I thought optimizations should

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Peter Große
On Thu, 20 Jul 2017 17:19:36 +0200 Tobias Rapp wrote: > > When I re-add --disable-optimizations --enable-mmx --disable-stripping to my > > configure command line, the test succeeds. > > > > Any further comments to the patch and test case? > > Maybe try adding

[FFmpeg-devel] [PATCH][RFC] JPEG2000: SSE optimisation for DWT decoding

2017-07-20 Thread maxime taisant
From: Maxime Taisant Hi, I am currently working on SSE optimisations for the dwt functions used to decode JPEG2000. For the moment, I have only managed to produce a SSE-optimized version of the sr_1d97_float function (with relatively good results). I would like to

Re: [FFmpeg-devel] [PATCH] avcodec/h264: Declare the local variable decode_chroma as const.

2017-07-20 Thread Michael Niedermayer
On Thu, Jul 20, 2017 at 10:31:19AM -0700, Wan-Teh Chang wrote: > ff_h264_decode_mb_cabac() and ff_h264_decode_mb_cavlc() are very long > functions. Declaring decode_chroma as const makes it clear the variable > doesn't change after initialization. > > Signed-off-by: Wan-Teh Chang

Re: [FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

2017-07-20 Thread Rostislav Pehlivanov
On 21 July 2017 at 00:49, Nicolas George wrote: > Le tridi 3 thermidor, an CCXXV, Rostislav Pehlivanov a écrit : > > It can be quite big. In some insane cases it can be bigger than the > actual > > packet or even the uncompressed frame. Its also not strictly necessary to > >

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext:support to set glyph spacing while drawing text.

2017-07-20 Thread efren yang
It is applied to every glyph. There is no space between all words in some languages, for example Chinese, Japanese and so on. So a sentence will look very compactly. I think if we could set glyph spacing, it will adapt to more different scenarios. Maybe it is simple but useful. ffmpeg -i input

Re: [FFmpeg-devel] [PATCH] avcodec/dca: remove GetBitContext usage from avpriv_dca_parse_core_frame_header()

2017-07-20 Thread James Almer
On 7/19/2017 4:43 PM, James Almer wrote: > This prevents potential ABI issues with GetBitContext. > > Signed-off-by: James Almer > --- > libavcodec/dca.c| 12 +++- > libavcodec/dca.h| 7 +-- > libavcodec/dca_core.c | 2 +- >

Re: [FFmpeg-devel] [PATCH] support set words' space

2017-07-20 Thread Michael Niedermayer
On Thu, Jul 20, 2017 at 10:02:25AM +0800, efren yang wrote: > vf_drawtext.c |3 +++ > 1 file changed, 3 insertions(+) > 369e0f0b0e08f3417e2e8206595cea4455561dae 0001-support-set-words-space.patch > From e02dd9859dee662d2e34428541058520495655b4 Mon Sep 17 00:00:00 2001 > From: efrenyang

Re: [FFmpeg-devel] [PATCH] fate: add tests for some video source filters

2017-07-20 Thread Michael Niedermayer
On Fri, Jul 21, 2017 at 01:04:03AM +0200, Nicolas George wrote: > Le duodi 2 thermidor, an CCXXV, Michael Niedermayer a écrit : > > breaks on mips (probably big endian issue) > > Breaks on MIPS, or detects that something is already broken in MIPS and > nobody noticed until now? this patch breaks

Re: [FFmpeg-devel] [PATCH V4] examples/hw_decode: Add a HWAccel decoding example.

2017-07-20 Thread Jun Zhao
On 2017/7/21 6:44, Mark Thompson wrote: > On 20/07/17 08:54, Jun Zhao wrote: >> V4: fix potential memory leak issue base on Steven Liu's review. >> V3: re-work to support the other hwaccels, rename from vaapi_dec.c to >> hw_decode.c. >>just test with vaapi, dxva2|d3d11va|videotoolbox might

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: hevc_await_progress: declare |y| only if used.

2017-07-20 Thread Michael Niedermayer
On Thu, Jul 20, 2017 at 11:39:11AM -0700, Wan-Teh Chang wrote: > hevc_await_progress() uses the variable |y| only inside the "if" block. > So |y| only needs to be declared and initialized in that block. > > Signed-off-by: Wan-Teh Chang > --- > libavcodec/hevcdec.c | 5 +++-- >

Re: [FFmpeg-devel] [PATCH V4] examples/hw_decode: Add a HWAccel decoding example.

2017-07-20 Thread Mark Thompson
On 20/07/17 08:54, Jun Zhao wrote: > V4: fix potential memory leak issue base on Steven Liu's review. > V3: re-work to support the other hwaccels, rename from vaapi_dec.c to > hw_decode.c. >just test with vaapi, dxva2|d3d11va|videotoolbox might work as well. > V2: re-work with new hw decoding

Re: [FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Rostislav Pehlivanov a écrit : > Many image formats support embedding of ICC profiles directly in > their bitstreams. Add a new side data type to allow exposing them to > API users. Why not make it a member of AVFrame directly? It looks to me very similar in

[FFmpeg-devel] [PATCH V5] examples/hw_decode: Add a HWAccel decoding example.

2017-07-20 Thread Jun Zhao
V5: remove qsv/cuda in the example and Mark have test dxva2|d3d11va, videotoolbox might work as well. V4: fix potential memory leak issue base on Steven Liu's review. V3: re-work to support the other hwaccels, rename from vaapi_dec.c to hw_decode.c. just test with vaapi,

[FFmpeg-devel] [PATCH] avformat/hlsenc: improve hls encrypt get key file operation

2017-07-20 Thread Steven Liu
get key file only once time is ok, no need more times. Ticket-id: #6545 Found-by: JohnPi Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index

Re: [FFmpeg-devel] [PATCH] avcodec/x86/cavsdsp: Delete #include "libavcodec/x86/idctdsp.h".

2017-07-20 Thread Michael Niedermayer
On Thu, Jul 20, 2017 at 10:44:03AM -0700, Wan-Teh Chang wrote: > This file already has #include "idctdsp.h", which is resolved to the > idctdsp.h header in the directory where this file resides by compilers. > Two other files in this directory, libavcodec/x86/idctdsp_init.c and >

Re: [FFmpeg-devel] [PATCH] fate: add tests for some video source filters

2017-07-20 Thread Nicolas George
Le duodi 2 thermidor, an CCXXV, Michael Niedermayer a écrit : > breaks on mips (probably big endian issue) Breaks on MIPS, or detects that something is already broken in MIPS and nobody noticed until now? Could you perhaps re-run the test with V=1, then re-run the command line with -f png, to

Re: [FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

2017-07-20 Thread Rostislav Pehlivanov
On 21 July 2017 at 00:08, Nicolas George wrote: > Le duodi 2 thermidor, an CCXXV, Rostislav Pehlivanov a écrit : > > Many image formats support embedding of ICC profiles directly in > > their bitstreams. Add a new side data type to allow exposing them to > > API users. > > Why

Re: [FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

2017-07-20 Thread Nicolas George
Le tridi 3 thermidor, an CCXXV, Rostislav Pehlivanov a écrit : > It can be quite big. In some insane cases it can be bigger than the actual > packet or even the uncompressed frame. Its also not strictly necessary to > display something more or less looking okay, but its necessary to display >

[FFmpeg-devel] [PATCH] doc/examples/encode_video: add qsv encoder support

2017-07-20 Thread Zhong Li
Signed-off-by: Zhong Li --- doc/examples/encode_video.c | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/doc/examples/encode_video.c b/doc/examples/encode_video.c index 8cd1321..9c26f63 100644 ---

[FFmpeg-devel] [PATCH] avcodec/hevcdec: hevc_await_progress: declare |y| only if used.

2017-07-20 Thread Wan-Teh Chang
hevc_await_progress() uses the variable |y| only inside the "if" block. So |y| only needs to be declared and initialized in that block. Signed-off-by: Wan-Teh Chang --- libavcodec/hevcdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] Add FITS Decoder

2017-07-20 Thread Paras Chadha
On Thu, Jul 20, 2017 at 11:19 PM, Nicolas George wrote: > Hi. > > Le duodi 2 thermidor, an CCXXV, Paras Chadha a écrit : > > +size = abs(header->bitpix) >> 3; > > > +size *= header->naxisn[i]; > > Can you explain why PCOUNT and GCOUNT are not taken into account here

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-20 Thread Paras Chadha
On Thu, Jul 20, 2017 at 11:17 PM, Nicolas George wrote: > Le primidi 1er thermidor, an CCXXV, Reimar Döffinger a écrit : > > I am a bit unclear on the details, but my memory: > > Well, they work better (only?) if the images are completely independent. > > > I am not sure this is

[FFmpeg-devel] [PATCH] avcodec/atrac3p: use float_dsp in ff_atrac3p_power_compensation

2017-07-20 Thread James Almer
Signed-off-by: James Almer --- Fate passes, so i guess the aligment requirements are met. libavcodec/atrac3plus.h| 5 +++-- libavcodec/atrac3plusdec.c | 36 ++-- libavcodec/atrac3plusdsp.c | 8 3 files changed, 25 insertions(+),

[FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-20 Thread Paras Chadha
Signed-off-by: Paras Chadha --- Made the changes suggested. doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 2 +- libavcodec/fitsenc.c | 237 + libavformat/img2enc.c | 1 +

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-20 Thread James Almer
On 7/20/2017 4:46 PM, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > > Made the changes suggested. > > doc/general.texi | 2 +- > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 +- > libavcodec/fitsenc.c | 237 >

[FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

2017-07-20 Thread Rostislav Pehlivanov
Many image formats support embedding of ICC profiles directly in their bitstreams. Add a new side data type to allow exposing them to API users. Signed-off-by: Rostislav Pehlivanov --- libavutil/frame.h | 6 ++ libavutil/version.h | 2 +- 2 files changed, 7

[FFmpeg-devel] [PATCH] pixdesc: Explicitly handle invalid arguments to av_find_best_pix_fmt_of_2()

2017-07-20 Thread Mark Thompson
--- On 20/07/17 01:33, Michael Niedermayer wrote: > Hi > > On Tue, Jul 18, 2017 at 11:01:01PM +, Mark Thompson wrote: >> ffmpeg | branch: master | Mark Thompson | Thu Jul 6 >> 22:50:35 2017 +0100| [8a442d7a8a687a469ca502a18a0c68f5302b15e0] | committer: >> Mark Thompson >>

Re: [FFmpeg-devel] [PATCH] fate: add tests for psnr and ssim filter

2017-07-20 Thread Michael Niedermayer
On Wed, Jul 19, 2017 at 05:23:07PM +0200, Tobias Rapp wrote: > On 19.07.2017 17:06, Nicolas George wrote: > >Le primidi 1er thermidor, an CCXXV, Tobias Rapp a écrit : > >>Indeed they are remainders from previous edits. It seems that stripping any > >>whitespace within the filter string is enough

Re: [FFmpeg-devel] [PATCH] fate: add tests for some video source filters

2017-07-20 Thread Michael Niedermayer
On Thu, Jul 20, 2017 at 11:07:12AM +0200, Tobias Rapp wrote: > Adds FATE tests for the previously untested allrgb, allyuv, rgbtestsrc, > smptebars, smptehdbars and yuvtestsrc filters. > > Signed-off-by: Tobias Rapp > --- > tests/fate/filter-video.mak| 21

[FFmpeg-devel] [PATCH 2/2] pngdec: decode and expose iCCP chunks as side data

2017-07-20 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- libavcodec/pngdec.c | 45 + 1 file changed, 45 insertions(+) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 083f61f4f8..64811c6fc3 100644 --- a/libavcodec/pngdec.c +++

[FFmpeg-devel] Reading Frames in File Order

2017-07-20 Thread Jacob Trimble
I am writing a program that will use libavformat to demux media segments. I will need to parse media segments that may appear in any order and produce playable regions of content. For example, think YouTube streaming; there are regions of buffered content and seeking can produce media segments

Re: [FFmpeg-devel] [PATCH] fate: add vf_overlay test for main source with alpha channel

2017-07-20 Thread Michael Niedermayer
On Thu, Jul 20, 2017 at 05:38:18PM +0200, Peter Große wrote: > On Thu, 20 Jul 2017 17:19:36 +0200 > Tobias Rapp wrote: > > > > When I re-add --disable-optimizations --enable-mmx --disable-stripping to > > > my > > > configure command line, the test succeeds. > > > > > >

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-20 Thread Carl Eugen Hoyos
2017-07-20 17:46 GMT+02:00 Vittorio Giovara : > +[AV_PIX_FMT_YUV444F32LE] = { 0, 0 }, > +[AV_PIX_FMT_YUV444F32BE] = { 0, 0 }, > +[AV_PIX_FMT_YUVA444F32LE] = { 0, 0 }, > +[AV_PIX_FMT_YUVA444F32BE] = { 0, 0 }, Feel free to ignore but imo adding

Re: [FFmpeg-devel] [PATCH][RFC] JPEG2000: SSE optimisation for DWT decoding

2017-07-20 Thread Carl Eugen Hoyos
2017-07-20 18:07 GMT+02:00 maxime taisant : > From: Maxime Taisant > I am currently working on SSE optimisations for the dwt functions used to > decode JPEG2000. > For the moment, I have only managed to produce a SSE-optimized version of the

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

2017-07-20 Thread Carl Eugen Hoyos
2017-07-20 21:46 GMT+02:00 Paras Chadha : > +case AV_PIX_FMT_RGB24: > +case AV_PIX_FMT_RGBA: > +for (k = 0; k < naxis3; k++) { > +for (i = 0; i < avctx->height; i++) { > +ptr = p->data[0]