Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: fix access to priv_data after codec close.

On 10/18/2017 12:34 AM, Mark Thompson wrote: int ff_v4l2_m2m_codec_end(AVCodecContext *avctx) { -V4L2m2mContext* s = avctx->priv_data; -int ret; +V4L2m2mContext *m2m, *s = avctx->priv_data; +int i, ret; ret = ff_v4l2_context_set_status(>output, VIDIOC_STREAMOFF);

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

On Tue, Oct 17, 2017 at 06:49:51AM +0200, wm4 wrote: > I have realized that your veto is actually not valid: > - it's a Libav merge There is no exception for changes from Libav. Not in the policy and not in actual actions. We never pushed changes with standing objections. [...] -- Michael

Re: [FFmpeg-devel] [PATCH 1/7] Revert "Revert "lavfi/buffersrc: push the frame deeper if requested.""

On 17.10.2017 20:12, Nicolas George wrote: Le sextidi 26 vendémiaire, an CCXXVI, Tobias Rapp a écrit : This commit seems to break transcoding of some input files on machines with a lot of CPU cores. See attached script that reproduces the problem ("-threads 32" is used to simulate the situation

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : On 2 October 2017 at 18:43, pkv.stream wrote: Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : On Mon, Oct 02, 2017 at 12:52:53AM +0200, pkv.stream wrote: Le 02/10/2017 à 12:43 AM, Carl Eugen Hoyos a écrit

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

On Tue, Oct 17, 2017 at 07:26:01AM +0200, wm4 wrote: [...] > > > it also violates the API IMO, but thats not so much the point > > It does not. I created the fucking API. > > > The data the user application wants to attach to a AVFrame for the > > user applications extrenal purposes > > and >

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Dave, > > The President of AJA has publicly stated an intent to add an open license to > their SDK, https://twitter.com/ajaprez/status/910100436224499713 > . This is certainly good news. Looking at AJA’s offering is on my TODO list

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 6:49 PM, Ricardo Constantino wrote: There's a few other libs that require static-only Cflags (libxml2, at least), so openjpeg shouldn't be different. pkgconf does support Cflags.private, but no one uses it. To be fair, I did submit a pull request¹ to twolame that would have

Re: [FFmpeg-devel] [PATCH 7/9] hevc: Fix aligned array declarations

On Tue, Oct 17, 2017 at 10:12:23PM +0100, Mark Thompson wrote: > (cherry picked from commit d41e10c1485ec34aa342f7bc2e5bf4f9b6e66414) > --- > This and the following patches were found with the TI ARM compiler. > > > libavcodec/hevcdsp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [PATCH 8/9] cinepakenc: Move declaration out of for initialisation statement

On Tue, Oct 17, 2017 at 10:12:24PM +0100, Mark Thompson wrote: > (cherry picked from commit 92f0aceb36c6e4412d4cf346e70dc74b5a4069e9) > --- > libavcodec/cinepakenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 4/7] xfacedec: Fix possible overread

On Tue, Oct 17, 2017 at 11:11:56PM +0100, Mark Thompson wrote: > Fixes #6745. > --- > libavcodec/xfacedec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) this should not be needed, AVPacket.data should have padding at the end but also shouldnt do any harm [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 1/9] lavc: Mark functions where ignoring returned error code is always wrong

On Tue, Oct 17, 2017 at 10:12:17PM +0100, Mark Thompson wrote: > --- > libavcodec/avcodec.h | 10 ++ > 1 file changed, 10 insertions(+) if you checked that failure for each cannot be detected by another way then it should be ok thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/7] nutdec: Fix repeated condition

On Tue, Oct 17, 2017 at 11:11:54PM +0100, Mark Thompson wrote: > Fixes #6742. > --- > libavformat/nutdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ok, also please backport this if this issue was in releases thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 01:46:59PM -0700, Michael Bradshaw wrote: > On Wed, Oct 18, 2017 at 1:26 PM, Michael Niedermayer > wrote: > > > > correction, xenial and zesty have 2.1.* under the name libopenjp2-7 > > > > trusty does not though > > > Yeah, Ubuntu 14.04 is stuck

Re: [FFmpeg-devel] [PATCH 1/7] vf_cover_rect: Fix repeated condition

On Tue, Oct 17, 2017 at 11:11:53PM +0100, Mark Thompson wrote: > Fixes #6741. > --- > libavfilter/vf_cover_rect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Modern terrorism, a quick

Re: [FFmpeg-devel] decklink 24/32 bit question

On Wed, Oct 18, 2017 at 01:15:21PM -0700, Douglas Marsh wrote: [...] > *dither= I am not aware of any audio bit-depth dithering algorithms > in FFMPEG, however it would make sense they do exist as this > software is quite simply an amazing 'swiss-army knife' i didnt follow the thread but theres

Re: [FFmpeg-devel] [PATCH 5/7] mxfdec: Fix return value check

On Tue, Oct 17, 2017 at 11:11:57PM +0100, Mark Thompson wrote: > Move the assignment out of the condition, because that was hiding the error. > > Fixes #6750. > --- > libavformat/mxfdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 2/9] apngenc: Add missing error check

On Tue, Oct 17, 2017 at 10:12:18PM +0100, Mark Thompson wrote: > --- > libavformat/apngenc.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/libavformat/apngenc.c b/libavformat/apngenc.c > index 77c1c916c2..16ead54cc8 100644 > --- a/libavformat/apngenc.c >

[FFmpeg-devel] [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst entry count.

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 16 +++- tests/fate/mov.mak | 6 ++- tests/ref/fate/mov-invalid-elst-entry-count | 57 + 3 files changed, 76 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 5:04 PM, Michael Niedermayer wrote: > > i think the patch should add some note to the release notes or > changelog > I've added a note to the Changelog. Let me know if there are additional notices that should be made. Updated patch attached

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 19 October 2017 at 00:14, James Almer wrote: > On 10/18/2017 7:49 PM, Ricardo Constantino wrote: > > > There's a few other libs that require static-only Cflags (libxml2, at > > least), so openjpeg shouldn't be different. pkgconf does support > > Cflags.private, but no one

[FFmpeg-devel] [RFC] v4l2_m2m: Fix races around freeing data on close

Refcount all of the context information. --- As discussed in the other thread, something like this. We move most of the context into a refcounted buffer and AVCodecContext.priv_data is left as a stub holding a reference to it. Thoughts: * Change is rather ugly; some structures and function

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: fix access to priv_data after codec close.

On 18/10/17 08:46, Jorge Ramirez wrote: > On 10/18/2017 12:34 AM, Mark Thompson wrote: >>> int ff_v4l2_m2m_codec_end(AVCodecContext *avctx) >>> { >>> -V4L2m2mContext* s = avctx->priv_data; >>> -int ret; >>> +V4L2m2mContext *m2m, *s = avctx->priv_data; >>> +int i, ret; >>> >>>

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

On Wed, Oct 18, 2017 at 09:48:16AM -0400, Compn wrote: [...] > a third party might be able to settle the stalemate. i strongly support this. And it was in part why i suggested to take this to the vote comittee. Most people from the vote committee are uninvolved in this This should be carefully

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

> On Oct 17, 2017, at 3:30 PM, Douglas Marsh wrote: > > On 2017-10-17 09:10, Dave Rice wrote: > -audio_depth .D.. audio bitdepth (from 0 to 1) (default 16bits) 16bits .D.. > >>> Hmm, first patch might be enough. >>

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: support cropped height tag

On 10/17/2017 10:07 PM, James Almer wrote: > Ported from libav. Authored by one of the following: > > Anton Khirnov > Diego Biurrun > Vittorio Giovara > > Signed-off-by: James Almer > --- > libavcodec/cfhd.c

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

On Tue, 17 Oct 2017 20:37:32 +0200, Thilo Borgmann wrote: > I do care because I am delaying my work on some other cuvid related thing > because of this. > > I would prefer not to dive into this topic any further because it seems > rather "not so important" to my task.

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config check for alsa

On Mon, Oct 16, 2017 at 11:01 PM, Jan Ekström wrote: > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index b9a3a9bc1f..5aa642a9bb 100755 > --- a/configure > +++ b/configure > @@ -6254,7 +6254,8 @@ EOF > fi >

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

On Wed, 4 Oct 2017 11:34:18 +0200, wm4 wrote: > > more so, opaque_ref is used in only 5 lines in the whole codebase, > > so there is not much code to consider when using a different solution > > We shouldn't add such special fields, we have enough hacks already. Is > that

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config check for alsa

> Please apply. Got my key registered onto the system and pushed along with an update to the commit message noting the static linking use case. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

Thanks for the review! On Wed, Oct 18, 2017 at 12:26 PM, James Almer wrote: > > Add a line to Changelog about dropping support for OpenJPEG <= 2.0. > Done. > +enabled libopenjpeg && require_pkg_config libopenjpeg libopenjp2 > openjpeg.h opj_version > > OpenJPEG 2.0.1

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

On Mon, 16 Oct 2017, Dave Rice wrote: Hi, I tested this with my Ultrastudio Express and confirmed that I'm getting higher bit depth recordings with the abitscope filter. This patch adds an option to get 32 bit audio as an input with the decklink device (beforehand only 16 bit audio was

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: fix access to priv_data after codec close.

On 10/18/2017 03:28 PM, Mark Thompson wrote: On 18/10/17 08:46, Jorge Ramirez wrote: On 10/18/2017 12:34 AM, Mark Thompson wrote: int ff_v4l2_m2m_codec_end(AVCodecContext *avctx) { -V4L2m2mContext* s = avctx->priv_data; -int ret; +V4L2m2mContext *m2m, *s = avctx->priv_data; +

[FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

Hi, Attached patch drops support for OpenJPEG 1.3, 1.4, 1.5, and 2.0. After this patch, only versions 2.1 and above will be supported (and will require pkg-config). Tested locally on macOS with OpenJPEG 2.3 by both encoding and decoding a jp2 file. Please review. Thanks, --Michael

Re: [FFmpeg-devel] decklink 24/32 bit question

On Tue, 17 Oct 2017, Devin Heitmueller wrote: > The decklink sdk only defines two BMDAudioSampleType values: bmdAudioSampleType16bitInteger and bmdAudioSampleType32bitInteger. I don't think there's an easy way to support a 24 bit input here. Generally in this case I've used

Re: [FFmpeg-devel] [PATCH 6/9] opusenc: Fix double-declaration of variable

On 17/10/17 23:58, Rostislav Pehlivanov wrote: > On 17 October 2017 at 22:12, Mark Thompson wrote: > >> --- >> libavcodec/opusenc_psy.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/libavcodec/opusenc_psy.c b/libavcodec/opusenc_psy.c >> index b446d41f75..1b108ecb87

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

> On Oct 18, 2017, at 3:07 PM, Marton Balint wrote: > > On Mon, 16 Oct 2017, Dave Rice wrote: > >> Hi, >> >> I tested this with my Ultrastudio Express and confirmed that I'm getting >> higher bit depth recordings with the abitscope filter. This patch adds an >> option to get

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 3:43 PM, Michael Bradshaw wrote: > Hi, > > Attached patch drops support for OpenJPEG 1.3, 1.4, 1.5, and 2.0. After > this patch, only versions 2.1 and above will be supported (and will require > pkg-config). > > Tested locally on macOS with OpenJPEG 2.3 by both encoding and

Re: [FFmpeg-devel] decklink 24/32 bit question

Hello Marton, > On Oct 18, 2017, at 3:02 PM, Marton Balint wrote: > > > > On Tue, 17 Oct 2017, Devin Heitmueller wrote: > >>> > The decklink sdk only defines two BMDAudioSampleType values: >>> > bmdAudioSampleType16bitInteger and bmdAudioSampleType32bitInteger. I >>> >

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

On Wed, 18 Oct 2017, Michael Niedermayer wrote: On Wed, Oct 18, 2017 at 09:48:16AM -0400, Compn wrote: [...] a third party might be able to settle the stalemate. i strongly support this. And it was in part why i suggested to take this to the vote comittee. Most people from the vote

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

> On Oct 6, 2017, at 12:56 PM, Devin Heitmueller > wrote: > > From: Devin Heitmueller > > Hook in libklvanc and use it for output of EIA-708 captions over > SDI. The bulk of this patch is just general support for ancillary > data for

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2: fix access to priv_data after codec close.

On Wed, Oct 18, 2017 at 09:46:40AM +0200, Jorge Ramirez wrote: > On 10/18/2017 12:34 AM, Mark Thompson wrote: > >> int ff_v4l2_m2m_codec_end(AVCodecContext *avctx) > >> { > >>-V4L2m2mContext* s = avctx->priv_data; > >>-int ret; > >>+V4L2m2mContext *m2m, *s = avctx->priv_data; > >>+

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

On Wed, 18 Oct 2017, Dave Rice wrote: On Oct 18, 2017, at 3:07 PM, Marton Balint wrote: On Mon, 16 Oct 2017, Dave Rice wrote: Hi, I tested this with my Ultrastudio Express and confirmed that I'm getting higher bit depth recordings with the abitscope filter. This patch

[FFmpeg-devel] [PATCH 2/2] fate: add fate test for ticket #6375

Signed-off-by: Marton Balint --- tests/fate/ffmpeg.mak | 4 + tests/ref/fate/ffmpeg-attached_pics | 141 2 files changed, 145 insertions(+) create mode 100644 tests/ref/fate/ffmpeg-attached_pics diff --git

[FFmpeg-devel] [PATCH 1/2] fate: add fate test for ticket #6603

Signed-off-by: Marton Balint --- tests/fate/ffmpeg.mak | 4 tests/ref/fate/ffmpeg-filter_complex_audio | 10 ++ 2 files changed, 14 insertions(+) create mode 100644 tests/ref/fate/ffmpeg-filter_complex_audio diff --git a/tests/fate/ffmpeg.mak

Re: [FFmpeg-devel] [PATCH] ffmpeg: always init output stream before reaping filters

On Thu, 12 Oct 2017, Marton Balint wrote: On Sun, 8 Oct 2017, Marton Balint wrote: On Sat, 7 Oct 2017, Hendrik Leppkes wrote: On Wed, Oct 4, 2017 at 12:48 AM, Marton Balint wrote: Otherwise the frame size of the codec is not set in the buffersink. Fixes ticket #6603

Re: [FFmpeg-devel] decklink 24/32 bit question

On 2017-10-17 12:44, Devin Heitmueller wrote: The decklink sdk only defines two BMDAudioSampleType values: bmdAudioSampleType16bitInteger and bmdAudioSampleType32bitInteger. I don't think there's an easy way to support a 24 bit input here. Generally in this case I've used

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 10:22:13PM +0200, Michael Niedermayer wrote: > On Wed, Oct 18, 2017 at 12:46:13PM -0700, Michael Bradshaw wrote: > > Thanks for the review! > > > > On Wed, Oct 18, 2017 at 12:26 PM, James Almer wrote: > > > > > > Add a line to Changelog about dropping

Re: [FFmpeg-devel] decklink 24/32 bit question

Hi Doug, > On Oct 18, 2017, at 4:15 PM, Douglas Marsh wrote: > > I am not really sure I follow. I am not sure supporting 24-bit is a big > issue. A sample size of 32-bit should work fine for most folks. I can only > think of people (in the output stream) converting to 24-bits

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 1:26 PM, Michael Niedermayer wrote: > > correction, xenial and zesty have 2.1.* under the name libopenjp2-7 > > trusty does not though Yeah, Ubuntu 14.04 is stuck on the ancient OpenJPEG 1.3. I think it's fine to proceed with this patch since:

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 18 October 2017 at 23:22, James Almer wrote: > On 10/18/2017 6:56 PM, Michael Bradshaw wrote: > > -DOPJ_STATIC was originally added to ffmpeg's configure script for > Windows. > > Unconditionally adding -DOPJ_STATIC would conflict with people who are > > dynamically

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

Patch LGTM. Thanks. On Wed, Oct 18, 2017 at 4:14 PM, Dale Curtis wrote: > On Wed, Oct 18, 2017 at 4:00 PM, Sasi Inguva wrote: > >> Thanks for the patch. The bug is because mov_fix_index updates >> skip_samples correctly, but not start_pad. Can you

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 18-10-2017 21:46, Michael Bradshaw wrote: > From fb8334d0cecc889ebce3af968c56a3afbd2f6047 Mon Sep 17 00:00:00 2001 > From: Michael Bradshaw > Date: Wed, 18 Oct 2017 11:34:06 -0700 > Subject: [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 19-10-2017 0:22, James Almer wrote: > It think the following should be enough: >> enabled libopenjpeg && { use_pkg_config libopenjpeg "libopenjp2 >= >> 2.1.0" openjpeg.h opj_version || >>{ require_pkg_config libopenjpeg "libopenjp2 >>

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 7:49 PM, Ricardo Constantino wrote: > On 18 October 2017 at 23:22, James Almer wrote: > >> On 10/18/2017 6:56 PM, Michael Bradshaw wrote: >>> -DOPJ_STATIC was originally added to ffmpeg's configure script for >> Windows. >>> Unconditionally adding -DOPJ_STATIC

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

On Wed, Oct 18, 2017 at 4:00 PM, Sasi Inguva wrote: > Thanks for the patch. The bug is because mov_fix_index updates > skip_samples correctly, but not start_pad. Can you instead of taking the > max, just update the mov_fix_index function so that start_pad = > skip_samples

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 5:46 PM, Michael Bradshaw wrote: > On Wed, Oct 18, 2017 at 1:26 PM, Michael Niedermayer > wrote: >> >> correction, xenial and zesty have 2.1.* under the name libopenjp2-7 >> >> trusty does not though > > > Yeah, Ubuntu 14.04 is stuck on the ancient OpenJPEG

Re: [FFmpeg-devel] [PATCH] lavf: add more beep options to sine asrc

Sorry for the long delay in my response! On Sun, Oct 8, 2017 at 11:14 AM, Nicolas George wrote: > > Le quintidi 15 vendémiaire, an CCXXVI, Michael Bradshaw a écrit : > > +OPT_DBL("beep_delay",beep_delay, 0, 0, > DBL_MAX, "set the delay for the first

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

> On Oct 6, 2017, at 5:31 PM, Devin Heitmueller > wrote: > >> Sorry, what I meant was: >> Nothing inside FFmpeg except the decklink device could use >> VANC? > > Ah, I understand now. > > Yes, the decklink device is currently the only SDI device which is supported

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 2:44 PM, Reino Wijnsma wrote: > > Is there a reason you left out -DOPJ_STATIC? > I assumed OpenJPEG's pkgconfig file would be smart enough to add it in if needed. Apparently that's not the case. Dang.

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

Hi Deron, > I was going to actually test this with some old broadcast equipment I have > just dying for a purpose, but I don't see how to generate AV_PKT_DATA_A53_CC > side packet data except using the Decklink capture. I have A53 documentation, > but it just refers to CEA-708 (or SMPTE 334,

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 7:49 PM, Reino Wijnsma wrote: > On 19-10-2017 0:22, James Almer wrote: >> It think the following should be enough: >>> enabled libopenjpeg && { use_pkg_config libopenjpeg "libopenjp2 >= >>> 2.1.0" openjpeg.h opj_version || >>>

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 12:46:13PM -0700, Michael Bradshaw wrote: > Thanks for the review! > > On Wed, Oct 18, 2017 at 12:26 PM, James Almer wrote: > > > > Add a line to Changelog about dropping support for OpenJPEG <= 2.0. > > > > Done. > > > +enabled libopenjpeg &&

Re: [FFmpeg-devel] [PATCH RFC] libavdevice/decklink: Add support for EIA-708 output over SDI

On 10/18/17 1:31 PM, Devin Heitmueller wrote: On Oct 6, 2017, at 12:56 PM, Devin Heitmueller wrote: From: Devin Heitmueller Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

Thanks for the patch. The bug is because mov_fix_index updates skip_samples correctly, but not start_pad. Can you instead of taking the max, just update the mov_fix_index function so that start_pad = skip_samples always. Something like this diff --git a/libavformat/mov.c b/libavformat/mov.c index

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 6:56 PM, Michael Bradshaw wrote: > -DOPJ_STATIC was originally added to ffmpeg's configure script for Windows. > Unconditionally adding -DOPJ_STATIC would conflict with people who are > dynamically linking. I'll look into this further. I'll start with the > following: > > enabled

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

Am 18.10.17 um 16:02 schrieb Compn: > On Wed, 4 Oct 2017 11:34:18 +0200, wm4 wrote: > >>> more so, opaque_ref is used in only 5 lines in the whole codebase, >>> so there is not much code to consider when using a different solution >> >> We shouldn't add such special