Re: [FFmpeg-devel] [PATCH 2/5] h264_metadata: Add support for A/53 closed captions

2018-03-26 Thread Mark Thompson
On 27/03/18 01:20, Michael Niedermayer wrote: > On Sun, Mar 25, 2018 at 06:41:34PM +0100, Mark Thompson wrote: >> Allows insertion (from side data), extraction (to side data), and removal >> of closed captions in SEI messages. >> --- >> libavcodec/Makefile| 2 +- >>

[FFmpeg-devel] [PATCH] avfilter: add OpenCL scale filter

2018-03-26 Thread Gabriel Machado
From: Gabriel Machado Some scaling filters implemented as OpenCL kernels. Can be used as: scale_opencl=::flags= where can be `neighbor', `bilinear', `bicubic' or `fast_bicubic' This is an initial draft, there's still a long way to go in terms of completeness,

Re: [FFmpeg-devel] [PATCH 2/5] h264_metadata: Add support for A/53 closed captions

2018-03-26 Thread James Almer
On 3/26/2018 9:31 PM, Mark Thompson wrote: > On 27/03/18 01:20, Michael Niedermayer wrote: >> On Sun, Mar 25, 2018 at 06:41:34PM +0100, Mark Thompson wrote: >>> Allows insertion (from side data), extraction (to side data), and removal >>> of closed captions in SEI messages. >>> --- >>>

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: Support signaling of last segment number

2018-03-26 Thread Steven Liu
> On 26 Mar 2018, at 04:01, sanilraut wrote: > > Last segment indicated by mpd is not parsed. > Example stream: > http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd > > This patch supports parsing of Supplemental

Re: [FFmpeg-devel] [PATCH] kmsgrab: add category for kmsgrab

2018-03-26 Thread Jun Zhao
On 2018/3/27 6:01, Mark Thompson wrote: > On 26/03/18 01:22, Jun Zhao wrote: >> From fc9b04d95b1e21fa9985dc611fcf43d2a4c635c0 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Fri, 23 Mar 2018 21:32:03 +0800 >> Subject: [PATCH] kmsgrab: add category for kmsgrab >> >> add

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-26 Thread Paul B Mahol
On 3/26/18, Michael Niedermayer wrote: > On Wed, Mar 21, 2018 at 09:18:21AM +0100, Paul B Mahol wrote: >> On 3/20/18, Michael Niedermayer wrote: >> > Signed-off-by: Michael Niedermayer >> > --- >> > libavfilter/vf_scale.c

Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: Document skip_bits_long()

2018-03-26 Thread Michael Niedermayer
On Fri, Mar 23, 2018 at 10:02:39PM +0100, Thilo Borgmann wrote: > Am 23.03.18 um 20:20 schrieb Michael Niedermayer: > > Found-by: Kieran > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/get_bits.h | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-26 Thread Martin Vignali
> >> This is not optimal, as full color_range should remain full when not > >> changed. > > > > there is no range for rgb formats. The range is specific to YUV based > > formats. > > Thats, if iam guessing correctly what you meant. You did not really say > > which case you meant here. So maybe

Re: [FFmpeg-devel] [PATCH] avcodec/openh264enc.c: generate IDR frame in response to I frame pict_type

2018-03-26 Thread Valery Kot
On Tue, Mar 20, 2018 at 9:21 AM, Valery Kot wrote: > On Fri, Mar 16, 2018 at 3:04 PM, Valery Kot wrote: >> >> Attached is an updated patch incorporating all feedback - only >> formatting for now. >> >> Friendly ping to maintainers to review and pull

Re: [FFmpeg-devel] [V2 1/2] lavc/vaapi_encode: fix the caculation overflow

2018-03-26 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Pengfei Qu > Sent: Monday, March 26, 2018 1:51 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Qu, Pengfei > Subject: [FFmpeg-devel] [V2 1/2] lavc/vaapi_encode: fix the caculation > overflow > > this fix

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-26 Thread Paul B Mahol
On 3/26/18, Martin Vignali wrote: >> >> This is not optimal, as full color_range should remain full when not >> >> changed. >> > >> > there is no range for rgb formats. The range is specific to YUV based >> > formats. >> > Thats, if iam guessing correctly what you meant.

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: initialize saveptrs

2018-03-26 Thread Liu Steven
> 在 2018年3月26日,上午11:49,Jeyapal, Karthick 写道: > > > > On 3/25/18 1:43 PM, Timo Rothenpieler wrote: >> Am 21.03.2018 um 20:37 schrieb Timo Rothenpieler: >>> Am 21.03.2018 um 20:33 schrieb Timo Rothenpieler: av_strtok calls strspn on a non-NULL *saveptr, so not NULL

Re: [FFmpeg-devel] [PATCH 2/5] h264_metadata: Add support for A/53 closed captions

2018-03-26 Thread Alex Giladi
Is there any documentation on the side data file format? On Sun, Mar 25, 2018 at 6:18 PM, James Almer wrote: > On 3/25/2018 2:41 PM, Mark Thompson wrote: > > Allows insertion (from side data), extraction (to side data), and removal > > of closed captions in SEI messages. > >

[FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-03-26 Thread Alexander Kravchenko
Hello, I have fixed issues listed in previous patch. > Say what the change is in the title. Something like "amfenc: Retain a > reference to D3D11 frames used as input during the encoding > process", maybe? Sure, but I am preparing next patch adding DX9 support, so probably better to write D3D

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

2018-03-26 Thread Даниил Чередник
Hi. Yes, I reproduced it on mac. A bit strange, I run fate with valgrind during patch preparation, it was ok. I will fix it, and send updated patch. Thank you! On Sun, Mar 25, 2018 at 5:57 PM, Michael Niedermayer wrote: > On Sun, Mar 25, 2018 at 01:55:42PM +0300,

Re: [FFmpeg-devel] [PATCH] lavfi: Add OpenCL avgblur filter

2018-03-26 Thread Dylan Fernando
On Fri, Mar 23, 2018 at 9:10 PM, Carl Eugen Hoyos wrote: > 2018-03-21 14:09 GMT+01:00, Dylan Fernando : > > > What information should I put in my GSoC application? How should I > > structure it? Should I give a rough timeline detailing exactly which >

[FFmpeg-devel] [PATCH 2/5] avformat/utils: optimize ff_packet_list_free()

2018-03-26 Thread James Almer
Don't contantly overwrite the list's head pointer. Signed-off-by: James Almer --- libavformat/utils.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index cb1ea5b386..9faffa03a3 100644 ---

[FFmpeg-devel] [PATCH 4/5] avformat/ttaenc: use AVPacketList helper functions to queue packets

2018-03-26 Thread James Almer
Simplifies code. Signed-off-by: James Almer --- libavformat/ttaenc.c | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/libavformat/ttaenc.c b/libavformat/ttaenc.c index add15873d0..8a8b565871 100644 --- a/libavformat/ttaenc.c +++

[FFmpeg-devel] [PATCH 5/5] avformat/mp3enc: use AVPacketList helper functions to queue packets

2018-03-26 Thread James Almer
Simplifies code. Signed-off-by: James Almer --- libavformat/mp3enc.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index 8479e2485b..78e231fbfd 100644 --- a/libavformat/mp3enc.c +++

[FFmpeg-devel] [PATCH 1/5] avformat/utils: make AVPacketList helper functions shared

2018-03-26 Thread James Almer
Based on a patch by Luca Barbato. Signed-off-by: James Almer --- libavformat/internal.h | 35 ++ libavformat/utils.c| 51 +++--- 2 files changed, 63 insertions(+), 23 deletions(-) diff --git

[FFmpeg-devel] [PATCH 3/5] avformat/matroskadec: use AVPacketList to queue packets

2018-03-26 Thread James Almer
It's more robust and efficient. Signed-off-by: James Almer --- libavformat/matroskadec.c | 62 ++- 1 file changed, 23 insertions(+), 39 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index

Re: [FFmpeg-devel] Moving enum AVFieldOrder to libavutil?

2018-03-26 Thread Devin Heitmueller
Hello all, > On Mar 24, 2018, at 6:37 AM, Michael Niedermayer > wrote: > > On Sat, Mar 24, 2018 at 01:07:48AM +0100, Marton Balint wrote: >> >> >> On Fri, 23 Mar 2018, Devin Heitmueller wrote: >> >>> Hello, >>> >>> I am in the process of reworking libavfilter to

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-03-26 Thread misty
From: Misty De Meo --- Changelog | 1 + doc/general.texi | 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 377 ++ libavformat/version.h |

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-03-26 Thread misty
From: Misty De Meo I reviewed the contributing guide one more time, and noticed I'd missed two items from the new muxer list. Updated the patch with: * Marked Sega FILM as having a muxer in general.texi * Bumped the minor version of libavformat Misty De Meo (1): Add

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-26 Thread Gyan Doshi
On 3/24/2018 7:39 AM, Michael Niedermayer wrote: On Thu, Mar 22, 2018 at 11:04:21PM +0530, Gyan Doshi wrote: Fixes #7091 --- libavformat/segafilm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) should be ok Ping for push. There's a pending patch by another user blocked by

[FFmpeg-devel] [GSoC] proposal idea: Color Constancy using Machine Learning

2018-03-26 Thread Mina
Hi,   I'm proposing a Color Constancy filter as a project idea for GSoC and was asking for any remarks about that idea.   Color constancy is the ability of the human visual system that ensures the perception of the color of objects to remain relatively constant under varying illumination

[FFmpeg-devel] [DEMO][PATCH] avcodec/eac3: add support for dependent stream

2018-03-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Need proper channel mapping support. libavcodec/aac_ac3_parser.c | 7 ++-- libavcodec/aac_ac3_parser.h | 2 ++ libavcodec/ac3_parser.c | 29 +-- libavcodec/ac3dec.c | 88 ++---

Re: [FFmpeg-devel] [PATCH 2/2] doc/examples/hw_decode: Remove logically dead code in decode_write()

2018-03-26 Thread Michael Niedermayer
On Mon, Mar 26, 2018 at 08:15:49AM +0800, Jun Zhao wrote: > > > On 2018/3/26 2:21, Michael Niedermayer wrote: > > Fixes CID1415951 > > > > Signed-off-by: Michael Niedermayer > > --- > > doc/examples/hw_decode.c | 4 +--- > > 1 file changed, 1 insertion(+), 3

[FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-03-26 Thread Alexander Kravchenko
Fixed issues of previous patch --- libavcodec/amfenc.c | 82 ++--- 1 file changed, 78 insertions(+), 4 deletions(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 89a10ff253..5f3440a9f3 100644 --- a/libavcodec/amfenc.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

2018-03-26 Thread Даниил Чередник
Now it should be fine. Second patch has been fixed. On Mon, Mar 26, 2018 at 3:59 PM, Даниил Чередник wrote: > Hi. > Yes, I reproduced it on mac. A bit strange, I run fate with valgrind > during patch preparation, it was ok. > I will fix it, and send updated patch. > >

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-03-26 Thread James Almer
On 3/26/2018 7:41 AM, Alexander Kravchenko wrote: > Hello, > I have fixed issues listed in previous patch. > > >> Say what the change is in the title. Something like "amfenc: Retain a >> reference to D3D11 frames used as input during the encoding >> process", maybe? > Sure, but I am preparing

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-26 Thread Mark Thompson
On 26/03/18 22:44, Michael Niedermayer wrote: > On Mon, Mar 26, 2018 at 08:34:06AM +0200, Paul B Mahol wrote: >> On 3/26/18, Michael Niedermayer wrote: >>> On Wed, Mar 21, 2018 at 09:18:21AM +0100, Paul B Mahol wrote: On 3/20/18, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/5] h264_metadata: Add support for A/53 closed captions

2018-03-26 Thread Mark Thompson
On 26/03/18 14:33, Alex Giladi wrote: > Is there any documentation on the side data file format? The format for the side data is the existing one used in AV_PKT_DATA_A53_CC. The documentation for that could probably be improved - basically it's just a sequence of the 3-byte CC data packets as

Re: [FFmpeg-devel] [PATCH 2/5] h264_metadata: Add support for A/53 closed captions

2018-03-26 Thread Mark Thompson
On 26/03/18 01:18, James Almer wrote: > On 3/25/2018 2:41 PM, Mark Thompson wrote: >> Allows insertion (from side data), extraction (to side data), and removal >> of closed captions in SEI messages. >> --- >> libavcodec/Makefile| 2 +- >> libavcodec/h264_metadata_bsf.c | 138 >>

Re: [FFmpeg-devel] [PATCH] kmsgrab: add category for kmsgrab

2018-03-26 Thread Mark Thompson
On 26/03/18 01:22, Jun Zhao wrote: > > From fc9b04d95b1e21fa9985dc611fcf43d2a4c635c0 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Fri, 23 Mar 2018 21:32:03 +0800 > Subject: [PATCH] kmsgrab: add category for kmsgrab > > add category for kmsgrab, then we can display

Re: [FFmpeg-devel] Moving enum AVFieldOrder to libavutil?

2018-03-26 Thread Michael Niedermayer
On Mon, Mar 26, 2018 at 11:48:01AM -0400, Devin Heitmueller wrote: > Hello all, > > > On Mar 24, 2018, at 6:37 AM, Michael Niedermayer > > wrote: > > > > On Sat, Mar 24, 2018 at 01:07:48AM +0100, Marton Balint wrote: > >> > >> > >> On Fri, 23 Mar 2018, Devin

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-03-26 Thread Mark Thompson
On 26/03/18 11:41, Alexander Kravchenko wrote: Put email comments on a patch below the "---" line (otherwise they end up in the commit message when applied). > Hello, > I have fixed issues listed in previous patch. > > >> Say what the change is in the title. Something like "amfenc: Retain a

Re: [FFmpeg-devel] [PATCH 0/1] libavfilter: Add OpenCL convolution filter v0.2

2018-03-26 Thread Mark Thompson
On 24/03/18 15:57, Danil Iashchenko wrote: > Behaves like existing convolution filter. > > Patch uses global kernel. > > --- > configure | 1 + > libavfilter/Makefile| 1 + > libavfilter/allfilters.c| 1 + >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_avgblur_opencl: fix error when clSetKernelArg fails

2018-03-26 Thread Mark Thompson
On 26/03/18 01:08, dylanf...@gmail.com wrote: > From: drfer3 > > Fixes Coverity CID 1430382 > --- > libavfilter/vf_avgblur_opencl.c | 6 ++ > 1 file changed, 6 insertions(+) LGTM, applied this along with the image size one. Thanks, - Mark

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-26 Thread Michael Niedermayer
On Mon, Mar 26, 2018 at 10:56:47PM +0100, Mark Thompson wrote: > On 26/03/18 22:44, Michael Niedermayer wrote: > > On Mon, Mar 26, 2018 at 08:34:06AM +0200, Paul B Mahol wrote: > >> On 3/26/18, Michael Niedermayer wrote: > >>> On Wed, Mar 21, 2018 at 09:18:21AM +0100, Paul

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-03-26 Thread Kravchenko, Alexander
> > Put email comments on a patch below the "---" line (otherwise they end up in > the commit message when applied). > Sorry, I am not sure I understand you correctly here > > +#define AMF_AV_GET_PROPERTY_INTERFACE(res, pThis, name, TargetType, val) \ > > +{ \ > > +AMFVariantStruct

Re: [FFmpeg-devel] [PATCH V2] ffmpeg_filter: enable stream_loop in HWAccel transcoding.

2018-03-26 Thread Mark Thompson
On 26/03/18 02:25, Jun Zhao wrote: > V2: simplified the logic as Michael's review. > > From 6c332c65d64977c4d6220acfb7e9db3505281f87 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Wed, 14 Mar 2018 16:13:39 +0800 > Subject: [PATCH V2] ffmpeg_filter: enable stream_loop in

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-26 Thread James Almer
On 3/26/2018 3:27 PM, Gyan Doshi wrote: > On 3/24/2018 7:39 AM, Michael Niedermayer wrote: >> On Thu, Mar 22, 2018 at 11:04:21PM +0530, Gyan Doshi wrote: > >>> >>> Fixes #7091 >>> --- >>>   libavformat/segafilm.c | 3 ++- >>>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> should be ok > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-26 Thread Michael Niedermayer
On Mon, Mar 26, 2018 at 08:34:06AM +0200, Paul B Mahol wrote: > On 3/26/18, Michael Niedermayer wrote: > > On Wed, Mar 21, 2018 at 09:18:21AM +0100, Paul B Mahol wrote: > >> On 3/20/18, Michael Niedermayer wrote: > >> > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-03-26 Thread Michael Niedermayer
On Mon, Mar 26, 2018 at 12:50:41PM +0200, Paul B Mahol wrote: > On 3/26/18, Martin Vignali wrote: > >> >> This is not optimal, as full color_range should remain full when not > >> >> changed. > >> > > >> > there is no range for rgb formats. The range is specific to YUV

Re: [FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-03-26 Thread Michael Niedermayer
On Mon, Mar 26, 2018 at 01:41:20PM +0300, Alexander Kravchenko wrote: > Hello, > I have fixed issues listed in previous patch. > > > > Say what the change is in the title. Something like "amfenc: Retain a > > reference to D3D11 frames used as input during the encoding > > process", maybe? >

Re: [FFmpeg-devel] [PATCH 2/5] h264_metadata: Add support for A/53 closed captions

2018-03-26 Thread Michael Niedermayer
On Sun, Mar 25, 2018 at 06:41:34PM +0100, Mark Thompson wrote: > Allows insertion (from side data), extraction (to side data), and removal > of closed captions in SEI messages. > --- > libavcodec/Makefile| 2 +- > libavcodec/h264_metadata_bsf.c | 138 >

[FFmpeg-devel] [PATCH] hwcontext_d3d11: Fix crash with valid adapter but no device

2018-03-26 Thread Mark Thompson
This crash was introduced by 8bbf2dacbfb4ead1535dea411035994f507f517d, which could incorrectly overwrite the failure result from creating the device. Fixes ticket #7108. --- libavutil/hwcontext_d3d11va.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git