Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-04 Thread Mattias Amnefelt
On 2018-04-04 03:42, James Almer wrote: On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: 2018-04-04 3:38 GMT+02:00, James Almer : On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: 2018-04-03 7:58 GMT+02:00, Mattias Amnefelt : Yes, my feeling was also that it's better to handle this when possible. Y

[FFmpeg-devel] [PATCH v2 01/11] avformat/dashenc: replacing 'min_seg_duration' with 'seg_duration'

2018-04-04 Thread vdixit
From: Vishwanath Dixit --- doc/muxers.texi | 4 +++- libavformat/dashenc.c | 17 - libavformat/version.h | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index cb75c26..a5358e3 100644 --- a/doc/muxers.texi +++ b/doc

[FFmpeg-devel] [PATCH v2 05/11] avformat/dashenc: setting @availabilityStartTime when the first frame is ready

2018-04-04 Thread vdixit
From: Vishwanath Dixit @availabilityStartTime specifies the anchor for the computation of the earliest availability time (in UTC) for any Segment in the Media Presentation. As per this requirement, the @AvailabilityStartTime should be set to the wallclock time at which the first frame of the fir

[FFmpeg-devel] [PATCH v2 02/11] avformat/dashenc: segmentation at the configured segment duration rate

2018-04-04 Thread vdixit
From: Vishwanath Dixit When use_template is enabled and use_timeline is disabled, typically it is required to generate the segments at the configured segment duration rate on an average. This commit is particularly needed to handle the segmentation when video frame rates are fractional like 29.97

[FFmpeg-devel] [PATCH v2 03/11] avformat/dashenc: writing average segment duration for @duration in template mode

2018-04-04 Thread vdixit
From: Vishwanath Dixit --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 54ccf30..e719409 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -345,7 +345,7 @@ static void output_segment_

[FFmpeg-devel] [PATCH v2 04/11] avformat/dashenc: removed 'write_manifest' call from 'write_header'

2018-04-04 Thread vdixit
From: Vishwanath Dixit Calling 'write_manifest' from 'write_header' was causing creation of first MPD with invalid values. Ex: zero @duration param value. Also, the manifest files (MPD or M3U8s) should be created when at-least one media frame is ready for consumption. --- libavformat/dashenc.c |

[FFmpeg-devel] [PATCH v2 08/11] avformat/dashenc: addition of muxer overhead in master playlist's bandwidth

2018-04-04 Thread vdixit
From: Vishwanath Dixit --- libavformat/dashenc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 0fff91f..72431b7 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -825,20 +825,23 @@ static int write_m

[FFmpeg-devel] [PATCH v2 06/11] avformat/dashenc: addition of @availabilityTimeOffset in MPD

2018-04-04 Thread vdixit
From: Vishwanath Dixit availability time of Nth segment = availabilityStartTime + (N*segment duration) - availabilityTimeOffset. This field helps to reduce the latency by about a segment duration in streaming mode. --- libavformat/dashenc.c | 14 +- 1 file changed, 13 insertions(+)

[FFmpeg-devel] [PATCH v2 10/11] avformat/dashenc: addition of muxer overhead for @bandwidth param in MPD

2018-04-04 Thread vdixit
From: Vishwanath Dixit --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 31b0c92..ac05378 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -553,7 +553,7 @@ static int write_adaptation

[FFmpeg-devel] [PATCH v2 07/11] avformat/dashenc: logic to compute muxer overhead

2018-04-04 Thread vdixit
From: Vishwanath Dixit --- libavformat/dashenc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 5921ef7..0fff91f 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -86,6 +86,8 @@ typedef struct OutputStream {

[FFmpeg-devel] [PATCH v2 09/11] avformat/dashenc: constructing MPD's bandwidth string locally

2018-04-04 Thread vdixit
From: Vishwanath Dixit --- libavformat/dashenc.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 72431b7..31b0c92 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -78,7 +78,6 @@ typedef

[FFmpeg-devel] [PATCH v2 11/11] avformat/dashenc: addition of segment index correction logic

2018-04-04 Thread vdixit
From: Vishwanath Dixit The logic is applicable only when use_template is enabled and use_timeline is disabled. The logic monitors the flow of segment indexes. If a streams's segment index value is not at the expected real time position, then the logic corrects that index value. Typically this lo

Re: [FFmpeg-devel] [PATCH] avformat/utils: Stream specifier enhancement

2018-04-04 Thread Bodecs Bela
2018.04.04. 2:37 keltezéssel, Michael Niedermayer írta: On Sun, Apr 01, 2018 at 11:42:34PM +0200, Bodecs Bela wrote: Dear All, currently when specifying the program id you can only decide to select all stream of the specified program (e.g. p:103 will select all streams of program 103) or narr

Re: [FFmpeg-devel] [PATCH 01/11] avformat/dashenc: renamed 'min_seg_duration' to 'seg_duration'

2018-04-04 Thread Dixit, Vishwanath
On 3/23/18 12:02 PM, Steven Liu wrote: > > >> On 23 Mar 2018, at 13:20, vdi...@akamai.com wrote: >> >> From: Vishwanath Dixit >> >> --- >> doc/muxers.texi | 2 +- >> libavformat/dashenc.c | 10 +- >> 2 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH 01/11] avformat/dashenc: renamed 'min_seg_duration' to 'seg_duration'

2018-04-04 Thread Dixit, Vishwanath
On 3/23/18 7:22 PM, Aurelien Jacobs wrote: > On Fri, Mar 23, 2018 at 02:32:30PM +0800, Steven Liu wrote: >> >> >>> On 23 Mar 2018, at 13:20, vdi...@akamai.com wrote: >>> >>> From: Vishwanath Dixit >>> >>> --- >>> doc/muxers.texi | 2 +- >>> libavformat/dashenc.c | 10 +- >>> 2 files

Re: [FFmpeg-devel] [PATCH 05/11] avformat/dashenc: setting @availabilityStartTime when the first frame is ready

2018-04-04 Thread Dixit, Vishwanath
On 4/2/18 9:29 AM, Jeyapal, Karthick wrote: > > > On 3/23/18 10:56 AM, vdi...@akamai.com wrote: >> From: Vishwanath Dixit >> >> @availabilityStartTime specifies the anchor for the computation of the >> earliest >> availability time (in UTC) for any Segment in the Media Presentation. > Please be

Re: [FFmpeg-devel] [PATCH 06/11] avformat/dashenc: addition of @availabilityTimeOffset in MPD

2018-04-04 Thread Dixit, Vishwanath
On 4/2/18 9:36 AM, Jeyapal, Karthick wrote: > > > On 3/23/18 10:57 AM, vdi...@akamai.com wrote: >> From: Vishwanath Dixit >> >> availability time of Nth segment = availabilityStartTime + (N*segment >> duration) - availabilityTimeOffset. >> This field helps to reduce the latency by about a segme

[FFmpeg-devel] [PATCH] lavf/qsvvpp: bypass vpp if not needed.

2018-04-04 Thread Zhong Li
Currently vpp pipeline is always created, even for the unnecessary cases such as setting the option "vpp_qsv=w=1280:h=720" for an input with native resolution 1280x720. Thus introduces unnecessary performance dropping, so bypass vpp if not needed. Signed-off-by: Zhong Li --- libavfilter/vf_vpp_q

[FFmpeg-devel] [PATCH] lavc/qsvenc: fix the hard code of height aligment checking

2018-04-04 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index afb953e..573c11e 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c @@ -1051,7 +1051,7 @@ static int submit_frame(QSVEncConte

[FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-04 Thread Gyan Doshi
From f86916b9e1128a4e41501f4d5b189749a344862f Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Wed, 4 Apr 2018 15:45:18 +0530 Subject: [PATCH] avformat/rawenc: check stream type Validate codec of stream to be muxed except for data muxer. --- libavformat/rawenc.c | 10 ++ 1 file changed, 1

[FFmpeg-devel] [PATCH v2 1/1] avformat/http: flushing tcp receive buffer when it is write only mode

2018-04-04 Thread vdixit
From: Vishwanath Dixit In write only mode, the TCP receive buffer's data keeps growing with http response messages and the buffer eventually becomes full. This results in zero tcp window size, which in turn causes unwanted issues, like, terminated tcp connection. The issue is apparent when http p

Re: [FFmpeg-devel] [PATCH 1/1] avformat/http: flushing tcp receive buffer when it is write only mode

2018-04-04 Thread Dixit, Vishwanath
On 3/28/18 11:00 AM, Steven Liu wrote: > > >> On 28 Mar 2018, at 12:52, vdi...@akamai.com wrote: >> >> From: Vishwanath Dixit >> >> In write only mode, the TCP receive buffer keeps growing and eventually >> becomes full. This results in zero tcp window size, which in turn causes >> unwanted issu

Re: [FFmpeg-devel] [PATCH v2 1/1] avformat/http: flushing tcp receive buffer when it is write only mode

2018-04-04 Thread Steven Liu
> On 4 Apr 2018, at 19:08, vdi...@akamai.com wrote: > > From: Vishwanath Dixit > > In write only mode, the TCP receive buffer's data keeps growing with > http response messages and the buffer eventually becomes full. > This results in zero tcp window size, which in turn causes unwanted > issue

[FFmpeg-devel] [PATCH 3/3] avformat/vivo: add support for siren codec

2018-04-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 6a88a09a01..1339a609b9 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -232,6 +232,11 @@ static int vivo_read_header(AVFormatContex

[FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2018-04-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 8 + libavcodec/siren.c | 847 5 files changed, 858 insertions(+) create mode 10064

[FFmpeg-devel] [PATCH 2/3] avformat/vivo: improve probing of some files

2018-04-04 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/vivo.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index c9e9c37f37..6a88a09a01 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -59,9 +59,10 @@ static int vivo_probe(AVProb

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2018-04-04 Thread James Almer
On 4/4/2018 11:09 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 8 + > libavcodec/siren.c | 847 >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: add siren audio decoder

2018-04-04 Thread Paul B Mahol
On 4/4/18, James Almer wrote: > On 4/4/2018 11:09 AM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/avcodec.h| 1 + >> libavcodec/codec_desc.c | 8 + >> libavcodec/siren.c | 847 >>

[FFmpeg-devel] [PATCH] display: Add AVDisplayOrientation API

2018-04-04 Thread Vittorio Giovara
The transformation operations that can be described by a display matrix are not limited to pure rotation, but include horizontal and vertical flip, as well as transpose and antitranspose. Unfortunately the current API can only return a rotation angle in degrees, and is not designed to detect flip o

[FFmpeg-devel] [PATCH] avcodec/decode: fix warning when decoding pseudo paletted formats

2018-04-04 Thread wm4
The pseudo palette allocation is optional now. But if it's still allocated (like the internal get_buffer2 implementation does, for compatibility), it shouldn't print a warning. --- libavcodec/decode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c i

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-04 Thread Michael Niedermayer
On Wed, Apr 04, 2018 at 03:53:25PM +0530, Gyan Doshi wrote: > rawenc.c | 10 ++ > 1 file changed, 10 insertions(+) > c144b841348e9af26d80e0014daf63c5b2477467 > 0001-avformat-rawenc-check-stream-type.patch > From f86916b9e1128a4e41501f4d5b189749a344862f Mon Sep 17 00:00:00 2001 > From:

[FFmpeg-devel] [PATCH] avformat/mov: Fix parsing of tfdt when using sample descriptors.

2018-04-04 Thread Jacob Trimble
Signed-off-by: Jacob Trimble --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index e7c32e6148..97b1462aab 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4601,7 +4601,7 @@ static int mov_read_tfdt(MOVContex

Re: [FFmpeg-devel] [PATCH] avcodec/decode: fix warning when decoding pseudo paletted formats

2018-04-04 Thread Michael Niedermayer
On Wed, Apr 04, 2018 at 06:07:20PM +0200, wm4 wrote: > The pseudo palette allocation is optional now. But if it's still > allocated (like the internal get_buffer2 implementation does, for > compatibility), it shouldn't print a warning. > --- > libavcodec/decode.c | 2 ++ > 1 file changed, 2 insert

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-04 Thread Gyan Doshi
On 4/5/2018 12:09 AM, Michael Niedermayer wrote: This does not work breaks fate-unknown_layout-ac3 Silly mistake. Fixed locally. also the tests mayb too strict, there are similar codec_ids like mpeg1/2 or jpeg variants which are all basically the same from a muxers point of view Will ch

Re: [FFmpeg-devel] [PATCH] display: Add AVDisplayOrientation API

2018-04-04 Thread Michael Niedermayer
On Wed, Apr 04, 2018 at 05:30:24PM +0200, Vittorio Giovara wrote: > The transformation operations that can be described by a display matrix > are not limited to pure rotation, but include horizontal and vertical > flip, as well as transpose and antitranspose. Unfortunately the current > API can onl

Re: [FFmpeg-devel] [PATCH 2/3] avformat/vivo: improve probing of some files

2018-04-04 Thread Michael Niedermayer
On Wed, Apr 04, 2018 at 04:09:36PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/vivo.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/vivo.c b/libavformat/vivo.c > index c9e9c37f37..6a88a09a01 100644 > --- a/libavformat/v

Re: [FFmpeg-devel] [PATCH 2/3] avformat/vivo: improve probing of some files

2018-04-04 Thread Paul B Mahol
On 4/4/18, Michael Niedermayer wrote: > On Wed, Apr 04, 2018 at 04:09:36PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavformat/vivo.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/vivo.c b/libavformat/vivo.c >> index c9e9

[FFmpeg-devel] [PATCH]lavf/amr: Stricter heuristic for auto-detection.

2018-04-04 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #7125, the jpg file in question contains a repeated pattern up to PROBE_SIZE that plays as amr_nb: 000d3290 05 14 51 40 05 14 51 40 05 14 51 40 05 14 51 40 |..Q@..Q@..Q@..Q@| * 00112900 1f ff d9 |...| Please comment, Car

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-04 Thread Mattias Amnefelt
On 2018-04-04 09:22, Mattias Amnefelt wrote: On 2018-04-04 03:42, James Almer wrote: On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: 2018-04-04 3:38 GMT+02:00, James Almer : On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: The "-f aac" looks like a bad idea to me. It's also true for the tests abov

[FFmpeg-devel] [PATCH 2/3] avformat/matroskadec: factor the prores packet parsing code out

2018-04-04 Thread James Almer
Simplifies code in matroska_parse_frame(). This is in preparation for the following patch. Signed-off-by: James Almer --- Prores specific stuff untested, as FATE doesn't cover it. libavformat/matroskadec.c | 50 +++ 1 file changed, 38 insertions(+), 1

[FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: use refcounted buffers in EbmlBin

2018-04-04 Thread James Almer
Data in EbmlBin objects is never changed after being read from the input file (save for two specific cases with encoded CodePrivate), so using AVBufferRef we can prevent unnecessary copy of data by instead creating new references to said constant data. Signed-off-by: James Almer --- The CodecPriv

[FFmpeg-devel] [PATCH 3/3] avformat/matroskadec: reference the existing data buffer when creating packets

2018-04-04 Thread James Almer
Newly allocated data buffers (wavpack, prores, compressed buffers) are padded to meet the requirements of AVPacket. matroska_parse_frame() speed up is ~10x. Signed-off-by: James Almer --- libavformat/matroskadec.c | 45 +++-- 1 file changed, 27 insertions

Re: [FFmpeg-devel] [PATCH 2/3] avformat/vivo: improve probing of some files

2018-04-04 Thread Michael Niedermayer
On Wed, Apr 04, 2018 at 10:40:39PM +0200, Paul B Mahol wrote: > On 4/4/18, Michael Niedermayer wrote: > > On Wed, Apr 04, 2018 at 04:09:36PM +0200, Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol > >> --- > >> libavformat/vivo.c | 5 +++-- > >> 1 file changed, 3 insertions(+), 2 deletions(-

Re: [FFmpeg-devel] [PATCH] display: Add AVDisplayOrientation API

2018-04-04 Thread Sasi Inguva
On Wed, Apr 4, 2018 at 8:30 AM, Vittorio Giovara wrote: > The transformation operations that can be described by a display matrix > are not limited to pure rotation, but include horizontal and vertical > flip, as well as transpose and antitranspose. Unfortunately the current > API can only return