Re: [FFmpeg-devel] [PATCH] swresample/arm: avoid conditional branch to PLT in THUMB-2.

On Fri, Apr 27, 2018 at 02:06:04PM -0700, Rahul Chaudhry wrote: > It was reported on github that this patch causes build errors with xcode: > > https://github.com/FFmpeg/FFmpeg/commit/b22db4f465c9adb2cf1489e04f7b65ef6bb55b8b#commitcomment-28725295 > > The attached patch fixes the build errors

[FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

This can "demux" .vpy files. Some minor code copied from other LGPL parts of FFmpeg. I did not found a good way to test a few of the more obscure features, like VFR nodes, compat pixel formats, or nodes with dynamic size/format changes. These can be easily implemented on demand. --- configure

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h2645: create a reference to the existing buffer when decomposing slice units

On Fri, 2018-04-27 at 20:50 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c | 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) > > diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c > index

Re: [FFmpeg-devel] [PATCH] avfilter: add amplify filter

On 4/28/18, Carl Eugen Hoyos wrote: > 2018-04-28 0:56 GMT+02:00, Paul B Mahol : > >> +static int query_formats(AVFilterContext *ctx) >> +{ >> +static const enum AVPixelFormat pixel_fmts[] = { >> +AV_PIX_FMT_GRAY8, AV_PIX_FMT_GRAY9, >> +

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hpeldsp: fix half pel interpolation

On Sat, Apr 28, 2018 at 10:44:54AM +0200, Jerome Borsboom wrote: > > This patch is not correct. > > > > this code is not used if AV_CODEC_FLAG_BITEXACT is set, because it is > > not bit exact ... > > > > Also the case where the off by 1 error occurs is a rare corner case, > > Compared to the

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hpeldsp: fix half pel interpolation

On 28 April 2018 at 10:42, Hendrik Leppkes wrote: > On Sat, Apr 28, 2018 at 10:44 AM, Jerome Borsboom > wrote: > >> This patch is not correct. > >> > >> this code is not used if AV_CODEC_FLAG_BITEXACT is set, because it is > >> not bit exact ...

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hpeldsp: fix half pel interpolation

2018-04-28 13:11 GMT+02:00, Rostislav Pehlivanov : > I'd say just remove it, it'll bitrot otherwise since no one will use it. Not all mpeg decoders are bit-exact and the date of the functions indicate they are used for such decoders. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hpeldsp: fix half pel interpolation

On 28 April 2018 at 12:34, Carl Eugen Hoyos wrote: > 2018-04-28 13:11 GMT+02:00, Rostislav Pehlivanov : > > > I'd say just remove it, it'll bitrot otherwise since no one will use it. > > Not all mpeg decoders are bit-exact and the date of the functions >

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_mpeg2: create a reference to the existing buffer when decomposing slice units

> Signed-off-by: James Almer > --- > libavcodec/cbs_mpeg2.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c > index 989daf0a4d..8ca47061fe 100644 > --- a/libavcodec/cbs_mpeg2.c > +++

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hpeldsp: fix half pel interpolation

On Sat, Apr 28, 2018 at 10:44 AM, Jerome Borsboom wrote: >> This patch is not correct. >> >> this code is not used if AV_CODEC_FLAG_BITEXACT is set, because it is >> not bit exact ... >> >> Also the case where the off by 1 error occurs is a rare corner case, >>

Re: [FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

On Sat, 28 Apr 2018 11:08:01 +0800 Steven Liu wrote: > > On 28 Apr 2018, at 03:37, wm4 wrote: > > > > + > > +if (strncmp(pd->name, "xyz", 3) == 0) > > +continue; > > liuqideMacBook-Pro:xxx liuqi$ ../tools/patcheck >

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hpeldsp: fix half pel interpolation

> This patch is not correct. > > this code is not used if AV_CODEC_FLAG_BITEXACT is set, because it is > not bit exact ... > > Also the case where the off by 1 error occurs is a rare corner case, > Compared to the errors introduced by the IDCT this is not significant > > If you want to optimize

[FFmpeg-devel] [PATCH] avfilter/vf_overlay: add slice threading

Signed-off-by: Paul B Mahol --- libavfilter/vf_overlay.c | 281 --- 1 file changed, 190 insertions(+), 91 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index c6a6ac82f3..cb304e9522 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h2645: create a reference to the existing buffer when decomposing slice units

On 4/28/2018 5:02 AM, Xiang, Haihao wrote: > On Fri, 2018-04-27 at 20:50 -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h2645.c | 18 -- >> 1 file changed, 4 insertions(+), 14 deletions(-) >> >> diff --git

Re: [FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

On 4/28/2018 8:51 AM, wm4 wrote: > On Sat, 28 Apr 2018 11:08:01 +0800 > Steven Liu wrote: > >>> On 28 Apr 2018, at 03:37, wm4 wrote: >>> > >>> + >>> +if (strncmp(pd->name, "xyz", 3) == 0) >>> +continue; >> >>

Re: [FFmpeg-devel] [PATCH 1/1] add CUgraphicsRegisterFlags enum

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 26 Apr 2018 17:09:14 +0200 Daniel Oberhoff wrote: > > On 26. Apr 2018, at 16:20, Daniel Oberhoff > > wrote: > > > > --- > > include/ffnvcodec/dynlink_cuda.h | 8 > > 1 file

Re: [FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

On Sat, 28 Apr 2018 11:58:27 -0300 James Almer wrote: > On 4/28/2018 8:51 AM, wm4 wrote: > > On Sat, 28 Apr 2018 11:08:01 +0800 > > Steven Liu wrote: > > > >>> On 28 Apr 2018, at 03:37, wm4 wrote: > >>> > > > >>> + > >>> +

[FFmpeg-devel] [PATCH] avcodec/vc1: fix mquant calculation

In vc1_decode_i_blocks_adv mquant needs to be reset to its default value for each macroblock, instead of once at the beginning of the slice. DQPROFILE specifies which macroblocks can have an alternative quantizer step size. When DQPROFILE specifies edges, the selection is applicable to the edges

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: change fps progress log message to show two decimal digits

On Fri, Apr 27, 2018 at 08:00:33PM -0300, André Camargo wrote: > Useful when transcoding videos at 29.97 fps because delivers a more accurate > result for monitoring. > --- > fftools/ffmpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thanks [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Add system time and real time to benchmarking.

On Fri, Apr 27, 2018 at 01:31:59PM -0400, Mark Wachsler wrote: > The -benchmark and -benchmark_all options now show user, system, and real > time, > instead of just user time. > --- > fftools/ffmpeg.c | 49 +++- > 1 file changed, 36 insertions(+), 13

Re: [FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

On Fri, 27 Apr 2018 22:27:47 -0300 James Almer wrote: > On 4/27/2018 4:37 PM, wm4 wrote: > > From: wm4 > > > > require_pkg_config libvapoursynth "vapoursynth-script >= 42" VSScript.h > > vsscript_init || die "ERROR: vapoursynth or vsscript not

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-04-28 19:24 GMT+02:00, wm4 : > If the API user doesn't set avg_frame_rate, matroskaenc will write the > current timebase as "default duration" for the video track. This makes > no sense, because the "default duration" implies the framerate of the > video. Since the

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

On Sat, 28 Apr 2018 19:52:38 +0200 Carl Eugen Hoyos wrote: > 2018-04-28 19:24 GMT+02:00, wm4 : > > If the API user doesn't set avg_frame_rate, matroskaenc will write the > > current timebase as "default duration" for the video track. This makes > > no

[FFmpeg-devel] [PATCH] avformat/hls: don't propagate deprecated "user-agent" AVOption

This code will print a warning if any user agent is set - even if the API user used the proper non-deprecated "user_agent" option. This change should not even break anything, because even if the user sets the deprecated "user-agent" option, http.c copies it to the "user_agent" option anyway. ---

Re: [FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

On Sat, 28 Apr 2018 15:28:13 -0300 James Almer wrote: > On 4/28/2018 2:05 PM, wm4 wrote: > > This can "demux" .vpy files. > > > > +pkt->data = pkt->buf->data; > > +pkt->size = pkt->buf->size; > > +pkt->flags |= AV_PKT_FLAG_TRUSTED; > > + > > +if

Re: [FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

On 4/28/2018 3:38 PM, wm4 wrote: > On Sat, 28 Apr 2018 15:28:13 -0300 > James Almer wrote: > >> On 4/28/2018 2:05 PM, wm4 wrote: >>> This can "demux" .vpy files. >>> > > >>> +pkt->data = pkt->buf->data; >>> +pkt->size = pkt->buf->size; >>> +pkt->flags |=

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-04-28 20:05 GMT+02:00, wm4 : > On Sat, 28 Apr 2018 19:52:38 +0200 > Carl Eugen Hoyos wrote: > >> 2018-04-28 19:24 GMT+02:00, wm4 : >> > If the API user doesn't set avg_frame_rate, matroskaenc will write the >> > current

[FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

If the API user doesn't set avg_frame_rate, matroskaenc will write the current timebase as "default duration" for the video track. This makes no sense, because the "default duration" implies the framerate of the video. Since the timebase is forced to 1/1000, this will make the resulting file claim

Re: [FFmpeg-devel] [PATCH] avformat: add vapoursynth wrapper

On 4/28/2018 2:05 PM, wm4 wrote: > This can "demux" .vpy files. > > Some minor code copied from other LGPL parts of FFmpeg. > > I did not found a good way to test a few of the more obscure features, > like VFR nodes, compat pixel formats, or nodes with dynamic size/format > changes. These can be

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

On Sat, 28 Apr 2018 21:18:47 +0200 Carl Eugen Hoyos wrote: > 2018-04-28 20:05 GMT+02:00, wm4 : > > On Sat, 28 Apr 2018 19:52:38 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2018-04-28 19:24 GMT+02:00, wm4 :

[FFmpeg-devel] [PATCH] avfilter/vf_fieldmatch: add support for >8 bit depth in ppsrc

Also fix leaks while here. Signed-off-by: Paul B Mahol --- libavfilter/vf_fieldmatch.c | 48 + 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_fieldmatch.c b/libavfilter/vf_fieldmatch.c index

Re: [FFmpeg-devel] [PATCH] avfilter/vf_overlay: add slice threading

On Sat, Apr 28, 2018 at 12:00:46PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_overlay.c | 281 > --- > 1 file changed, 190 insertions(+), 91 deletions(-) > > diff --git a/libavfilter/vf_overlay.c

Re: [FFmpeg-devel] [PATCH] avcodec/vc1: fix mquant calculation

On Sat, Apr 28, 2018 at 05:15:32PM +0200, Jerome Borsboom wrote: > In vc1_decode_i_blocks_adv mquant needs to be reset to its default value for > each macroblock, instead of once at the beginning of the slice. > > DQPROFILE specifies which macroblocks can have an alternative quantizer step >

[FFmpeg-devel] [PATCH] fftools/ffmpeg: fix mixed code and declarations

Signed-off-by: James Almer --- fftools/ffmpeg.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d3054092ba..9b3e9d121e 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -4727,8 +4727,7 @@ static int