Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1: fix mquant calculation for interlace field pictures

2018-05-20 11:00 GMT+02:00, Jerome Borsboom : >>> for patch 1 you list a file that it improves. >> >> The file - afaict - is related to the patchset as a whole. >> The current version of the patchset does not fix the >> file though, so I believe we should wait for a

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

2018-05-19 23:48 GMT+02:00, James Almer : > On 5/19/2018 6:31 PM, Michael Niedermayer wrote: >> On Fri, May 18, 2018 at 11:15:04AM -0700, Aman Gupta wrote: >>> From: Aman Gupta >>> >>> These fields will allow the mpegts demuxer to expose details about >>> the

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vc1: store zero MVs for all blocks in a MB

>> Direct prediction for interlace frame B pictures references the mv in the >> second block in an MB in the backward reference frame for the twomv case. >> When the backward reference frame is an I frame, this value may be unset. >> >> Signed-off-by: Jerome Borsboom >> --- >>

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vc1: FIELDTX is only coded raw in interlaced frame I pictures

On Sun, May 20, 2018 at 10:56:19AM +0200, Jerome Borsboom wrote: > >> libavcodec/vc1_block.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c > >> index f59c440943..daf30fdbfe 100644 > >> ---

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/vc1: FIELDTX is only coded raw in interlaced frame I pictures

>> libavcodec/vc1_block.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c >> index f59c440943..daf30fdbfe 100644 >> --- a/libavcodec/vc1_block.c >> +++ b/libavcodec/vc1_block.c >> @@ -2680,7 +2680,7 @@ static void

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

On Sun, May 20, 2018 at 1:54 PM, Carl Eugen Hoyos wrote: > > Reading the original submission above, isn't the whole point of the > patch to add public symbols to help downstream with real-world > issues? > > Carl Eugen Yes, currently the API user has no visibility over how

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1: fix mquant calculation for interlace field pictures

>> On Fri, May 18, 2018 at 05:06:23PM +0200, Jerome Borsboom wrote: >>> For interlace field pictures s->mb_height indicates the height of the >>> full >>> picture in MBs, i.e. the two fields combined. A single field is half this >>> size. When calculating mquant for interlace field pictures, the

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

On Sun, May 20, 2018 at 2:06 PM, Jan Ekström wrote: > On Sun, May 20, 2018 at 1:54 PM, Carl Eugen Hoyos wrote: >> >> Reading the original submission above, isn't the whole point of the >> patch to add public symbols to help downstream with real-world >>

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/vc1: FIELDTX is only present in interlaced frame I/BI pictures

If v->fieldtx_is_raw is not reset to zero, it may spill over from a previous interlaced frame I/BI picture. Signed-off-by: Jerome Borsboom --- This may address the concerns. Will make a mental note to clean up the parser at a later time. Thank you for the review.

Re: [FFmpeg-devel] HLS Questions

No I’ll give it a try and let you know. Since this is just audio (no keyframes) I wouldn’t have thought this would have mattered. Sent from my iPhone > On May 7, 2018, at 3:52 PM, Aman Gupta wrote: > > On Wed, May 2, 2018 at 7:59 AM, Ronak Patel < >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/vc1: fix mquant calculation for interlace field pictures

2018-05-20 0:01 GMT+02:00, Michael Niedermayer : > On Fri, May 18, 2018 at 05:06:23PM +0200, Jerome Borsboom wrote: >> For interlace field pictures s->mb_height indicates the height of the >> full >> picture in MBs, i.e. the two fields combined. A single field is half this

Re: [FFmpeg-devel] [PATCH] avutil/error: document av_err2str

tor 2018-05-17 klockan 12:19 +0200 skrev Tobias Rapp: > On 17.05.2018 11:24, Zhao Zhili wrote: > > --- > >   libavutil/error.h | 3 +++ > >   1 file changed, 3 insertions(+) > > > > diff --git a/libavutil/error.h b/libavutil/error.h > > index 71df4da..b357bfa 100644 > > --- a/libavutil/error.h > >

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vc1: store zero MVs for all blocks in a MB

2018-05-20 3:45 GMT+02:00, James Almer : > I see no emms in either ff_clear_blocks_mmx() or anywhere in > vc1_block.c, so either nobody tried this decoder on machines > without sse I do have access to an SSE-only system, I doubt FFmpeg was used or tested on MMX-only systems in

[FFmpeg-devel] [PATCH 3/8] ffserver.c: rename ReadInfo.in_filename to ReadInfo.in_uri

Signed-off-by: Stephan Holljes --- ffserver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffserver.c b/ffserver.c index bd7c694..44fc263 100644 --- a/ffserver.c +++ b/ffserver.c @@ -45,7 +45,7 @@ struct ReadInfo { struct PublisherContext

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

On 5/20/2018 3:37 PM, Aman Gupta wrote: > On Sat, May 19, 2018 at 2:56 PM James Almer wrote: > >> On 5/19/2018 6:31 PM, Michael Niedermayer wrote: >>> On Fri, May 18, 2018 at 11:15:04AM -0700, Aman Gupta wrote: From: Aman Gupta These fields will

Re: [FFmpeg-devel] [PATCH 6/8] ffserver.c: Add config file reading

On Sun, May 20, 2018 at 08:54:02PM +0200, Stephan Holljes wrote: > Signed-off-by: Stephan Holljes > --- > ffserver.c | 248 > ++--- > 1 file changed, 172 insertions(+), 76 deletions(-) > > diff --git a/ffserver.c

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

On Sat, May 19, 2018 at 2:56 PM James Almer wrote: > On 5/19/2018 6:31 PM, Michael Niedermayer wrote: > > On Fri, May 18, 2018 at 11:15:04AM -0700, Aman Gupta wrote: > >> From: Aman Gupta > >> > >> These fields will allow the mpegts demuxer to expose details

[FFmpeg-devel] [PATCH 6/8] ffserver.c: Add config file reading

Signed-off-by: Stephan Holljes --- ffserver.c | 248 ++--- 1 file changed, 172 insertions(+), 76 deletions(-) diff --git a/ffserver.c b/ffserver.c index 44fc263..3d842d8 100644 --- a/ffserver.c +++ b/ffserver.c @@

[FFmpeg-devel] [PATCH 1/8] ffserver.c: Different timestamp scaling, still does not properly work with mp4 files?

Signed-off-by: Stephan Holljes --- ffserver.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/ffserver.c b/ffserver.c index 39e1c32..bd7c694 100644 --- a/ffserver.c +++ b/ffserver.c @@ -127,13 +127,13 @@ void *read_thread(void

[FFmpeg-devel] [PATCH 7/8] Makefile: Update Makefile

Signed-off-by: Stephan Holljes --- Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index fbecdeb..83bc4e0 100644 --- a/Makefile +++ b/Makefile @@ -1,10 +1,11 @@ all: ffserver LAV_FLAGS = $(shell pkg-config --libs

[FFmpeg-devel] [GSoC] FFserver config file support

This patch set builds upon the previous set that implemented ffserver with a more flexible httpd interface. It includes a fix for timestamp handling, which sadly still does not properly fix the issue. The majority of this patch set adds the ability to read lua-config files. After reading up on

[FFmpeg-devel] [PATCH 5/8] publisher.h: Add stream_name to PublisherContext

Signed-off-by: Stephan Holljes --- publisher.c | 3 ++- publisher.h | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/publisher.c b/publisher.c index 1123056..2e96f2f 100644 --- a/publisher.c +++ b/publisher.c @@ -93,11 +93,12 @@ void

Re: [FFmpeg-devel] [PATCH v4 1/3] avformat: add fields to AVProgram/AVStream for PMT change tracking

On Sun, May 20, 2018 at 11:37:22AM -0700, Aman Gupta wrote: > On Sat, May 19, 2018 at 2:56 PM James Almer wrote: > > > On 5/19/2018 6:31 PM, Michael Niedermayer wrote: > > > On Fri, May 18, 2018 at 11:15:04AM -0700, Aman Gupta wrote: > > >> From: Aman Gupta > >

[FFmpeg-devel] [PATCH 2/8] ffserver: Implement lua config file reader

Signed-off-by: Stephan Holljes --- configreader.c | 211 + configreader.h | 46 + 2 files changed, 257 insertions(+) create mode 100644 configreader.c create mode 100644 configreader.h diff --git

[FFmpeg-devel] [PATCH 8/8] doc: Update Documentation.txt and add sample config as supplement

Signed-off-by: Stephan Holljes --- Documentation.txt | 17 - sample_config.lua | 28 2 files changed, 36 insertions(+), 9 deletions(-) create mode 100644 sample_config.lua diff --git a/Documentation.txt b/Documentation.txt

[FFmpeg-devel] [PATCH 4/8] httpd.h: Adapt structs to config file

Signed-off-by: Stephan Holljes --- httpd.h | 17 + 1 file changed, 17 insertions(+) diff --git a/httpd.h b/httpd.h index 6fb91bd..25cbe11 100644 --- a/httpd.h +++ b/httpd.h @@ -26,11 +26,28 @@ #include "publisher.h" +/* Supported stream formats,

Re: [FFmpeg-devel] [PATCH 2/8] ffserver: Implement lua config file reader

On Sun, May 20, 2018 at 08:53:58PM +0200, Stephan Holljes wrote: > Signed-off-by: Stephan Holljes > --- > configreader.c | 211 > + > configreader.h | 46 + > 2 files changed, 257 insertions(+) >

Re: [FFmpeg-devel] [PATCH v2 1/5] avcodec/vc1: FIELDTX is only present in interlaced frame I/BI pictures

On Sun, May 20, 2018 at 01:45:56PM +0200, Jerome Borsboom wrote: > If v->fieldtx_is_raw is not reset to zero, it may spill over from a previous > interlaced frame I/BI picture. > > Signed-off-by: Jerome Borsboom > --- > This may address the concerns. Will make a

[FFmpeg-devel] [PATCH] avformat/mov: replace a value error by clipping into valid range in mov_read_stsc()

Fixes: #7165 Signed-off-by: Michael Niedermayer --- libavformat/mov.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index a078bf4712..f2a540ad50 100644 --- a/libavformat/mov.c +++

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Only fail for STCO/STSC contradictions if both exist

On Tue, May 15, 2018 at 06:53:49PM +0200, Carl Eugen Hoyos wrote: > 2018-05-15 17:07 GMT+02:00, Michael Niedermayer : > > Fixes regression with playback of > > GF9720Repeal20the20Eighth20with20Helen20Linehan.m4a > > See: crbug 822666 > > Please mention ticket #7165 if