Re: [FFmpeg-devel] [PATCH] avcodec/libx265: apply lavc maxrate and bufsize

2018-06-17 Thread Gyan Doshi
On 15-06-2018 09:50 PM, Gyan Doshi wrote: On 13-06-2018 07:08 PM, Gyan Doshi wrote: Default for both parameters in both libs is 0. Ping. Will push in a day. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] Conversion to audible AAX(encrypted) format.

2018-06-17 Thread Tejasvi Singh Tomar
Feature of converting audio to AAX format is highly useful in some cases. In my case I need to transfer personal audio files for listening on Kindle e-reader, which only accepts Audible files. The AAX files are to be encrypted with information of activation_bytes of individual Audible accounts

Re: [FFmpeg-devel] [PATCH]lavfi/avfiltergraph: Do not return ENOMEM if filter is missing

2018-06-17 Thread Nicolas George
Mark Thompson (2018-06-17): > There is AVERROR_FILTER_NOT_FOUND - while it isn't currently returned > from lavfi, it does sound exactly right for this. It is not exactly right for this, because this can be ENOMEM too. Furthermore, this error code is really wrong, because this function does not

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias

2018-06-17 Thread Lou Logan
On Sun, Jun 17, 2018, at 8:25 AM, Carl Eugen Hoyos wrote: > > Wouldn't it make more sense to remove the extremely > long name at the next bump if consistency is needed > here? I don't think it matters too much to also have the alias video4linux2, or at least I can't think of any good reasons to

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias

2018-06-17 Thread Carl Eugen Hoyos
2018-06-17 19:10 GMT+02:00, Lou Logan : > On Sun, Jun 17, 2018, at 8:25 AM, Carl Eugen Hoyos wrote: >> >> Wouldn't it make more sense to remove the extremely >> long name at the next bump if consistency is needed >> here? > > I don't think it matters too much to also have the alias video4linux2,

Re: [FFmpeg-devel] [PATCH] lavfi: add helper macro for OpenCL error handling.

2018-06-17 Thread Mark Thompson
On 15/06/18 03:36, Dan Yaschenko wrote: > On 12 June 2018 at 10:20, Ruiling Song wrote: > >> Signed-off-by: Ruiling Song >> --- >> I am not sure whether do you think this would be useful? >> the main purpose is to make OpenCL error check code simpler. >> If we think this is good, I can go to

Re: [FFmpeg-devel] [PATCH v2 24/36] lavc/cbs: Add JPEG support

2018-06-17 Thread Mark Thompson
On 15/06/18 01:52, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> --- >> configure | 2 + >> libavcodec/Makefile | 1 + >> libavcodec/cbs.c | 6 + >> libavcodec/cbs_internal.h |

Re: [FFmpeg-devel] [PATCH v2 25/36] vaapi_encode_mjpeg: Use CBS to store parameters and write headers

2018-06-17 Thread Mark Thompson
On 15/06/18 02:37, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> Also adds greyscale, 4:2:2, 4:4:4 and RGB support. >> --- >> configure | 2 +- >> doc/encoders.texi | 17 +- >> libavcodec/vaapi_encode_mjpeg.c | 529

Re: [FFmpeg-devel] [PATCH v2 29/36] h264_metadata: Add option to set the level of the stream

2018-06-17 Thread Mark Thompson
On 15/06/18 03:49, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> --- >> doc/bitstream_filters.texi | 9 + >> libavcodec/h264_metadata_bsf.c | 90 >> ++ >> 2 files changed, 99 insertions(+) >> >> ... >> diff --git

Re: [FFmpeg-devel] [PATCH v2 33/36] vaapi_encode_h265: Improve profile support

2018-06-17 Thread Mark Thompson
On 15/06/18 04:59, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> Set profile compatibility/constraint flags properly (including the >> constraint flags used for RExt profiles, as all streams we can currently >> generate are RExt-compatible), and use that to add

Re: [FFmpeg-devel] [PATCH 1/4] lavu/frame: add mb_types side data

2018-06-17 Thread Hendrik Leppkes
On Sun, Jun 17, 2018 at 2:45 PM Rostislav Pehlivanov wrote: > > On 17 June 2018 at 05:21, Ramiro Polla wrote: > > > --- > > libavcodec/avcodec.h | 4 > > libavcodec/mpegutils.c | 20 > > libavcodec/options_table.h | 1 + > > libavutil/frame.c | 1

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: apply lavc maxrate and bufsize

2018-06-17 Thread Mark Thompson
On 13/06/18 14:38, Gyan Doshi wrote: > Default for both parameters in both libs is 0. > > Regards, > Gyan > > From f875734cc5a1652162156118864db406b192526b Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Wed, 13 Jun 2018 19:01:17 +0530 > Subject: [PATCH] avcodec/libx265: apply lavc maxrate

Re: [FFmpeg-devel] [PATCH 2/4] mpegutils: split debug function that prints mb_type so it may be used by ffprobe

2018-06-17 Thread Carl Eugen Hoyos
2018-06-17 6:21 GMT+02:00, Ramiro Polla : > +int ff_mb_type_str(char *str, int size, int mb_type) I don't think you can use "ff_" functions from a tool, you have to make this part of the API afaict. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2 11/36] vaapi_encode: Choose profiles dynamically

2018-06-17 Thread Mark Thompson
On 14/06/18 05:51, Xiang, Haihao wrote: > On Wed, 2018-06-13 at 23:27 +0100, Mark Thompson wrote: >> On 12/06/18 08:22, Xiang, Haihao wrote: >>> On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: Previously there was one fixed choice for each codec (e.g. H.265 -> Main profile), and

Re: [FFmpeg-devel] [PATCH v2 16/36] vaapi_encode: Clean up rate control configuration

2018-06-17 Thread Mark Thompson
On 14/06/18 07:07, Xiang, Haihao wrote: > On Wed, 2018-06-13 at 23:42 +0100, Mark Thompson wrote: >> On 13/06/18 08:03, Xiang, Haihao wrote: >>> On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: Query which modes are supported and select between VBR and CBR based on that - this

Re: [FFmpeg-devel] [PATCH v2 18/36] vaapi_encode: Clean up the GOP structure configuration

2018-06-17 Thread Mark Thompson
On 14/06/18 07:48, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> Choose what types of reference frames will be used based on what types >> are available, and make the intra-only mode explicit (GOP size one, >> which must be used for MJPEG). >> --- >>

Re: [FFmpeg-devel] [PATCH v2 16/36] vaapi_encode: Clean up rate control configuration

2018-06-17 Thread Mark Thompson
On 14/06/18 08:22, Li, Zhong wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Xiang, Haihao >> Sent: Thursday, June 14, 2018 2:08 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v2 16/36] vaapi_encode: Clean

Re: [FFmpeg-devel] [PATCH v2 28/36] vaapi_encode_h264: Set level based on stream if not set by user

2018-06-17 Thread Mark Thompson
On 15/06/18 03:24, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> --- >> libavcodec/vaapi_encode_h264.c | 34 ++ >> 1 file changed, 30 insertions(+), 4 deletions(-) >> >> diff --git a/libavcodec/vaapi_encode_h264.c

Re: [FFmpeg-devel] [PATCH v2 30/36] cbs_h264: Fix range and default value of max mv lengths

2018-06-17 Thread Mark Thompson
On 15/06/18 04:01, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> The max and default values are 15, not 16. > > I guessed you mixed both h264 and h265. The h264 doc i have specifies the > range > for log2_max_mv_length_vertical/log2_max_mv_length_horizontal is

Re: [FFmpeg-devel] [PATCH v2 35/36] vaapi_encode_h265: Set level based on stream if not set by user

2018-06-17 Thread Mark Thompson
On 15/06/18 05:22, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> Sets the level based on the stream properties if it is not explicitly >> set by the user. Also add a tier option to set general_tier_flag, since >> that affects the level choice. >> --- >>

Re: [FFmpeg-devel] Fw: [PATCH] Refactor two near-identical clauses.

2018-06-17 Thread Shlomi Fish
On Sun, 17 Jun 2018 03:05:27 +0200 Michael Niedermayer wrote: > On Tue, Jun 12, 2018 at 12:53:20PM +0300, Shlomi Fish wrote: > > This message did not arrive to the list after three submissions. > > > > Begin forwarded message: > > > > Date: Tue, 12 Jun 2018 12:42:52 +0300 > > From: Shlomi Fish

Re: [FFmpeg-devel] [PATCH 1/4] lavu/frame: add mb_types side data

2018-06-17 Thread Rostislav Pehlivanov
On 17 June 2018 at 05:21, Ramiro Polla wrote: > --- > libavcodec/avcodec.h | 4 > libavcodec/mpegutils.c | 20 > libavcodec/options_table.h | 1 + > libavutil/frame.c | 1 + > libavutil/frame.h | 9 + > 5 files changed, 35

Re: [FFmpeg-devel] [PATCH v2] lavc/qsv: suppress code scan complain

2018-06-17 Thread Mark Thompson
On 14/06/18 10:50, Carl Eugen Hoyos wrote: > 2018-06-14 5:08 GMT+02:00, Li, Zhong : >>> -Original Message- >>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >>> Of Carl Eugen Hoyos >>> Sent: Wednesday, June 13, 2018 6:11 PM >>> To: FFmpeg development discussions and

Re: [FFmpeg-devel] [PATCH v2 32/36] cbs_h264: Infer default VUI values if VUI parameters are not present

2018-06-17 Thread Mark Thompson
On 15/06/18 04:46, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> --- >> libavcodec/cbs_h264_syntax_template.c | 42 >> +++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/libavcodec/cbs_h264_syntax_template.c >>

[FFmpeg-devel] mpegaudio_parser question

2018-06-17 Thread Karsten Otto
Hi list, I have a question about mpegaudio_parser. I see that it keeps any packet data before a frame header, instead of discarding it. This makes sense, because it usually can combine this data with the leftovers from a previous packet to complete a frame. But the parser also does this when

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2enc: add video4linux2 name alias

2018-06-17 Thread Carl Eugen Hoyos
2018-06-14 23:39 GMT+02:00, Lou Logan : > AVOutputFormat ff_v4l2_muxer = { > -.name = "v4l2", > +.name = "video4linux2,v4l2", Wouldn't it make more sense to remove the extremely long name at the next bump if consistency is needed here? Carl Eugen

Re: [FFmpeg-devel] [PATCH v2 19/36] vaapi_encode: Clean up the packed header configuration

2018-06-17 Thread Mark Thompson
On 14/06/18 08:15, Xiang, Haihao wrote: > On Fri, 2018-06-08 at 00:43 +0100, Mark Thompson wrote: >> Add a larger warning more clearly explaining the consequences of missing >> packed header support in the driver. Also only write the extradata if the >> user actually requests it via the

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi: slice_vertical_position starts from zero for the second field

2018-06-17 Thread Mark Thompson
On 15/06/18 06:44, Xiang, Haihao wrote: > > I may confirm that the error is returned from the old version of libva and > vaapi > driver w/wo this patch, the command below works well for me if using the new > version of libva and vaapi driver. Trying others: * The Mesa driver running on an

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: fix version detection on cygwin

2018-06-17 Thread Mark Thompson
On 15/06/18 15:52, Timo Rothenpieler wrote: > --- > libavcodec/qsvenc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index d48272224c..bb175c5df8 100644 > --- a/libavcodec/qsvenc.h > +++ b/libavcodec/qsvenc.h > @@ -45,7

Re: [FFmpeg-devel] [PATCH]lavfi/avfiltergraph: Do not return ENOMEM if filter is missing

2018-06-17 Thread Mark Thompson
On 16/06/18 13:39, Carl Eugen Hoyos wrote: > 2018-02-05 3:05 GMT+01:00, James Almer : >> On 2/4/2018 10:33 PM, Carl Eugen Hoyos wrote: >>> Hi! >>> >>> OOM is unlikely as a failure for avfilter_graph_alloc_filter(), the >>> patch avoids a surprising error if a filter was not found. >>> >>> Please

Re: [FFmpeg-devel] [PATCH] avcodec/mips: [loongson] optimize vp8 decoding in vp8dsp.

2018-06-17 Thread Carl Eugen Hoyos
2018-06-14 13:56 GMT+02:00, yinshiyou...@loongson.cn : >> >> 2018-06-14 9:36 GMT+02:00, Shiyou Yin : >> > From: gxw >> > >> > Optimize vp8 decoding with mmi in function: >> > 1. ff_vp8_h_loop_filter8uv_mmi. >> > 2. ff_vp8_v_loop_filter8uv_mmi. >> > 3. ff_vp8_h_loop_filter16_mmi. >> > 4.

Re: [FFmpeg-devel] [PATCH] libavfilter/opencl.h: Add macro for setting opencl kernel

2018-06-17 Thread Mark Thompson
On 15/06/18 03:55, Danil Iashchenko wrote: > --- > > Hi! > I like your idea with OCL_FAIL_ON_ERR(), but still do not know which one is > better. > My idea relies on fact, that there are only few OpenCL functions which are > used multiple times in filters: > clSetKernelArg, clCreateKernel(in

Re: [FFmpeg-devel] [PATCH 2/4] mpegutils: split debug function that prints mb_type so it may be used by ffprobe

2018-06-17 Thread Michael Niedermayer
On Sun, Jun 17, 2018 at 06:21:15AM +0200, Ramiro Polla wrote: > --- > libavcodec/mpegutils.c | 115 > + > libavcodec/mpegutils.h | 7 +++ > 2 files changed, 76 insertions(+), 46 deletions(-) > > diff --git a/libavcodec/mpegutils.c

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: print mb_types frame side data

2018-06-17 Thread Stefano Sabatini
On date Sunday 2018-06-17 06:21:16 +0200, Ramiro Polla encoded: > --- > fftools/ffprobe.c | 19 +++ > 1 file changed, 19 insertions(+) [...] Missing changes to doc/ffprobe.xsd I think. -- FFmpeg = Fast and Foolish Mysterious Picky Efficient Guide

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc: fix version detection on cygwin

2018-06-17 Thread Timo Rothenpieler
Am 17.06.2018 um 17:48 schrieb Mark Thompson: On 15/06/18 15:52, Timo Rothenpieler wrote: --- libavcodec/qsvenc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h index d48272224c..bb175c5df8 100644 --- a/libavcodec/qsvenc.h +++

Re: [FFmpeg-devel] mpegaudio_parser question

2018-06-17 Thread Ronald S. Bultje
Hi Karsten, I believe that the parsers are seek-unaware, so you're expected to delete and recreate (or reinit) the parsers after each seek. Ronald On Sun, Jun 17, 2018 at 10:56 AM, Karsten Otto wrote: > Hi list, > > I have a question about mpegaudio_parser. I see that it keeps any packet >

Re: [FFmpeg-devel] [PATCH 3/4 v3] avcodec/vc1: rewrite vc1_decode_i_blocks to align with VC-1 spec

2018-06-17 Thread Michael Niedermayer
On Tue, Jun 12, 2018 at 11:34:58AM +0200, Jerome Borsboom wrote: > Change vc1_decode_i_blocks to use vc1_put_blocks_clamped and > ff_vc1_i_loop_filter. > > Signed-off-by: Jerome Borsboom > --- > The v3 patch should resolve the crashing that was seen on corrupted source > files. This (commit