Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Remove muxer overhead from Bandwidth field in DASH manifest

2018-09-11 Thread Jeyapal, Karthick
On 9/4/18 1:45 PM, Karthick J wrote: > From: Karthick Jeyapal > > Fixes bug id #7386 > Muxer overhead calculations was intented for HLS playlist as Apple's > mediastreamvalidator tests were failing. > But applying the same fix for DASH manifest proved counterproductive, as > Bandwidth can be

Re: [FFmpeg-devel] [PATCH 2/3] lavc: Add coded bitstream read/write support for AV1

2018-09-11 Thread James Almer
On 9/9/2018 7:08 PM, Mark Thompson wrote: > +static void cbs_av1_free_obu(void *unit, uint8_t *content) > +{ > +AV1RawOBU *obu = (AV1RawOBU*)content; > + > +switch (obu->header.obu_type) { > +case AV1_OBU_TILE_GROUP: > +cbs_av1_free_tile_data(>tile_group.tile_data); > +

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

2018-09-11 Thread Devin Heitmueller
On Mon, Sep 10, 2018 at 8:00 PM, Marton Balint wrote: > Yes, just put the same value to both line 12 (or whichever line the user > selects) and its pair line in the other field. Ok, will take care of this today. Thanks for reviewing. Devin -- Devin J. Heitmueller - Kernel Labs

Re: [FFmpeg-devel] [PATCH 1/5] avformat/tty: Remove .txt from the extensions as it more likely is not a multimedia related file

2018-09-11 Thread Michael Niedermayer
On Tue, Sep 11, 2018 at 11:31:23PM +0200, Carl Eugen Hoyos wrote: > 2018-05-12 18:33 GMT+02:00, Michael Niedermayer : > > Iam not sure if this is a good idea or not but it may make some > > attacks harder. So throwing this out for discussions ... > > I am definitely not objecting but I doubt that

Re: [FFmpeg-devel] [PATCH V7 0/3] enable multi-slices in vaapi_h264/265 encoder

2018-09-11 Thread myp...@gmail.com
On Wed, Aug 29, 2018 at 6:47 PM Jun Zhao wrote: > > V7: - Fix h264 first_mb_in_slice setting issue. (root cause by Mark) > - Refine the error handle > > V6: - Use rectangular slices and refine the code. > > V5: - In h265_vaapi encoder, when setting slice number > max slice number >

Re: [FFmpeg-devel] [PATCH 1/5] avformat/tty: Remove .txt from the extensions as it more likely is not a multimedia related file

2018-09-11 Thread Carl Eugen Hoyos
2018-09-11 23:42 GMT+02:00, Paul B Mahol : > On 9/11/18, Carl Eugen Hoyos wrote: >> 2018-05-12 18:33 GMT+02:00, Michael Niedermayer : >>> Iam not sure if this is a good idea or not but it may make some >>> attacks harder. So throwing this out for discussions ... >> >> I am definitely not

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-09-11 Thread Jacob Trimble
On Tue, Sep 11, 2018 at 1:48 PM Michael Niedermayer wrote: > > On Thu, Aug 30, 2018 at 08:43:25AM -0700, Jacob Trimble wrote: > > On Wed, Aug 29, 2018 at 4:37 PM Michael Niedermayer > > wrote: > > > > > > On Wed, Aug 29, 2018 at 03:30:39PM -0700, Jacob Trimble wrote: > > > > On Wed, Aug 29, 2018

[FFmpeg-devel] [PATCH 2/3] avcodec/bintext: Use ff_get_buffer instead of ff_reget_buffer and simplify

2018-09-11 Thread Michael Niedermayer
reget seems unneeded and it is slower Signed-off-by: Michael Niedermayer --- libavcodec/bintext.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/libavcodec/bintext.c b/libavcodec/bintext.c index b14a2a9c29..d85f2c2dd4 100644 ---

[FFmpeg-devel] [PATCH 3/3] avcodec/pictordec: Error out if more than one plane is unused

2018-09-11 Thread Michael Niedermayer
Fixes: Timeout Fixes: 9797/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PICTOR_fuzzer-5664441659031552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pictordec.c | 3 +++ 1 file

[FFmpeg-devel] [PATCH 1/3] avcodec/bintext: Check input size before allocating the input image

2018-09-11 Thread Michael Niedermayer
Fixes: Timeout Fixes: 9795/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XBIN_fuzzer-5768631928487936 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/bintext.c | 3 +++ 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-11 Thread James Almer
On 9/3/2018 6:03 AM, Maxym Dmytrychenko wrote: > On Mon, Sep 3, 2018 at 10:17 AM Michael Niedermayer > wrote: > >> On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: >>> From: Luca Barbato >>> >>> Merged-by: James Almer >>> --- >>> This is the next merge in the queue. It's a critical

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-09-11 Thread Jacob Trimble
On Thu, Aug 30, 2018 at 8:43 AM Jacob Trimble wrote: > > On Wed, Aug 29, 2018 at 4:37 PM Michael Niedermayer > wrote: > > > > On Wed, Aug 29, 2018 at 03:30:39PM -0700, Jacob Trimble wrote: > > > On Wed, Aug 29, 2018 at 3:20 PM James Almer wrote: > > > > > > > > On 8/29/2018 7:07 PM, Michael

[FFmpeg-devel] adding file append option to file: protocol

2018-09-11 Thread Duane Salbi
The file protocol always creates new files. For mpeg1 and mpeg2, one can append directly. It would seem to be a small change to the file protocol to add a flag to support opening the file in append mode. Is there a good reason this is not already added?? For some standards, this would seem to

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/vp8: Check bitstream input in vp7_fade_frame() before time consuming operation

2018-09-11 Thread Michael Niedermayer
On Sun, Jun 24, 2018 at 04:46:22AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp8.c | 3 +++ > 1 file changed, 3 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at

Re: [FFmpeg-devel] [PATCH] frame: Simplify the video allocation

2018-09-11 Thread Maxym Dmytrychenko
On Tue, Sep 11, 2018 at 6:43 PM James Almer wrote: > On 9/3/2018 6:03 AM, Maxym Dmytrychenko wrote: > > On Mon, Sep 3, 2018 at 10:17 AM Michael Niedermayer > > > wrote: > > > >> On Sun, Sep 02, 2018 at 09:34:23PM -0300, James Almer wrote: > >>> From: Luca Barbato > >>> > >>> Merged-by: James

Re: [FFmpeg-devel] [PATCH 1/5] avformat/tty: Remove .txt from the extensions as it more likely is not a multimedia related file

2018-09-11 Thread Michael Niedermayer
On Sat, May 12, 2018 at 06:33:25PM +0200, Michael Niedermayer wrote: > Iam not sure if this is a good idea or not but it may make some > attacks harder. So throwing this out for discussions ... no comment or other suggestion from anyone, so i will apply this [...] -- Michael GnuPG

[FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
When static linking programs using ffmpeg libraries, if linking against libavutil, -ldrm is listed before -lavutil. This leads to linking failure due to undefined reference of drmGetVersion() and drmFreeVersion(). This is why when pkg-config create libavutil.pc doesn't append -ldrm after -lavutil.

Re: [FFmpeg-devel] [PATCH] libavcodec/pnm_parser: do not loose skipped parts in reporting of how much was consumed

2018-09-11 Thread Michael Niedermayer
On Tue, Sep 04, 2018 at 03:40:43PM +0200, Moritz Barsnick wrote: > On Tue, Sep 04, 2018 at 02:29:51 +0200, Michael Niedermayer wrote: > > Subject: [PATCH] libavcodec/pnm_parser: do not loose skipped parts in > > reporting of how much was consumed > Nit:

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_remap: add bilinear interpolation

2018-09-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 13 libavfilter/vf_remap.c | 167 + 2 files changed, 166 insertions(+), 14 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 860d1eadca..3c5941d748 100644 ---

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_remap: refactor code

2018-09-11 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_remap.c | 242 ++--- 1 file changed, 84 insertions(+), 158 deletions(-) diff --git a/libavfilter/vf_remap.c b/libavfilter/vf_remap.c index 4f8d57f229..48ec38af7c 100644 --- a/libavfilter/vf_remap.c +++

Re: [FFmpeg-devel] [PATCH] avformat/utils: Don't parse encrypted packets.

2018-09-11 Thread Michael Niedermayer
On Thu, Aug 30, 2018 at 08:43:25AM -0700, Jacob Trimble wrote: > On Wed, Aug 29, 2018 at 4:37 PM Michael Niedermayer > wrote: > > > > On Wed, Aug 29, 2018 at 03:30:39PM -0700, Jacob Trimble wrote: > > > On Wed, Aug 29, 2018 at 3:20 PM James Almer wrote: > > > > > > > > On 8/29/2018 7:07 PM,

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread James Almer
On 9/11/2018 5:29 PM, Giulio Benetti wrote: > When static linking programs using ffmpeg libraries, if linking against > libavutil, -ldrm is listed before -lavutil. This leads to linking failure > due to undefined reference of drmGetVersion() and drmFreeVersion(). > This is why when pkg-config

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Hello, Il 11/09/2018 22:49, James Almer ha scritto: On 9/11/2018 5:29 PM, Giulio Benetti wrote: When static linking programs using ffmpeg libraries, if linking against libavutil, -ldrm is listed before -lavutil. This leads to linking failure due to undefined reference of drmGetVersion() and

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread James Almer
On 9/11/2018 5:59 PM, Giulio Benetti wrote: > Hello, > > Il 11/09/2018 22:49, James Almer ha scritto: >> On 9/11/2018 5:29 PM, Giulio Benetti wrote: >>> When static linking programs using ffmpeg libraries, if linking against >>> libavutil, -ldrm is listed before -lavutil. This leads to linking

Re: [FFmpeg-devel] [PATCH v8 1/2] lavc, doc, configure: add libxavs2 video encoder wrapper

2018-09-11 Thread Mark Thompson
On 10/09/18 21:18, Mark Thompson wrote: > On 10/09/18 04:59, hwren wrote: >> Signed-off-by: hwren >> --- >> Changelog | 1 + >> configure | 4 + >> doc/encoders.texi | 49 >> doc/general.texi | 14 +++ >> libavcodec/Makefile| 1 + >>

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Hello, Il 11/09/2018 23:21, James Almer ha scritto: -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex -lmodplug -lstdc++ -lfontconfig -lfreetype -lpng16 -lexpat -ldrm -lz -pthread -latomic -lswresample -lavutil -lm What i'm seeing here is that -ldrm is apparently present in

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Il 11/09/2018 23:34, James Almer ha scritto: On 9/11/2018 6:24 PM, Giulio Benetti wrote: Hello, Il 11/09/2018 23:21, James Almer ha scritto: -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex -lmodplug -lstdc++ -lfontconfig -lfreetype -lpng16 -lexpat -ldrm -lz -pthread -latomic

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread James Almer
On 9/11/2018 6:24 PM, Giulio Benetti wrote: > Hello, > > Il 11/09/2018 23:21, James Almer ha scritto: >>> -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex >>> -lmodplug -lstdc++ -lfontconfig -lfreetype -lpng16 -lexpat -ldrm -lz >>> -pthread -latomic -lswresample  -lavutil -lm >>

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Il 11/09/2018 23:24, Giulio Benetti ha scritto: Hello, Il 11/09/2018 23:21, James Almer ha scritto: -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex -lmodplug -lstdc++ -lfontconfig -lfreetype -lpng16 -lexpat -ldrm -lz -pthread -latomic -lswresample  -lavutil -lm What i'm

Re: [FFmpeg-devel] [PATCH 1/5] avformat/tty: Remove .txt from the extensions as it more likely is not a multimedia related file

2018-09-11 Thread Carl Eugen Hoyos
2018-05-12 18:33 GMT+02:00, Michael Niedermayer : > Iam not sure if this is a good idea or not but it may make some > attacks harder. So throwing this out for discussions ... I am definitely not objecting but I doubt that this patch can make any attack harder. The main "advantage" of the patch

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Il 11/09/2018 23:38, Carl Eugen Hoyos ha scritto: 2018-09-11 23:34 GMT+02:00, Giulio Benetti : Il 11/09/2018 23:24, Giulio Benetti ha scritto: Hello, Il 11/09/2018 23:21, James Almer ha scritto: -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex -lmodplug -lstdc++ -lfontconfig

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Carl Eugen Hoyos
2018-09-11 23:34 GMT+02:00, Giulio Benetti : > Il 11/09/2018 23:24, Giulio Benetti ha scritto: >> Hello, >> >> Il 11/09/2018 23:21, James Almer ha scritto: -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex -lmodplug -lstdc++ -lfontconfig -lfreetype -lpng16 -lexpat -ldrm

Re: [FFmpeg-devel] [PATCH 1/5] avformat/tty: Remove .txt from the extensions as it more likely is not a multimedia related file

2018-09-11 Thread Paul B Mahol
On 9/11/18, Carl Eugen Hoyos wrote: > 2018-05-12 18:33 GMT+02:00, Michael Niedermayer : >> Iam not sure if this is a good idea or not but it may make some >> attacks harder. So throwing this out for discussions ... > > I am definitely not objecting but I doubt that this patch can make > any