Re: [FFmpeg-devel] [PATCH V2 2/5] fftools/ffprobe: fix max_bit_rate dump.

2018-11-21 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 09:01:41AM +0800, Jun Zhao wrote: > ‘codec’ is deprecated in AVStream, so used the dec_ctx to dump > max_bit_rate in ffprobe. Clean the warning like: > "warning: ‘codec’ is deprecated [-Wdeprecated-declarations]" > > Reviewed-by: Moritz Barsnick > Signed-off-by: Jun Zhao

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-21 Thread Tomas Härdin
tis 2018-11-20 klockan 21:09 + skrev Thomas Tgames: > Hi everyone ! > > I would like to convert a wav file of music into APC format (Atlantis > The Lost Tales). > I’m working on a new version of the game. > I’m successfully able to convert all APC of the game to WAV. But i > want to do the

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-21 Thread Thomas Tgames
Here is a private video of our project : https://www.youtube.com/watch?v=dHB7CL9k1j4 Please don’t share it until we release the project to the public. Thanks. De : Thomas Tgames Envoyé le :mercredi 21 novembre 2018 12:19 À : FFmpeg development discussions and

Re: [FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

2018-11-21 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 10:28:16PM +1100, Peter Ross wrote: > On Tue, Nov 20, 2018 at 11:26:31PM +0100, Michael Niedermayer wrote: > > On Tue, Nov 20, 2018 at 11:24:10PM +0100, Michael Niedermayer wrote: > > > On Wed, Nov 21, 2018 at 01:29:48AM +1100, Peter Ross wrote: > > > > djgpp 2.05 finally

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-21 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 11:19:22AM +, Thomas Tgames wrote: > Hi, > > It’s only for a fan project. > We already almost finish the project but we want to include this music in the > game. > Like ffmpeg include the possibility to decode APC files, i ask if someone on > ffmpeg development team

[FFmpeg-devel] [PATCH] avformat/movenc: fix size calculation in mov_write_eac3_tag()

2018-11-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 33978ee1b0..bee8e89760 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -541,7 +541,7 @@ static int

Re: [FFmpeg-devel] [PATCH] avformat/movenc: fix size calculation in mov_write_eac3_tag()

2018-11-21 Thread Tomas Härdin
ons 2018-11-21 klockan 11:46 +0100 skrev Paul B Mahol: > Signed-off-by: Paul B Mahol > --- >  libavformat/movenc.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 33978ee1b0..bee8e89760 100644 > ---

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-21 Thread Thomas Tgames
Hi, It’s only for a fan project. We already almost finish the project but we want to include this music in the game. Like ffmpeg include the possibility to decode APC files, i ask if someone on ffmpeg development team can include the encoding to APC files into ffmpeg. The goal of the project

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-21 Thread Thomas Tgames
It’s based on my work last year to make a lot better version than GOG. I called it « Perfect Edition » because every single bugs has been fixed by me. Now we want to get further and get back every not used feature during development of the game. We also made a « HUB MODE » in another branch of

Re: [FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

2018-11-21 Thread Peter Ross
On Tue, Nov 20, 2018 at 11:26:31PM +0100, Michael Niedermayer wrote: > On Tue, Nov 20, 2018 at 11:24:10PM +0100, Michael Niedermayer wrote: > > On Wed, Nov 21, 2018 at 01:29:48AM +1100, Peter Ross wrote: > > > djgpp 2.05 finally provides posix-compatible memalign, but it is broken, > > > so use

[FFmpeg-devel] [PATCH] avcodec: add truehd_core bitstream filter

2018-11-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure | 1 + doc/bitstream_filters.texi | 4 + libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/truehd_core_bsf.c | 184 + 5 files changed, 191

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-21 Thread Lauri Kasanen
> ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt yuv420p > \ > -f null -vframes 100 -v error -nostats - > > 1158 UNITS in planar1, 65528 runs, 8 skips > > -cpuflags 0 > > 19082 UNITS in planar1, 65533 runs, 3 skips > > 16.48 speedup ratio. On x86, SSE2 is

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-21 Thread Thomas Tgames
Thanks a lot if you can do this Tomas Härdin !! It will be very cool for the game. Best Regards. De : Tomas Härdin Envoyé le :mercredi 21 novembre 2018 14:09 À : ffmpeg-devel@ffmpeg.org Objet :Re: [FFmpeg-devel] Cryo APC Files (How to

[FFmpeg-devel] [PATCH 0/3] Reconciling some FLV hacks

2018-11-21 Thread Derek Buitenhuis
The main point of this patchset is patch #2, so please read the lengthy commit message on that patch for the reasoning behind this set. For patch #1: I am not 100% sure this fix is "correct". Without it, the FATE sample nellymoser-discont.flv, which is used in the aresample test has issues.

[FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: Don't mangle start time based on discontinuities for FLV

2018-11-21 Thread Derek Buitenhuis
As far as I can tell, this isn't valid here sicne FLV may not have added streams yet. Signed-off-by: Derek Buitenhuis --- fftools/ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index a12208cce9..3bc42c8ca8 100644 ---

[FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-21 Thread Derek Buitenhuis
Any FLV file, not necessarily valid, but in extremely common use for live or archived live purposes, may output discontinuous timestamps. As it currently is, only files produced by NGINX's RTMP module will be marked as supporting discontinuous timestamps, which is obviously untrue, and the fix was

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread James Almer
On 11/20/2018 11:47 PM, Haihao Xiang wrote: > This fixes the link errors below: > > LD ffmpeg_g > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_sse2' > collect2: error: ld returned 1 exit status >

[FFmpeg-devel] [PATCH 3/3] lavf: Depecate the live_flv demuxer

2018-11-21 Thread Derek Buitenhuis
It is now the same as the regular FLV demuxer, and has no reason to exist. Signed-off-by: Derek Buitenhuis --- libavformat/allformats.c | 2 ++ libavformat/flvdec.c | 2 ++ libavformat/version.h| 3 +++ 3 files changed, 7 insertions(+) diff --git a/libavformat/allformats.c

Re: [FFmpeg-devel] [PATCH 4/4] lavf/dashenc: Fix AVDictionary leaks in case of various init errors.

2018-11-21 Thread Jeyapal, Karthick
On 11/20/18 6:01 PM, Andrey Semashev wrote: > On 11/18/18 1:55 PM, Jeyapal, Karthick wrote: > > Thanks for sending these excellent patches. The entire patchset looks good > > to me. > > Also, many thanks for your patience and taking the earlier review comments > > in the right spirit. > > Ping

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-21 Thread Thomas Tgames
Thanks for all your answer ! If someone can make the encoder, it will be credited into the credits of the game of course. It will helps Atlantis The Lost Tales Community, because lot of people ask me about include this music into the game. Pierre Esteve (the composer of the music) himself told

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread Derek Buitenhuis
On 21/11/2018 14:09, Hendrik Leppkes wrote: > This does not apply here, the function is called unconditionally on > x86 (or rather on ARCH_X86) > What we usually do is just put the contents of such functions into the > guard, and not the init function itself - instead of having a second > one.

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-21 Thread Lauri Kasanen
On Wed, 21 Nov 2018 13:21:58 +0100 Michael Niedermayer wrote: > On Wed, Nov 21, 2018 at 10:12:48AM +0200, Lauri Kasanen wrote: > > > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > > > yuv420p \ > > > -f null -vframes 100 -v error -nostats - > > > > > > 1158 UNITS in

Re: [FFmpeg-devel] Cryo APC Files (How to convert WAV files to APC files) ?

2018-11-21 Thread Tomas Härdin
ons 2018-11-21 klockan 11:19 + skrev Thomas Tgames: > Hi, > > It’s only for a fan project. > We already almost finish the project but we want to include this > music in the game. > Like ffmpeg include the possibility to decode APC files, i ask if > someone on ffmpeg development team can

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread Derek Buitenhuis
On 21/11/2018 02:47, Haihao Xiang wrote: > This fixes the link errors below: > > LD ffmpeg_g > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_sse2' > collect2: error: ld returned 1 exit status >

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread Hendrik Leppkes
On Wed, Nov 21, 2018 at 2:21 PM Derek Buitenhuis wrote: > > On 21/11/2018 02:47, Haihao Xiang wrote: > > This fixes the link errors below: > > > > LD ffmpeg_g > > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > > libavfilter/libavfilter.so: undefined reference to

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-21 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 10:12:48AM +0200, Lauri Kasanen wrote: > > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > > yuv420p \ > > -f null -vframes 100 -v error -nostats - > > > > 1158 UNITS in planar1, 65528 runs, 8 skips > > > > -cpuflags 0 > > > > 19082 UNITS

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-21 Thread Lauri Kasanen
On Wed, 21 Nov 2018 17:22:36 +0100 Michael Niedermayer wrote: > the full fate tests must be run, many of these tests use swscale without > having "scale" in their name > and yes on lower end hardware 20min and longer is possible I get failures on the baseline, without my patch. What is the

Re: [FFmpeg-devel] [PATCH 2/3] flvdec: Mark the demuxer as allowing discontinuous timestamps

2018-11-21 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 03:58:47PM +, Derek Buitenhuis wrote: > Any FLV file, not necessarily valid, but in extremely common use for live > or archived live purposes, may output discontinuous timestamps. As it > currently > is, only files produced by NGINX's RTMP module will be marked as

Re: [FFmpeg-devel] patch for failing on WavPack DSD files

2018-11-21 Thread David Bryant
On 11/20/18 10:58 PM, Peter Ross wrote: > On Tue, Nov 20, 2018 at 09:23:03PM -0800, David Bryant wrote: >> Hi, >> >> Was made aware of this problem on Kodi: >> >> https://github.com/xbmc/xbmc/issues/14771 >> >> I'm going to try to add full WavPack DSD support, but thought in the >> meantime it

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread James Almer
On 11/21/2018 9:57 PM, Xiang, Haihao wrote: > On Wed, 2018-11-21 at 12:27 -0300, James Almer wrote: >> On 11/20/2018 11:47 PM, Haihao Xiang wrote: >>> This fixes the link errors below: >>> >>> LD ffmpeg_g >>> libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' >>>

Re: [FFmpeg-devel] [PATCH V2 2/5] fftools/ffprobe: fix max_bit_rate dump.

2018-11-21 Thread myp...@gmail.com
On Thu, Nov 22, 2018 at 5:11 AM Michael Niedermayer wrote: > > On Wed, Nov 21, 2018 at 09:01:41AM +0800, Jun Zhao wrote: > > ‘codec’ is deprecated in AVStream, so used the dec_ctx to dump > > max_bit_rate in ffprobe. Clean the warning like: > > "warning: ‘codec’ is deprecated

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Fix segment duration overflow on fine time bases.

2018-11-21 Thread Jeyapal, Karthick
On 11/20/18 11:03 PM, Andrey Semashev wrote: > When stream time bases are very fine grained (e.g. nanoseconds), 32-bit > segment duration may overflow for even for rather small segment duration > (about 4 seconds long). Therefore we use 64-bit values for segment duration. > --- >

[FFmpeg-devel] [PATCH 4/4] avformat/concatdec: always re-calculate start time and duration

2018-11-21 Thread Marton Balint
This allows the underlying files to change their duration on subsequent avformat context opens. An example use case where this matters: ffconcat version 1.0 file dummy.mxf file dummy.mxf ffmpeg -re -stream_loop -1 -i dummy.ffconcat -f sdl2 none The user can seamlessly change the input by

[FFmpeg-devel] [PATCH 3/4] avformat/concatdec: fix cur_dts based duration calculation with nonzero stream start_time

2018-11-21 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/concatdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 97a0faea14..ebc50324cc 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -325,7 +325,7 @@

[FFmpeg-devel] [PATCH 2/4] avformat/concatdec: factorize the duration calculating function

2018-11-21 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/concatdec.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index a5883ec66e..97a0faea14 100644 --- a/libavformat/concatdec.c +++

Re: [FFmpeg-devel] [PATCH] Fix link errors when HAVE_X86ASM is not defined

2018-11-21 Thread Xiang, Haihao
On Wed, 2018-11-21 at 12:27 -0300, James Almer wrote: > On 11/20/2018 11:47 PM, Haihao Xiang wrote: > > This fixes the link errors below: > > > > LD ffmpeg_g > > libavfilter/libavfilter.so: undefined reference to `ff_scene_sad_avx2' > > libavfilter/libavfilter.so: undefined reference to

[FFmpeg-devel] [PATCH 1/4] avformat/concatdec: set seekable flag after opening the last file

2018-11-21 Thread Marton Balint
After finishing the last file all durations and start times should be known. Signed-off-by: Marton Balint --- libavformat/concatdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index bbe13136fa..a5883ec66e 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] avformat/dashenc : Handled error from ff_http_do_new_request() cleanly

2018-11-21 Thread Jeyapal, Karthick
Pushed the patchset. On 11/16/18 2:27 PM, Karthick J wrote: > --- > libavformat/dashenc.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index d151921175..2c1cce0c92 100644 > --- a/libavformat/dashenc.c > +++

[FFmpeg-devel] [PATCH] avutil/avsscanf: do not use unsupported p suffig for hex variable

2018-11-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavutil/avsscanf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavutil/avsscanf.c b/libavutil/avsscanf.c index 8fc9c5956b..360170c9a9 100644 --- a/libavutil/avsscanf.c +++ b/libavutil/avsscanf.c @@ -241,8 +241,6 @@ static long long

[FFmpeg-devel] [PATCH 1/3] cbs_h2645: Avoid memcpy when splitting fragment

2018-11-21 Thread Andreas Rheinhardt
Now memcpy is avoided for NAL units that don't contain 0x03 escape characters. Improves performance of cbs_h2645_fragment_add_nals from 36940 decicycles to 6364 decicycles based on 8 runs with a 5.1 Mb/s H.264 sample (262144 runs each). Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH 0/3] Updated patchset

2018-11-21 Thread Andreas Rheinhardt
> If something is so specific to one component that its not universally > useful, then it should probably be local to that component. Ok, I have completely removed the changes to buffer.c and buffer.h and incorporated them into a static function in h2645_parse.c. Thank you. - Andreas Andreas

[FFmpeg-devel] [PATCH 2/3] h2645_parse: Make ff_h2645_packet_split reference-compatible

2018-11-21 Thread Andreas Rheinhardt
This is in preparation for a patch for cbs_h2645. Now the packet's rbsp_buffer can be owned by an AVBuffer. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_h2645.c | 12 - libavcodec/extract_extradata_bsf.c | 4 +-- libavcodec/h2645_parse.c | 43

[FFmpeg-devel] [PATCH 3/3] cbs_h2645: Avoid memcpy when splitting fragment #2

2018-11-21 Thread Andreas Rheinhardt
Now memcpy can be avoided for NAL units containing escapes, too. Particularly improves performance for files with hardcoded black bars. For such a file, time spent in cbs_h2645_split_fragment went down from 369410 decicycles to 327677 decicycles. (It were 379114 decicycles when every NAL unit was

Re: [FFmpeg-devel] [PATCH v2] swscale/output: Altivec-optimize yuv2plane1_8

2018-11-21 Thread Michael Niedermayer
On Wed, Nov 21, 2018 at 02:35:32PM +0200, Lauri Kasanen wrote: > On Wed, 21 Nov 2018 13:21:58 +0100 > Michael Niedermayer wrote: > > > On Wed, Nov 21, 2018 at 10:12:48AM +0200, Lauri Kasanen wrote: > > > > ./ffmpeg_g -f rawvideo -pix_fmt rgb24 -s hd1080 -i /dev/zero -pix_fmt > > > > yuv420p \ >

Re: [FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: Don't mangle start time based on discontinuities for FLV

2018-11-21 Thread Hendrik Leppkes
On Wed, Nov 21, 2018 at 4:59 PM Derek Buitenhuis wrote: > > As far as I can tell, this isn't valid here sicne FLV may not have added > streams yet. > > Signed-off-by: Derek Buitenhuis > --- > fftools/ffmpeg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/3] fftools/ffmpeg: Don't mangle start time based on discontinuities for FLV

2018-11-21 Thread Derek Buitenhuis
On 21/11/2018 16:31, Hendrik Leppkes wrote: > Format name comparisons are basically always wrong. Don't we have > AVFMTCTX_NOHEADER for that? I could change it to use that, yeah. I'll send a v2 that does, if the author agrees it's the correct fix. - Derek