Re: [FFmpeg-devel] [PATCH] avfilter/tests/integral: Check malloc fail before using it

2019-02-11 Thread Michael Niedermayer
On Sun, Feb 10, 2019 at 01:07:20PM +0800, Jun Zhao wrote: > Need to check malloc fail before using it, so adjust the location > in the code. > > Signed-off-by: Jun Zhao > --- > libavfilter/tests/integral.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) LGTM thx [...] --

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/tests/integral: Fix build warning after adjust the location

2019-02-11 Thread Michael Niedermayer
On Sun, Feb 10, 2019 at 02:53:57PM +0800, Jun Zhao wrote: > Fix build warning like "warning: ISO C90 forbids mixed declarations > and code" after adjust the location for malloc fail check. > > Signed-off-by: Jun Zhao > --- > libavfilter/tests/integral.c |9 + > 1 files changed, 5

Re: [FFmpeg-devel] [PATCH] avformat/mov: don't rescale mastering display values from the SmDm atom

2019-02-11 Thread Michael Niedermayer
On Sat, Feb 09, 2019 at 08:21:41PM -0300, James Almer wrote: > Simplifies code. > > Signed-off-by: James Almer > --- > libavformat/mov.c | 21 - > 1 file changed, 8 insertions(+), 13 deletions(-) probably ok [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH v2 08/11] vaapi_encode_mjpeg: Warn if input is not full range

2019-02-11 Thread Michael Niedermayer
On Sun, Feb 10, 2019 at 06:21:42PM +, Mark Thompson wrote: > On 05/02/2019 13:27, Carl Eugen Hoyos wrote: > > 2019-01-28 0:47 GMT+01:00, Mark Thompson : > > > >> +if (avctx->color_range == AVCOL_RANGE_MPEG) { > >> +av_log(avctx, AV_LOG_WARNING, "Input video does not appear " > >>

[FFmpeg-devel] av_write_frame(ofmt_ctx, pkt) and localtime/gmtime

2019-02-11 Thread Subrata Goswami
Wondering how is the localtime/gmtime is calculated for writing to each frame. Is it based on pts or systemtime at the time of writing. Where exactly does that code reside ? Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-11 Thread Guillaume Desmottes
CDG doesn't ensure a constant framerate as we can have holes in the CDG stream. So there is no guarantee of the duration of a single frame, it will be displayed until a new packet with CDG instruction arrives in the stream. Signed-off-by: Guillaume Desmottes --- libavformat/cdg.c | 1 + 1 file

Re: [FFmpeg-devel] [PATCH v4] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-02-11 Thread Michael Niedermayer
On Mon, Feb 11, 2019 at 05:41:04PM -0500, Shaofei Wang wrote: > It enabled multiple filter graph concurrency, which bring above about > 4%~20% improvement in some 1:N scenarios by CPU or GPU acceleration > > Below are some test cases and comparison as reference. > (Hardware platform: Intel(R)

Re: [FFmpeg-devel] lavc/libvpxenc: Deprecate lossless option

2019-02-11 Thread James Zern
On Sat, Feb 9, 2019 at 3:15 AM Carl Eugen Hoyos wrote: > > 2019-02-09 7:49 GMT+01:00, Gyan : > > > > > > On 09-02-2019 02:26 AM, Carl Eugen Hoyos wrote: > >> 2019-02-08 6:08 GMT+01:00, Gyan : > >>> > >>> On 08-02-2019 03:31 AM, Carl Eugen Hoyos wrote: > . > No strong opinion here, I

Re: [FFmpeg-devel] [PATCH] configure: warn about disabled explicitly enabled components

2019-02-11 Thread Marton Balint
On Sun, 10 Feb 2019, Marton Balint wrote: On Sat, 9 Feb 2019, Marton Balint wrote: On Sat, 9 Feb 2019, Carl Eugen Hoyos wrote: 2019-02-05 22:14 GMT+01:00, Marton Balint : If we enable a component but a dependant library is disabled, then the enabled component gets silently disabled.

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-11 Thread Marton Balint
On Sun, 10 Feb 2019, Carl Eugen Hoyos wrote: 2019-02-10 23:04 GMT+01:00, Marton Balint : On Sun, 3 Feb 2019, Charles Liu wrote: Binary searching would hang if the fragment items do NOT have timestamp for the specified stream. For example, a fmp4 consists of separated 'moof' boxes for

[FFmpeg-devel] [PATCH 2/2] libavcodec/cbs: Stop needlessly reallocating the units array

2019-02-11 Thread Andreas Rheinhardt
Currently, a fragment's unit array is constantly reallocated during splitting of a packet. This commit changes this: One can keep the units array by distinguishing between the number of allocated and the number of valid units in the units array. The more units a packet is split into, the bigger

[FFmpeg-devel] [PATCH 1/2] filter_units, trace_headers: Always use fragment from context

2019-02-11 Thread Andreas Rheinhardt
This is in preparation for another patch that will stop needless reallocations of the unit array. Signed-off-by: Andreas Rheinhardt --- libavcodec/filter_units_bsf.c | 8 libavcodec/trace_headers_bsf.c | 13 +++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/utils: parse some stream specifiers recursively

2019-02-11 Thread Marton Balint
On Tue, 5 Feb 2019, Marton Balint wrote: This removes lots of code duplication and also allows more complex specifiers, for example you can use p:204:a:m:language:eng to select the English language audio stream from program 204. Ping... Will apply soon. Thanks, Marton Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-11 Thread Chris Cunningham
On Fri, Feb 8, 2019 at 2:37 PM Michael Niedermayer wrote: > ogg allows chaining streams when they have differing serial numbers > https://xiph.org/ogg/doc/oggstream.html > > i think ive seen actual files doing this > > ogg_replace_stream() might assign these into existing avstreams i think > If

Re: [FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-11 Thread Michael Niedermayer
On Mon, Feb 11, 2019 at 05:59:34PM +0100, Guillaume Desmottes wrote: > CDG doesn't ensure a constant framerate as we can have holes in the CDG > stream. So there is no guarantee of the duration of a single frame, it > will be displayed until a new packet with CDG instruction arrives in the >

[FFmpeg-devel] [PATCH 3/3] avformat/mpegtsenc: add support for service and provider names with utf8 encoding

2019-02-11 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 76 +++-- 1 file changed, 49 insertions(+), 27 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4470b7120c..a600394619 100644 --- a/libavformat/mpegtsenc.c +++

[FFmpeg-devel] [PATCH 1/3] avformat/mpegts: fix charset of type 0x11

2019-02-11 Thread Marton Balint
ISO-10646 alone means UCS-4 for iconv, the specs refers to the Basic Multilingual Plane (BMP), therefore we need UCS-2. VLC also using that. Signed-off-by: Marton Balint --- libavformat/mpegts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpegts.c

[FFmpeg-devel] [PATCH 2/3] avformat/mpegts: also convert strings without a specified encoding to UTF-8

2019-02-11 Thread Marton Balint
The default codepage (ISO6937) should be used in this case. Signed-off-by: Marton Balint --- libavformat/mpegts.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 2594b1eeb1..e7bbf3e488 100644 ---

Re: [FFmpeg-devel] [PATCH 4/4] lavc/libaribb24: use integer math to calculate font scaling

2019-02-11 Thread Michael Niedermayer
On Mon, Feb 11, 2019 at 03:06:54AM +0200, Jan Ekström wrote: > --- > libavcodec/libaribb24.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no

Re: [FFmpeg-devel] [PATCH 1/4] lavc/libaribb24: add error handling to region handling

2019-02-11 Thread Michael Niedermayer
On Mon, Feb 11, 2019 at 03:06:51AM +0200, Jan Ekström wrote: > Fixes some rather embarrassing mistakes that somehow passed my > eyes. > > * Now catches if memory allocation has failed during bprint usage > by checking av_bprint_is_complete(). > * Now catches if adding an ASS rectangle into an

Re: [FFmpeg-devel] [PATCH 2/4] lavc/libaribb24: protect handled value with parenthesis in RGB_TO_BGR

2019-02-11 Thread Michael Niedermayer
On Mon, Feb 11, 2019 at 03:06:52AM +0200, Jan Ekström wrote: > --- > libavcodec/libaribb24.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many things microsoft did are stupid, but not doing

Re: [FFmpeg-devel] [PATCH V2] tests/api/api-h264-test: Add AV_NOPTS_VALUE check for AVFrame.pkt_dts

2019-02-11 Thread myp...@gmail.com
On Tue, Feb 12, 2019 at 7:38 AM Michael Niedermayer wrote: > > On Mon, Feb 11, 2019 at 11:21:27AM +0800, Jun Zhao wrote: > > Add AV_NOPTS_VALUE check for AVFrame.pkt_dts to avoid print the > > pkt_dts as negative number like: > > "0,3616613, -9223372036854775808, 1001, 3110400,

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpegts: also convert strings without a specified encoding to UTF-8

2019-02-11 Thread Carl Eugen Hoyos
2019-02-11 23:42 GMT+01:00, Marton Balint : > The default codepage (ISO6937) should be used in this case. lgtm Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v4] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-02-11 Thread Mark Thompson
On 11/02/2019 22:41, Shaofei Wang wrote: Please avoid sending messages from the future - the list received this about thirteen hours before its supposed send time (received "Mon, 11 Feb 2019 11:42:09 +0200", sent "Mon, 11 Feb 2019 17:41:04 -0500"). Probably the sending machine or some

Re: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support more RC modes

2019-02-11 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark > Thompson > Sent: Sunday, February 10, 2019 11:51 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 01/11] vaapi_encode: Support more RC > modes > > On

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mpegts: fix charset of type 0x11

2019-02-11 Thread Carl Eugen Hoyos
2019-02-11 23:42 GMT+01:00, Marton Balint : > ISO-10646 alone means UCS-4 for iconv, the specs refers to the Basic > Multilingual Plane (BMP), therefore we need UCS-2. VLC also using that. > > Signed-off-by: Marton Balint > --- > libavformat/mpegts.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH V2] tests/api/api-h264-test: Add AV_NOPTS_VALUE check for AVFrame.pkt_dts

2019-02-11 Thread Michael Niedermayer
On Mon, Feb 11, 2019 at 11:21:27AM +0800, Jun Zhao wrote: > Add AV_NOPTS_VALUE check for AVFrame.pkt_dts to avoid print the > pkt_dts as negative number like: > "0,3616613, -9223372036854775808, 1001, 3110400, 0x75e37a65" > > Signed-off-by: Jun Zhao > --- > tests/api/api-h264-test.c |

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/tests/integral: Fix build warning after adjust the location

2019-02-11 Thread myp...@gmail.com
On Tue, Feb 12, 2019 at 1:48 AM Michael Niedermayer wrote: > > On Sun, Feb 10, 2019 at 02:53:57PM +0800, Jun Zhao wrote: > > Fix build warning like "warning: ISO C90 forbids mixed declarations > > and code" after adjust the location for malloc fail check. > > > > Signed-off-by: Jun Zhao > > ---

[FFmpeg-devel] [PATCHv2 3/3] avformat/mpegtsenc: add support for service and provider names with utf8 encoding

2019-02-11 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mpegtsenc.c | 88 + 1 file changed, 53 insertions(+), 35 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4470b7120c..523ac65d55 100644 --- a/libavformat/mpegtsenc.c +++

Re: [FFmpeg-devel] [PATCH 3/4] lavc/libaribb24: add missing type struct members to AVOptions

2019-02-11 Thread Michael Niedermayer
On Mon, Feb 11, 2019 at 03:06:53AM +0200, Jan Ekström wrote: > --- > libavcodec/libaribb24.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or

Re: [FFmpeg-devel] [PATCH] avfilter/tests/integral: Check malloc fail before using it

2019-02-11 Thread myp...@gmail.com
On Tue, Feb 12, 2019 at 1:48 AM Michael Niedermayer wrote: > > On Sun, Feb 10, 2019 at 01:07:20PM +0800, Jun Zhao wrote: > > Need to check malloc fail before using it, so adjust the location > > in the code. > > > > Signed-off-by: Jun Zhao > > --- > > libavfilter/tests/integral.c |6 +++---

[FFmpeg-devel] [PATCH V3] tests/api/api-h264-test: Add AV_NOPTS_VALUE check for AVFrame.pkt_dts/pts

2019-02-11 Thread Jun Zhao
Use av_ts2str() for AVFrame.pkt_dts/pts to avoid print the pkt_dts/pts as negative number like: "0,3616613, -9223372036854775808, 1001, 3110400, 0x75e37a65" Reviewed-by: Michael Niedermayer Signed-off-by: Jun Zhao --- tests/api/api-h264-test.c |7 --- 1 files changed, 4

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: update notes to explain the scale chosen for ROI encoding

2019-02-11 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Monday, February 04, 2019 5:34 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: update notes to > explain the scale chosen for

Re: [FFmpeg-devel] [PATCH 1/4] zmbvenc: don't sum the entropy when blocks are equal

2019-02-11 Thread Tomas Härdin
sön 2019-02-10 klockan 22:18 + skrev Matthew Fearnley: > > On Thu, 31 Jan 2019 at 15:00, Tomas Härdin wrote: > > > > > > 1. The entropy calculation in block_cmp() omits the score of histogram[0] > > > from the final sum. > > > It's tempting to do this to bias the scores in favour of

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx loading issues in fragmented files.

2019-02-11 Thread Michael Niedermayer
On Sat, Feb 09, 2019 at 11:44:52PM -0500, agrecascino...@gmail.com wrote: > From: mptcultist > > fixed issue where if sidx was after another sidx and happened to point to the > same media, it wouldn't be read. > this is done by counting the sidx atoms before they're read. for #7572 > --- >

[FFmpeg-devel] [PATCH v4] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-02-11 Thread Shaofei Wang
It enabled multiple filter graph concurrency, which bring above about 4%~20% improvement in some 1:N scenarios by CPU or GPU acceleration Below are some test cases and comparison as reference. (Hardware platform: Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz) (Software: Intel iHD driver - 16.9.00100,

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: add var_stream_map LANGUAGE field string parameter

2019-02-11 Thread Carl Eugen Hoyos
2019-01-23 12:24 GMT+01:00, Steven Liu : > use a:0,agroup:aud_low,default:Yes,language:CHN > a:1,agroup:aud_low,language:ENG > a:2,agroup:aud_high,default:YesYes,language:CHN > a:3,agroup:aud_high,language:ENG I know this is late but shouldn't the language be taken from the metadata if !=

Re: [FFmpeg-devel] [PATCH v4] Improved the performance of 1 decode + N filter graphs and adaptive bitrate.

2019-02-11 Thread Wang, Shaofei
Code clean and remove the "-abr_pipeline" option, use the perf improved code path by default only if HAVE_THREAD enabled. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-11 Thread C.H.Liu
It is lucky that my patch works to ticket 7572. However, #7572 has a deeper reason. Mov demuxer consider that fragmented index is completed if a ‘sidx’ point to the end of the file. But there may be other ‘sidx’ for other tracks. If we skip the tail from there, we will missing the last ‘sidx’ and

Re: [FFmpeg-devel] Proposal: Homebrew tap for FFmpeg

2019-02-11 Thread Werner Robitza
On Sun, Feb 10, 2019 at 7:40 PM Jean-Baptiste Kempf wrote: > > On Sun, 10 Feb 2019, at 19:37, Werner Robitza wrote: > > > Those options are just for non-free cases, and to be honest, I don't see > > > why FFmpeg should advertise those. > > > > That is not correct. The following