Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-22 Thread Michael Niedermayer
On Mon, Apr 22, 2019 at 11:42:57AM +, Andreas Håkon wrote: > > ‐‐‐ Original Message ‐‐‐ > On Friday, 19 de April de 2019 17:08, Michael Niedermayer > wrote: > > > On Fri, Apr 19, 2019 at 08:23:35AM +, Andreas Håkon via ffmpeg-devel > > wrote: > > > > > From

Re: [FFmpeg-devel] [PATCH 14/15] avformat/matroskaenc: Improve log messages for blocks

2019-04-22 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sun, Apr 21, 2019 at 11:04:00PM +, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Sat, Apr 20, 2019 at 01:41:09AM +0200, Andreas Rheinhardt wrote: Up until now, a block's relative offset has been reported as the offset in the log messages output

Re: [FFmpeg-devel] [PATCH] avfilter/af_astats: count number of NaNs/Infs/denormals for floating-point audio too

2019-04-22 Thread Alexander Strasser
Hi Paul, just three small comments from me... On 2019-04-22 11:51 +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi| 6 +++ > libavfilter/af_astats.c | 86 ++--- > 2 files changed, 86 insertions(+), 6 deletions(-) I

Re: [FFmpeg-devel] [PATCH] libavformat: fix copyts and muxrate in mpegts muxer

2019-04-22 Thread Michael Niedermayer
On Fri, Apr 19, 2019 at 08:47:34AM +, Andreas Håkon via ffmpeg-devel wrote: > ‐‐‐ Original Message ‐‐‐ > On Thursday, 18 de April de 2019 11:01, Andreas Håkon via ffmpeg-devel > wrote: > > > Hi, > > > > This patch resolves one very specific use case: > > > > - When you use the

Re: [FFmpeg-devel] [PATCH 14/15] avformat/matroskaenc: Improve log messages for blocks

2019-04-22 Thread Michael Niedermayer
On Sun, Apr 21, 2019 at 11:04:00PM +, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sat, Apr 20, 2019 at 01:41:09AM +0200, Andreas Rheinhardt wrote: > >> Up until now, a block's relative offset has been reported as the offset > >> in the log messages output when writing blocks; given

Re: [FFmpeg-devel] [PATCH V2 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-04-22 Thread Alexander Strasser
Hi! On 2019-04-15 21:23 +0800, Guo, Yejun wrote: > take decoder names an example, with the default page length, shell command > 'pr' needs two pages for all the decoder names. The names are firstly printed > in the first page, then in the second page. So, as a whole, the names are > sorted

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Fix a bug with writing "final" manifest

2019-04-22 Thread Jeyapal, Karthick
On 4/17/19 11:28 AM, Karthick J wrote: > This bug was introduced in the commit 951561b64ee6c11f01daedd9dcf73276cc1e765b > --- > libavformat/dashenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-22 Thread Nicolas George
Paul B Mahol (12019-04-21): > https://dspguru.com/dsp/faqs/multirate/resampling/ > > Resampling involves interpolation. > If I do resampling with aresample and resampling with factor 2 from > 44100 to 88200 > I can see there is still some spectrum data in highest frequencies. Resampling MAY

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-04-22 Thread Carl Eugen Hoyos
> Am 20.04.2019 um 11:31 schrieb Gyan : > > > Old patch that was never applied. Rebased. Please return patch_welcome for mlp and truehd. Wasn’t there another comment (not by me): “Why can’t .codec_tag be used?” Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 2/3] avfilter: add audio upsample filter

2019-04-22 Thread Paul B Mahol
On 4/22/19, Nicolas George wrote: > Paul B Mahol (12019-04-21): >> https://dspguru.com/dsp/faqs/multirate/resampling/ >> >> Resampling involves interpolation. >> If I do resampling with aresample and resampling with factor 2 from >> 44100 to 88200 >> I can see there is still some spectrum data in

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-04-22 Thread Sun, Jing A
-Original Message- From: Sun, Jing A Sent: Monday, April 1, 2019 10:38 AM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper Signed-off-by: Zhengxu Huang Signed-off-by:

[FFmpeg-devel] [PATCH] avfilter/af_astats: count number of NaNs/Infs/denormals for floating-point audio too

2019-04-22 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 6 +++ libavfilter/af_astats.c | 86 ++--- 2 files changed, 86 insertions(+), 6 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index cfff9b1f4d..945c557e8f 100644 --- a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-04-22 Thread Gyan
On 22-04-2019 01:15 PM, Gyan wrote: On 22-04-2019 12:30 PM, Carl Eugen Hoyos wrote: Am 20.04.2019 um 11:31 schrieb Gyan : Old patch that was never applied. Rebased. Please return patch_welcome for mlp and truehd. Will do. Wasn’t there another comment (not by me): “Why can’t .codec_tag

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Add a blank like at the end to avoid rollup reading from outside

2019-04-22 Thread Alexander Strasser
Hi Michael! On 2019-04-20 18:11 +0200, Michael Niedermayer wrote: > Fixes: index 20 out of bounds for type 'const char *[4][128]' Somehow I don't understand this diagnostic message. It says "index 20 out of bounds for [4][128]". You're change looks like an off-by-one fix. Sorry; I'm surely

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-04-22 Thread Gyan
On 22-04-2019 12:30 PM, Carl Eugen Hoyos wrote: Am 20.04.2019 um 11:31 schrieb Gyan : Old patch that was never applied. Rebased. Please return patch_welcome for mlp and truehd. Will do. Wasn’t there another comment (not by me): “Why can’t .codec_tag be used?” There's no codec_tag

Re: [FFmpeg-devel] [PATCH V2] lavf/oggparsevorbis: Fix change the case of metadata keys issue

2019-04-22 Thread myp...@gmail.com
On Mon, Apr 22, 2019 at 10:43 PM Derek Buitenhuis wrote: > > On 22/04/2019 13:19, myp...@gmail.com wrote: > > Ping? > > > > LGTM. > > - Derek Pushed, Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH V2] lavfi/frei0r: Fixes the compilation warnings

2019-04-22 Thread myp...@gmail.com
On Sun, Apr 21, 2019 at 9:03 PM Paul B Mahol wrote: > > On 4/21/19, Jun Zhao wrote: > > From: Jun Zhao > > > > Fixes the compilation warnings > > > > Signed-off-by: Jun Zhao > > --- > > libavfilter/vf_frei0r.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH V2 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-04-22 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Alexander Strasser > Sent: Tuesday, April 23, 2019 8:40 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2 1/2] configure: sort >

[FFmpeg-devel] [PATCH V3 2/2] configure: replace 'pr' with printf since busybox does not support pr

2019-04-22 Thread Guo, Yejun
It is part of change from https://trac.ffmpeg.org/ticket/5680 provided by Kylie McClain at Wed, 29 Jun 2016 16:37:20 -0400. That change contains two parts, in function log_file and in function print_in_columns. The second part is not good, so I have send out a new patch for print_in_columns.

[FFmpeg-devel] [PATCH V3 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-04-22 Thread Guo, Yejun
take decoder names an example, with the default page length, shell command 'pr' needs two pages for all the decoder names. The names are firstly printed in the first page, then in the second page. So, as a whole, the names are sorted neither in column order nor in row order. It's a little

[FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add support for maxframesize

2019-04-22 Thread Linjie Fu
Add support for max frame size: - max_frame_size (bytes) to indicate the allowed max frame size. - pass_num to indicate number of passes. - delta_qp to indicate adjust qp value. Currently only AVC encoder can support this settings in multiple pass case. If the frame size exceeds, the

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add support for maxframesize

2019-04-22 Thread myp...@gmail.com
On Tue, Apr 23, 2019 at 11:29 AM Linjie Fu wrote: > > Add support for max frame size: > - max_frame_size (bytes) to indicate the allowed max frame size. > - pass_num to indicate number of passes. > - delta_qp to indicate adjust qp value. > > Currently only AVC encoder can support this

Re: [FFmpeg-devel] [PATCH] libavformat/mov: limit nb_frames_for_fps to INT_MAX

2019-04-22 Thread Dan Sanders
It's this or add overflow detection in mov_read_header(). --- libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d5ce077e63..247a65ed11 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2940,7 +2940,7 @@

Re: [FFmpeg-devel] [PATCH] avdevice/alsa: fix indefinite stop on closing PCM capture

2019-04-22 Thread Lou Logan
On Fri, 19 Apr 2019 10:54:26 -0800 Lou Logan wrote: > From 10800493523b9274e7cc8784b65cc183a94b7281 Mon Sep 17 00:00:00 2001 > From: Takayuki 'January June' Suwa > Date: Thu, 18 Apr 2019 10:56:40 +0900 > Subject: [PATCH] avdevice/alsa: fix indefinite stop on closing PCM capture > > Sorry, I

Re: [FFmpeg-devel] [PATCH] avdevice/alsa: fix indefinite stop on closing PCM capture

2019-04-22 Thread Nicolas George
Lou Logan (12019-04-19): > Attached patch resolves the issue mentioned within. > >From 10800493523b9274e7cc8784b65cc183a94b7281 Mon Sep 17 00:00:00 2001 > From: Takayuki 'January June' Suwa > Date: Thu, 18 Apr 2019 10:56:40 +0900 > Subject: [PATCH] avdevice/alsa: fix indefinite stop on closing

Re: [FFmpeg-devel] [PATCH] libavformat: fix copyts and muxrate in mpegts muxer

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Friday, 19 de April de 2019 10:47, Andreas Håkon via ffmpeg-devel wrote: > ‐‐‐ Original Message ‐‐‐ > On Thursday, 18 de April de 2019 11:01, Andreas Håkon via ffmpeg-devel > ffmpeg-devel@ffmpeg.org wrote: > > > Hi, > > This patch resolves one very

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread myp...@gmail.com
On Mon, Apr 22, 2019 at 7:38 PM Li, Zhong wrote: > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Andreas Håkon via ffmpeg-devel > > Sent: Thursday, April 18, 2019 6:11 PM > > To: FFmpeg development discussions and patches > > > > Cc: Andreas Håkon > > Subject:

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Andreas Håkon via ffmpeg-devel > Sent: Thursday, April 18, 2019 6:11 PM > To: FFmpeg development discussions and patches > > Cc: Andreas Håkon > Subject: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with >

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Friday, 19 de April de 2019 17:08, Michael Niedermayer wrote: > On Fri, Apr 19, 2019 at 08:23:35AM +, Andreas Håkon via ffmpeg-devel > wrote: > > > From 936740731c17a9757aa093bdb35d9772df1e64a8 Mon Sep 17 00:00:00 2001 > > From: Andreas Hakon

Re: [FFmpeg-devel] [PATCH V2] lavf/oggparsevorbis: Fix change the case of metadata keys issue

2019-04-22 Thread myp...@gmail.com
On Wed, Apr 17, 2019 at 12:44 PM Jun Zhao wrote: > > From: Jun Zhao > > The spec in https://xiph.org/vorbis/doc/v-comment.html states that > the metadata keys are case-insensitive, so don't change the case > and update the fate test case. > > Fix #7784 > > Signed-off-by: Jun Zhao > --- >

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Monday, 22 de April de 2019 13:33, Li, Zhong wrote: > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Andreas Håkon via ffmpeg-devel > > Sent: Thursday, April 18, 2019 6:11 PM > > To: FFmpeg development discussions and patches >

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Monday, 22 de April de 2019 14:17, myp...@gmail.com wrote: > On Mon, Apr 22, 2019 at 7:38 PM Li, Zhong zhong...@intel.com wrote: > > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > > Of Andreas Håkon via ffmpeg-devel > > > Sent:

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread myp...@gmail.com
On Mon, Apr 22, 2019 at 8:42 PM Andreas Håkon wrote: > > > ‐‐‐ Original Message ‐‐‐ > On Monday, 22 de April de 2019 14:17, myp...@gmail.com > wrote: > > > On Mon, Apr 22, 2019 at 7:38 PM Li, Zhong zhong...@intel.com wrote: > > > > > > From: ffmpeg-devel

[FFmpeg-devel] [PATCHv2 3/5] avformat/mxfdec: guess wrapping of tracks by other tracks with the same body sid

2019-04-22 Thread Marton Balint
This affects the following samples: samples/ffmpeg-bugs/roundup/issue1775/av_seek_frame_failure.mxf samples/ffmpeg-bugs/trac/ticket1957/16ch.mxf samples/ffmpeg-bugs/trac/ticket5016/r0.mxf samples/ffmpeg-bugs/trac/ticket5016/r1.mxf samples/ffmpeg-bugs/trac/ticket5316/hq.MXF

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cbs_h2645: add macros to read and write fields with no custom range of values

2019-04-22 Thread James Almer
On 4/16/2019 11:56 PM, James Almer wrote: > Signed-off-by: James Almer > --- > Better macro names welcome. I used the same convention as in cbs_av1. > > fate-cbs passes, but i'm sure a bunch of these are not tested by it, > so help double checking i didn't screw up is welcome. > >

[FFmpeg-devel] [PATCH] cuviddec: improved way of finding out if a frame is interlaced or progressive

2019-04-22 Thread Sergey Svechnikov
There are 2 types of problems when using adaptive deinterlace with cuvid: 1. Sometimes, in the middle of transcoding, cuvid outputs frames with visible horizontal lines (as though weave deinterlace method was chosen); 2. Occasionally, on scene changes, cuvid outputs a wrong frame, which should

Re: [FFmpeg-devel] [PATCH V2] lavf/oggparsevorbis: Fix change the case of metadata keys issue

2019-04-22 Thread Derek Buitenhuis
On 22/04/2019 13:19, myp...@gmail.com wrote: > Ping? > LGTM. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-04-22 Thread Gyan
On 22-04-2019 04:30 PM, Gyan wrote: On 22-04-2019 01:15 PM, Gyan wrote: On 22-04-2019 12:30 PM, Carl Eugen Hoyos wrote: Am 20.04.2019 um 11:31 schrieb Gyan : Old patch that was never applied. Rebased. Please return patch_welcome for mlp and truehd. Will do. Wasn’t there another

[FFmpeg-devel] [PATCH] avcodec/zmbv: optimize motion compensation with memcpy()

2019-04-22 Thread Michael Niedermayer
Fixes: Timeout (16 sec - 7 sec) Fixes: 14237/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZMBV_fuzzer-5693453897302016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/zmbv.c | 8

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Add a blank like at the end to avoid rollup reading from outside

2019-04-22 Thread Michael Niedermayer
On Mon, Apr 22, 2019 at 09:49:41AM +0200, Alexander Strasser wrote: > Hi Michael! > > On 2019-04-20 18:11 +0200, Michael Niedermayer wrote: > > Fixes: index 20 out of bounds for type 'const char *[4][128]' > > Somehow I don't understand this diagnostic message. It says "index > 20 out of bounds