Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h265: add support for Alpha Channel Info SEI messages

2019-06-22 Thread James Almer
On 6/22/2019 3:32 AM, Andreas Rheinhardt wrote: > Hello, > > first a general note: hevc_parse_nal_header in h2645_parse.c > explicitly discards any NAL units with nuh_layer_id != 0. As long as > this is so adding support for this SEI is pointless. If you try this patch with the sample i linked,

[FFmpeg-devel] [PATCH 2/2] avcodec/vc1_block: Fix invalid shifts in vc1_decode_i_blocks()

2019-06-22 Thread Michael Niedermayer
Fixes: left shift of negative value -9 Fixes: 15299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5660922678345728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vc1_block: Fix invalid shifts in vc1_decode_i_blocks()

2019-06-22 Thread Paul B Mahol
On 6/22/19, Michael Niedermayer wrote: > Fixes: left shift of negative value -9 > Fixes: > 15299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5660922678345728 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH V1] lavf/flvenc: add automatic bitstream filtering

2019-06-22 Thread Steven Liu
> 在 2019年6月22日,17:04,Jun Zhao 写道: > > From: Jun Zhao > > add automatic bitstream filtering when mux AAC > > Signed-off-by: Jun Zhao > --- > libavformat/flvenc.c | 27 --- > 1 files changed, 24 insertions(+), 3 deletions(-) > > diff --git a/libavformat/flvenc.c

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: better checking var_stream_map content

2019-06-22 Thread Steven Liu
> 在 2019年6月20日,15:46,Bodecs Bela 写道: > > Dear All, > > When multiple variant streams are specified by var_stream_map option, > implementation assumes that each elementary stream is assigned only once > to any variant. But this is not checked currently. But 2nd and further > instances > of

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/flicvideo: Make line_packets int

2019-06-22 Thread Paul B Mahol
On 6/22/19, Michael Niedermayer wrote: > Fixes: signed integer overflow: -32768 * 196032 cannot be represented in > type 'int' > Fixes: > 15300/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5733319519502336 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH 1/2] avcodec/vc1_block: fix invalid shift in vc1_decode_p_mb()

2019-06-22 Thread Michael Niedermayer
Fixes: left shift of negative value -5 Fixes: 15294/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5733921754447872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c |

[FFmpeg-devel] [PATCH] avformat/hlsenc: better error log message for var_stream_map content

2019-06-22 Thread Bodecs Bela
Dear All, When multiple variant streams are specified by var_stream_map option, %v is expected either in the filename or in the last sub-directory name, but only in one of them. When both of them contain %v string, current error message only states half of the "truth". Additionally %v may

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h265: add support for Alpha Channel Info SEI messages

2019-06-22 Thread Andreas Rheinhardt
Hello, first a general note: hevc_parse_nal_header in h2645_parse.c explicitly discards any NAL units with nuh_layer_id != 0. As long as this is so adding support for this SEI is pointless. (Your comment on IRC was wrong: The Apple samples contain two SPS and PPS each.) James Almer: > As defined

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bink: Fix integer overflow in unquantize_dct_coeffs()

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 09:12:36AM +0200, Reimar Döffinger wrote: > > > On 18.06.2019, at 14:55, Michael Niedermayer wrote: > > > Fixes: signed integer overflow: -3447 * 2883584 cannot be represented in > > type 'int' > > Fixes: > >

Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 02:53:09PM +0200, Nicolas George wrote: > greg Luce (12019-06-21): > > I had them in a single patch before but split them as requested here > > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html > > Is there something I'm missing that allows me to split the

[FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check ham vs bpp

2019-06-22 Thread Michael Niedermayer
This checks the ham value much stricter and avoids hitting cases which cannot be reached with data from the libavformat demuxer. Fixes: out of array access Fixes: 15320/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5080476840099840 Fixes:

[FFmpeg-devel] [PATCH 3/3] avcodec/iff: finetune the palette size check in the mask case

2019-06-22 Thread Michael Niedermayer
Fixes: out of array access Fixes: 15381/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5668057826983936 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 1/3] avcodec/iff: Fix mask_buf / mask_palbuf leak

2019-06-22 Thread Michael Niedermayer
Fixes: 15372/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5708881759567872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [FFmpeg-devel] [PATCH 06/37] avformat/matroskadec: Use generic size check for signed integers

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > and drop the redundant checks contained in ebml_read_uint and > ebml_read_sint. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskadec.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 15/37] avformat/matroskadec: Don't keep old blocks

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > Before this commit, the Matroska muxer would read a block when required > to do so, parse the block, create and return the necessary AVPackets and > yet keep the blocks (in a dynamically allocated list), although they > aren't used at all any more.

Re: [FFmpeg-devel] [PATCH 08/37] avformat/matroskadec: Don't copy attached pictures

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > This commit replaces copying attached pictures by using references to > the already existing buffers. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskadec.c | 16 ++-- > 1 file changed, 10 insertions(+), 6

Re: [FFmpeg-devel] [PATCH 07/37] avformat/matroskadec: Set offset of first cluster

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > By default, the data_offset member of the AVFormatInternal of the > AVFormatContext associated with the MatroskaDemuxContext has not been > initialized explicitly by any Matroska-specific function, so that it was > initialized by default to the

Re: [FFmpeg-devel] [PATCH 05/37] avformat/matroskadec: Get rid of cluster size field assumption

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > The earlier code relied on the length of clusters always being coded on > eight bytes as was the behaviour of libavformat's Matroska muxer until > recently. But given that our own Matroska muxer now (and mkvmerge from > time immemorial) creates

Re: [FFmpeg-devel] FFmpeg 4.2

2019-06-22 Thread Gyan
On 21-05-2019 12:09 AM, Michael Niedermayer wrote: Hi Its quite some time since 4.1 so its probably getting time to branch 4.2. If there are any bugs you want fixed in 4.2 its probably a good idea to fix them soon. Are there any suggestions for a name ? If not ill pick something from unused

Re: [FFmpeg-devel] [PATCH 05/37] avformat/matroskadec: Get rid of cluster size field assumption

2019-06-22 Thread Andreas Rheinhardt
James Almer: > On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: >> The earlier code relied on the length of clusters always being coded on >> eight bytes as was the behaviour of libavformat's Matroska muxer until >> recently. But given that our own Matroska muxer now (and mkvmerge from >> time

Re: [FFmpeg-devel] [PATCH v6] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-22 Thread greg Luce
There's also a version as two separate patches submitted at http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245625.html if that's better etiquette. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-22 Thread greg Luce
> These were two different and independent patches written by two different > persons. I'm totally fine with them going in either way, but just to clarify the 0002 file was written as a companion to update the documentation to go along with 0001, it isn't meant to exist on its own. I can't speak

[FFmpeg-devel] [PATCH] movsub_bsf: Fix mov2textsub regression

2019-06-22 Thread Andreas Rheinhardt
The mov flavour of timed text uses the first two bytes of the packet as a length field. And up until 11bef2fe said length field has been read correctly in the mov2textsub bsf. But since then the next two bytes are read as if they were the length field. This is fixed in this commit. Signed-off-by:

Re: [FFmpeg-devel] [PATCH 14/37] avformat/matroskadec: Remove non-incremental parsing of clusters

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > When the new incremental parser was introduced, the old parser was > kept, because the new parser was unable to handle the way SSA packets > are put into Matroska. But since 2014 (since c7d8dbad) this is no > longer needed, so that the old parser

Re: [FFmpeg-devel] [PATCH 09/37] avformat/matroskadec: Remove redundant initialization

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > Every new element of an EbmlList is zeroed initially in > ebml_parse_elem, so that in particular a SimpleBlock's duration is > initialized to zero. Therefore it is unnecessary to initialize this > field again (for SimpleBlocks) in

Re: [FFmpeg-devel] [PATCH] add FF_DECODE_ERROR_DECODE_SLICES flag for AVFrame.decode_error_flags

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 07:15:55AM -0700, Amir Pauker wrote: > FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with > error(s) but the returned value from > avcodec_receive_frame is zero > > Signed-off-by: Amir Pauker > --- > doc/APIchanges | 3 +++ > libavutil/frame.h

Re: [FFmpeg-devel] [PATCH] libavformat/mux: Fix audio_preload

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 06:51:54PM +0200, Andreas Rheinhardt wrote: > Commit 31f9032b added the audio_preload feature; its goal is to > interleave audio earlier than the rest. Unfortunately, it has never ever > worked, because the check for whether a packet should be interleaved > before or after

Re: [FFmpeg-devel] [PATCH] add FF_DECODE_ERROR_DECODE_SLICES flag for AVFrame.decode_error_flags

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 07:15:55AM -0700, Amir Pauker wrote: > FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with > error(s) but the returned value from > avcodec_receive_frame is zero The first line of the commit message needs a "avutil:" prefix or similar also the first line

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 05:55:23AM +, Jacob Siddall wrote: > > doesnt apply with git > > > > > Applying: avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation > > Using index info to reconstruct a base tree... > > error: patch failed: libavformat/rtpdec_rfc4175.c:206 > > error:

[FFmpeg-devel] [PATCH V1] lavf/flvenc: add automatic bitstream filtering

2019-06-22 Thread Jun Zhao
From: Jun Zhao add automatic bitstream filtering when mux AAC Signed-off-by: Jun Zhao --- libavformat/flvenc.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index e4863f1..fb1dede 100644 ---