Re: [FFmpeg-devel] [PATCH] Fix segment muxer

2019-10-02 Thread just . one . man
Note that the second e-mail contains a more full version of patch which also updates times used to generate the playlist, so playlist is now also correct. --- Thanks, Vasily 02.10.2019, 14:22, "Vasily" : > When incoming media has non-zero start PTS, > segment muxer would fail to correctly

Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-02 Thread Raphaël Zumer
On Tue, 2019-10-01 at 15:57 -0400, Calvin Walton wrote: > On Tue, 2019-10-01 at 21:41 +0200, Carl Eugen Hoyos wrote: > > Am Di., 1. Okt. 2019 um 21:35 Uhr schrieb Raphaël Zumer < > > rzu...@tebako.net>: > > > On Tue, 2019-10-01 at 20:09 +0100, Derek Buitenhuis wrote: > > > > Why not just write

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/g2meet: Check for end of input in jpg_decode_block()

2019-10-02 Thread Michael Niedermayer
On Mon, Sep 30, 2019 at 08:07:30PM +0200, Tomas Härdin wrote: > lör 2019-09-28 klockan 17:47 +0200 skrev Michael Niedermayer: > > On Thu, Sep 12, 2019 at 11:09:16PM +0200, Tomas Härdin wrote: > > > tor 2019-09-12 klockan 00:21 +0200 skrev Michael Niedermayer: > > > > On Wed, Sep 11, 2019 at

Re: [FFmpeg-devel] [PATCH] avformat: Add max_probe_packets option

2019-10-02 Thread Andriy Gelman
On Fri, 27. Sep 16:26, Andriy Gelman wrote: > From: Andriy Gelman > > This allows the user to set a maximum number of buffered packets when > probing a codec. It was a hard-coded parameter before this commit. > --- > doc/formats.texi| 4 > libavformat/avformat.h | 7

Re: [FFmpeg-devel] [PATCH v5 1/3] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-10-02 Thread Andriy Gelman
On Thu, 26. Sep 14:09, Andriy Gelman wrote: > From: Andriy Gelman > > Fixes #7799 > > Currently, the mp4toannexb filter always inserts the same extradata at > the start of the first IRAP unit. As in ticket #7799, this can lead to > decoding errors if modified parameter sets are signalled

[FFmpeg-devel] [PATCH] avformat/ivfenc: Change the length fields to 32 bits

2019-10-02 Thread Raphaël Zumer
There is no change in the encoded bitstream, but this ensures that the written field length is consistent with the reference implementation. Unused bytes are zeroed out for backwards compatibility. Signed-off-by: Raphaël Zumer --- libavformat/ivfenc.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [FFmpeg-devel] [PATCH 1/3] avformat/aiffenc: Use standard packet list functions

2019-10-02 Thread Matthieu Bouron
On Wed, Oct 02, 2019 at 06:04:10AM +0200, Andreas Rheinhardt wrote: > Up until now, aiffenc didn't rely on the standard functions for adding > an element to a linked list and freeing the list, but instead > reimplemented them. This has been changed. > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH 2/3] avformat/aiffenc: Fix potential memleak upon failure

2019-10-02 Thread Matthieu Bouron
On Wed, Oct 02, 2019 at 06:04:11AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aiffenc.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c > index dd8b8c3d01..0b837cd264

Re: [FFmpeg-devel] [PATCH] Fix gas-preprocessor to translate .rdata sections for armasm and armasm64

2019-10-02 Thread Martin Storsjö
> On Oct 1, 2019, at 21:37, Lukas Fellechner wrote: > > Compiling FFmpeg with gas-preprocessor.pl and armasm or armasm64 fails since > FFmpeg 4.2. > > New .rdata sections have been added in ARM NEON assembly code (e.g. > libavutil/aarch64/asm.S). > This fix allows gas-preprocessor to

[FFmpeg-devel] [PATCH v2 02/14] avformat/udp: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/udp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index cf73d331e0..f4ec148a2f 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -274,7 +274,7 @@ static int

[FFmpeg-devel] [PATCH v2 13/14] avfilter/boxblur: add logging context to log

2019-10-02 Thread Steven Liu
Reviewed-by: Paul B Mahol Signed-off-by: Steven Liu --- libavfilter/boxblur.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/boxblur.c b/libavfilter/boxblur.c index 4534b456d9..2287396f2e 100644 --- a/libavfilter/boxblur.c +++ b/libavfilter/boxblur.c @@ -91,7

[FFmpeg-devel] [PATCH v2 11/14] avfilter/vf_crop: add logging context to log

2019-10-02 Thread Steven Liu
Reviewed-by: Paul B Mahol Signed-off-by: Steven Liu --- libavfilter/vf_crop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 9fca7a7309..d6b4feb513 100644 --- a/libavfilter/vf_crop.c +++ b/libavfilter/vf_crop.c @@ -244,7

[FFmpeg-devel] [PATCH v2 10/14] avcodec/pngdec: add logging context to log

2019-10-02 Thread Steven Liu
Reviewed-by: Paul B Mahol Signed-off-by: Steven Liu --- libavcodec/pngdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 2d6c1b218e..d37dabcc4d 100644 --- a/libavcodec/pngdec.c +++ b/libavcodec/pngdec.c @@ -424,7 +424,7 @@

[FFmpeg-devel] [PATCH v2 08/14] avcodec/mpegvideo_enc: add logging context to log

2019-10-02 Thread Steven Liu
Reviewed-by: Paul B Mahol Signed-off-by: Steven Liu --- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index ae3b131229..f12e603215 100644 --- a/libavcodec/mpegvideo_enc.c +++

Re: [FFmpeg-devel] [PATCH 3/3] avformat/aiffenc: Remove wrong and redundant check

2019-10-02 Thread Matthieu Bouron
On Wed, Oct 02, 2019 at 06:04:12AM +0200, Andreas Rheinhardt wrote: > The check "if (!pb->seekable & AVIO_SEEKABLE_NORMAL)" is wrong, because > ! has higher precendence than &. But it is also redundant, because this > part of the code is only ever reached when the AVIO_SEEKABLE_NORMAL flag > is

Re: [FFmpeg-devel] Various build errors with armasm64 and armasm after update to FFmpeg 4.2

2019-10-02 Thread Martin Storsjö
> On Oct 1, 2019, at 23:07, Lukas Fellechner wrote: > > This has worked very well for quite a long time. But after upgrading to > FFmpeg 4.2, the build fails. A lot of changes and additions have been done > for ARM/NEON 64-bit, and it looks like many of them are not compatible with >

[FFmpeg-devel] [PATCH v2 03/14] avformat/rtmpptoto: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/rtmpproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index b741e421af..eb08d4d424 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -2386,7 +2386,7 @@ static

[FFmpeg-devel] [PATCH v2 04/14] avformat/avidec: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/avidec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index e3cd844169..1ca26968fa 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -117,8 +117,8 @@ static

[FFmpeg-devel] [PATCH v2 07/14] avformat/mms: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/mms.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavformat/mms.c b/libavformat/mms.c index 768fda6525..16babc0954 100644 --- a/libavformat/mms.c +++ b/libavformat/mms.c @@ -60,7 +60,7 @@ int

[FFmpeg-devel] [PATCH v2 01/14] avformat/hlsenc: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 1f2bdfbe4d..ac46a82704 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1305,7 +1305,7 @@ static int

[FFmpeg-devel] [PATCH v2 12/14] avfilter/vf_scale_qsv: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavfilter/vf_scale_qsv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c index 3cc05b64f3..1cf5367969 100644 --- a/libavfilter/vf_scale_qsv.c +++ b/libavfilter/vf_scale_qsv.c @@ -541,7

[FFmpeg-devel] [PATCH v2 06/14] avformat/mmst: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/mmst.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/libavformat/mmst.c b/libavformat/mmst.c index a97c2e04a2..533cbe7698 100644 --- a/libavformat/mmst.c +++ b/libavformat/mmst.c @@ -141,7

[FFmpeg-devel] [PATCH v2 05/14] avformat/network: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/network.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/network.c b/libavformat/network.c index 5664455d18..0f5a575f77 100644 --- a/libavformat/network.c +++ b/libavformat/network.c @@ -238,7 +238,7 @@ int

[FFmpeg-devel] [PATCH v2 14/14] avfilter/vf_pad: add logging context to log

2019-10-02 Thread Steven Liu
Reviewed-by: Paul B Mahol Signed-off-by: Steven Liu --- libavfilter/vf_pad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_pad.c b/libavfilter/vf_pad.c index ed155578e1..186d3f028d 100644 --- a/libavfilter/vf_pad.c +++ b/libavfilter/vf_pad.c @@ -210,7 +210,7

[FFmpeg-devel] [PATCH v2 09/14] avcodec/videotoolbox: add logging context to log

2019-10-02 Thread Steven Liu
Signed-off-by: Steven Liu --- libavcodec/videotoolbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c index e9b3370169..8773de3393 100644 --- a/libavcodec/videotoolbox.c +++ b/libavcodec/videotoolbox.c @@ -617,7 +617,7

Re: [FFmpeg-devel] [PATCH] avfilter: add acomb filter

2019-10-02 Thread Paul B Mahol
On 10/2/19, Paul B Mahol wrote: > On 10/2/19, James Almer wrote: >> On 10/2/2019 12:11 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> doc/filters.texi | 28 ++ >>> libavfilter/Makefile | 1 + >>> libavfilter/af_acomb.c | 188

Re: [FFmpeg-devel] [PATCH] avfilter: add acomb filter

2019-10-02 Thread James Almer
On 10/2/2019 12:37 PM, Paul B Mahol wrote: > On 10/2/19, James Almer wrote: >> On 10/2/2019 12:11 PM, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> doc/filters.texi | 28 ++ >>> libavfilter/Makefile | 1 + >>> libavfilter/af_acomb.c | 188

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself to setpts

2019-10-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7f60ef0021..b0fa38ae99 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -365,6 +365,7 @@ Filters: vf_tonemap_opencl.c Ruiling Song vf_yadif.c

[FFmpeg-devel] libavfilter new filter proposal

2019-10-02 Thread Alexandre Buisson
Hi, I developed a simple filter to process all the video frame using any other external process while keeping the simplicity of the ffmpeg command line to transcode and keep all the properties of the original file (audio, subtitle, close caption, etc...) I would check if that filter respect the

[FFmpeg-devel] [PATCH] avfilter: add acomb filter

2019-10-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 28 ++ libavfilter/Makefile | 1 + libavfilter/af_acomb.c | 188 +++ libavfilter/allfilters.c | 1 + 4 files changed, 218 insertions(+) create mode 100644 libavfilter/af_acomb.c diff

Re: [FFmpeg-devel] [PATCH] avfilter: add acomb filter

2019-10-02 Thread Paul B Mahol
On 10/2/19, James Almer wrote: > On 10/2/2019 12:11 PM, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 28 ++ >> libavfilter/Makefile | 1 + >> libavfilter/af_acomb.c | 188 +++ >> libavfilter/allfilters.c

Re: [FFmpeg-devel] [PATCH] avfilter: add acomb filter

2019-10-02 Thread Paul B Mahol
On 10/2/19, James Almer wrote: > On 10/2/2019 12:37 PM, Paul B Mahol wrote: >> On 10/2/19, James Almer wrote: >>> On 10/2/2019 12:11 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- doc/filters.texi | 28 ++ libavfilter/Makefile | 1 +

Re: [FFmpeg-devel] libavfilter new filter proposal

2019-10-02 Thread James Almer
On 10/2/2019 11:54 AM, Alexandre Buisson wrote: > Hi, > I developed a simple filter to process all the video frame using any other > external process while keeping the simplicity of the ffmpeg command line to > transcode and keep all the properties of the original file (audio, > subtitle, close

Re: [FFmpeg-devel] [PATCH] avfilter: add acomb filter

2019-10-02 Thread James Almer
On 10/2/2019 12:11 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 28 ++ > libavfilter/Makefile | 1 + > libavfilter/af_acomb.c | 188 +++ > libavfilter/allfilters.c | 1 + > 4 files changed, 218

Re: [FFmpeg-devel] libavfilter new filter proposal

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 16:54 Uhr schrieb Alexandre Buisson : > I developed a simple filter to process all the video frame using > any other external process while keeping the simplicity of the > ffmpeg command line to transcode and keep all the properties > of the original file (audio, subtitle,

[FFmpeg-devel] [PATCH] avformat/amr: reduce raw amr false positive detection

2019-10-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/amr.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/libavformat/amr.c b/libavformat/amr.c index 42840a50a3..600cb1b0f0 100644 --- a/libavformat/amr.c +++ b/libavformat/amr.c @@ -190,9 +190,12 @@ static int

Re: [FFmpeg-devel] [PATCH] avfilter/setpts: switch to activate

2019-10-02 Thread Nicolas George
Paul B Mahol (12019-09-30): > Also properly handle EOF timestamps. > Fixes #6833. > > Signed-off-by: Paul B Mahol > --- > libavfilter/setpts.c | 74 > 1 file changed, 55 insertions(+), 19 deletions(-) > > diff --git a/libavfilter/setpts.c

Re: [FFmpeg-devel] [PATCH v2 0/2] AltiVec/VSX fixes in swscale

2019-10-02 Thread Daniel Kolesa
On Tue, Oct 1, 2019, at 17:26, Lauri Kasanen wrote: > Hi, > > I'll apply these in a couple days if no objections. Works ok in my > tests. Cool. Lemme know in case anything needs to get fixed. > > - Lauri > ___ > ffmpeg-devel mailing list >

Re: [FFmpeg-devel] [PATCH] avformat/amr: reduce raw amr false positive detection

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 20:19 Uhr schrieb Paul B Mahol : > > Signed-off-by: Paul B Mahol > --- > libavformat/amr.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/libavformat/amr.c b/libavformat/amr.c > index 42840a50a3..600cb1b0f0 100644 > ---

[FFmpeg-devel] [PATCH] avfilter: add arnndn filter

2019-10-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 11 + libavfilter/Makefile |1 + libavfilter/af_arnndn.c | 1543 ++ libavfilter/allfilters.c |1 + 4 files changed, 1556 insertions(+) create mode 100644 libavfilter/af_arnndn.c diff

Re: [FFmpeg-devel] [PATCH] avformat/amr: reduce raw amr false positive detection

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 22:18 Uhr schrieb Carl Eugen Hoyos : > > Am Mi., 2. Okt. 2019 um 20:19 Uhr schrieb Paul B Mahol : > > > > Signed-off-by: Paul B Mahol > > --- > > libavformat/amr.c | 18 -- > > 1 file changed, 12 insertions(+), 6 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avformat/amr: reduce raw amr false positive detection

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 22:27 Uhr schrieb Carl Eugen Hoyos : > Another idea is to require different modes This would work for amr-wb but not amr-nb: Silence encoded with libopencore_amrnb looks similar to the provided sample that decodes to noise. Carl Eugen

[FFmpeg-devel] [PATCH 1/5] avcodec/wmaprodec: Check if there is a stream

2019-10-02 Thread Michael Niedermayer
Fixes: null pointer dereference Fixes: signed integer overflow: 512 * 2147483647 cannot be represented in type 'int' Fixes: 17809/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA1_fuzzer-5634409947987968 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: split empty text sample when duration overflow

2019-10-02 Thread Jun Li
On Tue, Oct 1, 2019 at 5:20 PM Jun Li wrote: > > > On Tue, Oct 1, 2019 at 4:19 AM Carl Eugen Hoyos > wrote: > >> Am Di., 10. Sept. 2019 um 21:12 Uhr schrieb Jun Li : >> > >> > Fix #7637 >> > One empty/end sample is created and inserted between two caption lines >> when there is a gap. >> > This

[FFmpeg-devel] [PATCH 4/5] avcodec/tiff: Set FF_CODEC_CAP_INIT_CLEANUP

2019-10-02 Thread Michael Niedermayer
Fixes: memleaks Fixes: 17813/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-5145600206569472 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 3 +-- 1 file changed, 1

[FFmpeg-devel] [PATCH 2/5] avcodec/vc1_block: Fix invalid left shift in vc1_decode_p_mb()

2019-10-02 Thread Michael Niedermayer
Fixes: left shift of negative value -6 Fixes: 17810/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5638541240958976 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c |

[FFmpeg-devel] [PATCH 3/5] avcodec/dstdec: Check for input exhaustion

2019-10-02 Thread Michael Niedermayer
Fixes: Timeout (239sec -> 16sec) Fixes: 17811/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5715508149616640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dstdec.c | 7

[FFmpeg-devel] [PATCH 5/5] avcodec/ptx: Check that the input contains at least one line

2019-10-02 Thread Michael Niedermayer
Fixes: Timeout (19sec -> 44ms) Fixes: 17816/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PTX_fuzzer-5704459950227456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ptx.c | 3 +++ 1 file

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: split empty text sample when duration overflow

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 02:21 Uhr schrieb Jun Li : > > On Tue, Oct 1, 2019 at 4:19 AM Carl Eugen Hoyos wrote: > > > Am Di., 10. Sept. 2019 um 21:12 Uhr schrieb Jun Li : > > > > > > Fix #7637 > > > One empty/end sample is created and inserted between two caption lines > > when there is a gap. > >

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: split empty text sample when duration overflow

2019-10-02 Thread Jun Li
On Wed, Oct 2, 2019 at 3:22 PM Carl Eugen Hoyos wrote: > Am Mi., 2. Okt. 2019 um 02:21 Uhr schrieb Jun Li : > > > > On Tue, Oct 1, 2019 at 4:19 AM Carl Eugen Hoyos > wrote: > > > > > Am Di., 10. Sept. 2019 um 21:12 Uhr schrieb Jun Li < > junli1...@gmail.com>: > > > > > > > > Fix #7637 > > > >

[FFmpeg-devel] [PATCH 12/18] cbs: Expose the function to insert a new empty unit into a fragment

2019-10-02 Thread Mark Thompson
This will be helpful when adding new SEI to an existing access unit. --- libavcodec/cbs.c | 10 +- libavcodec/cbs.h | 7 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index f689221945..c9098b09b5 100644 --- a/libavcodec/cbs.c

[FFmpeg-devel] [PATCH v3 07/18] cbs_h2645: Ensure that non-refcounted parameter sets are fully copied

2019-10-02 Thread Mark Thompson
Only copying the main structure is not necessarily sufficient - there could be references to substructures. --- libavcodec/cbs_h2645.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 6c4315e152..4aba615bef 100644

[FFmpeg-devel] [PATCH 17/18] cbs_h265: Add functions to turn HDR metadata into SEI

2019-10-02 Thread Mark Thompson
--- With intent to add some sort of support for this in H.265 metadata, though it's not in this set. Is there any thought on what a human-usable text serialisation of AVMasteringDisplayMetadata should look like? Ideally it wants to be something which would require no escaping when using it on

[FFmpeg-devel] [PATCH 18/18] vaapi_encode_h265: Use common handling for HDR metadata

2019-10-02 Thread Mark Thompson
--- libavcodec/vaapi_encode_h265.c | 45 +- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index 538862a9d5..443139dfdb 100644 --- a/libavcodec/vaapi_encode_h265.c +++

[FFmpeg-devel] [PATCH v3 10/18] cbs_vp9: Use table-based alloc/free

2019-10-02 Thread Mark Thompson
--- libavcodec/cbs_vp9.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/libavcodec/cbs_vp9.c b/libavcodec/cbs_vp9.c index bd172100fc..df480f42e5 100644 --- a/libavcodec/cbs_vp9.c +++ b/libavcodec/cbs_vp9.c @@ -474,13 +474,6 @@ static int

[FFmpeg-devel] [PATCH v3 03/18] cbs: Describe allocate/free methods in tabular form

2019-10-02 Thread Mark Thompson
Unit types are split into three categories, depending on how their content is managed: * POD structure - these require no special treatment. * Structure containing references to refcounted buffers - these can use a common free function when the offsets of all the internal references are known.

[FFmpeg-devel] [PATCH v3 04/18] cbs: Add macros to support defining unit type tables

2019-10-02 Thread Mark Thompson
--- libavcodec/cbs_internal.h | 24 1 file changed, 24 insertions(+) diff --git a/libavcodec/cbs_internal.h b/libavcodec/cbs_internal.h index 7ed8ea0049..2b83c03408 100644 --- a/libavcodec/cbs_internal.h +++ b/libavcodec/cbs_internal.h @@ -146,6 +146,30 @@ int

[FFmpeg-devel] [PATCH v3 05/18] cbs_h264: Use table-based alloc/free

2019-10-02 Thread Mark Thompson
--- libavcodec/cbs_h2645.c | 163 ++--- 1 file changed, 70 insertions(+), 93 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 5dd371153a..6c4315e152 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -443,52

[FFmpeg-devel] [PATCH v3 11/18] cbs_av1: Use table-based alloc/free

2019-10-02 Thread Mark Thompson
--- libavcodec/cbs_av1.c | 85 1 file changed, 39 insertions(+), 46 deletions(-) diff --git a/libavcodec/cbs_av1.c b/libavcodec/cbs_av1.c index c027933218..67caaf3eea 100644 --- a/libavcodec/cbs_av1.c +++ b/libavcodec/cbs_av1.c @@ -810,50 +810,6 @@

[FFmpeg-devel] [PATCH v3 01/18] cbs: Mention all codecs in unit type comment

2019-10-02 Thread Mark Thompson
--- Now in alphabetical order. libavcodec/cbs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h index 7c341bffe7..be986df4e4 100644 --- a/libavcodec/cbs.h +++ b/libavcodec/cbs.h @@ -45,8 +45,10 @@ struct CodedBitstreamType; /** * The codec-specific

[FFmpeg-devel] [PATCH 14/18] cbs_h264: Add support for frame packing arrangement SEI messages

2019-10-02 Thread Mark Thompson
--- libavcodec/cbs_h264.h | 24 libavcodec/cbs_h2645.c| 1 + libavcodec/cbs_h264_syntax_template.c | 40 +++ 3 files changed, 65 insertions(+) diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h index

[FFmpeg-devel] [PATCH v3 02/18] cbs: Ensure that reference fields always follow the associated pointer

2019-10-02 Thread Mark Thompson
Hvaing these together allows us to find both pointers given the address of only one of them. --- libavcodec/cbs_av1.h | 6 +++--- libavcodec/cbs_h264.h | 18 +- libavcodec/cbs_h265.h | 16 libavcodec/cbs_jpeg.h | 2 +- libavcodec/cbs_mpeg2.h | 10 +-

[FFmpeg-devel] [PATCH 13/18] cbs_h264: Simplify SEI addition

2019-10-02 Thread Mark Thompson
At the same time, move the H.264 SEI functions to a new file - the combined H.26[45] CBS file is already very large, and these functions do not require any of the common read/write elements. --- libavcodec/Makefile| 2 +- libavcodec/cbs_h264.c | 106

[FFmpeg-devel] [PATCH 15/18] cbs_h264: Add a function to turn stereo 3D metadata into SEI

2019-10-02 Thread Mark Thompson
--- libavcodec/cbs_h264.c | 47 +++ libavcodec/cbs_h264.h | 8 2 files changed, 55 insertions(+) diff --git a/libavcodec/cbs_h264.c b/libavcodec/cbs_h264.c index 75759c7f25..cc52f68550 100644 --- a/libavcodec/cbs_h264.c +++

[FFmpeg-devel] [PATCH v3 09/18] cbs_h265: Use table-based alloc/free

2019-10-02 Thread Mark Thompson
--- libavcodec/cbs_h2645.c | 198 +++-- 1 file changed, 94 insertions(+), 104 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 4aba615bef..9f7d910711 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -443,71

[FFmpeg-devel] [PATCH 16/18] vaapi_encode_h264: Support stereo 3D metadata

2019-10-02 Thread Mark Thompson
Insert frame packing arrangement messages into the stream when input frames have associated stereo 3D side-data. --- This was requested recently on ffmpeg-user - . Easy to add, so here you go. Output matches that produced by

[FFmpeg-devel] [PATCH v3 08/18] h264_redundant_pps: Make it reference-compatible

2019-10-02 Thread Mark Thompson
From: Andreas Rheinhardt Since c6a63e11092c975b89d824f08682fe31948d3686, the parameter sets modified as content of PPS units were references shared with the CodedBitstreamH264Context, so modifying them alters the parsing process of future access units which meant that frames often got discarded

[FFmpeg-devel] [PATCH v3 06/18] cbs: Add support functions for handling unit content references

2019-10-02 Thread Mark Thompson
Use the unit type table to determine what we need to do to clone the internals of the unit content when making copies for refcounting or writeability. (This will still fail for units with complex content if they do not have a defined clone function.) Setup and naming from a patch by Andreas

Re: [FFmpeg-devel] [PATCH 17/18] cbs_h265: Add functions to turn HDR metadata into SEI

2019-10-02 Thread Mark Thompson
On 03/10/2019 00:04, Mark Thompson wrote: > --- > With intent to add some sort of support for this in H.265 metadata, though > it's not in this set. > > Is there any thought on what a human-usable text serialisation of > AVMasteringDisplayMetadata should look like? Ideally it wants to be >

[FFmpeg-devel] avcodec_send_packet: send 0 size packet to libopus for loss concealment

2019-10-02 Thread Anthony Alba
Hi devs, I am converting a PCAP RTP file using the libopus decoder and there may be missing packets. This is not a real-time application. I am implementing my own reordering/missing packet buffer so if the buffer declares a packet "lost" I want to inform the libopus. Two questions: 1. What is

[FFmpeg-devel] [PATCH V1 2/2] lavfi/hqdn3d: add slice thread optionmation

2019-10-02 Thread Jun Zhao
From: Jun Zhao Enabled one thread per planar, used the test command for 1080P video (YUV420P format) as follow: ffmpeg -i 1080p.mp4 -an -vf hqdn3d -f null /dev/nul This optimization improved the performance about 30% in 1080P YUV420P case (from 110fps to 143fps), also pass the framemd5 check

[FFmpeg-devel] [PATCH V1 1/2] avutil/common: Fix underflow for ROUNDED_DIV with unsigned integer

2019-10-02 Thread Jun Zhao
From: Mengye Lv When used ROUNDED_DIV(a,b), if a is unsigned integer zero, it's will lead to an underflow issue(it called unsigned integer wrapping). Fixes #8062 Signed-off-by: Mengye Lv Signed-off-by: Jun Zhao --- libavutil/common.h |2 +- 1 files changed, 1 insertions(+), 1