Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: fix the av_dirname path isn't include separator in the end of string

On Wed, Oct 09, 2019 at 10:32:40AM +0800, Steven Liu wrote: > > > > 在 2019年10月9日，09:37，lance.lmw...@gmail.com 写道： > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/hlsenc.c | 16 ++-- > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > >

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_freezedetect: add metadata lavfi.freezedetect.mafd

On Wed, 23 Oct 2019, Limin Wang wrote: ping, it's another approach to discard frozen frame, please comments. On Thu, Oct 10, 2019 at 11:48:40AM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang As suggested by Paul to support frozen frames discard, please refer to:

Re: [FFmpeg-devel] [PATCH] Support for zulu timezone format for PDT in HLS playlists

On Wed, 23 Oct 2019, Ole Andre Birkedal wrote: Thanks for the feedback, attached new complete patch with code changes + added documentation for it Please also explain why this might be required in the docs. In the commit message please name the specific vendor/device which is not parsing

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/tests: add h265_levels to .gitignore

On 10/15/2019 1:21 PM, Zhao Zhili wrote: > --- > libavcodec/tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/tests/.gitignore b/libavcodec/tests/.gitignore > index 56ddb2cbeb..a01a700e2d 100644 > --- a/libavcodec/tests/.gitignore > +++

Re: [FFmpeg-devel] [PATCH 2/2] FATE/dnn: add .gitignore

On 10/15/2019 10:08 PM, Guo, Yejun wrote: > > >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Zhao Zhili >> Sent: Wednesday, October 16, 2019 12:21 AM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Zhao Zhili >> Subject: [FFmpeg-devel] [PATCH

[FFmpeg-devel] [PATCH 4/6] avformat/flvenc: Add deinit function

Fixes memleaks when the trailer is never written or when shift_data() fails when writing the trailer. Signed-off-by: Andreas Rheinhardt --- libavformat/flvenc.c | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/libavformat/flvenc.c

[FFmpeg-devel] [PATCH v1 2/3] Revert "lavfi/colorlevels: Add slice threading support"

From: Limin Wang This reverts commit 360bee8ca49d94d5cc8b77106887d6d7250440fe An alternative approach will be used to make the code easy to maintain Signed-off-by: Limin Wang --- libavfilter/vf_colorlevels.c | 110 ++- 1 file changed, 19 insertions(+), 91

Re: [FFmpeg-devel] [PATCH] Support for zulu timezone format for PDT in HLS playlists

Thanks for the feedback, attached new complete patch with code changes + added documentation for it Ole ‐‐‐ Original Message ‐‐‐ On Wednesday, October 23, 2019 4:32 AM, Steven Liu wrote: > > > > 在 2019年10月22日，18:37，Ole Andre Birkedal birke...@extab.net 写道： > > Some HLS players prefer

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bilateral: process command to set the parameter at runtime

On Wed, Oct 23, 2019 at 8:34 PM leozhang wrote: > > --- > libavfilter/vf_bilateral.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/libavfilter/vf_bilateral.c b/libavfilter/vf_bilateral.c > index 3c9d800..a06f434 100644 > ---

Re: [FFmpeg-devel] [PATCH] Support for zulu timezone format for PDT in HLS playlists

On Wed, 23 Oct 2019, Marton Balint wrote: On Wed, 23 Oct 2019, Ole Andre Birkedal wrote: Thanks for the feedback, attached new complete patch with code changes + added documentation for it Please also explain why this might be required in the docs. In the commit message please name the

[FFmpeg-devel] [PATCH 1/6] avformat/aiffenc: Add deinit function

Prevents memleaks if the trailer is never written. Signed-off-by: Andreas Rheinhardt --- libavformat/aiffenc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c index d09c9afb95..4f24c2a28c 100644 ---

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_freezedetect: add metadata lavfi.freezedetect.mafd

lgtm On 10/10/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > As suggested by Paul to support frozen frames discard, please refer to: > https://patchwork.ffmpeg.org/patch/15423/ > > You can tested with below commands: > > ./ffmpeg -f lavfi -i >

[FFmpeg-devel] [PATCH 6/6] avformat/icoenc: Add deinit function

Prevents memleaks in situations where the trailer isn't written, e.g. because of errors during writing the header. Signed-off-by: Andreas Rheinhardt --- libavformat/icoenc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/icoenc.c

[FFmpeg-devel] [PATCH 3/6] avformat/apngenc: Add deinit function

Prevents memleaks when the trailer is never written (e.g. when there was a write error when writing the header). Signed-off-by: Andreas Rheinhardt --- libavformat/apngenc.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/apngenc.c

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_freezedetect: add metadata lavfi.freezedetect.mafd

ping, it's another approach to discard frozen frame, please comments. On Thu, Oct 10, 2019 at 11:48:40AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > As suggested by Paul to support frozen frames discard, please refer to: > https://patchwork.ffmpeg.org/patch/15423/ > > You

[FFmpeg-devel] [PATCH v1 3/3] avfilter/colorlevels: add slice threading support with less code

From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_colorlevels.c | 176 +++ 1 file changed, 77 insertions(+), 99 deletions(-) diff --git a/libavfilter/vf_colorlevels.c b/libavfilter/vf_colorlevels.c index 5385a5e754..f8645a08bd 100644 ---

[FFmpeg-devel] [PATCH v1 1/3] tests/fate/filter-video: add test for colorlevels

From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 6 +++ tests/ref/fate/filter-colorlevels| 55 tests/ref/fate/filter-colorlevels-16 | 55 3 files changed, 116 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] avfilter/settb: switch to activate

Paul B Mahol (12019-10-19): > Now correctly updates EOF timestamp. > > Signed-off-by: Paul B Mahol > --- > libavfilter/settb.c | 51 ++--- > 1 file changed, 44 insertions(+), 7 deletions(-) LGTM. It was actually much less complex to review than I thought

Re: [FFmpeg-devel] [PATCH v4 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

On Sat, Oct 12, 2019 at 11:41:53PM +0200, Michael Niedermayer wrote: > On Sat, Oct 12, 2019 at 09:39:14AM +0800, Limin Wang wrote: > > On Fri, Oct 11, 2019 at 08:13:02PM +0200, Michael Niedermayer wrote: > > > On Thu, Oct 10, 2019 at 10:11:10PM +0800, Limin Wang wrote: > > > > On Thu, Oct 10, 2019

[FFmpeg-devel] [PATCH 5/6] avformat/hdsenc: Add explicit deinit function

hdsenc already had an explicit function to free all allocations in case of an error, but it was not marked as deinit function, so that it was not called automatically when the AVFormatContext for muxing gets freed. Using an explicit deinit function also makes the code cleaner by allowing to

[FFmpeg-devel] [PATCH 2/6] avformat/aiffenc: Use better error codes

Signed-off-by: Andreas Rheinhardt --- libavformat/aiffenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c index 4f24c2a28c..acf7b62862 100644 --- a/libavformat/aiffenc.c +++ b/libavformat/aiffenc.c @@ -123,7 +123,7 @@

Re: [FFmpeg-devel] [PATCH] avfilter/vf_maskedclamp: add x86 SIMD

Will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v5] avfilter/vaapi: add overlay_vaapi filter

> -Original Message- > From: ffmpeg-devel On Behalf Of Eoff, > Ullysses A > Sent: Tuesday, October 22, 2019 9:00 PM > To: FFmpeg development discussions and patches > Cc: Zhou, Zachary > Subject: Re: [FFmpeg-devel] [PATCH v5] avfilter/vaapi: add overlay_vaapi > filter > > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bilateral: process command to set the parameter at runtime

Not ok, range sigma is used to change array values you never update here. On 10/23/19, leozhang wrote: > --- > libavfilter/vf_bilateral.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/libavfilter/vf_bilateral.c b/libavfilter/vf_bilateral.c >

[FFmpeg-devel] [PATCH v3 3/3] avutil/avstring: replace with system interface if dirname and basename functions are detected

From: Limin Wang Signed-off-by: Limin Wang --- configure| 4 libavutil/avstring.c | 13 - 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8413826..5296a4c 100755 --- a/configure +++ b/configure @@ -2188,6 +2188,8 @@

[FFmpeg-devel] [PATCH v3 2/3] avformat/hlsenc: free the original malloc pointer to avoid error when system function used in the following patch

From: Limin Wang Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index af4b532..7aefa28 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@

[FFmpeg-devel] [PATCH v3 1/3] avformat/hlsenc: fix the av_dirname path isn't include separator in the end of string

From: Limin Wang Reviewed-by: Liu Steven Signed-off-by: Limin Wang --- libavformat/hlsenc.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 7b1d54e..af4b532 100644 --- a/libavformat/hlsenc.c +++

Re: [FFmpeg-devel] [PATCH v3 3/3] avutil/avstring: replace with system interface if dirname and basename functions are detected

Why? On 10/23/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > configure| 4 > libavutil/avstring.c | 13 - > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_freezedetect: add metadata lavfi.freezedetect.mafd

On Wed, Oct 23, 2019 at 02:32:54PM +0200, Marton Balint wrote: > > > On Wed, 23 Oct 2019, Limin Wang wrote: > > > > > > >ping, it's another approach to discard frozen frame, please comments. > > > > > >On Thu, Oct 10, 2019 at 11:48:40AM +0800, lance.lmw...@gmail.com wrote: > >>From: Limin Wang

[FFmpeg-devel] [PATCH] ffmpeg: Properly handle EOF return when flushing encoder

From: Andriy Gelman When flushing an encoder we send a NULL frame to avcodec_send_frame() and then deque all compressed packets in avcodec_recieve_packet() until AVERROR(EAGAIN) is returned (indicating that all compressed packets have been removed). The second time that avcodec_send_frame() is

Re: [FFmpeg-devel] [PATCH] ffmpeg: Properly handle EOF return when flushing encoder

On 10/23/2019 9:11 AM, Andriy Gelman wrote: > From: Andriy Gelman > > When flushing an encoder we send a NULL frame to avcodec_send_frame() > and then deque all compressed packets in avcodec_recieve_packet() until > AVERROR(EAGAIN) is returned (indicating that all compressed packets have > been

[FFmpeg-devel] [PATCH 1/4] avcodec/atrac3plus: Check split point in fill mode 3

Fixes: index 32 out of bounds for type 'int [32]' Fixes: 18350/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC3P_fuzzer-5643794862571520 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 4/4] avcodec/cook: Enlarge gain table

Fixes: index 25 out of bounds for type 'float [23]' Fixes: 18355/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5641398941908992 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 3/4] avcodec/cook: Check samples_per_channel earlier

Fixes: division by zero Fixes: 18362/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5653727679086592 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cook.c | 17

[FFmpeg-devel] [PATCH 2/4] avcodec/vp5: Check render_x/y

Fixes: Timeout (15sec -> 91ms) Fixes: 18353/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP5_fuzzer-5704150326706176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp5.c | 9 +++--

Re: [FFmpeg-devel] [PATCH] mpegvideo_enc: add option to disable intra mbs in p frames

On Sun, Jun 17, 2018 at 6:23 AM Ramiro Polla wrote: > On Sun, Jun 10, 2018 at 2:32 AM, Michael Niedermayer > wrote: > > On Sat, Jun 09, 2018 at 05:09:13PM +0200, Ramiro Polla wrote: > >> On Thu, May 10, 2018 at 11:01 PM, Michael Niedermayer > >> wrote: > >> > On Wed, May 09, 2018 at 08:44:25PM

[FFmpeg-devel] [PATCH] avfilter: add crossfade filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 18 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_blend.c | 157 ++- 4 files changed, 175 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi

[FFmpeg-devel] ffmpeg-qsv: Is opaque memory allocation path used in ffmpeg-qsv?

Hi, I was looking into the ffmpeg qsv (mediasdk hw acceleration) path implementation and wonder whether opaque memory allocation path is actually used and exercised? I failed to come across any code in ffmpeg sources which use it. Do I miss something? Are there any other usages possible? For

Re: [FFmpeg-devel] [PATCH v1 2/3] Revert "lavfi/colorlevels: Add slice threading support"

The revert is for better code review, if it's ok, please merge the patch into one. I am not sure if it is worth saving 100 lines of code. vf_colorlevels.c | 246 --- 1 file changed, 76 insertions(+), 170 deletions(-) On Wed, Oct 23, 2019 at

[FFmpeg-devel] [PATCH v1] avformat/mpeg: fix CID 1455132: Memory - illegal accesses (UNINIT)

From: Limin Wang Before header_str is initialized, the code is possible to goto end and free the header_str and cause invalid access. Signed-off-by: Limin Wang --- libavformat/mpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c

Re: [FFmpeg-devel] [PATCH v3 1/3] avformat/hlsenc: fix the av_dirname path isn't include separator in the end of string

It's rebased against git master, the old patch has conflict for other developer push. On Wed, Oct 23, 2019 at 11:55:15PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Reviewed-by: Liu Steven > Signed-off-by: Limin Wang > --- > libavformat/hlsenc.c | 16 ++-- > 1

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bilateral: process command to set the parameter at runtime

myp...@gmail.com 于2019年10月23日周三 下午8:50写道： > > On Wed, Oct 23, 2019 at 8:34 PM leozhang wrote: > > > > --- > > libavfilter/vf_bilateral.c | 21 +++-- > > 1 file changed, 11 insertions(+), 10 deletions(-) > > > > diff --git a/libavfilter/vf_bilateral.c b/libavfilter/vf_bilateral.c

Re: [FFmpeg-devel] [PATCH v2] avformat/wavdec.c: copy id3 metadata to format metadata and stream side data

On Sun, Oct 20, 2019 at 4:14 PM Jun Li wrote: > Enhancement #7803 > Copy id3 metadata to format meta data and stream side data. > > Signed-off-by: Jun Li > --- > libavformat/Makefile | 4 ++-- > libavformat/wavdec.c | 10 ++ > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff

[FFmpeg-devel] [PATCH 3/3] avcodec/iff: Check available space before entering loop in decode_long_vertical_delta2() / decode_long_vertical_delta()

Fixes: Timeout (31sec -> 41ms) Fixes: 18380/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5645210121404416 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 6 ++

[FFmpeg-devel] [PATCH 1/3] avcodec/xsubdec: fix overflow in alpha handling

Fixes: left shift of 255 by 24 places cannot be represented in type 'int' Fixes: 18368/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XSUB_fuzzer-5702665442426880 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 2/3] avcodec/wmavoice: Check sample_rate

Fixes: left shift of 538976288 by 8 places cannot be represented in type 'int' Fixes: 18376/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAVOICE_fuzzer-5741645391200256 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avfilter/vf_bilateral: process command to set the parameter at runtime

Paul B Mahol 于2019年10月23日周三 下午9:47写道： > > Not ok, range sigma is used to change array values you never update here. Right, I will submit a new version which try to call config_props() when the user set range sigma at runtime. Thanks a lot. > > On 10/23/19, leozhang wrote: > > --- > >

Re: [FFmpeg-devel] [PATCH v1] avformat/mpeg: fix CID 1455132: Memory - illegal accesses (UNINIT)

On Thu, Oct 24, 2019 at 3:36 AM wrote: > From: Limin Wang > > Before header_str is initialized, the code is possible to goto end and > free the > header_str and cause invalid access. > > Signed-off-by: Limin Wang > --- > libavformat/mpeg.c | 2 +- > 1 file changed, 1 insertion(+), 1

[FFmpeg-devel] [PATCH] avfilter/vf_maskedclamp: add x86 SIMD

Signed-off-by: Paul B Mahol --- libavfilter/maskedclamp.h | 35 ++ libavfilter/vf_maskedclamp.c | 18 +++-- libavfilter/x86/Makefile | 2 + libavfilter/x86/vf_maskedclamp.asm| 95 +++ libavfilter/x86/vf_maskedclamp_init.c |

[FFmpeg-devel] [PATCH V1] lavfi/bilateral: Clean the option description and unused code

From: Jun Zhao Clean the option description and unused code. Signed-off-by: Jun Zhao --- libavfilter/vf_bilateral.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/libavfilter/vf_bilateral.c b/libavfilter/vf_bilateral.c index 31578a0..3c9d800 100644 ---

Re: [FFmpeg-devel] [PATCH V1] lavfi/bilateral: Clean the option description and unused code

lgtm On 10/23/19, Jun Zhao wrote: > From: Jun Zhao > > Clean the option description and unused code. > > Signed-off-by: Jun Zhao > --- > libavfilter/vf_bilateral.c |7 +-- > 1 files changed, 1 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_bilateral.c

Re: [FFmpeg-devel] [PATCH v4 2/2] avfilter: Add tonemap vaapi filter

Am 23.10.2019 um 06:48 schrieb Xiang, Haihao : >>> On 11/09/2019 06:39, Zachary Zhou wrote: >>> It supports ICL platform. >>> H2H (HDR to HDR): P010 -> A2R10G10B10 >>> H2S (HDR to SDR): P010 -> ARGB >> >> The input format doesn't have any alpha so the output shouldn't either. Not >> sure what

Re: [FFmpeg-devel] [PATCH V1] lavfi/bilateral: Clean the option description and unused code

On Wed, Oct 23, 2019 at 3:16 PM Paul B Mahol wrote: > > lgtm Thanks the quick review, will apply > > On 10/23/19, Jun Zhao wrote: > > From: Jun Zhao > > > > Clean the option description and unused code. > > > > Signed-off-by: Jun Zhao > > --- > > libavfilter/vf_bilateral.c |7 +-- > >

Re: [FFmpeg-devel] [PATCH 2/2] FATE/dnn: add .gitignore

> On Oct 16, 2019, at 9:08 AM, Guo, Yejun wrote: > > > >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Zhao Zhili >> Sent: Wednesday, October 16, 2019 12:21 AM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Zhao Zhili >> Subject: