Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself to libavfilter/dnn

LGTM. Em seg, 2 de dez de 2019 06:17, Steven Liu escreveu: > > > > 在 2019年11月30日，12:24，Guo, Yejun 写道： > > > > Signed-off-by: Guo, Yejun > > --- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 7f60ef0..5d02520 100644 > > ---

Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for H2S

> -Original Message- > From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Tuesday, December 3, 2019 11:23 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Sun, Xinpeng ; Zhou, Zachary > > Subject: Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi

Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for H2S

> -Original Message- > From: ffmpeg-devel On Behalf Of > Xinpeng Sun > Sent: Monday, December 2, 2019 15:17 > To: ffmpeg-devel@ffmpeg.org > Cc: Sun, Xinpeng ; Zhou, Zachary > > Subject: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for > H2S > > It performs HDR(High

[FFmpeg-devel] [PATCH v2] avfilter/buffersrc: deprecate sws_param option

From: Zhao Zhili --- doc/filters.texi| 4 +--- libavfilter/buffersrc.c | 14 -- libavfilter/version.h | 5 - 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 5fdec6f015..9b3c2d7c2d 100644 --- a/doc/filters.texi

Re: [FFmpeg-devel] [PATCH v2] Patch for memory optimization with QuickTime/MP4

> -Ursprüngliche Nachricht- > Von: ffmpeg-devel Im Auftrag von Michael > Niedermayer > Gesendet: Montag, 2. Dezember 2019 21:54 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] [PATCH v2] Patch for memory optimization with > QuickTime/MP4 > > On Mon, Dec

Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for H2S

> -Original Message- > From: Song, Ruiling > Sent: Tuesday, December 3, 2019 1:37 PM > To: FFmpeg development discussions and patches > Cc: Sun, Xinpeng ; Zhou, Zachary > > Subject: RE: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for > H2S > > > -Original

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_convolution: add 16-column operation for filter_column() and modify filter_slice().

From: chen Replace the existing C code for filter_column() with chen's code. Modify filter_slice() to be compatible with this change. Tested using the command: ./ffmpeg_g -s 1280*720 -pix_fmt yuv420p -i test.yuv -vf convolution="1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_convolution: add X86 SIMD for filter_column()

From: Xu Jun Tested using this command: ./ffmpeg_g -s 1280*720 -pix_fmt yuv420p -i test.yuv -vf convolution="1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1/45:1/45:1/45:1/45:1:2:3:4:column:column:column:column" -an -vframes 5000 -f null /dev/null -benchmark after

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_convolution: Add x86 SIMD optimizations for filter_row()

From: Xu Jun Tested using this command: ./ffmpeg_g -s 1280*720 -pix_fmt yuv420p -i test.yuv -vf convolution="1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1/45:1/45:1/45:1/45:1:2:3:4:row:row:row:row" -an -vframes 5000 -f null /dev/null -benchmark after patch: frame=

[FFmpeg-devel] [PATCH v2 5/5] lavc/libxavs2.c: optimize error descriptions

Signed-off-by: hwren --- libavcodec/libxavs2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 3dfe755..6ee2280 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -72,13 +72,13 @@ static av_cold

[FFmpeg-devel] [PATCH v2 3/5] lavc/libxavs2.c: fix code style - spaces

Signed-off-by: hwren --- libavcodec/libxavs2.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 0e525ee..0aa4d31 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -59,7 +59,7 @@ typedef struct

[FFmpeg-devel] [PATCH v2 4/5] lavc/libxavs2.c: replace deprecated parameter 'FrameRate' with new parameter 'fps'

Signed-off-by: hwren --- libavcodec/libxavs2.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 0aa4d31..3dfe755 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -60,10 +60,15 @@ typedef struct

[FFmpeg-devel] [PATCH v2 1/5] lavc/libxavs2.c: use more descriptive variable names in xavs2_copy_frame* functions

Signed-off-by: hwren --- libavcodec/libxavs2.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 0179a1e..3896f3b 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -132,16

[FFmpeg-devel] [PATCH v2 2/5] lavc/libxavs2.c: avoid recomputations of pointers in xavs2_copy_frame* functions

Signed-off-by: hwren --- libavcodec/libxavs2.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 3896f3b..0e525ee 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -132,28

[FFmpeg-devel] [PATCH] avformat, avcodec: add dfcmv demuxer and decoder

A few example CMV files can be found in the data/initial_movies folder of Dwarf Fortress (http://www.bay12games.com/dwarves/). The demuxer does not currently handle audio cues. There are warning messages logged for each audio file that should be played. As far as I know, the only two existing CMV

Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for H2S

> -Original Message- > From: ffmpeg-devel On Behalf Of > Vittorio Giovara > Sent: Tuesday, December 3, 2019 2:28 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Sun, Xinpeng ; Zhou, Zachary > > Subject: Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap

Re: [FFmpeg-devel] [PATCH 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

> -Original Message- > From: ffmpeg-devel On Behalf Of Carl > Eugen Hoyos > Sent: Monday, December 2, 2019 05:49 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 1/2] libswscale/x86/yuv2rgb: Change inline > assembly into nasm code > > Am Mo., 2.

[FFmpeg-devel] [PATCH 1/3] avformat/movenc: write the major brand also as the first compatible brand

Signed-off-by: James Almer --- This is meant to be squashed with patch 2/3, otherwise it will write duplicate compatible brands, and a lot of tests will have to be updated twice. I'm sending it like this to make reviewing/reading easier. libavformat/movenc.c | 61

[FFmpeg-devel] [PATCH 4/5] lavfi: remove AVFilterPad.poll_frame().

This design is no longer used and was replaced a long time ago. Signed-off-by: Nicolas George --- libavfilter/internal.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/libavfilter/internal.h b/libavfilter/internal.h index f98127c442..abe7537b5d 100644 ---

[FFmpeg-devel] [PATCH 5/5] lavfi/buffersrc: push frame directly.

This allows to remove the queued frame entirely. Signed-off-by: Nicolas George --- libavfilter/buffersrc.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index e95d9c4f49..0eaa6812fc 100644 ---

[FFmpeg-devel] [PATCH 2/5] lavfi: remove ff_poll_frame().

It is never used. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 18 -- libavfilter/internal.h | 9 - 2 files changed, 27 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 1004a6ee1d..baafd029e9 100644 ---

[FFmpeg-devel] [PATCH 3/5] lavfi/buffersrc: remove poll_frame.

Signed-off-by: Nicolas George --- libavfilter/buffersrc.c | 9 - 1 file changed, 9 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index d0ddc6b950..e95d9c4f49 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buffersrc.c @@ -455,19 +455,11 @@ static int

[FFmpeg-devel] [PATCH 1/5] lavfi/buffersrc: remove fifo.

The frame is immediately pushed, the fifo has never more than one. Signed-off-by: Nicolas George --- libavfilter/buffersrc.c | 45 ++--- 1 file changed, 11 insertions(+), 34 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index

[FFmpeg-devel] [PATCH 2/3] avformat/movenc: ensure we don't write the major brand as a compatible brand more than once

Signed-off-by: James Almer --- libavformat/movenc.c | 32 +- tests/ref/fate/binsub-movtextenc | 2 +- tests/ref/fate/copy-psp | 2 +- tests/ref/fate/movenc| 74 tests/ref/lavf/ismv | 12 +++--- 5 files

[FFmpeg-devel] [PATCH] tools: add a fuzzer tool for bitstream filters

Signed-off-by: James Almer --- Untested. The BSF can be set the same way a decoder can in target_dec_fuzzer. The codec_id will be randomly chosen from the supported list, if any. tools/Makefile| 3 + tools/target_bsf_fuzzer.c | 166 ++ 2 files

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: use iso6 major brand when signed CTS offsets are used in trun boxes

Signed-off-by: James Almer --- libavformat/movenc.c | 15 +++ tests/ref/fate/movenc | 8 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index a632882ab2..bffd56644a 100644 --- a/libavformat/movenc.c +++

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/buffersrc: remove write-only variable

Nicolas George (12019-12-02): > Then ok, and it can probably be simplified further, I will look into it. See incoming patch series. > Patch ok in the meantime. Patch applied. Thank you. Regards, -- Nicolas George signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH] ffmpeg_filter: enhance reporting of unconnected pads.

Signed-off-by: Nicolas George --- fftools/ffmpeg_filter.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 72838de1e2..ff46ffab01 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -269,6 +269,13 @@ static void

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: enhance reporting of unconnected pads.

Am Mo., 2. Dez. 2019 um 19:19 Uhr schrieb Nicolas George : > > Signed-off-by: Nicolas George > --- > fftools/ffmpeg_filter.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c > index 72838de1e2..ff46ffab01 100644 > ---

Re: [FFmpeg-devel] [PATCH v3] avfilter: Add tonemap vaapi filter for H2S

On Mon, Dec 2, 2019 at 2:19 AM Xinpeng Sun wrote: > It performs HDR(High Dynamic Range) to SDR(Standard Dynamic Range) > conversion > with tone-mapping. It only supports HDR10 as input temporarily. > > An example command to use this filter with vaapi codecs: > FFMPEG -hwaccel vaapi -vaapi_device

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: enhance reporting of unconnected pads.

Carl Eugen Hoyos (12019-12-02): > Does this change behaviour apart from printing an error message? I thought it did not, but I re-checked to reply, and it does. Patch withdrawn, for now. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/utils: simplify the ff_mkdir_p with SEPARATOR

On Mon, Dec 2, 2019 at 3:16 AM Limin Wang wrote: > > On Sun, Dec 01, 2019 at 05:33:16PM +0100, Hendrik Leppkes wrote: > > On Sun, Dec 1, 2019 at 3:08 PM wrote: > > > > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > --- > > > libavformat/utils.c | 16 ++-- > > > 1

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself to libavfilter/dnn

> 在 2019年11月30日，12:24，Guo, Yejun 写道： > > Signed-off-by: Guo, Yejun > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7f60ef0..5d02520 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -369,6 +369,8 @@ Filters: > Sources: >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add 16-column operation for filter_column() to prepare for x86 SIMD.

Am Mo., 2. Dez. 2019 um 08:33 Uhr schrieb chen : > +#define __assume(cond) do { if (!(cond)) __builtin_unreachable(); } > while (0) We currently don't do that. If you have a testcase where it makes a big difference, adding it could be discussed but has to be checked in configure and added

Re: [FFmpeg-devel] [PATCH] Patch for memory optimization with QuickTime/MP4

Am Mo., 2. Dez. 2019 um 10:05 Uhr schrieb Jörg Beckmann : > > Hi, > > this patch invents a new option "discard_fragments" for the MP4/Quicktime/MOV > decoder. If the option is not set, nothing changes at all. If it is set, old > fragments are discarded as far as possible on each call to

[FFmpeg-devel] [PATCH 2/5] lavc/libxavs2.c: avoid recomputations of pointers in xavs2_copy_frame* functions

Signed-off-by: hwren --- libavcodec/libxavs2.c | 42 -- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 3896f3b..6ec6349 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@

[FFmpeg-devel] [PATCH 1/5] lavc/libxavs2.c: use more descriptive variable names in xavs2_copy_frame* functions

Signed-off-by: hwren --- libavcodec/libxavs2.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 0179a1e..3896f3b 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -132,16

[FFmpeg-devel] [PATCH 3/5] lavc/libxavs2.c: fix code style - spaces

Signed-off-by: hwren --- libavcodec/libxavs2.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 6ec6349..cf448be 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -59,7 +59,7 @@ typedef struct

[FFmpeg-devel] [PATCH] Patch for memory optimization with QuickTime/MP4

Hi, this patch invents a new option "discard_fragments" for the MP4/Quicktime/MOV decoder. If the option is not set, nothing changes at all. If it is set, old fragments are discarded as far as possible on each call to switch_root. For pure audio streams, the memory usage is now constant. For

Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add 16-column operation for filter_column() to prepare for x86 SIMD.

Am Mo., 2. Dez. 2019 um 03:42 Uhr schrieb 徐鋆 : > I'm sorry not to reply in time. Definitely in time! > The performance of this C code is about 10% better than the existing C code. Please add this to the commit message. Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] [SCISYS Possible Spam] Re: [PATCH] Patch for memory optimization with QuickTime/MP4

Am Mo., 2. Dez. 2019 um 11:06 Uhr schrieb Jörg Beckmann : > The for-loop and the warning are copied from somewhere else in the decoder. > I'm also quite sure that it cannot really happen. Then use an assert(). > One cannot set the option to discard old frames and also try to seek. I did > not

Re: [FFmpeg-devel] [PATCH] avfilter/vf_convolution: add 16-column operation for filter_column() to prepare for x86 SIMD.

This is toy only, it depends on compiler On my PC, it helpful my old version compiler generate movaps other than movups. At 2019-12-02 17:21:58, "Carl Eugen Hoyos" wrote: >Am Mo., 2. Dez. 2019 um 08:33 Uhr schrieb chen : > >> +#define __assume(cond) do { if (!(cond))

[FFmpeg-devel] [PATCH 4/5] lavc/libxavs2.c: replace deprecated parameter 'FrameRate' with new parameter 'fps'

Signed-off-by: hwren --- libavcodec/libxavs2.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index cf448be..41b7a29 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -60,10 +60,15 @@ typedef struct

[FFmpeg-devel] [PATCH 5/5] lavc/libxavs2.c: optimize error descriptions

Signed-off-by: hwren --- libavcodec/libxavs2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c index 41b7a29..e3ba808 100644 --- a/libavcodec/libxavs2.c +++ b/libavcodec/libxavs2.c @@ -72,13 +72,13 @@ static av_cold

Re: [FFmpeg-devel] [PATCH] avformat/hls: Use av_packet_move_ref() for packet ownership transfer

> 在 2019年12月1日，13:21，Andreas Rheinhardt 写道： > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hls.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index 21353bbad7..f60396f246 100644 > --- a/libavformat/hls.c > +++

Re: [FFmpeg-devel] [PATCH 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

Am Mo., 2. Dez. 2019 um 04:17 Uhr schrieb Fu, Ting : > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Michael Niedermayer > > Sent: Friday, November 29, 2019 05:33 AM > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 1/2]

Re: [FFmpeg-devel] [SCISYS Possible Spam] Re: [PATCH] Patch for memory optimization with QuickTime/MP4

The for-loop and the warning are copied from somewhere else in the decoder. I'm also quite sure that it cannot really happen. One cannot set the option to discard old frames and also try to seek. I did not manage to create an example with calls to switch_root while reading from a file. But if

Re: [FFmpeg-devel] [PATCH] qsv: get FrameInfo.Shift by desc->comp[0].shift

> -Original Message- > From: Li, Zhong > Sent: Thursday, September 12, 2019 21:23 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: RE: [FFmpeg-devel] [PATCH] qsv: get FrameInfo.Shift by desc- > >comp[0].shift > > > From: ffmpeg-devel On

Re: [FFmpeg-devel] [PATCH] Patch for memory optimization with QuickTime/MP4

You cannot discard whatever is possible AND also try to seek. If you want to seek, you must not use this option. Even if I did not manage to create an example where switch root was called while reading from a file, I'm not sure that it is really impossible. And if switch root is called and the

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/buffersrc: remove write-only variable

zhilizhao (12019-12-02): > I can restore it, but I’m not sure whether the issue disappeared or not. > Current code > call request_frame immediately after av_fifo_generic_write, while the old code > call request_frame conditionally. Oh, I missed that. Then ok, and it can probably be simplified

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

On 1/12/19 09:05, Andreas Rheinhardt wrote: ggarr...@gmail.com: From: Gonzalo Garramuño Moved the check inside and at the end of the if (pktl) as per Michael Niedermayer's suggestion. This patch is based on one from Blake Senftner ( bsenftner at earthlink.net ). The hanging in

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/buffersrc: deprecate sws_param option

zhilizhao (12019-12-02): > You mean add attribute_deprecated? I will update the patch. Possibly that, but most of all an FF_API_ constant like in this commit. That way, the option will disappear automatically in a few months and the cleanup is made easier.

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/utils: simplify the ff_mkdir_p with SEPARATOR

On Mon, Dec 2, 2019 at 3:36 PM Limin Wang wrote: > > On Mon, Dec 02, 2019 at 09:26:11AM +0100, Hendrik Leppkes wrote: > > On Mon, Dec 2, 2019 at 3:16 AM Limin Wang wrote: > > > > > > On Sun, Dec 01, 2019 at 05:33:16PM +0100, Hendrik Leppkes wrote: > > > > On Sun, Dec 1, 2019 at 3:08 PM wrote: >

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/buffersrc: remove write-only variable

quinkbl...@foxmail.com (12019-12-02): > From: Zhao Zhili > > --- > libavfilter/buffersrc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c > index e0ff7e4dd8..bae7d86695 100644 > --- a/libavfilter/buffersrc.c > +++

Re: [FFmpeg-devel] [PATCH 2/5] lavc/libxavs2.c: avoid recomputations of pointers in xavs2_copy_frame* functions

On Mon, Dec 02, 2019 at 15:29:37 +0800, hwren wrote: > -int plane, hIdx, wIdx; > -for (plane = 0; plane < 3; plane++) { [...] > +for (plane = 0; plane < 3; ++plane) { ffmpeg prefers the plane++ syntax style. Same further below. Thanks, Moritz

[FFmpeg-devel] [PATCH 1/2] avfilter/buffersrc: remove write-only variable

From: Zhao Zhili --- libavfilter/buffersrc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index e0ff7e4dd8..bae7d86695 100644 --- a/libavfilter/buffersrc.c +++ b/libavfilter/buffersrc.c @@ -47,7 +47,6 @@ typedef struct

[FFmpeg-devel] [PATCH 2/2] avfilter/buffersrc: deprecate sws_param option

From: Zhao Zhili --- doc/filters.texi| 4 +--- libavfilter/buffersrc.c | 8 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 5fdec6f015..9b3c2d7c2d 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -21014,9 +21014,7

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/buffersrc: deprecate sws_param option

quinkbl...@foxmail.com (12019-12-02): > From: Zhao Zhili > > --- > doc/filters.texi| 4 +--- > libavfilter/buffersrc.c | 8 ++-- > 2 files changed, 7 insertions(+), 5 deletions(-) Ok. But ideally you would include deprecation guards so that it is automatically removed in two

[FFmpeg-devel] [PATCH v2] Patch for memory optimization with QuickTime/MP4

After discussion with Carl Eugen, I replaced the "if" in line 7737 with an assert(). There is still the question, whether mov_switch_root() might be called when reading from a file. If someone is really really sure that it cannot happen at all, the check in mov_read_seek() could be removed.

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/utils: simplify the ff_mkdir_p with SEPARATOR

On Mon, Dec 02, 2019 at 09:26:11AM +0100, Hendrik Leppkes wrote: > On Mon, Dec 2, 2019 at 3:16 AM Limin Wang wrote: > > > > On Sun, Dec 01, 2019 at 05:33:16PM +0100, Hendrik Leppkes wrote: > > > On Sun, Dec 1, 2019 at 3:08 PM wrote: > > > > > > > > From: Limin Wang > > > > > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/buffersrc: deprecate sws_param option

> On Dec 2, 2019, at 9:49 PM, Nicolas George wrote: > > quinkbl...@foxmail.com (12019-12-02): >> From: Zhao Zhili >> >> --- >> doc/filters.texi| 4 +--- >> libavfilter/buffersrc.c | 8 ++-- >> 2 files changed, 7 insertions(+), 5 deletions(-) > > Ok. But ideally you would include

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/buffersrc: remove write-only variable

> On Dec 2, 2019, at 9:33 PM, Nicolas George wrote: > > quinkbl...@foxmail.com (12019-12-02): >> From: Zhao Zhili >> >> --- >> libavfilter/buffersrc.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/libavfilter/buffersrc.c

Re: [FFmpeg-devel] [PATCH V2 1/2] lavf/libsrt: add linger parameter to libsrt

On Mon, 02. Dec 14:25, myp...@gmail.com wrote: > On Mon, Dec 2, 2019 at 12:57 PM Andriy Gelman > wrote: > > > > On Sun, 01. Dec 21:31, Jun Zhao wrote: > > > From: Jun Zhao > > > > > > add linger parameter to libsrt, it's setting he number of seconds > > > that the socket waits for unsent data

Re: [FFmpeg-devel] [PATCH] lavc/h2645_parse: Don't automatically remove nuh_layer_id > 0 packets

On Mon, 02. Dec 07:50, Andreas Rheinhardt wrote: > On Mon, Dec 2, 2019 at 3:49 AM Andriy Gelman > wrote: > > > From: Andriy Gelman > > > > HEVC standard supports multi-layer streams (ITU-T H.265 02/2018 Annex > > F). Each NAL unit belongs to a particular layer defined by nuh_layer_id > > in the

Re: [FFmpeg-devel] [PATCH v2] Patch for memory optimization with QuickTime/MP4

On Mon, Dec 02, 2019 at 02:12:14PM +, Jörg Beckmann wrote: > After discussion with Carl Eugen, I replaced the "if" in line 7737 with an > assert(). > > There is still the question, whether mov_switch_root() might be called when > reading from a file. If someone is really really sure that it