Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_elbg: Fix for the seed type

2019-12-05 Thread Limin Wang
On Wed, Dec 04, 2019 at 08:31:15PM +0100, Michael Niedermayer wrote: > On Fri, Nov 22, 2019 at 09:50:36AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavfilter/vf_elbg.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/fitsdec: Use lrint()

2019-12-05 Thread Michael Niedermayer
On Mon, Sep 30, 2019 at 10:30:59PM -0300, James Almer wrote: > On 9/30/2019 1:30 PM, Michael Niedermayer wrote: > > Fixes: -nan is outside the range of representable values of type 'unsigned > > short' > > From lrint documentation: > > "If x is a NaN or an infinity, or the rounded value is too

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/fitsdec: Use lrint()

2019-12-05 Thread James Almer
On 12/5/2019 2:46 PM, Michael Niedermayer wrote: > On Mon, Sep 30, 2019 at 10:30:59PM -0300, James Almer wrote: >> On 9/30/2019 1:30 PM, Michael Niedermayer wrote: >>> Fixes: -nan is outside the range of representable values of type 'unsigned >>> short' >> >> From lrint documentation: >> >> "If x

Re: [FFmpeg-devel] [PATCH] avfilter/crop: avoid premature eval error

2019-12-05 Thread Gyan
On 04-12-2019 04:09 pm, Gyan wrote: Valid width expressions were being rejected. Plan to push in the morning. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/fitsdec: Use lrint()

2019-12-05 Thread Michael Niedermayer
On Thu, Dec 05, 2019 at 02:51:32PM -0300, James Almer wrote: > On 12/5/2019 2:46 PM, Michael Niedermayer wrote: > > On Mon, Sep 30, 2019 at 10:30:59PM -0300, James Almer wrote: > >> On 9/30/2019 1:30 PM, Michael Niedermayer wrote: > >>> Fixes: -nan is outside the range of representable values of

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mpeg: Make VobSub demuxer have its own context struct

2019-12-05 Thread Michael Niedermayer
On Wed, Dec 04, 2019 at 01:37:12PM +0100, Andreas Rheinhardt wrote: > When the VobSub demuxer was added, the fields it required were simply > added to the MpegDemuxContext (if the VobSub demuxer was selected at > all). The mpeg demuxer of course doesn't use these fields even if they > are there;

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpeg: Don't copy or leak string in AVBPrint

2019-12-05 Thread Michael Niedermayer
On Wed, Dec 04, 2019 at 01:37:13PM +0100, Andreas Rheinhardt wrote: > vobsub_read_header() uses an AVBPrint to write a string and up until > now, it collected the string stored in the AVBPrint via > av_bprint_finalize(), which might involve an allocation and copy of the > string. But this is

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mpeg: Fix leaks of AVFormatContext and subtitle packets

2019-12-05 Thread Michael Niedermayer
On Wed, Dec 04, 2019 at 01:37:14PM +0100, Andreas Rheinhardt wrote: > If an error happens in vobsub_read_header() after allocating the > AVFormatContext intended to read the sub-file, both the AVFormatContext > as well as the data in the subtitles queues leaks. This has been fixed. > >

Re: [FFmpeg-devel] [PATCH] lavc/h2645_parse: Don't automatically remove nuh_layer_id > 0 packets

2019-12-05 Thread Andriy Gelman
On Mon, 02. Dec 00:07, James Almer wrote: > On 12/1/2019 11:48 PM, Andriy Gelman wrote: > > From: Andriy Gelman > > > > HEVC standard supports multi-layer streams (ITU-T H.265 02/2018 Annex > > F). Each NAL unit belongs to a particular layer defined by nuh_layer_id > > in the header. > > > >

Re: [FFmpeg-devel] [PATCH v2] tools: add a fuzzer tool for bitstream filters

2019-12-05 Thread Michael Niedermayer
On Tue, Dec 03, 2019 at 06:05:41PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > tools/Makefile| 3 + > tools/target_bsf_fuzzer.c | 153 ++ > 2 files changed, 156 insertions(+) > create mode 100644 tools/target_bsf_fuzzer.c > >

[FFmpeg-devel] [PATCH 2/2] avcodec/mpeg12dec: Fix invalid shift in mpeg2_fast_decode_block_intra()

2019-12-05 Thread Michael Niedermayer
Fixes: left shift of negative value -695 Fixes: 19232/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5702856963522560 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/2] avcodec/mvha: Check remaining space when reading VLC table probabilities

2019-12-05 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 19183/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVHA_fuzzer-5666216765292544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mvha.c | 3 +++ 1 file

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mpeg: Don't copy or leak string in AVBPrint

2019-12-05 Thread Andreas Rheinhardt
Michael Niedermayer: > On Wed, Dec 04, 2019 at 01:37:13PM +0100, Andreas Rheinhardt wrote: >> vobsub_read_header() uses an AVBPrint to write a string and up until >> now, it collected the string stored in the AVBPrint via >> av_bprint_finalize(), which might involve an allocation and copy of the

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mvha: Check remaining space when reading VLC table probabilities

2019-12-05 Thread Paul B Mahol
LGTM On 12/6/19, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 19183/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVHA_fuzzer-5666216765292544 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avutil/buffer: use appropriate atomic operations

2019-12-05 Thread James Almer
On 12/5/2019 6:02 AM, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > No functional changes. ref/unref vs add/sub is symmetrical. > --- > libavutil/buffer.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/buffer.c b/libavutil/buffer.c > index

Re: [FFmpeg-devel] [PATCH v2] tools: add a fuzzer tool for bitstream filters

2019-12-05 Thread James Almer
On 12/5/2019 6:57 PM, Michael Niedermayer wrote: > On Tue, Dec 03, 2019 at 06:05:41PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> tools/Makefile| 3 + >> tools/target_bsf_fuzzer.c | 153 ++ >> 2 files changed, 156

Re: [FFmpeg-devel] [PATCH v3] avformat/matroskaenc: Use random TrackUID

2019-12-05 Thread Andreas Rheinhardt
Michael Niedermayer: > On Tue, Dec 03, 2019 at 04:19:47PM +0100, Andreas Rheinhardt wrote: >> Up until now, the TrackUID of a Matroska track which is supposed to be >> random was not random at all: It always coincided with the TrackNumber >> which is usually the 1-based index of the corresponding

[FFmpeg-devel] [PATCH v1] avcodec/cbs_av1: rename enable_intraintra_compound flag

2019-12-05 Thread Wangfei
rename enable_intraintra_compound to enable_interintra_compound, which keep same as AV1 sepc(v1.0.0-errata1). Signed-off-by: Wangfei --- libavcodec/cbs_av1.h | 2 +- libavcodec/cbs_av1_syntax_template.c | 4 ++-- libavformat/av1.c| 2 +- 3 files changed, 4

[FFmpeg-devel] [PATCH v2 2/2] lavc/h2645_parse: Reorder H2645NAL to reduce size

2019-12-05 Thread Andriy Gelman
From: Andriy Gelman Size of H2645NAL reduced from 112 to 104 bytes on x86-64. Signed-off-by: Andriy Gelman --- libavcodec/h2645_parse.h | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavcodec/h2645_parse.h b/libavcodec/h2645_parse.h index

[FFmpeg-devel] [PATCH v2 1/2] lavc/h2645_parse: Don't automatically remove nuh_layer_id > 0 packets

2019-12-05 Thread Andriy Gelman
From: Andriy Gelman HEVC standard supports multi-layer streams (ITU-T H.265 02/2018 Annex F). Each NAL unit belongs to a particular layer defined by nuh_layer_id in the header. Currently, all NAL units that do not belong to a base layer are automatically removed in ff_h2645_packet_split(). Some

Re: [FFmpeg-devel] [PATCH] avfilter/crop: avoid premature eval error

2019-12-05 Thread Gyan
On 05-12-2019 11:31 pm, Gyan wrote: On 04-12-2019 04:09 pm, Gyan wrote: Valid width expressions were being rejected. Plan to push in the morning. Pushed as b66a800877d6f97fa94b41533e3d6a6273f7fb9f Gyan ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/3] avfilter/buffersink: remove unused macros

2019-12-05 Thread quinkblack
From: Zhao Zhili --- libavfilter/buffersink.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 25b3f4ab6b..30153adbb2 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -61,8 +61,6 @@ typedef struct

[FFmpeg-devel] [PATCH 2/3] avfilter/buffersink: replace init_opaque by init

2019-12-05 Thread quinkblack
From: Zhao Zhili The argument 'opaque' is always NULL since 0acf7e2 (2013). --- libavfilter/buffersink.c | 35 ++- 1 file changed, 2 insertions(+), 33 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 30153adbb2..5f2ed0e4b3

[FFmpeg-devel] [PATCH 3/3] avfilter/buffersink: remove AVBufferSinkParams and AVABufferSinkParams

2019-12-05 Thread quinkblack
From: Zhao Zhili The patch breaks API in theory. Since there is no reason to allocate an object which you can do nothing with it, the API break should have no effect. --- libavfilter/buffersink.c | 20 libavfilter/buffersink.h | 32 2 files

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/buffersink: remove AVBufferSinkParams and AVABufferSinkParams

2019-12-05 Thread zhilizhao
Please ignore patch 3/3. FFmpeg user may pass AVBufferSinkParams to avfilter_graph_create_filter with the opaque pointer, which is ignored by implementation. It should be marked as obsolete. > On Dec 6, 2019, at 1:14 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > The patch breaks

[FFmpeg-devel] [PATCH v2 2/4] avfilter/buffersink: replace init_opaque by init

2019-12-05 Thread quinkblack
From: Zhao Zhili The argument 'opaque' is always NULL since 0acf7e2 (2013). --- libavfilter/buffersink.c | 35 ++- 1 file changed, 2 insertions(+), 33 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 30153adbb2..5f2ed0e4b3

[FFmpeg-devel] [PATCH v2 1/4] avfilter/buffersink: remove unused macros

2019-12-05 Thread quinkblack
From: Zhao Zhili --- libavfilter/buffersink.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 25b3f4ab6b..30153adbb2 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -61,8 +61,6 @@ typedef struct

[FFmpeg-devel] [PATCH v2 3/4] avfilter/buffersink: deprecate AVBufferSinkParams and AVABufferSinkParams

2019-12-05 Thread quinkblack
From: Zhao Zhili --- libavfilter/buffersink.c | 2 ++ libavfilter/buffersink.h | 4 2 files changed, 6 insertions(+) diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c index 5f2ed0e4b3..76a46f6678 100644 --- a/libavfilter/buffersink.c +++ b/libavfilter/buffersink.c @@ -125,6

[FFmpeg-devel] [PATCH v2 4/4] avfilter/avfilter: update documentation of avfilter_graph_create_filter

2019-12-05 Thread quinkblack
From: Zhao Zhili --- libavfilter/avfilter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h index 3eaa8a4089..197e12a625 100644 --- a/libavfilter/avfilter.h +++ b/libavfilter/avfilter.h @@ -947,7 +947,7 @@ AVFilterContext

Re: [FFmpeg-devel] [PATCH v2 4/4] avfilter/avfilter: update documentation of avfilter_graph_create_filter

2019-12-05 Thread zhilizhao
> On Dec 6, 2019, at 3:06 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > --- > libavfilter/avfilter.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h > index 3eaa8a4089..197e12a625 100644 > ---

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: Improve non-shm performance

2019-12-05 Thread Kusanagi Kouichi
On 2019-12-04 22:32:52 +0100, Marton Balint wrote: > > > On Wed, 4 Dec 2019, Kusanagi Kouichi wrote: > > > On 2019-12-03 21:25:37 +0100, Marton Balint wrote: > > > > > > > > > On Tue, 3 Dec 2019, Kusanagi Kouichi wrote: > > > > > > > On 2019-11-19 22:59:56 +0900, Kusanagi Kouichi wrote: > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_yaepblur: add yaepblur filter

2019-12-05 Thread Tao Zhang
Hello everyone, Can I assume this patch is ok if no comments or objections? Tao Zhang 于2019年12月3日周二 下午5:26写道: > > ping:) > > leozhang 于2019年11月25日周一 下午5:53写道: > > > > Signed-off-by: leozhang > > --- > > This filter blur the input while preserving edges, with slice threads speed > > up. > > My

[FFmpeg-devel] [PATCH] avutil/buffer: use appropriate atomic operations

2019-12-05 Thread quinkblack
From: Zhao Zhili No functional changes. ref/unref vs add/sub is symmetrical. --- libavutil/buffer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/buffer.c b/libavutil/buffer.c index 8d1aa5fa84..f0034b026a 100644 --- a/libavutil/buffer.c +++

Re: [FFmpeg-devel] [PATCH, v3, 1/7] lavu/pixfmt: add new pixel format 0yuv/y210/y410

2019-12-05 Thread James Darnley
On 2019-12-04 15:43, Linjie Fu wrote: > Previously, media driver provided planar format(like 420 8 bit), > but for HEVC Range Extension (422/444 8/10 bit), the decoded image > is produced in packed format because Windows expects it. > > Add some packed pixel formats for hardware decode support in

Re: [FFmpeg-devel] [PATCH, v3, 1/7] lavu/pixfmt: add new pixel format 0yuv/y210/y410

2019-12-05 Thread Paul B Mahol
On 12/5/19, James Darnley wrote: > On 2019-12-04 15:43, Linjie Fu wrote: >> Previously, media driver provided planar format(like 420 8 bit), >> but for HEVC Range Extension (422/444 8/10 bit), the decoded image >> is produced in packed format because Windows expects it. >> >> Add some packed

Re: [FFmpeg-devel] [PATCH] avfilter/vf_yaepblur: add yaepblur filter

2019-12-05 Thread Paul B Mahol
On 12/5/19, Tao Zhang wrote: > Hello everyone, > Can I assume this patch is ok if no comments or objections? Yes, give some time for it to be applied. I'm busy with other stuff right now. So this patch LGTM (Note to committer to bump minor of libavfiter upon pushing). > > Tao Zhang