Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2019-12-31 Thread Moritz Barsnick
On Tue, Dec 17, 2019 at 14:42:21 -0800, Wonkap Jang wrote: > +memset(_id, 0, sizeof(vpx_svc_layer_id_t)); ffmpeg coding tends to prefer sizeof(variable) over sizeof(type). Cheers, Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264_ps: Provide more details with "Truncated VUI" Message

2019-12-31 Thread Michael Niedermayer
On Sun, Dec 15, 2019 at 11:00:29PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/h264_ps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Observe

[FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2019-12-31 Thread Gyan Doshi
Retains parsed expressions which allows for better error-checking and adding animation support. --- libavfilter/scale_eval.c | 69 +- libavfilter/vf_scale.c | 264 +++ 2 files changed, 246 insertions(+), 87 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 5/5] avfilter/scale: add animation support

2019-12-31 Thread Gyan Doshi
Width and height expressions in scale and scale2ref filters can now reference frame index, timestamp and packet position. --- libavfilter/vf_scale.c | 64 +++--- 1 file changed, 60 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_scale.c

[FFmpeg-devel] [PATCH v2 4/5] avfilter/scale: add function to check expressions

2019-12-31 Thread Gyan Doshi
Allows finer identification and logging of invalid expressions and use of a single list for symbols and their index for both scale and scale2ref. --- libavfilter/vf_scale.c | 97 +- 1 file changed, 59 insertions(+), 38 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] tools/target_dec_fuzzer: Stop negative block_align and sampling rate

2019-12-31 Thread Michael Niedermayer
On Sat, Dec 28, 2019 at 09:16:16PM +0100, Michael Niedermayer wrote: > These are checked for early in avcodec_open2() and do not really test the > decoder > but instead waste resources which could be better spend fuzzing the actual > decoder > > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH 7/8] avcodec/utils: remove access of AV_SAMPLE_FMT_NB

2019-12-31 Thread Michael Niedermayer
On Mon, Dec 30, 2019 at 09:54:18PM +0800, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > --- > libavcodec/utils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Any man who

Re: [FFmpeg-devel] [PATCHv2 8/8] avformat/img2enc: add support for specifying protocol options

2019-12-31 Thread Nicolas George
Marton Balint (12019-12-28): > v2: simplified example > > Signed-off-by: Marton Balint > --- > doc/muxers.texi | 11 +++ > libavformat/img2enc.c | 13 - > 2 files changed, 23 insertions(+), 1 deletion(-) image2 is not the only demuxer that opens new streams. I think a

Re: [FFmpeg-devel] [PATCH 6/8] swscale/tests/swscale: remove access of AV_PIX_FMT_NB

2019-12-31 Thread Michael Niedermayer
On Mon, Dec 30, 2019 at 09:54:17PM +0800, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > --- > libswscale/tests/swscale.c | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/libswscale/tests/swscale.c b/libswscale/tests/swscale.c > index

[FFmpeg-devel] [PATCH] avfilter: add freezeframes video filter

2019-12-31 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 19 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_freezeframes.c | 167 ++ 4 files changed, 188 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH 5/8] swscale/utils: remove access of AV_PIX_FMT_NB

2019-12-31 Thread Michael Niedermayer
On Mon, Dec 30, 2019 at 09:54:16PM +0800, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > --- > libswscale/utils.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you

Re: [FFmpeg-devel] [PATCH v2 6/7] avcodec/utils: Fix ff_add_cpb_side_data() add twice

2019-12-31 Thread Moritz Barsnick
On Thu, Dec 19, 2019 at 17:43:26 +0100, Nicolas Gaullier wrote: > +return (AVCPBProperties *)avctx->coded_side_data[i].data; Nit: ^^ two spaces Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cook: Use 3 stage VLC decoding for channel_coupling

2019-12-31 Thread Michael Niedermayer
On Mon, Nov 25, 2019 at 11:47:15PM +0100, Michael Niedermayer wrote: > Fixes: shift exponent -1 is negative > Fixes: out of array read > Fixes: > 19028/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_COOK_fuzzer-5759766471376896 > Fixes: >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/ffwavesynth: Fix undefined overflow in wavesynth_synth_sample()

2019-12-31 Thread Michael Niedermayer
On Mon, Nov 25, 2019 at 11:47:16PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147464192 + 21176 cannot be represented in > type 'int' > Fixes: > 19042/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5719828090585088 > > Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH] avformat/dtsdec: make S16LE discrimination sharper

2019-12-31 Thread Michael Niedermayer
Both S16LE as well as DTS can have lots of 0 bytes in silent segments Using these results in error. Thus this patch skips 0 bytes in comparission. Fixes Ticket6561 Signed-off-by: Michael Niedermayer --- libavformat/dtsdec.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpeg: Remove secondary packet for reading VobSub

2019-12-31 Thread Andreas Rheinhardt
On Tue, Dec 24, 2019 at 1:58 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Andreas Rheinhardt: > > Andreas Rheinhardt: > >> Andreas Rheinhardt: > >>> Andreas Rheinhardt: > When vobsub_read_packet() reads a packet, it uses a dedicated AVPacket > to get the subtitle

Re: [FFmpeg-devel] [PATCH 1/5] avcodec: Replace show_bits_long() by show_bits() where possible

2019-12-31 Thread Michael Niedermayer
On Sun, Nov 24, 2019 at 04:45:02PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/golomb.h| 2 +- > libavcodec/ivi.c | 2 +- > libavcodec/mpeg4audio.c| 2 +- > libavcodec/mpeg4videodec.c | 4 ++-- > 4 files changed, 5

Re: [FFmpeg-devel] [PATCH v5] avfilter/buffersrc: deprecate sws_param option

2019-12-31 Thread James Almer
On 12/31/2019 10:05 AM, James Almer wrote: > On 12/30/2019 7:25 AM, Nicolas George wrote: >> quinkbl...@foxmail.com (12019-12-30): >>> From: Zhao Zhili >>> >>> --- >>> Rebase patch on master. >>> >>> doc/filters.texi| 8 >>> libavfilter/buffersrc.c | 14 -- >>>

Re: [FFmpeg-devel] [PATCH v5] avfilter/buffersrc: deprecate sws_param option

2019-12-31 Thread Nicolas George
zhilizhao (12019-12-31): > I have a pending patch for it. > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-December/253879.html > I am about to apply it. It removes flags that used to be passed, but since nobody noticed they

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2019-12-31 Thread Nicolas George
Anton Khirnov (12019-12-29): > Maybe I missed something, but I am not aware of the UB-ness of signed > overflow being a practical problem. Typically, your computation will > return a meaningless result. You would get a similarly meaningless > result from the analogous perfectly well-defined

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2019-12-31 Thread Nicolas George
Anton Khirnov (12019-12-29): > In the API namespace (function names) or the parameter names? For the > latter, it can be changed at any time without problem and I don't really > care much. For the former, the header is called channel_layout and I'd > lean towards keeping that aligned with the

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/twinvqdec: Correct overflow in block align check

2019-12-31 Thread Michael Niedermayer
On Tue, Dec 03, 2019 at 10:23:54PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 538976288 * 8 cannot be represented in type > 'int' > Fixes: > 19126/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TWINVQ_fuzzer-5687464110325760 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Support fuzzing error detection

2019-12-31 Thread Michael Niedermayer
On Tue, Dec 03, 2019 at 04:07:32PM +0100, Michael Niedermayer wrote: > On Sat, Nov 30, 2019 at 12:59:20AM +0100, Michael Niedermayer wrote: > > This should increase coverage > > > > Signed-off-by: Michael Niedermayer > > --- > > tools/target_dec_fuzzer.c | 6 ++ > > 1 file changed, 6

Re: [FFmpeg-devel] [PATCH v5] avfilter/buffersrc: deprecate sws_param option

2019-12-31 Thread James Almer
On 12/30/2019 7:25 AM, Nicolas George wrote: > quinkbl...@foxmail.com (12019-12-30): >> From: Zhao Zhili >> >> --- >> Rebase patch on master. >> >> doc/filters.texi| 8 >> libavfilter/buffersrc.c | 14 -- >> libavfilter/version.h | 5 - >> 3 files changed, 20

Re: [FFmpeg-devel] [PATCH 6/8] swscale/tests/swscale: remove access of AV_PIX_FMT_NB

2019-12-31 Thread zhilizhao
> On Dec 31, 2019, at 7:49 PM, Michael Niedermayer > wrote: > > On Mon, Dec 30, 2019 at 09:54:17PM +0800, quinkbl...@foxmail.com > wrote: >> From: Zhao Zhili mailto:zhiliz...@tencent.com>> >> >> --- >> libswscale/tests/swscale.c

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: remove sws_param option from buffersrc

2019-12-31 Thread Nicolas George
quinkbl...@foxmail.com (12019-12-04): > From: Zhao Zhili > > The option is deprecated and ignored by buffersrc. > --- > fftools/ffmpeg_filter.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Pushed, thanks. Regards, -- Nicolas George signature.asc Description: PGP

Re: [FFmpeg-devel] [PATCH v3 1/1] avdevice/gdigrab: Add use_captureblt option for disable or use CAPTUREBLT flag, when useing the bitblt function with CAPTUREBLT it caused the mouse cursor flicker. mo

2019-12-31 Thread Marton Balint
On Tue, 31 Dec 2019, fgodt wrote: On 2019/12/31 上午1:37, Calvin Walton wrote: On Mon, 2019-12-30 at 12:31 +0100, Marton Balint wrote: On Mon, 30 Dec 2019, fgodt...@hotmail.com wrote: From: FgoDt +@item use_captureblt +When use gdigrab to capture window or desktop, the mouse cursor will

Re: [FFmpeg-devel] [PATCH v5] avfilter/buffersrc: deprecate sws_param option

2019-12-31 Thread zhilizhao
> On Dec 31, 2019, at 9:08 PM, James Almer wrote: > > On 12/31/2019 10:05 AM, James Almer wrote: >> On 12/30/2019 7:25 AM, Nicolas George wrote: >>> quinkbl...@foxmail.com (12019-12-30): From: Zhao Zhili --- Rebase patch on master. doc/filters.texi| 8

Re: [FFmpeg-devel] [PATCH v1] avfilter: add overlay vaapi filter

2019-12-31 Thread Paul B Mahol
On 12/20/19, Xinpeng Sun wrote: > Overlay one video on the top of another. > > It takes two inputs and has one output. The first input is the "main" video > on which the > second input is overlaid. This filter requires same memory layout for all > the inputs. > > An example command to use this

[FFmpeg-devel] [PATCH v2 4/5] avfilter/scale: add function to check expressions

2019-12-31 Thread Gyan Doshi
Allows finer identification and logging of invalid expressions and use of a single list for symbols and their index for both scale and scale2ref. --- Rebased upon the correct rebase of v2 3/5 libavfilter/vf_scale.c | 113 - 1 file changed, 67

Re: [FFmpeg-devel] [PATCH 05/20] avformat/matroskaenc: Check return value of ff_isom_write_hvcc()

2019-12-31 Thread myp...@gmail.com
On Wed, Jan 1, 2020 at 8:59 AM Andreas Rheinhardt wrote: > > The Matroska muxer currently does not check the return value of > ff_isom_write_hvcc(), the function used to write mp4-style > HEVC-extradata as Matroska also uses it. This was intentionally done in > 7a5356c72 to allow remuxing from

[FFmpeg-devel] [PATCH v2 5/5] avfilter/scale: add animation support

2019-12-31 Thread Gyan Doshi
Width and height expressions in scale and scale2ref filters can now reference frame index, timestamp and packet position. --- Rebased upon correct rebase of v2 3/5 libavfilter/vf_scale.c | 64 +++--- 1 file changed, 60 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 5/7] avformat/matroskadec: Use AV_DICT_DONT_STRDUP_VAL to save av_strdup

2019-12-31 Thread Andreas Rheinhardt
On Sun, Nov 10, 2019 at 5:07 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > This will likely also fix CID 1452562, a false positive resulting from > Coverity thinking that av_dict_set() automatically frees its key and > value parameters (even without the AV_DICT_DONT_STRDUP_*

[FFmpeg-devel] [PATCH 00/20] Matroska muxer patches

2019-12-31 Thread Andreas Rheinhardt
Hello, this patchset is about the Matroska muxer. It consists partially of patches from my earlier patchset [1] that is currently blocked by the webm_chunk muxer [2]. One focus of this patchset is about improving writing Cues; in particular, an assert that is triggered if the reserved space for

Re: [FFmpeg-devel] [PATCH V1 02/12] lavc/libkvazaar: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread James Almer
On 1/1/2020 2:20 AM, Jun Zhao wrote: > From: Jun Zhao > > In case of failure, all the successfully set entries are stored in > *pm. We need to manually free the created dictionary to avoid > memory leak. > > Signed-off-by: Jun Zhao > --- > libavcodec/libkvazaar.c |2 +- > 1 files changed,

Re: [FFmpeg-devel] [PATCH 02/20] avformat/matroskaenc: Improve writing Projection

2019-12-31 Thread Andreas Rheinhardt
On Wed, Jan 1, 2020 at 4:53 AM Carl Eugen Hoyos wrote: > Am Mi., 1. Jan. 2020 um 01:59 Uhr schrieb Andreas Rheinhardt > : > > > > The Matroska Projection master element has such a small maximum length > > that it can always be written with a length field of length one. > > So it is unnecessary

Re: [FFmpeg-devel] [PATCH] configure: bump year

2019-12-31 Thread myp...@gmail.com
On Wed, Jan 1, 2020 at 2:46 PM Gyan Doshi wrote: > > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 43dc409fe6..965b4c71b8 100755 > --- a/configure > +++ b/configure > @@ -7456,7 +7456,7 @@ cat > $TMPH < #define

Re: [FFmpeg-devel] [PATCH 02/20] avformat/matroskaenc: Improve writing Projection

2019-12-31 Thread Carl Eugen Hoyos
Am Mi., 1. Jan. 2020 um 01:59 Uhr schrieb Andreas Rheinhardt : > > The Matroska Projection master element has such a small maximum length > that it can always be written with a length field of length one. > So it is unnecessary to first write the element into a dynamic buffer to > get the accurate

[FFmpeg-devel] [PATCH V1] libavcodec/aacdec: fix HE-AAC decoder dirty date (for sbr) when flush

2019-12-31 Thread Jun Zhao
From: qoroliang aac decoder only do the window overlapping data buffer flush but without sbr related buffer flush, that will cause dirty data in the first output frame after flush. Signed-off-by: qoroliang --- libavcodec/aacdec_template.c |6 ++ 1 files changed, 6 insertions(+), 0

[FFmpeg-devel] [PATCH] configure: bump year

2019-12-31 Thread Gyan Doshi
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 43dc409fe6..965b4c71b8 100755 --- a/configure +++ b/configure @@ -7456,7 +7456,7 @@ cat > $TMPH

[FFmpeg-devel] [PATCH 12/20] avformat/matroskaenc: Avoid allocation for Cues

2019-12-31 Thread Andreas Rheinhardt
Up until now, the Matroska muxer would allocate a structure containing three members: The segment offset, a pointer to an array containing Cue (index) entries and a counter for said array. It is unnecessary to allocate it separately and it is unnecessary to contain the segment offset in said

[FFmpeg-devel] [PATCH 14/20] avformat/matroskadec: Simplify writing Cues

2019-12-31 Thread Andreas Rheinhardt
When the Matroska muxer writes the Cues (the index), it groups index entries with the same timestamp into the same CuePoint to save space. But given Matroska's variable-length length fields, it either needs to have an upper bound of the final size of the CuePoint before writing it or the CuePoint

[FFmpeg-devel] [PATCH 07/20] avformat/matroskaenc: Avoid allocations for SeekHead

2019-12-31 Thread Andreas Rheinhardt
Up until e7ddafd5, the Matroska muxer wrote two SeekHeads: One at the beginning referencing the main level 1 elements (i.e. not the Clusters) and one at the end, referencing the Clusters. This second SeekHead was useless and has therefore been removed. Yet the SeekHead-related functions and

[FFmpeg-devel] [PATCH 09/20] avformat/matroskaenc: Check for failure when writing SeekHead

2019-12-31 Thread Andreas Rheinhardt
mkv_write_seekhead() would up until now try to seek to the position where the SeekHead ought to be written, write the SeekHead and seek back. The first of these seeks was checked as was writing, yet the seek back was unchecked. Moreover the return value of mkv_write_seekhead() was unchecked (the

[FFmpeg-devel] [PATCH 08/20] avformat/matroskaenc: Improve calculating EBML ID size

2019-12-31 Thread Andreas Rheinhardt
When the Matroska muxer writes an EBML ID, it calculates the length of said ID before; and it does this as if this were a number that needs to be encoded as EBML number: The formula used is (av_log2(id + 1) - 1) / 7 + 1. But the constants used already contain the VINT_MARKER (the leading bit

[FFmpeg-devel] [PATCH 13/20] avformat/aviobuf: Add function to reset dynamic buffer

2019-12-31 Thread Andreas Rheinhardt
Resetting a dynamic buffer means to keep the AVIOContext and the internal buffer used by the dynamic buffer. This is done in order to save (re)allocations when one has a workflow where one opens and closes dynamic buffers in sequence. Signed-off-by: Andreas Rheinhardt --- This function might

[FFmpeg-devel] [PATCH 18/20] avformat/matroskaenc: Don't fail if reserved Cues space doesn't suffice

2019-12-31 Thread Andreas Rheinhardt
When the user opted to write the Cues at the beginning, the Cues were simply written without checking in advance whether enough space has been reserved for them. If it wasn't enough, the data following the space reserved for the Cues was simply overwritten, corrupting the file. This commit

[FFmpeg-devel] [PATCH 19/20] avformat/matroskaenc: Fix edge case of writing Cues at the beginning

2019-12-31 Thread Andreas Rheinhardt
The Matroska muxer has the ability to write the Cues (the index) at the beginning of the file (in front of the Cluster): The user inputs the amount of space that should be reserved at the beginning of the file and if this is sufficient, the Cues will be written there and the part of the reserved

[FFmpeg-devel] [PATCH 15/20] avformat/matroskaenc: Write level 1 elements in one go

2019-12-31 Thread Andreas Rheinhardt
Up until now, writing level 1 elements proceeded as follows: First, the element id was written to the ordinary output AVIOContext and a dynamic buffer was opened for the content of the level 1 element in start_ebml_master_crc32(). Then this buffer was actually used and after it was closed (in

[FFmpeg-devel] [PATCH 06/20] avformat/matroskaenc: Check functions that can fail

2019-12-31 Thread Andreas Rheinhardt
Sometimes it has not been checked whether opening the dynamic buffer for writing Tags fails; this might have led to segfaults. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskaenc.c

[FFmpeg-devel] [PATCH 03/20] avformat/matroskaenc: Remove useless AVIOContext

2019-12-31 Thread Andreas Rheinhardt
Write a few numbers directly via AV_WB32 instead of using an AVIOContext (that is initialized only for this very purpose) to write these numbers at known offsets into a fixed buffer. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 23 ++- 1 file changed, 10

[FFmpeg-devel] [PATCH 05/20] avformat/matroskaenc: Check return value of ff_isom_write_hvcc()

2019-12-31 Thread Andreas Rheinhardt
The Matroska muxer currently does not check the return value of ff_isom_write_hvcc(), the function used to write mp4-style HEVC-extradata as Matroska also uses it. This was intentionally done in 7a5356c72 to allow remuxing from mpeg-ts. But if ff_isom_write_hvcc() fails, it has not output

[FFmpeg-devel] [PATCH 04/20] avformat/matroskaenc: Adapt documentation of put_ebml_num

2019-12-31 Thread Andreas Rheinhardt
to its actual behaviour: That it uses the least amount of bytes unless overridden. The current documentation leaves it undefined how many bytes will be used when no number to use has been given explicitly. But several estimates (used to write EBML Master elements with a small length field)

[FFmpeg-devel] [PATCH 02/20] avformat/matroskaenc: Improve writing Projection

2019-12-31 Thread Andreas Rheinhardt
The Matroska Projection master element has such a small maximum length that it can always be written with a length field of length one. So it is unnecessary to first write the element into a dynamic buffer to get the accurate length in order not to waste bytes on the length field. Signed-off-by:

[FFmpeg-devel] [PATCH 01/20] avformat/matroskaenc: Fix ReferenceBlock timestamp

2019-12-31 Thread Andreas Rheinhardt
In order to indicate that the frames in a BlockGroup are not keyframes, one has to add a ReferenceBlock element containing the timestamp of a referenced Block that has already been written. The timestamp ought to be relative to the timestamp of the Block it is attached to. Yet the Matroska muxer

[FFmpeg-devel] [PATCH 20/20] avformat/matroskaenc: Avoid seek when writing Cues at the front

2019-12-31 Thread Andreas Rheinhardt
When the Cues are written in front of the Cluster, the muxer would seek to the beginning (to where the Cues ought to be written) and write the Cues; afterwards it would seek back to the end of the file only to seek to the beginning once again to update several elements there. This commit removes

[FFmpeg-devel] [PATCH 17/20] avformat/matroskaenc: Check that Cluster has been opened

2019-12-31 Thread Andreas Rheinhardt
before setting the field indicating that a Cluster has been opened. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index c0979feb88..d7aa832eb3 100644 ---

[FFmpeg-devel] [PATCH 10/20] avformat/matroskaenc: Avoid unnecessary seek

2019-12-31 Thread Andreas Rheinhardt
When writing the SeekHead (a form of index) at the end of the muxing process, mkv_write_seekhead() would first seek to the position where the SeekHead ought to be written, then write it there and seek back to the original position afterwards. Which means: To the end of the file. Afterwards, a seek

[FFmpeg-devel] [PATCH 16/20] avformat/matroskaenc: Remove unused function parameter

2019-12-31 Thread Andreas Rheinhardt
end_ebml_master_crc32_preliminary() has a MatroskaMuxContext as parameter that isn't used at all. So remove it. Furthermore it doesn't close its dynamic buffer; it just uses the underlying buffer and therefore it only needs a pointer to the dynamic buffer, not a pointer to a pointer.

[FFmpeg-devel] [PATCH 11/20] avformat/matroskaenc: Cosmetics

2019-12-31 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 8040c8311c..6dd731eb90 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@

[FFmpeg-devel] [PATCH V1 04/12] lavc/libvpxenc: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/libvpxenc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 05/12] lavc/libx264: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/libx264.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 03/12] lavc/librav1e: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/librav1e.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 08/12] lavfi/coreimage: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavfilter/vf_coreimage.m |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 12/12] tools/aviocat: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- tools/aviocat.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/aviocat.c

[FFmpeg-devel] [PATCH V1] lavfi/buffersrc: Remove redundancy free after ff_filter_frame fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao ff_filter_frame always free the frame in case of error, so we don't need to free the frame after ff_filter_frame fail. Signed-off-by: Jun Zhao --- libavfilter/buffersrc.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/libavfilter/buffersrc.c

[FFmpeg-devel] [PATCH V1 07/12] lavc/libxavs2: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/libxavs2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 10/12] lavf/hlsenc: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavformat/hlsenc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 11/12] libavutil/opt: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavutil/opt.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 06/12] lavc/libx265: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/libx265.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 09/12] lavf/dashenc: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavformat/dashenc.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 02/12] lavc/libkvazaar: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[FFmpeg-devel] [PATCH V1 01/12] lavc/bsf: fix memory leak after av_dict_parse_string fail

2019-12-31 Thread Jun Zhao
From: Jun Zhao In case of failure, all the successfully set entries are stored in *pm. We need to manually free the created dictionary to avoid memory leak. Signed-off-by: Jun Zhao --- libavcodec/bsf.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/bsf.c

[FFmpeg-devel] [PATCH v2 3/5] avfilter/scale: separate exprs parse and eval

2019-12-31 Thread Gyan Doshi
Retains parsed expressions which allows for better error-checking and adding animation support. --- First version was rebased incorrectly in scale_eval_dimensions libavfilter/scale_eval.c | 69 +- libavfilter/vf_scale.c | 264 +++ 2 files changed,

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-12-31 Thread William Martin
I doesn't look like there are any blockers on this patch request - could someone go ahead and merge it? On Sat, Sep 28, 2019 at 2:55 AM Reino Wijnsma wrote: > On 2019-09-27T19:37:40+0200, William Martin > wrote: > > On Wed, Sep 25, 2019 at 2:36 PM Reino Wijnsma > wrote: > >> On

Re: [FFmpeg-devel] [PATCHv2 8/8] avformat/img2enc: add support for specifying protocol options

2019-12-31 Thread Michael Niedermayer
On Tue, Dec 31, 2019 at 12:37:02PM +0100, Nicolas George wrote: > Marton Balint (12019-12-28): > > v2: simplified example > > > > Signed-off-by: Marton Balint > > --- > > doc/muxers.texi | 11 +++ > > libavformat/img2enc.c | 13 - > > 2 files changed, 23 insertions(+),