Re: [FFmpeg-devel] [PATCH] avutil/log: Add av_log_once() for printing a message just once with a high log level

2020-02-12 Thread Michael Niedermayer
On Sun, Feb 02, 2020 at 11:49:56AM +0100, Michael Niedermayer wrote: > Compared to ad-hoc if(printed) ... code this allows the user to disable > it by adjusting the log level > > TODO: APIChanges & version bump will add and will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730B

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-12 Thread Paul B Mahol
On 2/12/20, Asaf Kave wrote: > On Sun, Feb 9, 2020 at 10:59 AM Asaf Kave wrote: > >> >> >> On Thu, Feb 6, 2020 at 4:10 PM Lynne wrote: >> >>> Feb 6, 2020, 11:17 by kavea...@gmail.com: >>> >>> > On Sun, Feb 2, 2020 at 11:15 AM Asaf Kave wrote: >>> > >>> >> >>> >> >>> >> On Tue, Jan 28, 2020 at 1

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/apedec: Fix invalid shift with 24 bps

2020-02-12 Thread Paul B Mahol
LGTM On 2/11/20, Michael Niedermayer wrote: > Fixes: left shift of negative value -463 > Fixes: > 20542/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5688714435231744 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

[FFmpeg-devel] Getting Started On ffmpeg development

2020-02-12 Thread Goutham Kancherla
Greetings, I have just begun to explore the code-base of ffmpeg repository found on https://github.com/FFmpeg/FFmpeg I hope that I have accessed the correct and official repository. I have searched for the code documentation i.e, the architecture and flow of the development.But, my efforts have b

Re: [FFmpeg-devel] Getting Started On ffmpeg development

2020-02-12 Thread James Almer
On 2/12/2020 9:02 AM, Goutham Kancherla wrote: > Greetings, > I have just begun to explore the code-base of ffmpeg repository found on > > https://github.com/FFmpeg/FFmpeg > > I hope that I have accessed the correct and official repository. > I have searched for the code documentation i.e, the ar

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-12 Thread Asaf Kave
On Wed, Feb 12, 2020 at 11:35 AM Paul B Mahol wrote: > On 2/12/20, Asaf Kave wrote: > > On Sun, Feb 9, 2020 at 10:59 AM Asaf Kave wrote: > > > >> > >> > >> On Thu, Feb 6, 2020 at 4:10 PM Lynne wrote: > >> > >>> Feb 6, 2020, 11:17 by kavea...@gmail.com: > >>> > >>> > On Sun, Feb 2, 2020 at 11:1

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-12 Thread Paul B Mahol
On 2/12/20, Asaf Kave wrote: > On Wed, Feb 12, 2020 at 11:35 AM Paul B Mahol wrote: > >> On 2/12/20, Asaf Kave wrote: >> > On Sun, Feb 9, 2020 at 10:59 AM Asaf Kave wrote: >> > >> >> >> >> >> >> On Thu, Feb 6, 2020 at 4:10 PM Lynne wrote: >> >> >> >>> Feb 6, 2020, 11:17 by kavea...@gmail.com:

[FFmpeg-devel] [PATCH 1/3] avcodec/avpacket: Always treat dst in av_packet_ref as uninitialized

2020-02-12 Thread Andreas Rheinhardt
av_packet_ref() mostly treated the destination packet dst as uninitialized, i.e. the destination fields were simply overwritten. But if the source packet was not reference-counted, dst->buf was treated as if it pointed to an already allocated buffer (if != NULL) to be reallocated to the desired siz

[FFmpeg-devel] [PATCH 3/3] avcodec/avpacket: Don't write into non-writable buffer

2020-02-12 Thread Andreas Rheinhardt
The data of an AVPacket may be a part of the data of an AVBufferRef; Therefore av_grow_packet() doesn't reallocate if the available space in the actual buffer is sufficient for the enlargement. But given that it also zeroes the padding it also needs to make sure that the buffer is actually writable

[FFmpeg-devel] [PATCH 2/3] ffplay, avcodec, avformat: Don't initialize before av_packet_ref()

2020-02-12 Thread Andreas Rheinhardt
It already initializes the packet. Signed-off-by: Andreas Rheinhardt --- fftools/ffplay.c | 2 +- libavcodec/cuviddec.c | 2 +- libavcodec/qsvdec_h2645.c | 2 +- libavcodec/qsvdec_other.c | 2 +- libavformat/fifo.c| 1 - libavformat/img2enc.c | 8 libavformat/te

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/avpacket: Don't write into non-writable buffer

2020-02-12 Thread Andreas Rheinhardt
On Wed, Feb 12, 2020 at 4:31 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > But given that it > also zeroes the padding it also needs to make sure that the buffer is > actually writable; this commit implements this. > av_shrink_packet has a similar issue and it seems unfixable giv

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/avpacket: Don't write into non-writable buffer

2020-02-12 Thread James Almer
On 2/12/2020 12:44 PM, Andreas Rheinhardt wrote: > On Wed, Feb 12, 2020 at 4:31 PM Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > >> But given that it >> also zeroes the padding it also needs to make sure that the buffer is >> actually writable; this commit implements this. >> > >

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/avcodec: Nits

2020-02-12 Thread Andreas Rheinhardt
On Tue, Dec 10, 2019 at 11:00 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/avcodec.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h > index 735a3c2d7

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/apedec: Fix invalid shift with 24 bps

2020-02-12 Thread Michael Niedermayer
On Wed, Feb 12, 2020 at 10:41:21AM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 2 "100% positive feedback" - "All either got their money back or didnt complain" "Best seller ever

Re: [FFmpeg-devel] [PATCH 1/6] avformat/format: add av_demuxer_find_by_ext

2020-02-12 Thread Gyan Doshi
On 01-02-2020 10:45 am, Gyan Doshi wrote: On 31-01-2020 10:41 pm, Andreas Rheinhardt wrote: Gyan Doshi: Allows selecting demuxer by extension which are more widely recognized by users. Conditional cast added since this function will usually be called after av_find_input_format, and so matc

[FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-12 Thread gautamramk
From: Gautam Ramakrishnan This commit fixes bug #8466 wherein URLs with query string not preceeded by the '/' symbol in a URL was failing to get parsed. The av_url_split() function now checks if the path starts with a '/' and prepends it if it does not. --- libavformat/utils.c | 7 +++ 1 fil

Re: [FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-12 Thread Paul B Mahol
On 2/12/20, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This commit fixes bug #8466 wherein URLs with query string > not preceeded by the '/' symbol in a URL was failing to get > parsed. The av_url_split() function now checks if the path > starts with a '/' and prepends it if it d

Re: [FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-12 Thread Marton Balint
On Wed, 12 Feb 2020, gautamr...@gmail.com wrote: From: Gautam Ramakrishnan This commit fixes bug #8466 wherein URLs with query string not preceeded by the '/' symbol in a URL was failing to get parsed. The av_url_split() function now checks if the path starts with a '/' and prepends it if it

Re: [FFmpeg-devel] [avfomat/rtp: source ips lost when specified as URL options] Patch for ffmpeg using rtp protocol where sources option is not retained

2020-02-12 Thread Ross Nicholson
The patch was created as a workaround to an issue from in kodi (apologies, it's a rather long thread): https://forum.kodi.tv/showthread.php?tid=350901&pid=2923550#pid2923550 As an example, here is a URL: rtp://87.141.215.251@232.0.10.234:1 Taking this URL we should be able to either reformat

[FFmpeg-devel] [avfomat/rtp: source ips lost when specified as URL options] Patch for ffmpeg using rtp protocol where sources option is not retained

2020-02-12 Thread phunkyfish
--- libavformat/rtsp.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 859defa592..f922055134 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -2334,7 +2334,9 @@ static int sdp_read_header(AVFo

[FFmpeg-devel] [PATCH] avcodec: add cdtoons decoder

2020-02-12 Thread Paul B Mahol
From: Alyssa Milburn This adds a decoder for Broderbund's sprite-based QuickTime CDToons codec, based on the decoder I wrote for ScummVM. Signed-off-by: Alyssa Milburn Signed-off-by: Paul B Mahol --- doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c |

Re: [FFmpeg-devel] [PATCH] avcodec: add cdtoons decoder

2020-02-12 Thread Carl Eugen Hoyos
Am Mi., 12. Feb. 2020 um 20:50 Uhr schrieb Paul B Mahol : > +c->pal[i] = (0xff << 24) | (r << 16) | (g << 8) | (b); Should be "0xffu" iirc, and we usually have less parentheses. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@

[FFmpeg-devel] [PATCH 2/2] avcodec/adpcm: Fix integer overflow in ADPCM THP

2020-02-12 Thread Michael Niedermayer
The reference (thp.txt) uses floats so wrap around would seem incorrect. Fixes: signed integer overflow: 1073741824 + 1073741824 cannot be represented in type 'int' Fixes: 20658/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_THP_fuzzer-5646302555930624 Found-by: continuous fuzzing proc

[FFmpeg-devel] [PATCH 1/2] avcodec/midivid: Check dimensions to be the multiple assumed by the implementation

2020-02-12 Thread Michael Niedermayer
Fixes: out of array access Fixes: 20626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVDV_fuzzer-6279905350516736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/midivid.c | 3 +++ 1 file

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/midivid: Check dimensions to be the multiple assumed by the implementation

2020-02-12 Thread Paul B Mahol
This is incorrect. On 2/12/20, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 20626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVDV_fuzzer-6279905350516736 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/midivid: Check dimensions to be the multiple assumed by the implementation

2020-02-12 Thread Reino Wijnsma
On 2020-02-12T23:17:09+0100, Paul B Mahol wrote: > This is incorrect. > > On 2/12/20, Michael Niedermayer wrote: >> Fixes: out of array access >> Fixes: >> 20626/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVDV_fuzzer-6279905350516736 >> >> Found-by: continuous fuzzing process >> https://gi

[FFmpeg-devel] [PATCH v2] avcodec/h264_ps: Return error if pps has FMO parameters

2020-02-12 Thread Andriy Gelman
From: Andriy Gelman FMO is not supported and fields related to FMO are not parsed, meaning that any fields which follow will be corrupt. --- libavcodec/h264_ps.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index d36921e47bf..

[FFmpeg-devel] [PATCH 1/1] ffmpeg: gnutls: ignore TLS rehandshake requests

2020-02-12 Thread Tristan Matthews
Log a warning instead of terminating. TLS does not explicitly require that the client initiate the handshake when requested by the server, it can be ignored (although the server is free to break the connection if no handshake is forthcoming). https://www.gnutls.org/manual/html_node/Core-TLS-API.h

Re: [FFmpeg-devel] [PATCH] avcodec/h264_pc: Return error if pps has FMO parameters

2020-02-12 Thread Andriy Gelman
On Sat, 08. Feb 21:30, James Almer wrote: > On 2/8/2020 7:20 PM, Andriy Gelman wrote: > > From: Andriy Gelman > > > > FMO is not supported and fields related to FMO are not parsed, meaning > > that any fields which follow will be corrupt. > > --- > > libavcodec/h264_ps.c | 2 ++ > > 1 file chang

Re: [FFmpeg-devel] [PATCH 2/3] fftools/ffmpeg: Integrate two checks

2020-02-12 Thread Michael Niedermayer
On Sat, Oct 12, 2019 at 05:18:39AM +0200, Andreas Rheinhardt wrote: > For audio packets with dts != AV_NOPTS_VALUEs the dts was converted > twice to the muxer's timebase during streamcopy, once as a normal > packet and once specifically as an audio packet. This has been changed. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 11/11] avcodec/avcodec: Nits

2020-02-12 Thread Michael Niedermayer
On Tue, Dec 10, 2019 at 10:59:55PM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/avcodec.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB D

[FFmpeg-devel] [PATCH] MAINTAINERS: Add myself as libzmq maintainer

2020-02-12 Thread Andriy Gelman
From: Andriy Gelman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5244d9237a9..55e2b385b5a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -507,6 +507,7 @@ Protocols: ftp.c Lukasz Marek http.c

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_ps: Return error if pps has FMO parameters

2020-02-12 Thread James Almer
On 2/12/2020 8:36 PM, Andriy Gelman wrote: > From: Andriy Gelman > > FMO is not supported and fields related to FMO are not parsed, meaning > that any fields which follow will be corrupt. > --- > libavcodec/h264_ps.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/li

Re: [FFmpeg-devel] [PATCH] libavformat/utils.c: Fixed URL parsing

2020-02-12 Thread Gautam Ramakrishnan
On Thu, Feb 13, 2020 at 12:31 AM Marton Balint wrote: > > > > On Wed, 12 Feb 2020, gautamr...@gmail.com wrote: > > > From: Gautam Ramakrishnan > > > > This commit fixes bug #8466 wherein URLs with query string > > not preceeded by the '/' symbol in a URL was failing to get > > parsed. The av_url_

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: add missing value constrains to point_y_value, point_cb_value and point_cr_value

2020-02-12 Thread James Almer
If i is greater than 0, it is a requirement of bitstream conformance that point_y_value[ i ] is greater than point_y_value[ i - 1 ]. If i is greater than 0, it is a requirement of bitstream conformance that point_cb_value[ i ] is greater than point_cb_value[ i - 1 ]. If i is greater than 0, it is

[FFmpeg-devel] Getting Started :: Need for render API

2020-02-12 Thread Goutham Kancherla
Greetings! I have been going through the repos and find that there are dependencies on VULAKN and other render API's , my question is what is the need? isnt ffmpeg a command line tool? Pardon me for asking such a naive question cheers ___ ffmpeg-devel mai

[FFmpeg-devel] [PATCH] compat/os2threads:define INCL_DOSERRORS

2020-02-12 Thread Dave Yeo
From 6182a7f6b83905fb2315b416ae714a329ec2d0df Mon Sep 17 00:00:00 2001 From: Dave Yeo Date: Wed, 12 Feb 2020 20:13:00 -0800 Subject: [PATCH] compat/os2threads:define INCL_DOSERRORS This is needed to pull in the define for ERROR_TIMEOUT Signed-off-by: Dave Yeo --- compat/os2threads.h | 1 + 1

[FFmpeg-devel] [Getting Started]

2020-02-12 Thread Goutham Kancherla
Greetings There are 3 binaries at the end ffmpeg , play ,probe where is the main for each one Just Getting Started , pardon the naive question Cheers ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel T

Re: [FFmpeg-devel] [Getting Started]

2020-02-12 Thread Andreas Rheinhardt
On Thu, Feb 13, 2020 at 6:23 AM Goutham Kancherla < kancherlagout...@gmail.com> wrote: > Greetings > There are 3 binaries at the end > ffmpeg , play ,probe > where is the main for each one > Just Getting Started , pardon the naive question > Cheers The binaries are in the fftools/ folder and the