Re: [FFmpeg-devel] [PATCH 2/2] fate/truehd: add a test for the truehd_core bitstream filter

2020-04-20 Thread James Almer
On 4/19/2020 4:01 PM, James Almer wrote: > On 4/19/2020 2:57 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 4/19/2020 2:45 PM, Andreas Rheinhardt wrote: James Almer: > Signed-off-by: James Almer > --- > tests/fate/truehd.mak | 5 + > 1 file changed, 5 insertions(+)

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: don't print warning for DVB text streams

2020-04-20 Thread Gyan Doshi
They can be demuxed by ffmpeg. --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index ccb631d746..3818001976 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -381,6 +381,10 @@ static int

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add an automatic timescale computation

2020-04-20 Thread Kevin Wheatley
Activated when the -mov_timescale command line/MOVMuxContext parameter is set to 0 or less. If the user passes any value greater than 0, then it will be used as-is. The default value is kept unchanged at 1000. When active, it uses the base assumption from the QuickTime specification of 600 and

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: Pass ret from decode_iccp_chunk()

2020-04-20 Thread Michael Niedermayer
On Mon, Apr 20, 2020 at 03:04:35PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-04-18 01:48:47) > > Found while reviewing a patch fixing a similar issue > > > > Signed-off-by: Michael Niedermayer > > --- > > Looks ok will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Don't free uninitialized AVBPrint

2020-04-20 Thread Andreas Rheinhardt
Marton Balint: > > > On Mon, 20 Apr 2020, Andreas Rheinhardt wrote: > >> Fixes Coverity ID 1462307. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> I intend to apply this soon if there are no objections. >> >> libavformat/rtsp.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Put strings instead of pointers to strings into array

2020-04-20 Thread Andreas Rheinhardt
Marton Balint: > > > On Mon, 20 Apr 2020, Andreas Rheinhardt wrote: > >> In this example, the difference in length between the shortest and >> longest string is three, so that not using pointers to strings saves >> space even on 32bit systems. >> >> Moreover, there is no need to use a sentinel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_ima_{apc, ssi, oki}: replace while() with for()

2020-04-20 Thread Michael Niedermayer
On Sat, Apr 18, 2020 at 12:59:25AM +, Zane van Iperen wrote: > Per discussion at > https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260854.html > > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) will apply thx

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/jpeg2000dec.c: Support for CRG marker

2020-04-20 Thread Gautam Ramakrishnan
On Tue, Apr 21, 2020 at 1:12 AM Carl Eugen Hoyos wrote: > > Am Mo., 20. Apr. 2020 um 21:38 Uhr schrieb : > > > > From: Gautam Ramakrishnan > > > > This patch adds support for CRG marker. Allows > > samples such as p0_03.j2k to be decoded. > > The patch indicates to me that it adds support for >

Re: [FFmpeg-devel] [PATCH v2 4/4] avformat/mpegtsenc: use the correct stream_types and write HDMV descriptors for m2ts

2020-04-20 Thread Marton Balint
On Thu, 16 Apr 2020, Carl Eugen Hoyos wrote: Am Mo., 13. Apr. 2020 um 02:17 Uhr schrieb Marton Balint : On Mon, 13 Apr 2020, Carl Eugen Hoyos wrote: > Am Mo., 13. Apr. 2020 um 00:38 Uhr schrieb Marton Balint : >> >> Fixes ticket #2622. >> >> Signed-off-by: Marton Balint >> --- >>

[FFmpeg-devel] [PATCH 2/3] avformat/movenc: Use base container timescale, instead of hard coded default

2020-04-20 Thread Kevin Wheatley
Signed-off-by: Kevin Wheatley --- libavformat/movenc.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7d79eca..508fa73 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -2879,7 +2879,7

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/adpcm: update get_nb_samples() doc

2020-04-20 Thread Michael Niedermayer
On Sat, Apr 18, 2020 at 12:59:33AM +, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill

[FFmpeg-devel] [PATCH 2/2] libavcodec/jpeg2000dec.c: ROI marker support

2020-04-20 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for decoding images with a Region of Interest. Allows decoding samples such as p0_03.j2k. This patch should fix ticket #4681. --- libavcodec/jpeg2000.h| 1 + libavcodec/jpeg2000dec.c | 57 +++- 2 files

Re: [FFmpeg-devel] [PATCH] avformat/utils: Fix memleak when decoding subtitle in find_stream_info

2020-04-20 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-04-18 21:54:26) >> avformat_find_stream_info() may decode some frames to get stream >> information. And when it does this for subtitles, the decoded subtitles >> leak. >> >> (Decoding subtitles was added in b1511e00f6fefde6cb31b2e17f7812cfac1c8bd6

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: Use macro for "packet is empty"

2020-04-20 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2020-04-19 21:22:52) >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/bsf.c | 13 ++--- >> 1 file changed, 6 insertions(+), 7 deletions(-) >> > > Good idea > Applied, thanks. - Andreas

[FFmpeg-devel] [PATCH] libavcodec/dnxhddata.c: Fix quantization weights for id 1271

2020-04-20 Thread Neil Birkbeck
From the ST 2019-1:2016 standard, https://ieeexplore.ieee.org/abstract/document/7513364 in Table D.1, compression ID 1235, 1271 use the same weights. This fixes what looks like a slight sharpening when decoding samples encoded as DNxHR HQX 10- or 12-bit from other encoders (e.g., like from

Re: [FFmpeg-devel] [PATCH] lavf/tls_gnutls: check for interrupt inside handshake loop

2020-04-20 Thread Jan Ekström
On Thu, Sep 5, 2019 at 6:13 PM Michael Niedermayer wrote: > > On Fri, Aug 16, 2019 at 10:38:46AM +0200, Błażej Szczygieł wrote: > > fixes #8080 > > > > Signed-off-by: Błażej Szczygieł > > --- > > libavformat/tls_gnutls.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] gas-preprocessor: Fix use of Visual Studio compiler values -w... or -FS

2020-04-20 Thread Martin Storsjö
On Mon, 20 Apr 2020, Martin Storsjö wrote: On Mon, 20 Apr 2020, phunkyfish wrote: From: Alwin Esch --- gas-preprocessor.pl | 4 1 file changed, 4 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 860b97c..126ee50 100755 --- a/gas-preprocessor.pl +++

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/jpeg2000dec.c: Support for CRG marker

2020-04-20 Thread Carl Eugen Hoyos
Am Mo., 20. Apr. 2020 um 21:38 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch adds support for CRG marker. Allows > samples such as p0_03.j2k to be decoded. The patch indicates to me that it adds support for skipping the CRG marker: Am I wrong? Carl Eugen

Re: [FFmpeg-devel] [PATCH] avformat/oggenc: Don't free AVStream's priv_data, fix memleak

2020-04-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Andreas Rheinhardt: >> For FLAC, Speed, Opus and VP8 the Ogg muxer allocates two buffers >> for building the headers: The first for extradata in an Ogg-specific >> format and the second contains a Vorbiscomment. These buffers are >> reachable via pointers in the corresponding

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe

2020-04-20 Thread James Almer
On 4/20/2020 1:28 PM, Anton Khirnov wrote: > Quoting James Almer (2020-04-20 15:39:19) >> On 4/20/2020 10:30 AM, Anton Khirnov wrote: >>> Quoting James Almer (2020-04-17 05:10:08) Signed-off-by: James Almer --- libavcodec/qpeg.c | 1 + 1 file changed, 1 insertion(+) >>> >>>

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe

2020-04-20 Thread Anton Khirnov
Quoting James Almer (2020-04-20 15:39:19) > On 4/20/2020 10:30 AM, Anton Khirnov wrote: > > Quoting James Almer (2020-04-17 05:10:08) > >> Signed-off-by: James Almer > >> --- > >> libavcodec/qpeg.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > Looks good. > > Could have INIT_CLEANUP too,

[FFmpeg-devel] [PATCH v3 0/3] avformat/movenc: Support for variable timescale in mov containers

2020-04-20 Thread Kevin Wheatley
v3 - rebased to current master This set of patches work together to facilitate user specified timescales for the Movie Header Atom 'mvhd', which allows constant sample table durations for all frame rates. Currently there is a fixed timescale of 1000, which is not an even multiple of all the

[FFmpeg-devel] [PATCH 1/3] avformat/movenc: Add command line option to set base mov file timescale

2020-04-20 Thread Kevin Wheatley
Signed-off-by: Kevin Wheatley --- libavformat/movenc.c | 1 + libavformat/movenc.h | 1 + 2 files changed, 2 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 253cff8..7d79eca 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -91,6 +91,7 @@ static const

[FFmpeg-devel] [PATCH 1/2] libavcodec/jpeg2000dec.c: Support for CRG marker

2020-04-20 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for CRG marker. Allows samples such as p0_03.j2k to be decoded. --- libavcodec/jpeg2000dec.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index af6dcee228..5a7d9e7882

Re: [FFmpeg-devel] [PATCH 6/6] dnn-layer-mathbinary-test: add unit test for divide

2020-04-20 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Guo, Yejun > Sent: Thursday, April 16, 2020 8:53 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 6/6] dnn-layer-mathbinary-test: add unit > test for divide > > > > >

Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: Remove write-only variable

2020-04-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/webvttdec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/webvttdec.c b/libavformat/webvttdec.c > index 52579c5ed2..6c4d5f6736 100644 > --- a/libavformat/webvttdec.c > +++

Re: [FFmpeg-devel] [PATCH] avformat/r3d: Remove write-only array

2020-04-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/r3d.c | 20 +++- > 1 file changed, 3 insertions(+), 17 deletions(-) > > diff --git a/libavformat/r3d.c b/libavformat/r3d.c > index 224bcf780d..7aa0c5a2c3 100644 > --- a/libavformat/r3d.c > +++

Re: [FFmpeg-devel] [PATCH] libavcodec/avpacket: Don't simply forward return value of av_dict_set()

2020-04-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The documentation of av_dict_set() states that values >= 0 indicate > success, whereas av_packet_unpack_dictionary() implies that return > values > 0 are impossible. So only forward the return value of > av_dict_set() in av_packet_unpack_dictionary() on error. > > (Btw:

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h265_syntax_template: Limit num_long_term_pics more strictly

2020-04-20 Thread James Almer
On 4/20/2020 7:03 PM, Michael Niedermayer wrote: > The limit is based on hevcdec.c > Fixes: > 20854/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_METADATA_fuzzer-5160442882424832 > Fixes: out of array access > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/jpeg2000dec.c: ROI marker support

2020-04-20 Thread Carl Eugen Hoyos
Am Mo., 20. Apr. 2020 um 21:38 Uhr schrieb : > > From: Gautam Ramakrishnan > > This patch adds support for decoding images > with a Region of Interest. Allows decoding > samples such as p0_03.j2k. This patch should > fix ticket #4681. The following inlined poc makes FFmpeg's output for this

Re: [FFmpeg-devel] [RFC PATCH v2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-20 Thread Michael Niedermayer
On Mon, Apr 20, 2020 at 04:13:44PM +0530, Gautam Ramakrishnan wrote: > On Mon, Apr 20, 2020 at 3:38 PM Michael Niedermayer > wrote: > > > > On Mon, Apr 20, 2020 at 01:36:47AM +0530, gautamr...@gmail.com wrote: > > > From: Gautam Ramakrishnan > > > > > > I have attempted to write a JPEG2000

[FFmpeg-devel] [PATCH 3/4] avcodec/cbs_h265: move the payload_extension_present check into its own function

2020-04-20 Thread James Almer
Will be reused in the following patch. Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 9 + libavcodec/cbs_h265_syntax_template.c | 8 +++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index

[FFmpeg-devel] [PATCH 4/4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-04-20 Thread James Almer
Fixes ticket #8622 Signed-off-by: James Almer --- It fixes it assuming the Picture Timing in that sample is not being misparsed by cbs_h265. We're compliant with the latest revision of the spec, so any reserved_payload_extension_data found in a sample created today is almost guaranteed to be

[FFmpeg-devel] [PATCH 2/4] avcodec/cbs_h265: rename H265RawPSExtensionData to H265RawExtensionData

2020-04-20 Thread James Almer
So that NAL types other than Parameter Set ones may use it. Signed-off-by: James Almer --- libavcodec/cbs_h265.h | 10 +- libavcodec/cbs_h265_syntax_template.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/cbs_h265.h

[FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h265: fix writing extension_data bits

2020-04-20 Thread James Almer
We only care about the right most bit. Signed-off-by: James Almer --- Fixes handling files like https://trac.ffmpeg.org/attachment/ticket/7965/puppets_with_alpha_hevc.mov Without this patch, parsing works but passing the VPS through hevc_metadata_bsf when writing fails.

[FFmpeg-devel] [PATCH 1/3] avcodec/iff: Fix invalid pointer intermediates in decode_deep_rle32()

2020-04-20 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index acd6519b06..2e65e266d0 100644 --- a/libavcodec/iff.c +++ b/libavcodec/iff.c @@ -715,7 +715,7 @@ static void

[FFmpeg-devel] [PATCH 3/3] avcodec/cbs_h265_syntax_template: Limit num_long_term_pics more strictly

2020-04-20 Thread Michael Niedermayer
The limit is based on hevcdec.c Fixes: 20854/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_METADATA_fuzzer-5160442882424832 Fixes: out of array access Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check length before memcpy() in decode_deep_rle32()

2020-04-20 Thread Michael Niedermayer
Fixes: out of array read Fixes: 20796/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5111364702175232.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 2 ++ 1

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-20 Thread myp...@gmail.com
On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07) > > I'd like to ask opinions whether a installed header for just one structure > > is a good idea. > > I see no problem with it. More smaller headers is better that a few big > headers. > >

Re: [FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: fix the infinite loop while framerate lower than input

2020-04-20 Thread Fu, Linjie
> From: Zhong Li > Sent: Sunday, April 19, 2020 23:00 > To: Fu, Linjie > Cc: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavfi/vf_vpp_qsv: fix the infinite loop > while framerate lower than input > > Fu, Linjie 于2020年2月29日周六 下午5:35写道: > >

[FFmpeg-devel] [PATCH v2 1/4] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-04-20 Thread lance . lmwang
From: Limin Wang For better code review, the patch is helping to update the fate tests result so the change of ffmpeg.c willbe deleted in the last patch. Signed-off-by: Limin Wang --- fftools/ffmpeg.c | 1 + tests/ref/fate/binsub-movtextenc | 2 +- tests/ref/fate/sub2video

[FFmpeg-devel] [PATCH 1/8] avformat/utils: Remove superfluous headers

2020-04-20 Thread Andreas Rheinhardt
stdarg.h has been included in 780d7897a9c9295b43f1f0e9b49a11f99cd402c3 for ff_url_join(). This header became unnecessary when this function was moved into a separate file in df9f22d42b0905385629a9d368bb5a1eef2b45ef. libavutil/pixdesc.h has been included for av_get_pix_fmt_name() in

[FFmpeg-devel] [PATCH 7/8] avcodec/noise_bsf: Remove unnecessary headers

2020-04-20 Thread Andreas Rheinhardt
With 33d18982fa03feb061c8f744a4f0a9175c1f63ab, the commit introducing the new packet-based bsf API, a new buffer was no longer allocated directly, but via av_new_packet(), so that libavutil/mem.h was no longer needed. Moreover since commit dc99ee6b08e54de13b4c82ff265609b6ab83e3d8

[FFmpeg-devel] [PATCH 6/8] avcodec/dump_extradata_bsf: Remove unnecessary header

2020-04-20 Thread Andreas Rheinhardt
Since 33d18982fa03feb061c8f744a4f0a9175c1f63ab (the commit that introduced the new bsf API) allocating an enlarged buffer in case extradata needs to be added to a packet is done via av_new_packet(), so that libavutil/mem.h is no longer needed. Furthermore, remove libavutil/log.h. This function

[FFmpeg-devel] [PATCH 2/8] avformat/mux: Remove unnecessary headers

2020-04-20 Thread Andreas Rheinhardt
mux.c was split from utils.c in 55f9037f38bc3beacb2f5a17408c1d24c077d7fd and during this split all headers were simply copied without checking if they were only needed in the part that stayed in utils.c (or whether these haeders were needed at all). As a result quite a lot of headers in mux.c are

[FFmpeg-devel] [PATCH 5/8] avcodec/dca_core_bsf: Remove unnecessary header

2020-04-20 Thread Andreas Rheinhardt
This bsf never needed libavutil/mem.h. Signed-off-by: Andreas Rheinhardt --- libavcodec/dca_core_bsf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/dca_core_bsf.c b/libavcodec/dca_core_bsf.c index 8565796951..f0c5039e30 100644 --- a/libavcodec/dca_core_bsf.c +++

[FFmpeg-devel] [PATCH 4/8] avcodec/chomp_bsf: Remove unnecessary header

2020-04-20 Thread Andreas Rheinhardt
This bsf never needed internal.h. Signed-off-by: Andreas Rheinhardt --- libavcodec/chomp_bsf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/chomp_bsf.c b/libavcodec/chomp_bsf.c index 3ba45f3e06..9b06ace0a4 100644 --- a/libavcodec/chomp_bsf.c +++ b/libavcodec/chomp_bsf.c @@

[FFmpeg-devel] [PATCH 3/8] avcodec/vp9_raw_reorder_bsf: Remove unnecessary header

2020-04-20 Thread Andreas Rheinhardt
This bsf doesn't have any options, so including libavutil/opt.h is unnecessary. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp9_raw_reorder_bsf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/vp9_raw_reorder_bsf.c b/libavcodec/vp9_raw_reorder_bsf.c index

[FFmpeg-devel] [PATCH 8/8] avcodec/mjpeg2jpeg_bsf: Remove unnecessary header

2020-04-20 Thread Andreas Rheinhardt
libavutil/mem.h is unneeded since 33d18982fa03feb061c8f744a4f0a9175c1f63ab, the commit that introduced the new packet-based bsf API, because with this switch the allocations were no longer performed directly, but by av_new_packet(). Signed-off-by: Andreas Rheinhardt ---

[FFmpeg-devel] [PATCH v2 3/4] avformat/utils: move is_intra_only() to header and rename to ff_is_intra_only()

2020-04-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/internal.h | 2 ++ libavformat/utils.c| 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 329b2e972d..716e42cc3e 100644 --- a/libavformat/internal.h +++

[FFmpeg-devel] [PATCH v2 4/4] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-04-20 Thread lance . lmwang
From: Limin Wang delete the previous change of ffmpeg.c and movenc.c as mux.c will be in charge of setting AV_PKT_FLAG_KEY. Signed-off-by: Limin Wang --- fftools/ffmpeg.c | 1 - libavformat/internal.h | 2 ++ libavformat/mux.c | 7 ++- libavformat/tests/movenc.c | 1

[FFmpeg-devel] [PATCH v2 2/4] avformat/tests/movenc: set AV_PKT_FLAG_KEY for audio packet

2020-04-20 Thread lance . lmwang
From: Limin Wang For better code review, the patch is helping to update the fate tests result so the change of movenc.c will be deleted in the last patch. Signed-off-by: Limin Wang --- libavformat/tests/movenc.c | 1 + tests/ref/fate/movenc | 50 +++--- 2

[FFmpeg-devel] [PATCH v2 1/4] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

2020-04-20 Thread lance . lmwang
From: Limin Wang For better code review, the patch is helping to update the fate tests result so the change of ffmpeg.c will be deleted in the last patch. Signed-off-by: Limin Wang --- fftools/ffmpeg.c | 1 + tests/ref/fate/binsub-movtextenc | 2 +- tests/ref/fate/sub2video

Re: [FFmpeg-devel] OpenColorIO - Google Summer of Code

2020-04-20 Thread Vittorio Giovara
On Mon, Apr 20, 2020 at 10:09 AM Paul B Mahol wrote: > On 4/20/20, Rashil Gandhi wrote: > > Hi, > > > > I figured reading my proposal was too much work so I have a one-line > > question here that I'd like to know the answer to. > > > > Can an FFmpeg video filter access unclamped 32-bit float

Re: [FFmpeg-devel] [PATCH] cmdutils: stop using deprecated av_codec_next()

2020-04-20 Thread Josh de Kock
On 14/04/2020 13:37, Josh de Kock wrote: On Tue, Apr 14, 2020, at 9:09 AM, Anton Khirnov wrote: --- fftools/cmdutils.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) [...] LGTM, thanks. I will apply this a bit later after my set (or you can if

Re: [FFmpeg-devel] [PATCH 3/3] tools: stop using deprecated av_codec_next()

2020-04-20 Thread Josh de Kock
On 14/04/2020 13:38, Josh de Kock wrote: Signed-off-by: Josh de Kock --- tools/enum_options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/enum_options.c b/tools/enum_options.c index 28631d1a6b..548e427b7a 100644 --- a/tools/enum_options.c +++

[FFmpeg-devel] [PATCH v1] lavf/mp3enc: fix ID3v1 year metadata setting issue

2020-04-20 Thread Jun Zhao
From: Jun Zhao Follow the http://id3.org/ID3v1, setting the year metadata for ID3v1. fix #8623 Signed-off-by: Jun Zhao --- libavformat/mp3enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index 34b753f..157174f 100644 ---

[FFmpeg-devel] [PATCH v2] lavf/tls_mbedtls: fix resource leak

2020-04-20 Thread Jun Zhao
From: Jun Zhao fix resource leak in mbedtls part. fix #8614 Signed-off-by: Jun Zhao --- libavformat/tls_mbedtls.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c index 9b80a1e..965adf1 100644 --- a/libavformat/tls_mbedtls.c +++

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-04-20 Thread Nicolas George
Paul B Mahol (12020-04-18): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 96 ++ > libavfilter/filters.h | 17 > 2 files changed, 113 insertions(+) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index

Re: [FFmpeg-devel] [PATCH 12/20] avformat/matroskaenc: Improve Cues in case of no video

2020-04-20 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The Matroska muxer currently only adds CuePoints in three cases: > a) For video keyframes. b) For the first audio frame in a new Cluster if > in DASH-mode. c) For subtitles. This means that ordinary Matroska audio > files won't have any Cues which impedes seeking. > > This

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2020-04-20 Thread Marton Balint
On Mon, 20 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 23:43, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 14:53, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:42, Wolfgang Haupt wrote: Hey, is someone up to

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2020-04-20 Thread Wolfgang Haupt
On 20.04.20 10:08, Marton Balint wrote: On Mon, 20 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 23:43, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 14:53, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:42, Wolfgang

Re: [FFmpeg-devel] [PATCH v1] lavf/tls_mbedtls: fix resource leak

2020-04-20 Thread myp...@gmail.com
On Mon, Apr 20, 2020 at 3:05 PM Andreas Rheinhardt wrote: > > Jun Zhao: > > From: Jun Zhao > > > > fix resource leak in mbedtls part. > > > > fix #8614 > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/tls_mbedtls.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Put strings instead of pointers to strings into array

2020-04-20 Thread Marton Balint
On Mon, 20 Apr 2020, Andreas Rheinhardt wrote: In this example, the difference in length between the shortest and longest string is three, so that not using pointers to strings saves space even on 32bit systems. Moreover, there is no need to use a sentinel here; it can be replaced with

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Don't free uninitialized AVBPrint

2020-04-20 Thread Marton Balint
On Mon, 20 Apr 2020, Andreas Rheinhardt wrote: Fixes Coverity ID 1462307. Signed-off-by: Andreas Rheinhardt --- I intend to apply this soon if there are no objections. libavformat/rtsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtsp.c

Re: [FFmpeg-devel] [PATCH] tests/fate/hlsenc: rename fate macro define from FATE_AFILTER to FATE_HLSENC

2020-04-20 Thread Steven Liu
> 2020年4月15日 下午2:58,Steven Liu 写道: > > and add fate-hlsenc for test all of the testcase > Signed-off-by: Steven Liu > --- > tests/fate/hlsenc.mak | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak > index

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2020-04-20 Thread Wolfgang Haupt
On 19.04.20 23:43, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 14:53, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: ping On 03.04.20 08:42, Wolfgang Haupt wrote: Hey, is someone up to review this patch? It's an attempt to fix rtsp

[FFmpeg-devel] [PATCH v1] lavf/tls_mbedtls: fix resource leak

2020-04-20 Thread Jun Zhao
From: Jun Zhao fix resource leak in mbedtls part. fix #8614 Signed-off-by: Jun Zhao --- libavformat/tls_mbedtls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c index 9b80a1e..eb4b2a0 100644 --- a/libavformat/tls_mbedtls.c +++

Re: [FFmpeg-devel] [PATCH v1] lavf/tls_mbedtls: fix resource leak

2020-04-20 Thread Andreas Rheinhardt
Jun Zhao: > From: Jun Zhao > > fix resource leak in mbedtls part. > > fix #8614 > > Signed-off-by: Jun Zhao > --- > libavformat/tls_mbedtls.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/tls_mbedtls.c b/libavformat/tls_mbedtls.c > index 9b80a1e..eb4b2a0 100644 >

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Don't free uninitialized AVBPrint

2020-04-20 Thread Ross Nicholson
> On 20 Apr 2020, at 08:53, Marton Balint wrote: > >  > >> On Mon, 20 Apr 2020, Andreas Rheinhardt wrote: >> >> Fixes Coverity ID 1462307. >> >> Signed-off-by: Andreas Rheinhardt >> --- >> I intend to apply this soon if there are no objections. >> >> libavformat/rtsp.c | 2 +- >> 1 file

Re: [FFmpeg-devel] [RFC PATCH v2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-20 Thread Michael Niedermayer
On Mon, Apr 20, 2020 at 01:36:47AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > I have attempted to write a JPEG2000 Parser. Need > help on testing the code and some tips on how to to test the code i would sugest to generate a file or files with many jpeg2000 images and

Re: [FFmpeg-devel] [RFC PATCH v2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-20 Thread Gautam Ramakrishnan
On Mon, Apr 20, 2020 at 3:38 PM Michael Niedermayer wrote: > > On Mon, Apr 20, 2020 at 01:36:47AM +0530, gautamr...@gmail.com wrote: > > From: Gautam Ramakrishnan > > > > I have attempted to write a JPEG2000 Parser. Need > > help on testing the code and some tips on how to > > to test the code i

Re: [FFmpeg-devel] [RFC PATCH v2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-20 Thread Kieran O Leary
Hi, Forgive my ignorance ,but what is the difference between a parser and a decoder in this context? What does this parser add that wasn't covered in the decoder? Best, Kieran O'Leary Irish Film Institute ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [RFC PATCH v2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-20 Thread Paul B Mahol
On 4/20/20, Kieran O Leary wrote: > Hi, > > Forgive my ignorance ,but what is the difference between a parser and a > decoder in this context? What does this parser add that wasn't covered in > the decoder? Bunch of stuff, like splitting packets. ___

Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: fix rtsp multicasts

2020-04-20 Thread Wolfgang Haupt
On 20.04.20 10:52, Wolfgang Haupt wrote: On 20.04.20 10:08, Marton Balint wrote: On Mon, 20 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 23:43, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt wrote: On 19.04.20 14:53, Marton Balint wrote: On Sun, 19 Apr 2020, Wolfgang Haupt

[FFmpeg-devel] [PATCH v1] avcodec/utils: use av_rescale()

2020-04-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 26c038dfd9..005d596dfd 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2229,8 +2229,8 @@ int64_t

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: Put strings instead of pointers to strings into array

2020-04-20 Thread Ross Nicholson
> On 20 Apr 2020, at 02:42, Andreas Rheinhardt > wrote: > > In this example, the difference in length between the shortest and > longest string is three, so that not using pointers to strings saves > space even on 32bit systems. > > Moreover, there is no need to use a sentinel here; it can

[FFmpeg-devel] [PATCH v1] avcodec/h264_metadata_bsf: add option to delete SEI user data

2020-04-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- doc/bitstream_filters.texi | 3 +++ libavcodec/h264_metadata_bsf.c | 19 +++ 2 files changed, 22 insertions(+) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 8fe5b3ad75..652eb4620f 100644 ---

Re: [FFmpeg-devel] [RFC PATCH v2] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-04-20 Thread Gautam Ramakrishnan
On Mon, Apr 20, 2020 at 4:18 PM Kieran O Leary wrote: > > Hi, > > Forgive my ignorance ,but what is the difference between a parser and a > decoder in this context? What does this parser add that wasn't covered in > the decoder? > Quoting Carl from a previous thread: Try the following: $ cat

[FFmpeg-devel] [PATCH] gas-preprocessor: Fix use of Visual Studio compiler values -w... or -FS

2020-04-20 Thread phunkyfish
From: Alwin Esch --- gas-preprocessor.pl | 4 1 file changed, 4 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 860b97c..126ee50 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -164,6 +164,8 @@ if ($as_type ne "armasm") { @preprocess_c_cmd =

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-20 Thread Anton Khirnov
Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07) > I'd like to ask opinions whether a installed header for just one structure is > a good idea. I see no problem with it. More smaller headers is better that a few big headers. Another issue is that this struct has no constructor and thus cannot

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: Use macro for "packet is empty"

2020-04-20 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-04-19 21:22:52) > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/bsf.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 deletions(-) > Good idea -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe

2020-04-20 Thread Anton Khirnov
Quoting James Almer (2020-04-17 05:10:08) > Signed-off-by: James Almer > --- > libavcodec/qpeg.c | 1 + > 1 file changed, 1 insertion(+) Looks good. Could have INIT_CLEANUP too, it seems. -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] OpenColorIO - Google Summer of Code

2020-04-20 Thread Rashil Gandhi
Hi, I figured reading my proposal was too much work so I have a one-line question here that I'd like to know the answer to. Can an FFmpeg video filter access unclamped 32-bit float values from an OpenEXR input file? I'd like to request again, if this is not the correct place to approach the

Re: [FFmpeg-devel] [PATCH v1] lavf/mp3enc: fix ID3v1 year metadata setting issue

2020-04-20 Thread Anton Khirnov
Quoting Jun Zhao (2020-04-20 10:17:06) > From: Jun Zhao > > Follow the http://id3.org/ID3v1, setting the year metadata > for ID3v1. > > fix #8623 > > Signed-off-by: Jun Zhao > --- > libavformat/mp3enc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v1] lavf/mp3enc: fix ID3v1 year metadata setting issue

2020-04-20 Thread myp...@gmail.com
On Mon, Apr 20, 2020 at 8:00 PM Anton Khirnov wrote: > > Quoting Jun Zhao (2020-04-20 10:17:06) > > From: Jun Zhao > > > > Follow the http://id3.org/ID3v1, setting the year metadata > > for ID3v1. > > > > fix #8623 > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/mp3enc.c | 3 ++- > > 1

Re: [FFmpeg-devel] [PATCH v1] lavf/mp3enc: fix ID3v1 year metadata setting issue

2020-04-20 Thread Anton Khirnov
Quoting myp...@gmail.com (2020-04-20 14:05:50) > On Mon, Apr 20, 2020 at 8:00 PM Anton Khirnov wrote: > > > > Quoting Jun Zhao (2020-04-20 10:17:06) > > > From: Jun Zhao > > > > > > Follow the http://id3.org/ID3v1, setting the year metadata > > > for ID3v1. > > > > > > fix #8623 > > > > > >

Re: [FFmpeg-devel] [PATCH] avformat/utils: Fix memleak when decoding subtitle in find_stream_info

2020-04-20 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-04-18 21:54:26) > avformat_find_stream_info() may decode some frames to get stream > information. And when it does this for subtitles, the decoded subtitles > leak. > > (Decoding subtitles was added in b1511e00f6fefde6cb31b2e17f7812cfac1c8bd6 > for PGS subtitles.

Re: [FFmpeg-devel] [PATCH] gas-preprocessor: Fix use of Visual Studio compiler values -w... or -FS

2020-04-20 Thread Martin Storsjö
On Mon, 20 Apr 2020, phunkyfish wrote: From: Alwin Esch --- gas-preprocessor.pl | 4 1 file changed, 4 insertions(+) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 860b97c..126ee50 100755 --- a/gas-preprocessor.pl +++ b/gas-preprocessor.pl @@ -164,6 +164,8 @@ if ($as_type

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: Pass ret from decode_iccp_chunk()

2020-04-20 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-04-18 01:48:47) > Found while reviewing a patch fixing a similar issue > > Signed-off-by: Michael Niedermayer > --- Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/qpeg: remove an unnecessary intermediary AVFrame

2020-04-20 Thread Anton Khirnov
Quoting James Almer (2020-04-17 05:10:06) > Decoding can be handled directly in the output frame. > > Signed-off-by: James Almer > --- > libavcodec/qpeg.c | 22 +- > 1 file changed, 9 insertions(+), 13 deletions(-) > Seems you're also fixing flush, so maybe mention that in

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/qpeg: export missing frame properties

2020-04-20 Thread Anton Khirnov
Quoting James Almer (2020-04-17 05:10:07) > Signed-off-by: James Almer > --- Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] OpenColorIO - Google Summer of Code

2020-04-20 Thread Paul B Mahol
On 4/20/20, Rashil Gandhi wrote: > Hi, > > I figured reading my proposal was too much work so I have a one-line > question here that I'd like to know the answer to. > > Can an FFmpeg video filter access unclamped 32-bit float values from > an OpenEXR input file? > Nope, because decoder outputs

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/qpeg: remove an unnecessary intermediary AVFrame

2020-04-20 Thread James Almer
On 4/20/2020 10:28 AM, Anton Khirnov wrote: > Quoting James Almer (2020-04-17 05:10:06) >> Decoding can be handled directly in the output frame. >> >> Signed-off-by: James Almer >> --- >> libavcodec/qpeg.c | 22 +- >> 1 file changed, 9 insertions(+), 13 deletions(-) >> > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qpeg: mark the init function as thread-safe

2020-04-20 Thread James Almer
On 4/20/2020 10:30 AM, Anton Khirnov wrote: > Quoting James Almer (2020-04-17 05:10:08) >> Signed-off-by: James Almer >> --- >> libavcodec/qpeg.c | 1 + >> 1 file changed, 1 insertion(+) > > Looks good. > Could have INIT_CLEANUP too, it seems. No, since the only way for init() to fail now is