Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/jpeg2000dec.c: ROI marker support

2020-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2020 at 08:44:10AM +0530, Gautam Ramakrishnan wrote: > On Wed, Apr 22, 2020 at 3:04 AM Michael Niedermayer > wrote: > > > > On Tue, Apr 21, 2020 at 01:07:39AM +0530, gautamr...@gmail.com wrote: > > > From: Gautam Ramakrishnan > > > > > > This patch adds support for decoding

Re: [FFmpeg-devel] [PATCH] libavformat/flacdec: Workaround for truncated metadata picture size

2020-04-22 Thread Mattias Wadman
On Wed, Apr 22, 2020 at 5:18 PM Andreas Rheinhardt wrote: > > Mattias Wadman: > > lavf flacenc could previously write truncated metadata picture size if > > the picture data did not fit in 24 bits. Detect this by truncting the > > size found inside the picture block and if it matches the block

Re: [FFmpeg-devel] [PATCH 1/5] x86 inline assembly compliance

2020-04-22 Thread Michael Niedermayer
On Sat, Apr 04, 2020 at 12:32:13PM +0200, FRÉDÉRIC RECOULES wrote: > [inline assembly] prepares for contiguous assembly statements merging > > --- > libavcodec/x86/inline_asm.h | 29 + > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v6 0/9] Support Dolby Vision

2020-04-22 Thread myp...@gmail.com
On Wed, Apr 22, 2020 at 7:53 PM Jun Zhao wrote: > > From: Jun Zhao > > V6: > - split the header and .c file > - bump version and update APIChnage > > V5: > - add a constructor for DOVI (tks Anton Khirnov) > - some minor coding style clean > > V4: > - change the DOVI dump message (tks Jan

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-04-22 Thread Andreas Rheinhardt
James Almer: > Fixes ticket #8622 > > Signed-off-by: James Almer > --- > It fixes it assuming the Picture Timing in that sample is not being misparsed > by cbs_h265. > We're compliant with the latest revision of the spec, so any > reserved_payload_extension_data found in a sample created today

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-04-22 Thread Andreas Rheinhardt
James Almer: > Fixes ticket #8622 > > Signed-off-by: James Almer > --- > It fixes it assuming the Picture Timing in that sample is not being misparsed > by cbs_h265. > We're compliant with the latest revision of the spec, so any > reserved_payload_extension_data found in a sample created today

[FFmpeg-devel] [PATCH 11/11] avformat/matroskadec: Cosmetics

2020-04-22 Thread Andreas Rheinhardt
Reindentation as well as marking several variables used for demuxing RealAudio as const to clearly see that they don't change during demuxing. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff

[FFmpeg-devel] [PATCH 05/11] avformat/matroskadec: Don't output uninitialized data for RealAudio 28.8

2020-04-22 Thread Andreas Rheinhardt
The Matroska demuxer splits every sequence of h Matroska Blocks into h * w / cfs packets of size cfs; here h (sub_packet_h), w (frame_size) and cfs (coded_framesize) are parameters from the track's CodecPrivate. It does this by splitting the Block's data in h/2 pieces of size cfs each and putting

[FFmpeg-devel] [PATCH 09/11] avformat/matroskadec: Cache whether a track needs to be decoded

2020-04-22 Thread Andreas Rheinhardt
There is no need to recheck this for every frame. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 088eeabf2d..9e3e98e9c0 100644 ---

[FFmpeg-devel] [PATCH 07/11] avformat/matroskadec: Don't discard valid packets

2020-04-22 Thread Andreas Rheinhardt
A Block (meaning both a Block in a BlockGroup as well as a SimpleBlock) must have at least three bytes after the field containing the encoded TrackNumber. So if there are <= 3 bytes, the Matroska demuxer would skip this block, believing it to be an empty, but valid Block. This might discard valid

[FFmpeg-devel] [PATCH 08/11] avformat/matroskadec: Improve forward compability

2020-04-22 Thread Andreas Rheinhardt
Matroska is built around the principle that a reader does not need to understand everything in a file in order to be able to make use of it; it just needs to ignore the data it doesn't know about. Our demuxer typically follows this principle, but there is one important instance where it does not:

[FFmpeg-devel] [PATCH 04/11] avformat/matroskadec: Fix buffer overflow when demuxing RealAudio 28.8

2020-04-22 Thread Andreas Rheinhardt
RealAudio 28.8 (like other RealAudio codecs) uses a special demuxing mode in which the data of the existing Matroska Blocks is not simply forwarded as-is. Instead data from several Blocks is recombined together to output several packets. The parameters governing this process are parsed from the

[FFmpeg-devel] [PATCH 06/11] avformat/matroskadec: Simplify checks for cook and ATRAC3

2020-04-22 Thread Andreas Rheinhardt
Some conditions which don't change and which can therefore be checked in read_header() were instead rechecked upon parsing each block. This has been changed. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskadec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 10/11] avformat/matroskadec: Support ContentCompression for all codecs

2020-04-22 Thread Andreas Rheinhardt
The Matroska demuxer has three functions for creating packets out of the data read: One for certain RealAudio codecs (ATRAC3, cook, sipr, RealAudio 28.8), one for WebVTT (actually, the WebM flavour of it) and one for all the others. Only the last function supported Matroska's ContentCompression

[FFmpeg-devel] [PATCH 03/11] avformat/matroskadec: Fix demuxing RealAudio 28.8

2020-04-22 Thread Andreas Rheinhardt
RealAudio 28.8 does not need or use sub_packet_size for its demuxing and this field is therefore commonly set to zero. But since 18ca491b the Real Audio specific demuxing is no longer applied if sub_packet_size is zero because the codepath for cook and ATRAC3 divide by it; this made these files

[FFmpeg-devel] [PATCH 02/11] avformat/matroskadec: Simplify check for RealAudio

2020-04-22 Thread Andreas Rheinhardt
They need a special parsing mode and in order to find out whether this mode is in use, several checks have to be performed. They can all be combined into one: If the buffer that is only used to assemble their packets has been allocated, use the RealAudio parsing mode. Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-04-22 Thread James Almer
On 4/23/2020 12:00 AM, Andreas Rheinhardt wrote: > James Almer: >> On 4/22/2020 9:17 PM, Andreas Rheinhardt wrote: >>> James Almer: Fixes ticket #8622 Signed-off-by: James Almer --- It fixes it assuming the Picture Timing in that sample is not being misparsed

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1_metadata: filter parameter sets in packet side data

2020-04-22 Thread Andreas Rheinhardt
James Almer: > Extradata included in packet side data is meant to replace the codec context > extradata. So when muxing for example to MP4 without this change and if > extradata is present in a packet side data, the result will be that the > parameter sets present in keyframes will be filtered,

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/cbs_h265: move the payload_extension_present check into its own function

2020-04-22 Thread Andreas Rheinhardt
James Almer: > Will be reused in the following patch. > > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c| 9 + > libavcodec/cbs_h265_syntax_template.c | 8 +++- > 2 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/cbs_h2645.c

[FFmpeg-devel] [PATCH v3] libavcodec/jpeg2000dec.c: ROI marker support

2020-04-22 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for decoding images with a Region of Interest. Allows decoding samples such as p0_03.j2k. This patch should fix ticket #4681. --- libavcodec/jpeg2000.h| 1 + libavcodec/jpeg2000dec.c | 66 ++-- 2 files

Re: [FFmpeg-devel] [PATCH 1/3] lavu/pix_fmt: add new pixel format x2rgb10

2020-04-22 Thread Carl Eugen Hoyos
Am Mi., 22. Apr. 2020 um 04:32 Uhr schrieb Wang, Fei W : > > > From: ffmpeg-devel On Behalf Of > > Hendrik Leppkes > > Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavu/pix_fmt: add new pixel format > > x2rgb10 > > > > On Tue, Apr 21, 2020 at 9:53 AM Fei Wang wrote: > > > > > > The format is packed

Re: [FFmpeg-devel] [PATCH v2 2/2] libavcodec/jpeg2000dec.c: ROI marker support

2020-04-22 Thread Andriy Gelman
On Thu, 23. Apr 00:04, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds support for decoding images > with a Region of Interest. Allows decoding > samples such as p0_03.j2k. This patch should > fix ticket #4681. > --- > libavcodec/jpeg2000.h| 1 + >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-04-22 Thread Andreas Rheinhardt
James Almer: > On 4/22/2020 9:17 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Fixes ticket #8622 >>> >>> Signed-off-by: James Almer >>> --- >>> It fixes it assuming the Picture Timing in that sample is not being >>> misparsed >>> by cbs_h265. >>> We're compliant with the latest revision of

[FFmpeg-devel] [PATCH] configure: enable ffnvcodec, nvenc, nvdec for aarch64

2020-04-22 Thread ManojGuptaBonda
Adding the support to build FFMPEG with HW accelerated decode(nvdec) and encode on aarch64 architecture. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 6533b43250..080d93a129 100755 --- a/configure +++ b/configure @@ -6675,7 +6675,7

[FFmpeg-devel] [PATCH v2] lavf/mp3enc: fix ID3v1 year metadata setting issue

2020-04-22 Thread Jun Zhao
From: Jun Zhao Follow the http://id3.org/ID3v1, setting the year metadata for ID3v1. fix #8623 Signed-off-by: Jun Zhao --- libavformat/mp3enc.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index 34b753f..14d4b6e

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread Anton Khirnov
Quoting myp...@gmail.com (2020-04-22 05:39:38) > On Tue, Apr 21, 2020 at 2:23 PM Anton Khirnov wrote: > > > > Quoting myp...@gmail.com (2020-04-21 04:47:42) > > > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > > > > > > > Quoting Jean-Baptiste Kempf (2020-04-19 10:25:07) > > > > > I'd

Re: [FFmpeg-devel] [PATCH v5 5/7] lavf/dump: dump DOVI side data

2020-04-22 Thread myp...@gmail.com
On Wed, Apr 22, 2020 at 12:36 PM Jun Zhao wrote: > > From: Jun Zhao > > dump DOVI side data. > > Signed-off-by: Jun Zhao > --- > libavformat/dump.c | 23 +++ > 1 file changed, 23 insertions(+) > > diff --git a/libavformat/dump.c b/libavformat/dump.c > index 220f404..9578b88

Re: [FFmpeg-devel] [PATCH 6/9] lavfi/vf_pp: convert to the video_enc_params API

2020-04-22 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-04-18 21:52:22) > On Sat, Apr 18, 2020 at 09:07:09PM +0200, Marton Balint wrote: > > > > > > On Sat, 18 Apr 2020, Michael Niedermayer wrote: > > > > >On Sat, Apr 18, 2020 at 07:03:16PM +0200, Marton Balint wrote: > > >> > > >> > > >>On Sat, 18 Apr 2020, Michael

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/dump_extradata_bsf: Remove unnecessary header

2020-04-22 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-04-21 17:28:08) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2020-04-21 04:31:51) > >> Since 33d18982fa03feb061c8f744a4f0a9175c1f63ab (the commit that > >> introduced the new bsf API) allocating an enlarged buffer in case > >> extradata needs to be added to a

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread myp...@gmail.com
On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov wrote: > > Quoting myp...@gmail.com (2020-04-22 05:39:38) > > On Tue, Apr 21, 2020 at 2:23 PM Anton Khirnov wrote: > > > > > > Quoting myp...@gmail.com (2020-04-21 04:47:42) > > > > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > > > > > >

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread myp...@gmail.com
On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov wrote: > > Quoting myp...@gmail.com (2020-04-22 05:39:38) > > On Tue, Apr 21, 2020 at 2:23 PM Anton Khirnov wrote: > > > > > > Quoting myp...@gmail.com (2020-04-21 04:47:42) > > > > On Mon, Apr 20, 2020 at 9:08 PM Anton Khirnov wrote: > > > > > > >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264_metadata: filter parameter sets in packet side data

2020-04-22 Thread Andreas Rheinhardt
James Almer: > Extradata included in packet side data is meant to replace the codec context > extradata. So when muxing for example to MP4 without this change and if > extradata is present in a packet side data, the result will be that the > parameter sets present in keyframes will be filtered,

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-04-22 Thread James Almer
On 4/22/2020 9:17 PM, Andreas Rheinhardt wrote: > James Almer: >> Fixes ticket #8622 >> >> Signed-off-by: James Almer >> --- >> It fixes it assuming the Picture Timing in that sample is not being misparsed >> by cbs_h265. >> We're compliant with the latest revision of the spec, so any >>

[FFmpeg-devel] [PATCH 01/11] avformat/matroskadec: Reject sipr flavor > 3

2020-04-22 Thread Andreas Rheinhardt
Only flavors 0..3 seem to exist. E.g. rmdec.c treats any flavor > 3 as invalid data. Furthermore, we do not know how big the packets to create ought to be given that for sipr these values are not read from the bitstream, but from a table. Furthermore, flavor is only used for sipr, so only check

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread myp...@gmail.com
On Wed, Apr 22, 2020 at 7:55 PM Anton Khirnov wrote: > > Quoting myp...@gmail.com (2020-04-22 10:56:52) > > On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov wrote: > > > Making it inline would invalidate the whole point, which is to avoid > > > embedding the size of the struct into the calling

Re: [FFmpeg-devel] [PATCH 3/8] avcodec/vp9_raw_reorder_bsf: Remove unnecessary header

2020-04-22 Thread Peter Ross
On Tue, Apr 21, 2020 at 04:31:48AM +0200, Andreas Rheinhardt wrote: > This bsf doesn't have any options, so including libavutil/opt.h is > unnecessary. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp9_raw_reorder_bsf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: don't print warning for DVB text streams

2020-04-22 Thread Gyan Doshi
On 22-04-2020 01:21 am, Marton Balint wrote: On Mon, 20 Apr 2020, Gyan Doshi wrote: They can be demuxed by ffmpeg. --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index ccb631d746..3818001976 100644 ---

Re: [FFmpeg-devel] [PATCH v4 2/7] lavutil: add DOVI related header

2020-04-22 Thread Anton Khirnov
Quoting myp...@gmail.com (2020-04-22 10:56:52) > On Wed, Apr 22, 2020 at 4:19 PM Anton Khirnov wrote: > > Making it inline would invalidate the whole point, which is to avoid > > embedding the size of the struct into the calling program. > > > Do you mean I need to split the av_dovi_alloc

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check length before memcpy() in decode_deep_rle32()

2020-04-22 Thread Peter Ross
On Tue, Apr 21, 2020 at 12:03:40AM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 20796/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5111364702175232.fuzz > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH v6 5/9] lavf/dump: dump DOVI side data

2020-04-22 Thread Jun Zhao
From: Jun Zhao dump DOVI side data. Signed-off-by: Jun Zhao --- libavformat/dump.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 220f404..5e9a031 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -27,6 +27,7 @@

[FFmpeg-devel] [PATCH v6 4/9] lavf/mov: support dvcC/dvvC box for DOVI

2020-04-22 Thread Jun Zhao
From: vacingfang support dvcC/dvcC box from spec Dolby Vision Streams Within the ISO Base MediaFile Format Version 2.1.2 (https://www.dolby.com/in/en/technologies/dolby-vision/dolby-vision\ -bitstreams-within-the-iso-base-media-file-format-v2.1.2.pdf) export the DOVI information to sidedata.

[FFmpeg-devel] [PATCH v6 0/9] Support Dolby Vision

2020-04-22 Thread Jun Zhao
From: Jun Zhao V6: - split the header and .c file - bump version and update APIChnage V5: - add a constructor for DOVI (tks Anton Khirnov) - some minor coding style clean V4: - change the DOVI dump message (tks Jan Ekström) - fix the file order in Makefile V3: - rename the file name for Dolby

[FFmpeg-devel] [PATCH v6 7/9] lavf/movenc: enable dvcC/dvvC box support from DOVI sidedata

2020-04-22 Thread Jun Zhao
From: Jun Zhao enable dvcC/dvvC box support from DOVI sidedata. Signed-off-by: Jun Zhao --- libavformat/movenc.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 253cff8..556dd06 100644 ---

[FFmpeg-devel] [PATCH v6 6/9] fftools/ffprobe: support DOVI sidedata

2020-04-22 Thread Jun Zhao
From: Jun Zhao support DOVI sidedata. Signed-off-by: Jun Zhao --- fftools/ffprobe.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index e3f221f..840fcb7 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -36,6 +36,7 @@ #include

[FFmpeg-devel] [PATCH v6 2/9] lavutil: add DOVI related header

2020-04-22 Thread Jun Zhao
From: vacingfang add DOVI related struct Signed-off-by: vacingfang --- libavutil/Makefile| 2 ++ libavutil/dovi_meta.c | 35 ++ libavutil/dovi_meta.h | 70 +++ 3 files changed, 107 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH v6 1/9] lavc: add a new sidedata type for DOVI

2020-04-22 Thread Jun Zhao
From: Jun Zhao add a new sidedata type for DOVI. Signed-off-by: Jun Zhao --- libavcodec/avpacket.c | 1 + libavcodec/packet.h | 9 + 2 files changed, 10 insertions(+) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index ad020ee..1b53451 100644 ---

[FFmpeg-devel] [PATCH v6 3/9] lavf/mpegts: support DOVI Video Stream Descriptor

2020-04-22 Thread Jun Zhao
From: vacingfang support DOVI Video Stream Descriptor from Dolby Vision Streams Within the MPEG-2 Transport Stream Format V1.2 From the spec: https://www.dolby.com/us/en/technologies/\ dolby-vision/dolby-vision-bitstreams-in-mpeg-2-transport-\ stream-multiplex-v1.2.pdf. export the DOVI

[FFmpeg-devel] [PATCH v6 8/9] lavc/version: bump minor version for DOVI sidedata

2020-04-22 Thread Jun Zhao
From: Jun Zhao Signed-off-by: Jun Zhao --- libavcodec/version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/version.h b/libavcodec/version.h index 8cff2e8..ad85fb1 100644 --- a/libavcodec/version.h +++ b/libavcodec/version.h @@ -28,7 +28,7 @@ #include

[FFmpeg-devel] [PATCH v6 9/9] doc/APIChanges: add AV_PKT_DATA_DOVI_CONF entry

2020-04-22 Thread Jun Zhao
From: Jun Zhao Signed-off-by: Jun Zhao --- doc/APIchanges | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/APIchanges b/doc/APIchanges index e30148d..5aa25de 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -15,6 +15,9 @@ libavutil: 2017-10-21 API changes, most recent

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: use av_log_once for data stream warning

2020-04-22 Thread Gyan Doshi
--- libavformat/mpegtsenc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4fe3d84c59..f2be6c6632 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -238,6 +238,7 @@ typedef struct

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/iff: Fix invalid pointer intermediates in decode_deep_rle32()

2020-04-22 Thread Peter Ross
On Tue, Apr 21, 2020 at 12:03:39AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/iff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/iff.c b/libavcodec/iff.c > index acd6519b06..2e65e266d0 100644 > ---

Re: [FFmpeg-devel] [inline assembly compliance] Issues and patches

2020-04-22 Thread FRÉDÉRIC RECOULES
Hi Michael, We are looking forward to hear news about the patches ([PATCH /5] x86 inline assembly compliance). Did you have time to take a look? We are trying to keep track of the state of the assembly in projects in which we found issues. Please recall that they should be now small, very

[FFmpeg-devel] [PATCH] libavformat/flacdec: Workaround for truncated metadata picture size

2020-04-22 Thread Mattias Wadman
lavf flacenc could previously write truncated metadata picture size if the picture data did not fit in 24 bits. Detect this by truncting the size found inside the picture block and if it matches the block size use it and read rest of picture data. flacenc was fixed in

[FFmpeg-devel] [PATCH 1/3] avcodec/av1_metadata: filter parameter sets in packet side data

2020-04-22 Thread James Almer
Extradata included in packet side data is meant to replace the codec context extradata. So when muxing for example to MP4 without this change and if extradata is present in a packet side data, the result will be that the parameter sets present in keyframes will be filtered, but the parameter sets

[FFmpeg-devel] [PATCH 2/3] avcodec/h264_metadata: filter parameter sets in packet side data

2020-04-22 Thread James Almer
Extradata included in packet side data is meant to replace the codec context extradata. So when muxing for example to MP4 without this change and if extradata is present in a packet side data, the result will be that the parameter sets present in keyframes will be filtered, but the parameter sets

Re: [FFmpeg-devel] [PATCH v2 1/4] fftools/qsv: enabling d3d11va/dxva2 device selection

2020-04-22 Thread Artem Galin
Hi Steve, On Tue, 21 Apr 2020 at 11:25, Steve Lhomme wrote: > Hi, > > On 2020-04-15 15:07, artem.ga...@gmail.com wrote: > > From: Artem Galin > > > > child_device_type argument is responsible for selection. > > > > Usage examples: -init_hw_device qsv:hw,child_device_type=d3d11va > >

Re: [FFmpeg-devel] [PATCH] libavformat/flacdec: Workaround for truncated metadata picture size

2020-04-22 Thread Andreas Rheinhardt
Mattias Wadman: > lavf flacenc could previously write truncated metadata picture size if > the picture data did not fit in 24 bits. Detect this by truncting the > size found inside the picture block and if it matches the block size > use it and read rest of picture data. > > flacenc was fixed in

Re: [FFmpeg-devel] [PATCH 0/2] lavd/avfoundation: Fix build on iOS and fix screen capture

2020-04-22 Thread Thilo Borgmann
Am 04.04.20 um 13:55 schrieb Thilo Borgmann: > Hi, > > fixing two bugs revealed after last patch to avfoundation. > > Will apply soon if there are no objections. Applied. Thx, Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 4/5] [inline assembly] add mmx clobbers in 3 statements

2020-04-22 Thread frederic . recoules
From: Frédéric Recoules - 1 in lossless_videoencdsp_init.c - 2 in rnd_template.c --- libavcodec/x86/lossless_videoencdsp_init.c | 4 +++- libavcodec/x86/rnd_template.c | 8 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/5] [inline assembly] add "memory" to sub_median_pred_mmxext

2020-04-22 Thread frederic . recoules
From: Frédéric Recoules --- libavcodec/x86/lossless_videoencdsp_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/lossless_videoencdsp_init.c b/libavcodec/x86/lossless_videoencdsp_init.c index fb481e66f5..feb6874f94 100644 ---

Re: [FFmpeg-devel] [PATCH v2 4/4] libavutil/qsv: enabling d3d11va support

2020-04-22 Thread Artem Galin
On Tue, 21 Apr 2020 at 11:26, Steve Lhomme wrote: > On 2020-04-15 15:07, artem.ga...@gmail.com wrote: > > From: Artem Galin > > > > Makes selection of d3d11va device type by default and over DirectX 9, > > which is still supported but requires explicit selection. > > This enables usage of

[FFmpeg-devel] [PATCH 1/5] [inline assembly] prepares for contiguous assembly statements merging

2020-04-22 Thread frederic . recoules
From: Frédéric Recoules --- libavcodec/x86/inline_asm.h | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/libavcodec/x86/inline_asm.h b/libavcodec/x86/inline_asm.h index 0198746719..6ead73ac33 100644 --- a/libavcodec/x86/inline_asm.h +++

[FFmpeg-devel] [PATCH 3/5] [inline assembly] prepares for mmx clobbers akin to xmm

2020-04-22 Thread frederic . recoules
From: Frédéric Recoules --- configure | 4 libavutil/x86/asm.h | 20 2 files changed, 24 insertions(+) diff --git a/configure b/configure index 6533b43250..ddfea5ccfa 100755 --- a/configure +++ b/configure @@ -2275,6 +2275,7 @@ TOOLCHAIN_FEATURES="

[FFmpeg-devel] [PATCH 2/5] [inline assembly] merges contiguous assembly statements

2020-04-22 Thread frederic . recoules
From: Frédéric Recoules --- libavcodec/x86/hpeldsp_init.c | 8 libavcodec/x86/rnd_template.c | 14 +++--- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/libavcodec/x86/hpeldsp_init.c b/libavcodec/x86/hpeldsp_init.c index d89928cec6..c99513035b 100644 ---

Re: [FFmpeg-devel] [PATCH v2 2/4] libavfilter/qsvvpp: enabling d3d11va support

2020-04-22 Thread Artem Galin
On Tue, 21 Apr 2020 at 11:25, Steve Lhomme wrote: > Comments below. > > On 2020-04-15 15:07, artem.ga...@gmail.com wrote: > > From: Artem Galin > > > > Adding DX11 relevant device type checks and adjusting callback with > > proper MediaSDK pair type support. > > > > Signed-off-by: Artem Galin

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264_metadata: filter parameter sets in packet side data

2020-04-22 Thread James Almer
On 4/22/2020 12:09 PM, James Almer wrote: > Extradata included in packet side data is meant to replace the codec context > extradata. So when muxing for example to MP4 without this change and if > extradata is present in a packet side data, the result will be that the > parameter sets present in

Re: [FFmpeg-devel] [PATCH 1/5] x86 inline assembly compliance

2020-04-22 Thread FRÉDÉRIC RECOULES
For whatever reason, something gobbles the space just before '#include "constants.h"'... Once again, the patches have been resubmitted (from my orange.fr address using 'git send-email', I had a hard time with the professional SMTP server). Hope everything goes right this time, sorry for this

Re: [FFmpeg-devel] [PATCH v2 3/4] libavcodec/qsv: enabling d3d11va support, added mfxhdlpair

2020-04-22 Thread Artem Galin
On Tue, 21 Apr 2020 at 11:26, Steve Lhomme wrote: > Mostly the same remarks as for 2/4 regarding the uneeded loop and > uninitialized handle_type, plus comments below. > > Answers on the same remarks in 2/4 > On 2020-04-15 15:07, artem.ga...@gmail.com wrote: > > From: Artem Galin > > > >

[FFmpeg-devel] [PATCH 3/3] avcodec/h265_metadata: filter parameter sets in packet side data

2020-04-22 Thread James Almer
Extradata included in packet side data is meant to replace the codec context extradata. So when muxing for example to MP4 without this change and if extradata is present in a packet side data, the result will be that the parameter sets present in keyframes will be filtered, but the parameter sets

[FFmpeg-devel] [PATCH v2 2/2] libavcodec/jpeg2000dec.c: ROI marker support

2020-04-22 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support for decoding images with a Region of Interest. Allows decoding samples such as p0_03.j2k. This patch should fix ticket #4681. --- libavcodec/jpeg2000.h| 1 + libavcodec/jpeg2000dec.c | 67 ++-- 2 files

[FFmpeg-devel] [PATCH v2 1/2] libavcodec/jpeg2000dec.c: Support for CRG marker

2020-04-22 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support to skip the CRG marker. The CRG marker, is an informational marker. Allows samples such as p0_03.j2k to be decoded. --- libavcodec/jpeg2000dec.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/jpeg2000dec.c

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: use av_log_once for data stream warning

2020-04-22 Thread Marton Balint
On Wed, 22 Apr 2020, Gyan Doshi wrote: --- libavformat/mpegtsenc.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4fe3d84c59..f2be6c6632 100644 --- a/libavformat/mpegtsenc.c +++

Re: [FFmpeg-devel] [PATCH v2 1/2] libavcodec/jpeg2000dec.c: Support for CRG marker

2020-04-22 Thread Michael Niedermayer
On Thu, Apr 23, 2020 at 12:04:39AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > This patch adds support to skip the CRG marker. > The CRG marker, is an informational marker. > Allows samples such as p0_03.j2k to be decoded. > --- > libavcodec/jpeg2000dec.c | 12

Re: [FFmpeg-devel] [PATCH] mpeg4videoenc: Don't crash with -fsanitize=bounds

2020-04-22 Thread Michael Niedermayer
On Tue, Apr 21, 2020 at 09:34:19PM -0700, Vitaly Buka wrote: > Also the patch makes this code consistent with mpeg4videodec.c > --- > libavcodec/mpeg4videoenc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 3/5] [inline assembly] prepares for mmx clobbers akin to xmm

2020-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2020 at 07:49:16PM +0200, frederic.recou...@univ-grenoble-alpes.fr wrote: > From: Frédéric Recoules > > --- > configure | 4 > libavutil/x86/asm.h | 20 > 2 files changed, 24 insertions(+) > > diff --git a/configure b/configure > index

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/iff: Fix invalid pointer intermediates in decode_deep_rle32()

2020-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2020 at 08:07:21PM +1000, Peter Ross wrote: > On Tue, Apr 21, 2020 at 12:03:39AM +0200, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/iff.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/iff.c

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check length before memcpy() in decode_deep_rle32()

2020-04-22 Thread Michael Niedermayer
On Wed, Apr 22, 2020 at 08:10:44PM +1000, Peter Ross wrote: > On Tue, Apr 21, 2020 at 12:03:40AM +0200, Michael Niedermayer wrote: > > Fixes: out of array read > > Fixes: > > 20796/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5111364702175232.fuzz > > > > Found-by:

Re: [FFmpeg-devel] [PATCH 0/2] lavd/avfoundation: Fix build on iOS and fix screen capture

2020-04-22 Thread Carl Eugen Hoyos
Am Mi., 22. Apr. 2020 um 17:06 Uhr schrieb Thilo Borgmann : > > Am 04.04.20 um 13:55 schrieb Thilo Borgmann: > > Hi, > > > > fixing two bugs revealed after last patch to avfoundation. > > > > Will apply soon if there are no objections. > > Applied. Does one of the patches fix ticket #8615? Carl