Re: [FFmpeg-devel] [PATCH] avfilter: add chromanr video filter

2020-07-08 Thread Paul B Mahol
On 7/4/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 19 > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_chromanr.c | 211 ++ > 4 files changed, 232 insertions(+) >

[FFmpeg-devel] [PATCH V3] tests/dnn/mathunary: fix the issue of NAN

2020-07-08 Thread Ting Fu
When one of output[i] & expected_output is NAN, the unit test will always pass. Signed-off-by: Ting Fu --- tests/dnn/dnn-layer-mathunary-test.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/dnn/dnn-layer-mathunary-test.c b/tests/dnn/dnn-layer-mathunary-test.c

[FFmpeg-devel] [PATCH v6 2/7] avformat/apm: use the entire APMState structure as extradata

2020-07-08 Thread Zane van Iperen
Is the "actual" codec extradata instead of the hand-crafted one from the previous revision. Signed-off-by: Zane van Iperen --- libavformat/apm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/apm.c b/libavformat/apm.c index 4158b81457..8d655d0a33 100644

[FFmpeg-devel] [PATCH v6 0/7] Add support for encoding adpcm_ima_apm and muxing to apm.

2020-07-08 Thread Zane van Iperen
v6: [8] * split out header and extradata fixes * add more-descriptive commit messages * fix bit_rate overflow v5: [7] * split out cosmetic changes into their own patch v4: * fix rebase issues v3: [4][5][6] * Support both extradata formats - fixes FATE failure + preserves compatibility *

[FFmpeg-devel] [PATCH v6 1/7] avformat/apm: read header correctly

2020-07-08 Thread Zane van Iperen
The leading WAVEFORMATEX in .APM files is malformed: * The nAvgBytesPerSec field is wrong, and * sizeof(cbSize) is 4 instead of 2. Signed-off-by: Zane van Iperen --- libavformat/Makefile | 2 +- libavformat/apm.c| 50 2 files changed, 33

[FFmpeg-devel] [PATCH v6 3/7] avformat/apm: fix variable/structure names and cosmetics

2020-07-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/apm.c | 100 +++--- 1 file changed, 51 insertions(+), 49 deletions(-) diff --git a/libavformat/apm.c b/libavformat/apm.c index 8d655d0a33..0d88e1099a 100644 --- a/libavformat/apm.c +++ b/libavformat/apm.c @@

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec: add support for animated WebP decoding

2020-07-08 Thread Lynne
Jul 8, 2020, 06:28 by jo...@pex.com: > Fixes: 4907 > > Adds support for decoding of animated WebP. > > The WebP parser now splits the input stream into packets containing one frame. > > The WebP decoder adds the animation related features according to the specs: >

[FFmpeg-devel] [PATCH] avformat/riffenc: indicate storage of flipped RGB bitmaps

2020-07-08 Thread Gyan Doshi
Some legacy applications such as AVI2MVE expect raw RGB bitmaps to be stored bottom-up, whereas our RIFF BITMAPINFOHEADER assumes they are always stored top-down and thus write a negative value for height. This can prevent reading of these files. Option flipped_raw_rgb added to AVI and Matroska

[FFmpeg-devel] [PATCH v6 6/7] fate: add adpcm_ima_apm encoding test

2020-07-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/acodec.mak | 2 ++ tests/ref/acodec/adpcm-ima_apm | 4 2 files changed, 6 insertions(+) create mode 100644 tests/ref/acodec/adpcm-ima_apm diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index bb6bfe5ada..197b6ed7c0 100644

[FFmpeg-devel] [PATCH v6 5/7] avformat: add apm muxer

2020-07-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/apm.c| 107 ++- libavformat/version.h| 2 +- 5 files changed, 110 insertions(+), 2 deletions(-)

[FFmpeg-devel] [PATCH v6 4/7] avcodec: add adpcm_ima_apm encoder

2020-07-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 34 -- libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 7 files

[FFmpeg-devel] [PATCH v6 7/7] avcodec/adpcmenc: cleanup trellis checks

2020-07-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcmenc.c | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index 4985abb163..adb7bf0bbf 100644 --- a/libavcodec/adpcmenc.c +++

[FFmpeg-devel] [PATCH v5] avdevice/xcbgrab: Add select_region option

2020-07-08 Thread Omar Emara
This patch adds a select_region option to the xcbgrab input device. If set to 1, the user will be prompted to select the grabbing area graphically by clicking and dragging. A rectangle will be drawn to mark the grabbing area. A single click with no dragging will select the whole screen. The option

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec: add support for animated WebP decoding

2020-07-08 Thread Zlomek, Josef
On Wed, Jul 8, 2020 at 11:57 AM Lynne wrote: > Jul 8, 2020, 06:28 by jo...@pex.com: > > > Fixes: 4907 > > > > Adds support for decoding of animated WebP. > > > > The WebP parser now splits the input stream into packets containing one > frame. > > > > The WebP decoder adds the animation related

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

2020-07-08 Thread Michael Niedermayer
On Tue, Jul 07, 2020 at 01:14:41PM -0700, Brian Kim wrote: > On Tue, Jul 7, 2020 at 4:35 AM Michael Niedermayer > wrote: > [...] > > I wonder if linesizes for newly added functions should be ptrdiff_t > > this would add some type converting loops though > > > > And size probably should be

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

2020-07-08 Thread Michael Niedermayer
On Tue, Jul 07, 2020 at 05:41:11PM -0300, James Almer wrote: > On 7/7/2020 5:07 PM, Brian Kim wrote: > > On Tue, Jul 7, 2020 at 6:34 AM James Almer wrote: > >> > >> If i understand this right, you could easily solve it with just the > >> following changes: > >> > >>> diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: fix build w/libaom v1.0.0

2020-07-08 Thread James Zern
On Mon, Jul 6, 2020 at 10:50 AM James Zern wrote: > > James, > > On Thu, Jul 2, 2020 at 10:28 AM James Zern wrote: > > > > broken since: > > aa5c6f382b avcodec/libaomenc: Add command-line options to control the use > > of partition tools > > > > Signed-off-by: James Zern > > --- > >

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000dec: Fix RPCL progression order

2020-07-08 Thread Gautam Ramakrishnan
On Thu, Jul 9, 2020 at 12:50 AM wrote: > > From: Gautam Ramakrishnan > > This patch fixes a check in the RPCL progression order, > making it similar to the openjpeg implementation. > --- > libavcodec/jpeg2000dec.c | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > >

[FFmpeg-devel] [PATCH] libavcodec/jpeg2000dec: Fix RPCL progression order

2020-07-08 Thread gautamramk
From: Gautam Ramakrishnan This patch fixes a check in the RPCL progression order, making it similar to the openjpeg implementation. --- libavcodec/jpeg2000dec.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/libavcodec/jpeg2000dec.c

Re: [FFmpeg-devel] [PATCH] libavutil/video_enc_params: add block type

2020-07-08 Thread Yongle Lin
On Tue, Jul 7, 2020 at 12:59 AM Anton Khirnov wrote: > Quoting Yongle Lin (2020-07-06 23:08:17) > > add block type field to AVVideoBlockParams so we could either export or > visualize it later. > > --- > > libavutil/video_enc_params.h | 20 > > 1 file changed, 20

Re: [FFmpeg-devel] [PATCH 2/2] libavformat: add WebP demuxer

2020-07-08 Thread Carl Eugen Hoyos
Am Mi., 8. Juli 2020 um 07:28 Uhr schrieb Josef Zlomek : > > Fixes: 4907 It seems surprising that two commits should fix a ticket. > Adds support for demuxing of animated WebP. Does this demuxer also support single frame files? What about concatenated webps? [...] > +static int

Re: [FFmpeg-devel] [PATCH v6 3/3] avdevice/decklink_dec: export timecode with s12m side data

2020-07-08 Thread Marton Balint
On Wed, 8 Jul 2020, lance.lmw...@gmail.com wrote: On Wed, Jul 01, 2020 at 09:39:58PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavdevice/decklink_dec.cpp | 16 1 file changed, 16 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] swscale/tests: check return value of sws_scale

2020-07-08 Thread Martin Storsjö
On Tue, 7 Jul 2020, Lynne wrote: Patch attached. From a89bfd810cf40e3005fbcbdcf43a7b858b4dd12c Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 7 Jul 2020 22:19:14 +0100 Subject: [PATCH] swscale/tests: check return value of sws_scale --- libswscale/tests/swscale.c | 4 +++- 1 file changed,

Re: [FFmpeg-devel] libavutil/imgutils: UBSan nullptr-with-offset in av_image_fill_pointer

2020-07-08 Thread James Almer
On 7/8/2020 4:44 PM, Michael Niedermayer wrote: > On Tue, Jul 07, 2020 at 05:41:11PM -0300, James Almer wrote: >> On 7/7/2020 5:07 PM, Brian Kim wrote: >>> On Tue, Jul 7, 2020 at 6:34 AM James Almer wrote: If i understand this right, you could easily solve it with just the

Re: [FFmpeg-devel] [PATCH] libavcodec/jpeg2000dec: Fix RPCL progression order

2020-07-08 Thread Carl Eugen Hoyos
Am Mi., 8. Juli 2020 um 21:30 Uhr schrieb Gautam Ramakrishnan : > This patch was verified on p1_07.j2k Then please add this (important) information to the commit message, we don't want to get "more similar to openjpeg", you can therefore remove this sentence. Carl Eugen

Re: [FFmpeg-devel] [PATCH v6 3/3] avdevice/decklink_dec: export timecode with s12m side data

2020-07-08 Thread lance . lmwang
On Wed, Jul 08, 2020 at 11:59:17PM +0200, Marton Balint wrote: > > > On Wed, 8 Jul 2020, lance.lmw...@gmail.com wrote: > > > On Wed, Jul 01, 2020 at 09:39:58PM +0800, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > --- > > >

Re: [FFmpeg-devel] [PATCH v1 1/3] doc/developer.texi: Improvements in "Submitting patches" section.

2020-07-08 Thread Manolis Stamatogiannakis
On Tue, 7 Jul 2020 at 19:14, Michael Niedermayer wrote: > > a lot of patchwork patch maintaince can be automated, ive written a script > to do that. > What this does is basically look at local git, fetch all patches from > patchwork > (and cache them locally) > and then find stuff which is

Re: [FFmpeg-devel] Project orientation

2020-07-08 Thread Manolis Stamatogiannakis
On Tue, 7 Jul 2020 at 16:27, Nicolas George wrote: > Manolis Stamatogiannakis (12020-07-07): > > If I reply to the email, my response will appear online in the issue/PR > > page. > > That is good to know. I have never noticed it documented. Does it work > reliably? > > Haven't noticed any

Re: [FFmpeg-devel] [PATCH v1 1/3] doc/developer.texi: Improvements in "Submitting patches" section.

2020-07-08 Thread Manolis Stamatogiannakis
On Tue, 7 Jul 2020 at 16:00, Nicolas George wrote: > Manolis Stamatogiannakis (12020-07-05): > > The section has been expanded to outline how to manage patch revisions. > > --- > > doc/developer.texi | 37 ++--- > > 1 file changed, 26 insertions(+), 11

Re: [FFmpeg-devel] [PATCH] swscale/tests: check return value of sws_scale

2020-07-08 Thread Michael Niedermayer
On Tue, Jul 07, 2020 at 11:22:20PM +0200, Lynne wrote: > Patch attached. > > swscale.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > e4eb17aee95423afb258e2368ac1503720393263 > 0001-swscale-tests-check-return-value-of-sws_scale.patch > From

[FFmpeg-devel] [PATCH v2 1/3] libavutil/imgutils: add utility to get plane sizes

2020-07-08 Thread Brian Kim
Patch attached. Main changes from v1 are switching to from int to size_t/ptrdiff_t where relevant and removing av_image_fill_pointers_from_sizes() Some things to note: - The av_image_fill_planes_sizes uses size_t/ptrdiff_t for buffer sizes, but as mentioned during the v1 review, this leads to

[FFmpeg-devel] [PATCH v2 2/3] libavcodec/decode: avoid UB when getting plane sizes

2020-07-08 Thread Brian Kim
Patch attached From 6e28dfde91443fba276fdd792dee9480c0b00558 Mon Sep 17 00:00:00 2001 From: Brian Kim Date: Tue, 7 Jul 2020 11:42:04 -0700 Subject: [PATCH 2/3] libavcodec/decode: avoid UB when getting plane sizes This uses av_image_fill_plane_sizes instead of av_image_fill_pointers when we are

Re: [FFmpeg-devel] [PATCH v2 3/3] libavutil/imgutils: check for non-null buffer in av_image_fill_pointer

2020-07-08 Thread Brian Kim
Patch attached. There was some discussion on the v1 thread on whether it was acceptable to break code that was relying on UB, so this patch will probably want to get delayed until a major version bump to avoid breaking places that were relying on av_image_fill_pointers() populating data when the

Re: [FFmpeg-devel] [PATCH v2 3/3] libavutil/imgutils: check for non-null buffer in av_image_fill_pointer

2020-07-08 Thread James Almer
On 7/8/2020 10:54 PM, Brian Kim wrote: > Patch attached. > > There was some discussion on the v1 thread on whether it was > acceptable to break code that was relying on UB, so this patch will > probably want to get delayed until a major version bump to avoid > breaking places that were relying on

Re: [FFmpeg-devel] [PATCH v2 1/3] libavutil/imgutils: add utility to get plane sizes

2020-07-08 Thread James Almer
On 7/8/2020 10:50 PM, Brian Kim wrote: > Patch attached. > > Main changes from v1 are switching to from int to size_t/ptrdiff_t > where relevant and removing av_image_fill_pointers_from_sizes() > > Some things to note: > - The av_image_fill_planes_sizes uses size_t/ptrdiff_t for buffer > sizes,

Re: [FFmpeg-devel] [PATCH V3] tests/dnn/mathunary: fix the issue of NAN

2020-07-08 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年7月8日 14:10 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V3] tests/dnn/mathunary: fix the issue of NAN > > When one of output[i] & expected_output is NAN, the unit test will always > pass. >