Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Hendrik Leppkes
On Tue, Jul 27, 2021 at 5:50 AM Gyan Doshi wrote: > > > > On 2021-07-26 22:51, Hendrik Leppkes wrote: > > On Mon, Jul 26, 2021 at 5:16 PM Gyan Doshi wrote: > >> > >> > >> On 2021-07-26 19:49, Steven Liu wrote: > >>> 在 2021年7月26日星期一,Gyan Doshi 写道: > >>> > On 2021-07-26 16:39, Steven Liu

Re: [FFmpeg-devel] [PATCH] avformat/concat: finalize the AVBprint buffer immediately

2021-07-26 Thread James Almer
On 7/26/2021 6:49 PM, Marton Balint wrote: On Mon, 26 Jul 2021, James Almer wrote: Don't attempt to read its contents in place. Fixes invalid reads when run under Valgrind. As far as I remember AVBPrint buffer CAN be read in place by design, zero terminator is always guaranteed, not only

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Gyan Doshi
On 2021-07-27 04:28, Steven Liu wrote: 在 2021年7月26日星期一,Gyan Doshi 写道: On 2021-07-26 19:49, Steven Liu wrote: 在 2021年7月26日星期一,Gyan Doshi 写道: On 2021-07-26 16:39, Steven Liu wrote: 2021年7月26日 下午6:57,Gyan Doshi 写道: Are you referring to the choice of FLV_CODECID values? Not only, you

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Gyan Doshi
On 2021-07-26 22:51, Hendrik Leppkes wrote: On Mon, Jul 26, 2021 at 5:16 PM Gyan Doshi wrote: On 2021-07-26 19:49, Steven Liu wrote: 在 2021年7月26日星期一,Gyan Doshi 写道: On 2021-07-26 16:39, Steven Liu wrote: 2021年7月26日 下午6:57,Gyan Doshi 写道: Are you referring to the choice of FLV_CODECID

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Steven Liu
在 2021年7月27日星期二,Gyan Doshi 写道: > > > On 2021-07-27 04:28, Steven Liu wrote: > >> 在 2021年7月26日星期一,Gyan Doshi 写道: >> >> >>> On 2021-07-26 19:49, Steven Liu wrote: >>> >>> 在 2021年7月26日星期一,Gyan Doshi 写道: On 2021-07-26 16:39, Steven Liu wrote: > > 2021年7月26日 下午6:57,Gyan Doshi

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Gyan Doshi
On 2021-07-26 13:45, Steven Liu wrote: 2021年7月26日 上午11:44,Gyan Doshi 写道: On 2021-07-25 19:07, James Almer wrote: On 7/25/2021 10:04 AM, Xiaolei Yu wrote: Explicitly supply an HEVC codec id to enable this feature. --- libavformat/flv.h| 1 + libavformat/flvdec.c | 21

Re: [FFmpeg-devel] Fix x264 SEI offset

2021-07-26 Thread Jack Waller
Oops Sent wrong patch, Please use the following: diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 9afaf19547..f78365a4f7 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -936,7 +936,7 @@ static av_cold int X264_init(AVCodecContext *avctx) for (i = 0; i <

Re: [FFmpeg-devel] [PATCH 2/2] libswscale: Adds ff_hscale8to15_4_avx2 and ff_hscale8to15_X4_avx2 for all filter sizes.

2021-07-26 Thread Alan Kelly
On Wed, Jul 21, 2021 at 11:11 AM Alan Kelly wrote: > > > On Fri, Jul 16, 2021 at 3:48 PM Alan Kelly wrote: > >> These functions replace all ff_hscale8to15_*_ssse3 when avx2 is available. >> --- >> EXTERNAL_AVX2_FAST is now used instead of EXTERNAL_AVX2_FAST_GATHER as >> discussed in the email

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Steven Liu
> 2021年7月26日 下午6:57,Gyan Doshi 写道: > > Are you referring to the choice of FLV_CODECID values? Not only, you can find whole history on: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/ https://trac.ffmpeg.org/ticket/6389 https://trac.ffmpeg.org/ticket/3581 And there have lots of use case in

[FFmpeg-devel] [PATCH] avformat/concat: finalize the AVBprint buffer immediately

2021-07-26 Thread James Almer
Don't attempt to read its contents in place. Fixes invalid reads when run under Valgrind. Signed-off-by: James Almer --- libavformat/concat.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/concat.c b/libavformat/concat.c index aec1f52d8e..64ac03e1d8

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Steven Liu
> 2021年7月26日 上午11:44,Gyan Doshi 写道: > > > > On 2021-07-25 19:07, James Almer wrote: >> On 7/25/2021 10:04 AM, Xiaolei Yu wrote: >>> Explicitly supply an HEVC codec id to enable this feature. >>> --- >>> libavformat/flv.h| 1 + >>> libavformat/flvdec.c | 21 ++--- >>>

[FFmpeg-devel] [PATCH] avfilter/avf_concat: fix EOF timestamp

2021-07-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avf_concat.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c index cb46f52a04..f7d3889dfa 100644 --- a/libavfilter/avf_concat.c +++ b/libavfilter/avf_concat.c @@ -397,12

Re: [FFmpeg-devel] [PATCH] avfilter/avf_concat: fix EOF timestamp

2021-07-26 Thread Nicolas George
Paul B Mahol (12021-07-26): > Signed-off-by: Paul B Mahol > --- > libavfilter/avf_concat.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c > index cb46f52a04..f7d3889dfa 100644 > --- a/libavfilter/avf_concat.c

Re: [FFmpeg-devel] [PATCH] avformat/concat: finalize the AVBprint buffer immediately

2021-07-26 Thread Marton Balint
On Mon, 26 Jul 2021, James Almer wrote: Don't attempt to read its contents in place. Fixes invalid reads when run under Valgrind. As far as I remember AVBPrint buffer CAN be read in place by design, zero terminator is always guaranteed, not only after finalizing. So this should not be

Re: [FFmpeg-devel] [PATCH] avformat/concat: finalize the AVBprint buffer immediately

2021-07-26 Thread Nicolas George
Marton Balint (12021-07-26): > As far as I remember AVBPrint buffer CAN be read in place by design, zero > terminator is always guaranteed, not only after finalizing. So this should > not be needed. What is causing the invalid reads exactly? I confirm your memory. The documentation states: *

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Steven Liu
在 2021年7月26日星期一,Gyan Doshi 写道: > > > On 2021-07-26 19:49, Steven Liu wrote: > >> 在 2021年7月26日星期一,Gyan Doshi 写道: >> >> >>> On 2021-07-26 16:39, Steven Liu wrote: >>> >>> 2021年7月26日 下午6:57,Gyan Doshi 写道: > Are you referring to the choice of FLV_CODECID values? > > Not only, you

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Steven Liu
在 2021年7月27日星期二,Hendrik Leppkes 写道: > On Mon, Jul 26, 2021 at 5:16 PM Gyan Doshi wrote: > > > > > > > > On 2021-07-26 19:49, Steven Liu wrote: > > > 在 2021年7月26日星期一,Gyan Doshi 写道: > > > > > >> > > >> On 2021-07-26 16:39, Steven Liu wrote: > > >> > > >>> 2021年7月26日 下午6:57,Gyan Doshi 写道: > >

[FFmpeg-devel] [PATCH v3 1/2] avformat/ttml: split TTML paragraph based or not check into header

2021-07-26 Thread Jan Ekström
From: Jan Ekström This way it can be re-utilized in movenc. Signed-off-by: Jan Ekström --- libavformat/ttmlenc.c | 9 ++--- libavformat/ttmlenc.h | 39 +++ 2 files changed, 41 insertions(+), 7 deletions(-) create mode 100644 libavformat/ttmlenc.h

[FFmpeg-devel] [PATCH v3 0/2] TTML in MP4, part 1

2021-07-26 Thread Jan Ekström
To keep it simpler this first part includes only non-fragmented use cases if the built-in sample squashing is utilized. Contains the basic mapping code as well as the function that writes out the squashed documents. Works with both subtitle-only output as well as with other streams. In a

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Gyan Doshi
On 2021-07-26 19:49, Steven Liu wrote: 在 2021年7月26日星期一,Gyan Doshi 写道: On 2021-07-26 16:39, Steven Liu wrote: 2021年7月26日 下午6:57,Gyan Doshi 写道: Are you referring to the choice of FLV_CODECID values? Not only, you can find whole history on:

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Steven Liu
在 2021年7月26日星期一,Gyan Doshi 写道: > > > On 2021-07-26 16:39, Steven Liu wrote: > >> >> 2021年7月26日 下午6:57,Gyan Doshi 写道: >>> >>> Are you referring to the choice of FLV_CODECID values? >>> >> Not only, you can find whole history on: >> >> https://lists.ffmpeg.org/pipermail/ffmpeg-devel/ >>

[FFmpeg-devel] Fix x264 SEI offset

2021-07-26 Thread Jack Waller
Dear: The libavcodec/libx264.c uses the wrong offset to obtain the SEI diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index f78365a4f7..9afaf19547 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -936,7 +936,7 @@ static av_cold int X264_init(AVCodecContext *avctx)

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Gyan Doshi
On 2021-07-26 16:39, Steven Liu wrote: 2021年7月26日 下午6:57,Gyan Doshi 写道: Are you referring to the choice of FLV_CODECID values? Not only, you can find whole history on: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/ https://trac.ffmpeg.org/ticket/6389 https://trac.ffmpeg.org/ticket/3581

[FFmpeg-devel] [PATCH v3 2/2] avformat/movenc: add support for TTML muxing

2021-07-26 Thread Jan Ekström
From: Jan Ekström Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') methods. This initial version also foregoes fragmentation support in case the built-in sample squashing is to be utilized, as this eases the initial review. Additionally, add basic tests for both muxing modes

Re: [FFmpeg-devel] [PATCH] libavformat/flvdec: add HEVC demuxing support

2021-07-26 Thread Hendrik Leppkes
On Mon, Jul 26, 2021 at 5:16 PM Gyan Doshi wrote: > > > > On 2021-07-26 19:49, Steven Liu wrote: > > 在 2021年7月26日星期一,Gyan Doshi 写道: > > > >> > >> On 2021-07-26 16:39, Steven Liu wrote: > >> > >>> 2021年7月26日 下午6:57,Gyan Doshi 写道: > Are you referring to the choice of FLV_CODECID values? >