[FFmpeg-devel] Initial tickering at unifying ProRes encoder

Hello there, I'm currently investigating an issue¹ affecting Kostya ProRes encoder which is not reproducible with Anatoliy encoder (but it's too early to say if the bug is not present there as well given the differences in quantization, and it's also unclear if the issue is even actually there in

[FFmpeg-devel] [PATCH 01/35] avcodec/proresenc_kostya: remove an unnecessary parenthesis level in MAKE_CODE() macro

--- libavcodec/proresenc_kostya.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 52fe5639b1..58fc340879 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/proresenc_kostya.c @@ -429,7 +429,7 @@ static

[FFmpeg-devel] [PATCH 02/35] avcodec/proresenc_kostya: remove unused plane factor variables

--- libavcodec/proresenc_kostya.c | 36 --- 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 58fc340879..7aed3974c3 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/prorese

[FFmpeg-devel] [PATCH 03/35] avcodec/proresenc_kostya: remove redundant codebook assignments

This is already assigned at declaration. --- libavcodec/proresenc_kostya.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 7aed3974c3..6e1d5a0cef 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/proresenc_kostya.c

[FFmpeg-devel] [PATCH 04/35] avcodec/proresenc_anatoliy: move run/lev to codebook LUT to shared proresdata

This is going to be shared with proresenc_kostya in the upcoming commit. --- libavcodec/proresdata.c | 6 ++ libavcodec/proresdata.h | 2 ++ libavcodec/proresenc_anatoliy.c | 9 ++--- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libavcodec/proresdata.c b/

[FFmpeg-devel] [PATCH 05/35] avcodec/proresenc_kostya: remove one LUT indirection for run/level to codebook mapping

This is following the same logic as proresenc_anatoliy. --- libavcodec/proresenc_kostya.c | 47 +++ 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 6e1d5a0cef..f883ab550b 100644 ---

[FFmpeg-devel] [PATCH 08/35] avcodec/proresenc_kostya: save a few operations in DC encoding

This matches the logic from proresenc_anatoliy. --- libavcodec/proresenc_kostya.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index f883ab550b..2d45f9a685 100644 --- a/libavcodec/proresenc_

[FFmpeg-devel] [PATCH 09/35] avcodec/proresenc_kostya: fix chroma quantisation matrix in frame header

--- libavcodec/proresenc_kostya.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 2d45f9a685..103051830a 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/proresenc_kostya.c @@ -1019,7 +1019,7 @@ stat

[FFmpeg-devel] [PATCH 10/35] avcodec/proresenc_kostya: simplify quantization matrix bytestream writing

--- libavcodec/proresenc_kostya.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 103051830a..e0aa7cf47a 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/proresenc_kostya.c @@ -1014,12 +1014,

[FFmpeg-devel] [PATCH 06/35] avcodec/proresenc_anatoliy: remove duplicated define

This is already defined in proresdata.h --- libavcodec/proresenc_anatoliy.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 6b2e513bed..c6f49be9b8 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/proresenc_an

[FFmpeg-devel] [PATCH 12/35] avcodec/proresenc_anatoliy: shuffle encode_codeword() code to match Kostya encoder

Code is functionally identical, it's just rename of variables, cosmetics and branch logic shuffling. --- libavcodec/proresenc_anatoliy.c | 45 + 1 file changed, 23 insertions(+), 22 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_an

[FFmpeg-devel] [PATCH 11/35] avcodec/proresenc_anatoliy: use FRAME_ID defined in proresdata.h

--- libavcodec/proresenc_anatoliy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index d6f5cefc16..804ff6ddf7 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/proresenc_anatoliy.c @@ -755,7 +755,7

[FFmpeg-devel] [PATCH 13/35] avcodec/proresenc_anatoliy: rework encode_codeword() prototype

This matches the function of the same name in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index c7e43fc88c..86e436615c 100644 --- a/libavcodec/

[FFmpeg-devel] [PATCH 14/35] avcodec/proresenc_anatoliy: inline QSCALE()

Also replaces 16384 with 0x4000. This makes the function slightly closer to same function in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 86e

[FFmpeg-devel] [PATCH 15/35] avcodec/proresenc_anatoliy: rename new_code/code to code/codebook

This makes the function closer to encode_dcs() in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index b8433ee872..e79c465590 100644 --- a/l

[FFmpeg-devel] [PATCH 16/35] avcodec/proresenc_anatoliy: execute codebook FFMIN() at assignment

This makes the function closer to encode_dcs() in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index e79c465590..f8feff850f 100644 --- a/libavcodec/pro

[FFmpeg-devel] [PATCH 17/35] avcodec/proresenc_anatoliy: reduce DC encoding function prototype differences with Kostya encoder

--- libavcodec/proresenc_anatoliy.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index f8feff850f..97d681467d 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/proresenc_anatoliy.c @@ -2

[FFmpeg-devel] [PATCH 20/35] avcodec/proresenc_anatoliy: compute sign only once

This makes the function closer to encode_dcs() in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 0de262c9c5..0d8ca5515f 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 18/35] avcodec/proresenc_anatoliy: directly work with blocks in encode_dcs()

This makes the function closer to encode_dcs() in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 97d681467d..a418a12705 100644 --- a/libavcode

[FFmpeg-devel] [PATCH 19/35] avcodec/proresenc_anatoliy: import GET_SIGN() macro from Kostya encoder and use it

--- libavcodec/proresenc_anatoliy.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index a418a12705..0de262c9c5 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/proresenc_anatoliy.c @@ -255,9

[FFmpeg-devel] [PATCH 21/35] avcodec/proresenc_anatoliy: rename new_dc to dc

This makes the function closer to encode_dcs() in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 0d8ca5515f..4ea3d89126 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 23/35] avcodec/proresenc_kostya: add Anatoliy copyright

Both encoders share a lot of code from both authors. --- libavcodec/proresenc_kostya.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index e0aa7cf47a..c6c045be73 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/proresen

[FFmpeg-devel] [PATCH 22/35] avcodec/proresenc_anatoliy: remove IS_NEGATIVE() macro

This makes the function closer to encode_acs() in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 4ea3d89126..43dee7f79b 100644 --- a/libavcodec/prore

[FFmpeg-devel] [PATCH 24/35] avcodec/proresenc_anatoliy: rename TO_GOLOMB() to MAKE_CODE()

This matches the name in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 43dee7f79b..4b72798689 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/l

[FFmpeg-devel] [PATCH 25/35] avcodec/proresenc_anatoliy: shuffle declarations around in encode_dcs()

This makes the function closer to the same function in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 4b72798689..56baeb9956 100644 --- a/l

[FFmpeg-devel] [PATCH 26/35] avcodec/proresenc_anatoliy: only pass down the first scale to encode_dcs()

This matches encode_dcs() prototype from proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 56baeb9956..bdf7bface4 100644 --- a/libavcodec/proresen

[FFmpeg-devel] [PATCH 27/35] avcodec/proresenc_anatoliy: remove TO_GOLOMB2()

A few cosmetics aside, this makes the function identical to the one with the same name in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index bdf7bfac

[FFmpeg-devel] [PATCH 28/35] avcodec/proresenc_anatoliy: cosmetics to make encode_dcs() identical to the one in Kostya encoder

--- libavcodec/proresenc_anatoliy.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index aed5c68b1b..0318379461 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/proresenc_anatoli

[FFmpeg-devel] [PATCH 29/35] avcodec/proresenc_anatoliy: replace get_level() with FFABS()

This matches the code from proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 0318379461..88c6d47ab7 100644 --- a/libavcodec/proresenc_anatoliy.c +

[FFmpeg-devel] [PATCH 30/35] avcodec/proresenc_anatoliy: rework encode_ac_coeffs() prototype

This makes the prototype closer to the function of the same name in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 88c6d47ab7..57324a3b27 1006

[FFmpeg-devel] [PATCH 31/35] avcodec/proresenc_anatoliy: avoid using ff_ prefix in function arguments

--- libavcodec/proresenc_anatoliy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 57324a3b27..816c27e481 100644 --- a/libavcodec/proresenc_anatoliy.c +++ b/libavcodec/proresenc_anatoliy.c @@ -284,

[FFmpeg-devel] [PATCH 32/35] avcodec/proresenc_anatoliy: rework inner loop in encode_acs()

This matches the logic from the function of the same name in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 816c27e481..161a05a6e6 100644 -

[FFmpeg-devel] [PATCH 34/35] avcodec/proresenc_anatoliy: make a few cosmetics in encode_acs()

This makes the function pretty much identical to the function of the same name in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c i

[FFmpeg-devel] [PATCH 33/35] avcodec/proresenc_anatoliy: execute AC run/level FFMIN() at assignment

This matches the logic from the function of the same name in proresenc_kostya. --- libavcodec/proresenc_anatoliy.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c index 161a05a6e6..2515ee38f8 100644

[FFmpeg-devel] [PATCH 35/35] avcodec/proresenc_kostya: make a few cosmetics in encode_acs()

Unify cosmetics with encode_acs() from proresenc_anatoliy. --- libavcodec/proresenc_kostya.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index c6c045be73..05e90bb236 100644 --- a/libavcodec/proresenc_kost

[FFmpeg-devel] [PATCH 07/35] avcodec/proresenc_anatoliy: move DC codebook LUT to shared proresdata

This is going to be shared with proresenc_kostya in the upcoming commit. --- libavcodec/proresdata.c | 2 ++ libavcodec/proresdata.h | 1 + libavcodec/proresenc_anatoliy.c | 3 +-- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/proresdata.c b/libavcodec/p

Re: [FFmpeg-devel] Initial tickering at unifying ProRes encoder

On Mon, Dec 11, 2023 at 10:15:09AM +0100, Anton Khirnov wrote: > Quoting Clément Bœsch (2023-12-11 02:35:01) > > Hello there, > > > > I'm currently investigating an issue¹ affecting Kostya ProRes encoder > > which is not reproducible with Anatoliy encoder (but it&#

[FFmpeg-devel] Misc ProRes frame header conformity fixes

A bunch of fixes (currently made on top of the previous patchset but shouldn't conflict much with a rebase) which are not extensively tested. If some people have specific decoders available, tests are welcome. ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH 1/5] avcodec/proresenc_anatoliy: use a compatible bitstream version

Quoting SMPTE RDD 36:2015: A decoder shall abort if it encounters a bitstream with an unsupported bitstream_version value. If 0, the value of the chroma_format syntax element shall be 2 (4:2:2 sampling) and the value of the alpha_channel_type element shall be 0 (no encoded alpha); if 1, any

[FFmpeg-devel] [PATCH 2/5] avcodec/proresenc_kostya: use a compatible bitstream version

Quoting SMPTE RDD 36:2015: A decoder shall abort if it encounters a bitstream with an unsupported bitstream_version value. If 0, the value of the chroma_format syntax element shall be 2 (4:2:2 sampling) and the value of the alpha_channel_type element shall be 0 (no encoded alpha); if 1, any

[FFmpeg-devel] [PATCH 3/5] avcodec/proresenc_kostya: do not write into alpha reserved bitfields

This byte represents 4 reserved bits followed by 4 alpha_channel_type bits. alpha_channel_type currently has 3 differents defined values: 0 (no alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are reserved. This part is correctly written (alpha_bits>>3 does the correct thing), but the

[FFmpeg-devel] [PATCH 4/5] avcodec/proresenc_anatoliy: do not write into alpha reserved bitfields

This byte represents 4 reserved bits followed by 4 alpha_channel_type bits. alpha_channel_type currently has 3 differents defined values: 0 (no alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are reserved. The 4 initial reserved bits are expected to be 0. --- libavcodec/proresenc_an

[FFmpeg-devel] [PATCH 5/5] avcodec/proresenc_anatoliy: do not write into chroma reserved bitfields

The layout for the frame flags is as follow: chroma_format u(2) reserved u(2) interlace_mode u(2) reserved u(2) chroma_format has 2 allowed values: 0: reserved 1: reserved 2: 4:2:2 3: 4:4:4 interlace_mode has 3 allowed values: 0: progressive 1: tff 2

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: add cineSpace 3D lut support

On Fri, Apr 19, 2019 at 07:53:37PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 2 + > libavfilter/vf_lut3d.c | 91 ++ > 2 files changed, 93 insertions(+) > LGTM -- Clément B. signature.asc Description: PG

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: add cineSpace 1D lut parsing

On Fri, Apr 19, 2019 at 07:53:36PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 2 ++ > libavfilter/vf_lut3d.c | 77 ++ > 2 files changed, 79 insertions(+) > LGTM -- Clément B. signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

On Thu, Apr 25, 2019 at 04:47:00PM +0200, Paul B Mahol wrote: > On 4/25/19, Reto Kromer wrote: > > Paul B Mahol wrote: > > > >>Found 65x65x65 3D LUT in wild > > > > FYI: 128x128x128 3D LUTs do also exist in film production. > > > > Thank you, changed locally. This means one single malloc of 24M

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: fix range domain processing for .cube format

On Thu, Apr 25, 2019 at 02:57:26PM +0200, Paul B Mahol wrote: > The ranges are for input, not for output. > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_lut3d.c | 73 +- > 1 file changed, 51 insertions(+), 22 deletions(-) > LGTM, thanks -- Clém

Re: [FFmpeg-devel] [PATCH] avformat/subtitles: ignore extra '\r' at line endings

On Thu, Apr 25, 2019 at 11:22:47PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/microdvddec.c | 2 ++ > libavformat/subtitles.c | 2 +- > libavformat/subtitles.h | 2 +- > 3 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/microdvdde

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: increase MAX_LEVEL

On Sat, Apr 27, 2019 at 12:29:44PM +0200, Paul B Mahol wrote: > On 4/27/19, Clément Bœsch wrote: > > On Thu, Apr 25, 2019 at 04:47:00PM +0200, Paul B Mahol wrote: > >> On 4/25/19, Reto Kromer wrote: > >> > Paul B Mahol wrote: > >> > > >>

Re: [FFmpeg-devel] [PATCH] avfilter/f_ebur128: use correct type for chl

On Mon, Apr 29, 2019 at 04:47:52PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/f_ebur128.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c > index f613d8def2..f25d5f096e 100644 > --- a/lib

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

On Sun, Feb 23, 2020 at 09:59:59PM +0100, Michael Niedermayer wrote: [...] > > The subtitles refactor requires to see the big picture and all the problems > > at > > once. > > really ? > just hypothetically, and playing the devils advocat here. > what would happen if one problem or set of proble

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

On Thu, Feb 27, 2020 at 12:35:03PM +0100, Anton Khirnov wrote: [...] > AFAIU one of the still-open questions for the subtitle redesign is what > does it mean to decode or encode a subtitle. There are multiple markups available for text subtitles, and there are multiple ways of representing graphic

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

On Thu, Feb 27, 2020 at 07:36:24PM +0100, Clément Bœsch wrote: [...] > And then you can't have them in libavfilter, so you can't have a sane > harmony with medias including subtitle streams. It's problematic with many > basic use cases. One random example: if you'

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

On Fri, Feb 28, 2020 at 05:55:19AM +0100, Anton Khirnov wrote: > Quoting Clément Bœsch (2020-02-27 19:36:24) > > On Thu, Feb 27, 2020 at 12:35:03PM +0100, Anton Khirnov wrote: > > [...] > > > AFAIU one of the still-open questions for the subtitle redesign is what > &g

Re: [FFmpeg-devel] [PATCH] avfilter/f_ebur128: add all sample rates support

On Thu, Mar 04, 2021 at 04:05:53PM +0100, Paul B Mahol wrote: [...] > +double f0 = 1681.974450955533; > +double G = 3.999843853973347; > +double Q = 0.7071752369554196; > + > +double K = tan(M_PI * f0 / (double)inlink->sample_rate); > +double Vh = pow(10.0, G / 20.0); > +dou

Re: [FFmpeg-devel] [PATCH] avfilter/vf_nlmeans: round values toward nearest integer

On Sun, Oct 20, 2019 at 09:54:16PM +0200, Paul B Mahol wrote: > Instead of rounding toward zero and thus producing > darker output. > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_nlmeans.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_nlmeans.c

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: allocate 3d lut dynamically

On Fri, Oct 25, 2019 at 11:27:48AM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_lut3d.c | 165 +++-- > 1 file changed, 108 insertions(+), 57 deletions(-) > LGTM [...] -- Clément B.

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: increase max level to upper limit defined by cube format specification

On Fri, Oct 25, 2019 at 11:27:49AM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_lut3d.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c > index 8ef1bb7385..edaf9a711e 100644 > --- a/libavf

Re: [FFmpeg-devel] [aarch64] improve performance of ff_hscale_8_to_15_neon

On Wed, Nov 27, 2019 at 07:36:01PM +, Pop, Sebastian wrote: > Thanks Jean-Baptiste for your review and suggestions on how to improve my > patch submission. > From the git logs I found out that Clément Bœsch wrote the original aarch64 > vectorization for that function. > Mayb

Re: [FFmpeg-devel] [aarch64] improve performance of ff_hscale_8_to_15_neon

On Wed, Nov 27, 2019 at 12:30:35PM -0600, Sebastian Pop wrote: [...] > From 9ecaa99fab4b8bedf3884344774162636eaa5389 Mon Sep 17 00:00:00 2001 > From: Sebastian Pop > Date: Sun, 17 Nov 2019 14:13:13 -0600 > Subject: [PATCH] [aarch64] use FMA and increase vector factor to 4 > > This patch implement

Re: [FFmpeg-devel] [PATCH] avfilter/vf_nlmeans: add >8 bit support

On Wed, Nov 20, 2019 at 10:54:42AM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/aarch64/vf_nlmeans_init.c | 6 +- > libavfilter/nlmeans_template.c| 370 ++ > libavfilter/vf_nlmeans.c | 539 ++ > libavfi

Re: [FFmpeg-devel] [aarch64] improve performance of ff_hscale_8_to_15_neon

On Wed, Dec 04, 2019 at 05:24:46PM -0600, Sebastian Pop wrote: > Hi Clément, > > please find attached the updated patch addressing all your comments. > Let me know if there is anything else that I missed and that I need to > address. > I can't test but patch LGTM. Aside from the commit message:

Re: [FFmpeg-devel] [aarch64] improve performance of ff_hscale_8_to_15_neon

On Sun, Dec 08, 2019 at 11:08:31PM +0200, Martin Storsjö wrote: > On Sun, 8 Dec 2019, Clément Bœsch wrote: > > > On Wed, Dec 04, 2019 at 05:24:46PM -0600, Sebastian Pop wrote: > > > Hi Clément, > > > > > > please find attached the updated patch addressing

Re: [FFmpeg-devel] [aarch64] improve performance of ff_yuv2planeX_8_neon

On Tue, Dec 10, 2019 at 04:38:25PM -0600, Sebastian Pop wrote: > Hi, > > This patch rewrites the innermost loop of ff_yuv2planeX_8_neon to avoid zips > and > horizontal adds by using fused multiply adds. The patch also uses ld1r to load > one element and replicate it across all lanes of the vecto

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

On Fri, Feb 14, 2020 at 03:26:30AM +, Soft Works wrote: > Hi, > Hi, > I am looking for some guidance regarding future plans about processing > subtitle streams in filter graphs. > > Please correct me where I'm wrong - this is the situation as I've understood > it so far: [...] Your analy

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

On Sat, Feb 22, 2020 at 10:59:46AM +, Soft Works wrote: [...] > Reading through the discussion around your patch was discouraging, > even destructive in some parts. I understand why you felt alone with that > and I wonder why nobody else chimed in. I mean, sometimes there are > extensive disc

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

On Sat, Feb 22, 2020 at 12:51:13PM +, Soft Works wrote: [...] > > > Would there be any filters at all that would operate on subtitles? > > > (other than rendering to a video surface) > > > > Sure. A few ideas that come to my mind: > > > > - rasterization (text subtitles to bitmap subtitles)

Re: [FFmpeg-devel] [PATCH] palettegen: Fill with last color, not black

On Wed, Jan 16, 2019 at 01:40:20PM +0100, Tomas Härdin wrote: > Hi > > I was helping the fine folks at peppercarrot.com with web video > nonsense, and I notice palettegen outputs more colors than it should > due to padding the generated palette with pure black. > > Compare this (ffmpeg version 3.

Re: [FFmpeg-devel] [PATCH] avfilter/vf_paletteuse: don't constantly free and realloc internal frames

On Tue, Jan 15, 2019 at 01:14:34AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/vf_paletteuse.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c > index 5966f10685..2

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

On Fri, Feb 01, 2019 at 10:45:24AM +0800, Jun Zhao wrote: > Remove the pdiff_lut_scale in nlmeans and increase weight_lut table size > from 2^9 to 80, this change will avoid using pdiff_lut_scale in > nlmeans_slice() for weight_lut table search, it's will improve the > performance about 12%. (i

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

On Fri, Feb 01, 2019 at 04:57:37PM +0800, myp...@gmail.com wrote: [...] > > > -#define WEIGHT_LUT_NBITS 9 > > > -#define WEIGHT_LUT_SIZE (1< > > +#define WEIGHT_LUT_SIZE (80) // need to > 300 * 300 * log(255) > > > > So the LUT is now 3.2MB? > > > > Why 300? 300*300*log(255) is closer to 500

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

On Fri, Feb 01, 2019 at 05:19:53PM +0800, myp...@gmail.com wrote: > On Fri, Feb 1, 2019 at 5:11 PM Clément Bœsch wrote: > > > > On Fri, Feb 01, 2019 at 04:57:37PM +0800, myp...@gmail.com wrote: > > [...] > > > > > -#define WEIGHT_LUT_NBITS 9 &g

Re: [FFmpeg-devel] [PATCH V2] lavfi/vf_nlmeans: Improve the performance for nlmeans

On Fri, Feb 01, 2019 at 05:50:37PM +0800, myp...@gmail.com wrote: [...] > > Ok, makes sense. Would you mind updating the comment to something like: > > > > /* Note: WEIGHT_LUT_SIZE must be larger than max_meaningful_diff > > * (log(255)*max(h)^2, which is approximately 50 with the curr

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP1 and MP2 as distinct containers from MP3

On Sat, Mar 18, 2017 at 10:52:27AM +0100, wm4 wrote: [...] > > -if (!strcmp(s->iformat->name, "mp3") || !strcmp(s->iformat->name, > > "aac") || > > -!strcmp(s->iformat->name, "tta")) { > > +if (!strcmp(s->iformat->name, "mp1") || !strcmp(s->iformat->name, > > "mp2") ||

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: add dash demuxer base version

On Sun, Mar 19, 2017 at 05:05:55PM +0800, Steven Liu wrote: > ffmpeg need a dash demuxer for demux the dash formats > base on > https://github.com/samsamsam-iptvplayer/exteplayer3/blob/master/tmp/ffmpeg/patches/3.2.2/01_add_dash_demux.patch > > Signed-off-by: Steven Liu > --- > configure

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: add dash demuxer base version

On Sun, Mar 19, 2017 at 05:51:15PM +0800, Steven Liu wrote: > 2017-03-19 17:48 GMT+08:00 Clément Bœsch : > > > On Sun, Mar 19, 2017 at 05:05:55PM +0800, Steven Liu wrote: > > > ffmpeg need a dash demuxer for demux the dash formats > > > base on https://github.com/sa

[FFmpeg-devel] [PATCH 1/2] fate: add fate-sws-pixdesc-query

@@ -1,2 +1,3 @@ /colorspace +/pixdesc_query /swscale diff --git a/libswscale/tests/pixdesc_query.c b/libswscale/tests/pixdesc_query.c new file mode 100644 index 00..d1ce1eb4a8 --- /dev/null +++ b/libswscale/tests/pixdesc_query.c @@ -0,0 +1,78 @@ +/* + * Copyright (c) 2017 Clément Bœsch

[FFmpeg-devel] [PATCH 2/2] swscale: use a function for isGray

--- libswscale/swscale_internal.h | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index af82396b1c..6bcb4640ee 100644 --- a/libswscale/swscale_internal.h +++ b/libswscale/swscale_interna

Re: [FFmpeg-devel] [PATCH 1/2] fate: add fate-sws-pixdesc-query

On Sun, Mar 19, 2017 at 03:00:55PM +0100, Clément Bœsch wrote: > Test the pixel format querying within libswscale. > --- > libswscale/Makefile | 1 + > libswscale/tests/.gitignore | 1 + > libswscale/tests/pixdesc_query.c | 78 &g

[FFmpeg-devel] Patchset v2 for pixel format querying within swscale

This is in response to the next Libav commit I'll (partially) noop soon (aa37d2bf45). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/5] swscale: use a function for isGray

--- libswscale/swscale_internal.h | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index af82396b1c..6bcb4640ee 100644 --- a/libswscale/swscale_internal.h +++ b/libswscale/swscale_interna

[FFmpeg-devel] [PATCH 3/5] swscale: use a function for isBayer

--- libswscale/swscale_internal.h | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index 6bcb4640ee..b3bb1695fb 100644 --- a/libswscale/swscale_internal.h +++ b/libswscale/swscale_internal.h @@ -

[FFmpeg-devel] [PATCH 1/5] fate: add fate-sws-pixdesc-query

+1,3 @@ /colorspace +/pixdesc_query /swscale diff --git a/libswscale/tests/pixdesc_query.c b/libswscale/tests/pixdesc_query.c new file mode 100644 index 00..bc49809d4b --- /dev/null +++ b/libswscale/tests/pixdesc_query.c @@ -0,0 +1,90 @@ +/* + * Copyright (c) 2017 Clément Bœsch

[FFmpeg-devel] [PATCH 5/5] swscale: use a (more correct) function for isPacked

--- libswscale/swscale_internal.h| 21 +++-- tests/ref/fate/sws-pixdesc-query | 19 +++ 2 files changed, 22 insertions(+), 18 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index 9a28d180f1..2c2329ae56 100644 --- a/libsw

[FFmpeg-devel] [PATCH 4/5] swscale: use a function for isAnyRGB

--- libswscale/swscale_internal.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libswscale/swscale_internal.h b/libswscale/swscale_internal.h index b3bb1695fb..9a28d180f1 100644 --- a/libswscale/swscale_internal.h +++ b/libswscale/swscale_internal.h @@ -767,13

Re: [FFmpeg-devel] [PATCH 3/5] swscale: use a function for isBayer

On Sun, Mar 19, 2017 at 04:35:12PM +0100, Michael Niedermayer wrote: > On Sun, Mar 19, 2017 at 03:33:41PM +0100, Clément Bœsch wrote: > > --- > > libswscale/swscale_internal.h | 20 ++-- > > 1 file changed, 6 insertions(+), 14 deletions(-) > >

Re: [FFmpeg-devel] [PATCH v7] - Added Turing codec interface for ffmpeg

On Tue, Feb 21, 2017 at 05:15:59PM +, Saverio Blasi wrote: [...] > enabled libspeex && require_pkg_config speex speex/speex.h > speex_decoder_init -lspeex > enabled libtesseract && require_pkg_config tesseract tesseract/capi.h > TessBaseAPICreate > enabled libtheora &

Re: [FFmpeg-devel] [PATCH 3/5] swscale: use a function for isBayer

On Sun, Mar 19, 2017 at 10:13:37PM +0100, Michael Niedermayer wrote: [...] > > > > +static av_always_inline int isBayer(enum AVPixelFormat pix_fmt) > > > > +{ > > > > +const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(pix_fmt); > > > > +av_assert0(desc); > > > > +return !strncmp(desc

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/wavpack: Check shift

On Mon, Mar 20, 2017 at 02:21:50AM +0100, Michael Niedermayer wrote: > Fixes: runtime error: shift exponent 255 is too large for 32-bit type > 'unsigned int' > Fixes: 894/clusterfuzz-testcase-4841537823309824 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] Patchset v2 for pixel format querying within swscale

On Sun, Mar 19, 2017 at 03:33:38PM +0100, Clément Bœsch wrote: > This is in response to the next Libav commit I'll (partially) noop soon > (aa37d2bf45). patchset applied -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-de

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'

On Mon, Mar 20, 2017 at 09:17:36AM +0100, Carl Eugen Hoyos wrote: > 2017-03-20 8:57 GMT+01:00 Clément Bœsch : > > ffmpeg | branch: master | Clément Bœsch | Mon Mar 20 08:52:07 > > 2017 +0100| [3835283293bfd38ba69203f4618f0f0f21377bcc] | committer: Clément > > Bœsch

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'

On Mon, Mar 20, 2017 at 09:38:15AM +0100, Carl Eugen Hoyos wrote: > 2017-03-20 9:35 GMT+01:00 Clément Bœsch : > > On Mon, Mar 20, 2017 at 09:17:36AM +0100, Carl Eugen Hoyos wrote: > >> 2017-03-20 8:57 GMT+01:00 Clément Bœsch : > >> > ffmpeg | branch: master | Clément

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'

On Mon, Mar 20, 2017 at 09:59:24AM +0100, Carl Eugen Hoyos wrote: > 2017-03-20 9:42 GMT+01:00 Clément Bœsch : > > On Mon, Mar 20, 2017 at 09:38:15AM +0100, Carl Eugen Hoyos wrote: > >> 2017-03-20 9:35 GMT+01:00 Clément Bœsch : > >> > On Mon, Mar 20, 2017 at 09:17:36AM

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '4fb311c804098d78e5ce5f527f9a9c37536d3a08'

On Mon, Mar 20, 2017 at 10:12:49AM +0100, Carl Eugen Hoyos wrote: > 2017-03-20 10:04 GMT+01:00 Clément Bœsch : > > >> Is there really no incentive that would make you work on subtitle > >> support in the filter chain? > > > > Yes, someone else working on

Re: [FFmpeg-devel] [PATCH] vf_drawtext: Fix memory leak

On Mon, Mar 20, 2017 at 07:42:58PM +, Kieran Kunhya wrote: > $subj LGTM -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: add dash demuxer base version

On Mon, Mar 20, 2017 at 10:29:48PM +0800, Steven Liu wrote: > v2 fixed: > 1. from autodetect to disabled > 2. from camelCase code style to ffmpeg code style > 3. from RepType to AVMediaType > 4. fix variable typo > 5. change time value from uint32_t to uint64_t > 6. removed be used once API > 7. ch

Re: [FFmpeg-devel] [PATCH] avformat, ffmpeg: deprecate old rotation API

On Tue, Mar 21, 2017 at 08:42:58AM +0100, wm4 wrote: > The old "API" that signaled rotation as a metadata value has been > replaced by DISPLAYMATRIX side data quite a while ago. > > There is no reason to make muxers/demuxers/API users support both. In > addition, the metadata API is dangerous, as

[FFmpeg-devel] [PATCH] lavc/mips: fix mpegvideo.h includes (UNTESTED)

--- libavcodec/mips/blockdsp_mips.h| 3 ++- libavcodec/mips/idctdsp_mips.h | 3 ++- libavcodec/mips/me_cmp_mips.h | 2 +- libavcodec/mips/pixblockdsp_mips.h | 3 ++- libavcodec/mips/qpeldsp_mips.h | 3 ++- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/m

Re: [FFmpeg-devel] [PATCH] avcodec/dnxhd_parser: take into account compressed frame size and skip it

On Tue, Mar 21, 2017 at 03:36:39PM +0100, Paul B Mahol wrote: > Fixes #6214. > > Signed-off-by: Paul B Mahol > --- > libavcodec/dnxhd_parser.c | 65 > ++- > 1 file changed, 58 insertions(+), 7 deletions(-) > > diff --git a/libavcodec/dnxhd_parser.c b

Re: [FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

On Fri, Mar 24, 2017 at 10:40:21AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes #6255. > > Please comment, Carl Eugen > From 1c249440c62271565be12112f321ad9aa6a922fb Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Fri, 24 Mar 2017 10:38:22 +0100 > Subject: [PATCH] lav

  1   2   3   4   5   6   7   8   9   10   >