Note1: when the EOF pts is not accurate enough, the last frame
can be dropped by vf_fps with default rounding.
Note2: vf_scale use framesync since e82a3997cdd6c0894869b33ba42430ac3,
so this is a very commonplace scenario.
For example:
./ffprobe -f lavfi testsrc=d=1,scale,fps -of flat \
-count_f
>Envoyé : mardi 21 mai 2024 21:39
>
>Note1: when the EOF pts is not accurate enough, the last frame can be dropped
>by vf_fps with default rounding.
>
>Note2: vf_scale use framesync since e82a3997cdd6c0894869b33ba42430ac3,
>so this is a very commonplace scenario.
>
>For example:
>./ffprobe -f lavf
Objet : Re: [FFmpeg-devel] [PATCH v3 0/1] avformat/demux: fix accurate
>>probing of durations in mpegts/ps
>>
>>>De : Nicolas Gaullier Envoyé : mardi 2
>>>avril 2024 23:26 Objet : [PATCH v3 0/1] avformat/demux: fix accurate
>>>probing of durations in
se this simple command line and then compare the xml, it seems quite clear:
>ffprobe xxx.ts -show_packets -show_data -print_format xml
>
>Nicolas Gaullier (1):
> avcodec/h264_parser: fix start of packet for some broken streams
>
> libavcodec/h264_parser.c | 11 ++-
> 1 file cha
This a new ping but I post the patch again to get fate cleanly completed
on patchwork.
BTW, the initial design of framesync/EOF was in n3.4-dev-1799-g4e0e9ce2dc,
so one can say that time has past...
Thank you in advance for the review.
Nicolas
Nicolas Gaullier (1):
avfilter/framesync: fix
Note1: when the EOF pts is not accurate enough, the last frame
can be dropped by vf_fps with default rounding.
Note2: vf_scale use framesync since e82a3997cdd6c0894869b33ba42430ac3,
so this is a very commonplace scenario.
For example:
./ffprobe -f lavfi testsrc=d=1,scale,fps -of flat \
-count_f
>Envoyé : mardi 28 mai 2024 11:11
>
>This a new ping but I post the patch again to get fate cleanly completed on
>patchwork.
>BTW, the initial design of framesync/EOF was in n3.4-dev-1799-g4e0e9ce2dc, so
>one can say that time has past...
>
>Thank you in advance for the review.
>Nicolas
Another
>Envoyé : lundi 3 juin 2024 12:00
>>Envoyé : mardi 28 mai 2024 11:11
>>
>>This a new ping but I post the patch again to get fate cleanly completed on
>>patchwork.
>>BTW, the initial design of framesync/EOF was in n3.4-dev-1799-g4e0e9ce2dc, so
>>one can say that time has past...
>>
>>Thank you in
... thank you for your
feedbacks...
Nicolas Gaullier (1):
avformat: Add probe_streams option
doc/formats.texi| 3 +++
libavformat/avformat.h | 9 +
libavformat/mpeg.c | 5 +++--
libavformat/mpegts.c| 10 ++
libavformat/options_table.h | 1
Allow user to disable codec probing:
- spdif (and s337m incl. s-adm in the future) is not sub-demuxed and
may pass-through to a muxer
- disable any stream probing in wav files (dts detection).
- mpeg-ts files missing PAT/PMT are considered invalid.
Signed-off-by: Nicolas Gaullier
---
doc
This V2 is just a rebase. See my post yesterday for details.
Nicolas Gaullier (1):
avformat: Add probe_streams option
doc/formats.texi| 3 +++
libavformat/avformat.h | 9 +
libavformat/mpeg.c | 5 +++--
libavformat/mpegts.c| 10
Allow user to disable codec probing:
- spdif (and s337m incl. s-adm in the future) is not sub-demuxed and
may pass-through to a muxer
- disable any stream probing in wav files (dts detection).
- mpeg-ts files missing PAT/PMT are considered invalid.
Signed-off-by: Nicolas Gaullier
---
doc
Allow user to disable codec probing:
- spdif (and s337m incl. s-adm in the future) is not sub-demuxed and
may pass-through to a muxer
- disable any stream probing in wav files (dts detection).
- mpeg-ts files missing PAT/PMT are considered invalid.
Signed-off-by: Nicolas Gaullier
---
doc
.
I am surprised there was no reaction to this patch: there is for sure things to
discuss about what is a proposal for now.
This patch is required for me before rolling out my patch serie for s337m
support in WAV files.
(This v3 is just a rebased version)
Thank you!
Nicolas
Nicolas Gaullier
>Nicolas Gaullier (1):
> avformat: Add probe_streams option
>
> doc/formats.texi| 3 +++
> libavformat/avformat.h | 9 +
> libavformat/mpeg.c | 5 +++--
> libavformat/mpegts.c| 10 ++
> libavformat/options_table.h | 1 +
Fixes mpeg2video stream copy to mpeg muxer.
Note: this is a following of 1ec86be79b11.
Signed-off-by: Nicolas Gaullier
---
libavformat/concatdec.c | 11 +++
tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +-
tests/ref/fate/concat-demuxer-extended
Fix GC container ul.
Fix GC element type both for the generic case and for OPAtom.
Thanks to Philip de Nier
for checking the values, especially for OPAtom.
---
libavformat/mxfenc.c | 8 ++--
tests/ref/lavf/mxf_opatom | 2 +-
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a
>Please add a reference to the relevant SMPTE document in the comment, or
>perhaps at the list of references at the start of the file
>
>/Tomas
I have added the reference to ST2019-4 for "VC3 mapping", so that should be ok
for generic standard files.
It seems redundant for me, but if you want, I
When no IDR nor mmco_reset is found, prev_poc_lsb is
undefined and shall not be assumed to be zero
---
libavcodec/h264_parse.c | 2 ++
libavcodec/h264dec.c| 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/h264_parse.c b/libavcodec/h264_parse.c
index ac31f54e07..6
sample where log2_max_pic_order_cnt_lsb_minus4=5 ie. 512
frames (@25fps),
thus there is about 10 seconds of video that are 'lost'.
https://framadrop.org/r/a5RSjBKXAS#yBbeVfBR4LQwK4x3seqg4uGRdPv8FLJ6YNv8dVpjGJ4=
NB: FATE pass without modification
Thank you for the review,
Nicolas
Nicolas Gaullier (1):
av
u_JxHeVIRc#Fs2PXutr7geTBoTpnnJ/4+dTDNGBUuGT1Gf/wh00ZDw=
https://framadrop.org/r/nmjF4PbdxV#Flq5vPoRMrdfPKuM5+zdf3itUamIeWCVDriZaSKPkPQ=
Thank you for the review
Nicolas Gaullier (3):
avformat/s337m: Make available as subdemuxer
avformat: Support s337m in mxf/wav/w64
avformat/s337m: Test mx
---
libavformat/s337m.c | 57 +++--
libavformat/s337m.h | 48
2 files changed, 95 insertions(+), 10 deletions(-)
create mode 100644 libavformat/s337m.h
diff --git a/libavformat/s337m.c b/libavformat/s337
---
libavformat/avformat.h | 7 +++
libavformat/mxfdec.c| 20 +++-
libavformat/options_table.h | 1 +
libavformat/wavdec.c| 7 ++-
4 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/libavformat/avformat.h b/libavformat/avformat.h
index 6
incl. 24bits 5.1+2 dolby_e decoding
---
tests/Makefile | 1 +
tests/fate-run.sh| 4
tests/fate/audio.mak | 5 +
3 files changed, 10 insertions(+)
diff --git a/tests/Makefile b/tests/Makefile
index 624292d451..e8e23085eb 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -74,6
:
https://framadrop.org/r/05WkojY4i3#VWCpClXRaLnju5Z479g2qvLgMjD64rCTjYu31kQSAbI=
https://framadrop.org/r/dL5lFkBf3P#3lBD0SHINiZsN8BNBHUL2D1lRx17FJurCxzIRpXsMXg=
Nicolas Gaullier (5):
avformat/s337m: Use base AVClass for av_log usage
avformat/s337m: Split read_packet/get_packet
avformat/s337m
s337m_get_offset_and_codec does not make use of
AVFormatContext: AVClass is enough for logging.
Will facilitate further use from outside
---
libavformat/s337m.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavformat/s337m.c b/libavformat/s337m.c
index 48ab66a6da
Prepare use of s337m_get_packet from outside
---
libavformat/s337m.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/libavformat/s337m.c b/libavformat/s337m.c
index 8956afb23f..22140297e6 100644
--- a/libavformat/s337m.c
+++ b/libavformat/s337m.c
Enabled by AVOption dolbyeprobe
Requires stereo
---
libavformat/s337m.h | 1 +
libavformat/wavdec.c | 41 ++---
2 files changed, 35 insertions(+), 7 deletions(-)
diff --git a/libavformat/s337m.h b/libavformat/s337m.h
index bfe2a5d457..0c3fbf1990 100644
--- a/
---
libavformat/s337m.c | 63 +++-
libavformat/s337m.h | 64 +
2 files changed, 116 insertions(+), 11 deletions(-)
create mode 100644 libavformat/s337m.h
diff --git a/libavformat/s337m.c b/libavfo
incl. 24bits 5.1+2 dolby_e decoding
---
tests/Makefile | 1 +
tests/fate-run.sh| 4
tests/fate/audio.mak | 5 +
3 files changed, 10 insertions(+)
diff --git a/tests/Makefile b/tests/Makefile
index 0ef571b067..ebaa465597 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -75,6
---
libavformat/s337m.c | 64 -
libavformat/s337m.h | 64 +
2 files changed, 117 insertions(+), 11 deletions(-)
create mode 100644 libavformat/s337m.h
diff --git a/libavformat/s337m.c b/libavf
te min/max
values that would be really relevant and worth sharing
depend on video resolution...
Nicolas Gaullier (6):
avformat/s337m: Use base AVClass for av_log usage
avformat/s337m: Split read_packet/get_packet
avformat/s337m: Make available as subdemuxer
avformat/wavdec: s337m support
Enabled by AVOption dolbyeprobe
Requires stereo
---
libavformat/s337m.h | 1 +
libavformat/wavdec.c | 23 +++
2 files changed, 24 insertions(+)
diff --git a/libavformat/s337m.h b/libavformat/s337m.h
index 0f21a23a30..aff76373d3 100644
--- a/libavformat/s337m.h
+++ b/libavfor
---
libavformat/wavdec.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index 2ef2d9e549..b9a782bec5 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -712,14 +712,14 @@ smv_out:
}
if (!CONF
---
doc/developer.texi | 8
1 file changed, 8 insertions(+)
diff --git a/doc/developer.texi b/doc/developer.texi
index 5c342c9106..1e95768364 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -213,6 +213,14 @@ please use av_log() instead.
@item
Casts should be used only when
FFMAX removed (Michael's review)
and avctx->rc_buffer_size is not used anymore (James's review)
Nicolas Gaullier (3):
avformat/utils: Make find_stream_info get side data from codec context
avcodec/utils: Fix ff_add_cpb_side_data() add twice
avcodec/mpeg12dec: Add CPB coded side dat
Makes it behave similarly to av_stream_add_side_data().
---
libavcodec/utils.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index c4dc136d3c..08e2d5b68b 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1980,6 +1980,11 @@ AVCPBProperti
This will allow probing input coded side data, and also forwarding them to the
output.
---
libavformat/utils.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index cb15f6a4b3..a58e47fabc 100644
--- a/libavformat/utils.c
+++ b/liba
This fixes mpeg2video stream copies to mpeg muxer like this:
ffmpeg -i xdcamhd.mxf -c:v copy output.mpg
---
libavcodec/mpeg12dec.c | 7 +++
tests/ref/fate/mxf-probe-d10 | 3 +++
tests/ref/fate/ts-demux | 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/libavcod
Makes it behave similarly to av_stream_add_side_data().
---
libavcodec/utils.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index c4dc136d3c..08e2d5b68b 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1980,6 +1980,11 @@ AVCPBProperti
---
libavcodec/mpeg12dec.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index 17f9495a1d..2945728edd 100644
--- a/libavcodec/mpeg12dec.c
+++ b/libavcodec/mpeg12dec.c
@@ -64,6 +64,7 @@ typedef struct Mpeg1Context {
This will allow probing input coded side data, and also forwarding them to the
output.
---
libavformat/utils.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index cb15f6a4b3..a58e47fabc 100644
--- a/libavformat/utils.c
+++ b/liba
I have not received any feedback yet.
I repost here with all 4 patches, maybe it is easier for the review
- 1/4: fix mpeg12 decoder use of avctx->rc_buffer_size with is forbidden by API
doc
- 2/4,3/4,4/4: fix mpeg1/2 stream copy
Thank you
Nicolas Gaullier (4):
avcodec/mpeg12dec: Do not al
This fixes mpeg2video stream copies to mpeg muxer like this:
ffmpeg -i xdcamhd.mxf -c:v copy output.mpg
---
libavcodec/mpeg12dec.c | 7 +++
tests/ref/fate/mxf-probe-d10 | 3 +++
tests/ref/fate/ts-demux | 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/libavcod
review!
Nicolas
Nicolas Gaullier (1):
avformat/mpegenc.c: vbvsize option
libavformat/mpegenc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
--
2.22.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo
Allow the user to set or override the vbv size
---
libavformat/mpegenc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c
index f6980231a2..1613c8afa1 100644
--- a/libavformat/mpegenc.c
+++ b/libavformat/mpegenc.c
@@ -67,6 +67,7
---
fftools/ffmpeg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 27f68933f8..36c207653b 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3562,12 +3562,14 @@ static int init_output_stream(OutputStream *ost, char
*error, int error_len)
Make find_stream_info get side data from the codec context.
---
fftools/ffmpeg.c | 16 +++-
libavformat/avformat.h | 11 +++
libavformat/utils.c| 18 ++
3 files changed, 32 insertions(+), 13 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.
pg -vcodec copy output.mpg
NB: Back to v2.8.9 (before codecpar was introduced), it was working because of
direct access to rc_buffer_size by the muxer.
Nicolas Gaullier (5):
fftools/ffmpeg: Fix forward CPB props in to out
fftools/ffmpeg: Reindent after last commit
avformat/utils: Use coded
---
fftools/ffmpeg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 36c207653b..9af2bc2fb5 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3563,12 +3563,12 @@ static int init_output_stream(OutputStream *ost, char
---
libavcodec/mpeg12dec.c | 7 +++
tests/ref/fate/mxf-probe-d10 | 3 +++
tests/ref/fate/ts-demux | 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index 775579f9f0..2dc44e6d6f 100644
--- a/libavcodec/mpeg12dec.c
+
Makes it behave similarly to av_stream_add_side_data.
---
libavcodec/utils.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 8a49234bcd..f35cfcf2f9 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1975,6 +1975,11 @@ AVCPBProperties
Includes Hendrik and Michael feedbacks (thanks to you!) :
- comments added
- API changes and minor version updated
- split lib/tools commits
(the code itself was left untouched)
Nicolas Gaullier (7):
fftools/ffmpeg: Fix forward CPB props in to out
fftools/ffmpeg: Reindent after last commit
---
fftools/ffmpeg.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 36c207653b..9af2bc2fb5 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3563,12 +3563,12 @@ static int init_output_stream(OutputStream *ost, char
CPB side_data is copied when stream-copying (see
init_output_stream_streamcopy()),
but it shall not be copied when the stream is decoded.
---
fftools/ffmpeg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 27f68933f8..36c207653b 100644
--- a/fftool
This will allow probing input coded side data, and also forwarding them to the
output.
---
libavformat/utils.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index fe92ad4a1d..f7c949f0a1 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@
Makes it behave similarly to av_stream_add_side_data().
---
libavcodec/utils.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index 8a49234bcd..f35cfcf2f9 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1975,6 +1975,11 @@ AVCPBProperti
This fixes mpeg2video stream copies to mpeg muxer like this:
ffmpeg -i xdcamhd.mxf -c:v copy output.mpg
---
libavcodec/mpeg12dec.c | 7 +++
tests/ref/fate/mxf-probe-d10 | 3 +++
tests/ref/fate/ts-demux | 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/libavcod
This code is now shared with avformat_find_stream_info().
---
fftools/ffmpeg.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 9af2bc2fb5..232c8f5fd8 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3537,19 +35
This will allow avformat_find_stream_info() get side data from the codec
context.
---
doc/APIchanges | 3 +++
libavformat/avformat.h | 11 +++
libavformat/utils.c| 15 +++
libavformat/version.h | 2 +-
4 files changed, 30 insertions(+), 1 deletion(-)
diff --git
This will allow avformat_find_stream_info() get side data from the codec
context.
---
doc/APIchanges | 3 +++
libavformat/avformat.h | 11 +++
libavformat/utils.c| 15 +++
libavformat/version.h | 4 ++--
4 files changed, 31 insertions(+), 2 deletions(-)
diff --
This will allow avformat_find_stream_info() get side data from the codec
context.
---
doc/APIchanges | 3 +++
libavformat/avformat.h | 11 +++
libavformat/utils.c| 15 +++
libavformat/version.h | 4 ++--
4 files changed, 31 insertions(+), 2 deletions(-)
diff --
)
Nicolas Gaullier (5):
avformat: Add av_stream_add_coded_side_data()
avformat/utils: Make find_stream_info get side data from codec context
fftools/ffmpeg: Use the new av_stream_add_coded_side_data()
avcodec/utils: Fix ff_add_cpb_side_data add twice
avcodec/mpeg12dec: Add CPB coded side data
This will allow avformat_find_stream_info() get side data from the codec
context.
---
doc/APIchanges | 3 +++
libavformat/avformat.h | 11 +++
libavformat/utils.c| 15 +++
libavformat/version.h | 4 ++--
4 files changed, 31 insertions(+), 2 deletions(-)
diff --
,
but this one could also be 'forwarded' to spdif
- verbose detection and phase (I think it is a broadcast requirement)
Fate samples can be found here:
- 512.wav : http://0x0.st/zdW-.wav
- 512.mxf.pcm : http://0x0.st/zdWo.pcm
Thank you for this new review...
Nicolas Gaullier (9):
av
Prepare the support of s337m in muxers other than raw (ex: wav).
For example, this forbids reading 16 bits DolbyE stream from a 24 bit wav file.
---
libavformat/s337m.c | 20 ++--
libavformat/s337m.h | 3 ++-
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/libavfor
s337m_get_offset_and_codec does not make use of
AVFormatContext: AVClass is enough for logging.
Will facilitate further use from outside
---
libavformat/s337m.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavformat/s337m.c b/libavformat/s337m.c
index 48ab66a6da
Prepare use of s337m_get_packet from outside.
---
libavformat/s337m.c | 28 +---
libavformat/s337m.h | 38 ++
2 files changed, 59 insertions(+), 7 deletions(-)
create mode 100644 libavformat/s337m.h
diff --git a/libavformat/s337m.c b/li
---
libavformat/wavdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index 2796905e1f..ccb9576b84 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -78,7 +78,7 @@ static void set_spdif_s337m(AVFormatContext *s,
WAVD
Test the new 'dolbyeprobe' AVOption.
Test dolby_e decoding for 24 bits with program config '5.1+2'
---
tests/Makefile | 1 +
tests/fate-run.sh| 4
tests/fate/audio.mak | 5 +
3 files changed, 10 insertions(+)
diff --git a/tests/Makefile b/tests/Makefile
index e5f41008d4..65ccca
---
libavformat/wavdec.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index 039ec1658e..0980d85189 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -714,14 +714,14 @@ smv_out:
size = FFMIN(S
Fix reading beyond data_end.
---
libavformat/wavdec.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index ccb9576b84..039ec1658e 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -643,8 +643,6 @@ static int wav
Similar to ff_spdif_probe() with two additionnal parameters:
- an AVClass for logging
- the bit resolution of the container as it may be 16 or 24 for s337m
---
libavformat/s337m.c | 35 +++
libavformat/s337m.h | 19 +++
2 files changed, 54 insertions
Add s337m probing/reading similarly to spdif.
Add a new AVOption 'dolbyeprobe' to enable it.
---
libavformat/wavdec.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index 575c667452..2796905e1f 100644
--- a/l
the review.
For the record, the target use case is to fix things like this:
ffmpeg -i xdcamhd.mxf -c:v copy output.mpg
(And note that as a side effect, ffmpeg now reports the cpb and signaled
bitrate of mpeg2 video inputs)
Nicolas
Nicolas Gaullier (5):
avformat: Add
This will allow probing input coded side data, and also forwarding them to the
output.
---
libavformat/utils.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index 3270d971c6..ddc36cce1c 100644
--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@
This will allow avformat_find_stream_info() get side data from the codec
context.
---
doc/APIchanges | 3 +++
libavformat/avformat.h | 11 +++
libavformat/utils.c| 15 +++
libavformat/version.h | 4 ++--
4 files changed, 31 insertions(+), 2 deletions(-)
diff --
This code is now shared with avformat_find_stream_info().
---
fftools/ffmpeg.c | 16 +++-
1 file changed, 3 insertions(+), 13 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 6bcd7b94d2..a513e9f3cc 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -3534,19 +35
Makes it behave similarly to av_stream_add_side_data().
---
libavcodec/utils.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index ab48754a64..d9af6053bb 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1978,6 +1978,11 @@ AVCPBProperti
This fixes mpeg2video stream copies to mpeg muxer like this:
ffmpeg -i xdcamhd.mxf -c:v copy output.mpg
---
libavcodec/mpeg12dec.c | 7 +++
tests/ref/fate/mxf-probe-d10 | 3 +++
tests/ref/fate/ts-demux | 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/libavcod
Makes it behave similarly to av_stream_add_side_data().
---
libavcodec/utils.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/utils.c b/libavcodec/utils.c
index ab48754a64..d9af6053bb 100644
--- a/libavcodec/utils.c
+++ b/libavcodec/utils.c
@@ -1978,6 +1978,11 @@ AVCPBProperti
Modified with Anton feedback: no public amendment,
the code from add_coded_side_data() is now duplicated from existing one in
ffmpeg.c,
but it is rather small.
Nicolas Gaullier (3):
avformat/utils: Make find_stream_info get side data from codec context
avcodec/utils: Fix ff_add_cpb_side_data
This will allow probing input coded side data, and also forwarding them to the
output.
---
libavformat/utils.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/libavformat/utils.c b/libavformat/utils.c
index f3d71642c3..cc9898681a 100644
--- a/libavformat/utils.c
+++ b/liba
This fixes mpeg2video stream copies to mpeg muxer like this:
ffmpeg -i xdcamhd.mxf -c:v copy output.mpg
---
libavcodec/mpeg12dec.c | 7 +++
tests/ref/fate/mxf-probe-d10 | 3 +++
tests/ref/fate/ts-demux | 2 +-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/libavcod
discussed
with Carl Eugen
If possible, I would like to continue this review, but when time will come to
apply,
I would like to postpone it a little bit to wait for the global AVOption, this
is to make
sure that users will be able to disable the wav s337m probing if they need to.
Thank you al
Test s337m probing in wav container.
Test dolby_e decoding for 24 bits with program config '5.1+2'
---
tests/Makefile | 1 +
tests/fate/audio.mak | 5 +
2 files changed, 6 insertions(+)
diff --git a/tests/Makefile b/tests/Makefile
index e5f41008d4..65cccac312 100644
--- a/tests/Makefile
---
libavformat/wavdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index 3571733817..d8a27c79cf 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -77,7 +77,7 @@ static void set_spdif_s337m(AVFormatContext *s,
WAVD
Add s337m probing/reading similarly to spdif.
---
libavformat/wavdec.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index 575c667452..d030ed9f9d 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
s337m_get_offset_and_codec does not make use of
AVFormatContext: AVClass is enough for logging.
Will facilitate further use from outside
---
libavformat/s337m.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavformat/s337m.c b/libavformat/s337m.c
index 48ab66a6da
Prepare use of s337m_get_packet from outside.
---
libavformat/s337m.c | 26 --
libavformat/s337m.h | 37 +
2 files changed, 57 insertions(+), 6 deletions(-)
create mode 100644 libavformat/s337m.h
diff --git a/libavformat/s337m.c b/libav
Prepare the support of s337m in muxers other than raw (ex: wav).
For example, this forbids reading 16 bits DolbyE stream from a 24 bit wav file.
---
libavformat/s337m.c | 20 ++--
libavformat/s337m.h | 3 ++-
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/libavfor
---
libavformat/wavdec.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index d030ed9f9d..3571733817 100644
--- a/libavformat/wavdec.c
+++ b/libavformat/wavdec.c
@@ -713,14 +713,14 @@ smv_out:
size = FFMIN(S
Similar to ff_spdif_probe() with just an additional checking of
the bit resolution of the container as it may be 16 or 24 for s337m.
---
libavformat/s337m.c | 32
libavformat/s337m.h | 16
2 files changed, 48 insertions(+)
diff --git a/libavformat
Add s337m probing/reading similarly to spdif.
---
libavformat/wavdec.c | 35 +++
1 file changed, 27 insertions(+), 8 deletions(-)
diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
index 575c667452..9802eef561 100644
--- a/libavformat/wavdec.c
+++ b/libavform
---
libavcodec/mpeg12dec.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index 17f9495a1d..2945728edd 100644
--- a/libavcodec/mpeg12dec.c
+++ b/libavcodec/mpeg12dec.c
@@ -64,6 +64,7 @@ typedef struct Mpeg1Context {
when it is not specified:
the documentation states the output defaults to the same value as the
input, but it does not seem possible to implement currently.
Signed-off-by: Nicolas Gaullier
---
libavfilter/vf_colorspace.c | 62 +
1 file changed, 36 insertions
by it, so I don't feel it is acceptable?
Any input welcome.
Nicolas Gaullier (1):
avformat/mpegts: Add duration_probesize AVOption
doc/demuxers.texi | 13 +
doc/formats.texi | 2 +-
libavformat/demux.c | 23 ++---
libavformat/mpegts.c | 104 +--
n is found but not the other
audio/video stream durations, there will be a retry, so at the end the
full user-overriden probesize will be used as expected by the user.
Signed-off-by: Nicolas Gaullier
---
doc/demuxers.texi | 13 +
doc/formats.texi | 2 +-
libavformat/demux.c | 23
.ts
Same sample modified to exhibit the issue (invalid NAL_AUDs + an available null
ending byte at 0x291F):
https://0x0.st/Xs9j.ts
I use this simple command line and then compare the xml, it seems quite clear:
ffprobe xxx.ts -show_packets -show_data -print_format xml
Nicolas Gaullier (1):
avco
---
libavcodec/h264_parser.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c
index 94cfbc481e..6b721ec253 100644
--- a/libavcodec/h264_parser.c
+++ b/libavcodec/h264_parser.c
@@ -124,7 +124,16 @@ static int h264_fi
1 - 100 of 306 matches
Mail list logo
