Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-28 Thread Michael Niedermayer
On Wed, Aug 27, 2014 at 07:08:00PM -0700, James Zern wrote: On Wed, Aug 27, 2014 at 1:04 PM, Deb Mukherjee debar...@google.com wrote: Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate

[FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-26 Thread Deb Mukherjee
Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate is 0, then the 'constant quality' mode of VP9 is used. However if both are present, the 'constrained quality' mode is used as before. ---

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-26 Thread James Zern
On Tue, Aug 26, 2014 at 10:30 AM, Deb Mukherjee debar...@google.com wrote: Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate is 0, then the 'constant quality' mode of VP9 is used. However

[FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-22 Thread Deb Mukherjee
Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate is 0, then the 'constant quality' mode of VP9 is used. However if both are present, the 'constrained quality' mode is used as before. ---

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-22 Thread James Zern
On Fri, Aug 22, 2014 at 10:53 AM, Deb Mukherjee debar...@google.com wrote: [...] @@ -311,7 +316,7 @@ static av_cold int vpx_init(AVCodecContext *avctx, } else { if (enccfg.rc_end_usage == VPX_CQ) { enccfg.rc_target_bitrate = 100; -} else { +}

Re: [FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-22 Thread Timothy Gu
On Aug 22, 2014 1:29 PM, Debargha Mukherjee debar...@google.com wrote: Unless the codec is VP9, VPX_Q will not be set. So the behavior does not change for VP8. If it's not set, then the code won't compile with older libvpx. Timothy ___ ffmpeg-devel

[FFmpeg-devel] [PATCH] Adds support for constant quality mode in VP9.

2014-08-21 Thread Deb Mukherjee
Changes in the parameter mapping for libvpx to support the constant quality mode in VP9. The assumption in the patch is that if crf is provided but bitrate is 0, then the 'constant quality' mode of VP9 is used. However if both are present, the 'constrained quality' mode is used as before. ---