Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-19 Thread Felix Matouschek
Am 19.12.2017 um 21:19 schrieb James Almer : > > Pushed. > > Wouldn't this need to be done for vp8 as well, for that matter? > At least on Android using libvpx 1.6.1 it was not needed for vp8, only for vp9. ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-19 Thread James Almer
On 12/12/2017 11:53 AM, Felix Matouschek wrote: > Am 12.12.2017 15:37, schrieb James Almer: >> No, this is not correct. If anything has to be added here, it would be >> $libm_extralibs. -lm is not needed/available on some systems. > > Ok, changed it. > >> Also, you should be using pkg-config. Its

Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-19 Thread Felix Matouschek
Any chance this could get merged? > Am 12.12.2017 um 15:53 schrieb Felix Matouschek : > > Am 12.12.2017 15:37, schrieb James Almer: >> No, this is not correct. If anything has to be added here, it would be >> $libm_extralibs. -lm is not needed/available on some systems. > > Ok, changed it. > >>

Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-12 Thread Felix Matouschek
Am 12.12.2017 15:37, schrieb James Almer: No, this is not correct. If anything has to be added here, it would be $libm_extralibs. -lm is not needed/available on some systems. Ok, changed it. Also, you should be using pkg-config. Its job is to make sure all the cflags and ldflags are correct f

Re: [FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-12 Thread James Almer
On 12/12/2017 6:55 AM, Felix Matouschek wrote: > This fixes the detection of the vp9 decoder/encoder. > > The vp9 decoder/encoder needs libm to successfully link, -lm was missing > in the check_lib calls for vp9 in configure. > > 0001-configure-Fix-detection-of-vp9-decoder-encoder.patch > > > F

[FFmpeg-devel] [PATCH] configure: Fix detection of vp9 decoder/encoder

2017-12-12 Thread Felix Matouschek
This fixes the detection of the vp9 decoder/encoder. The vp9 decoder/encoder needs libm to successfully link, -lm was missing in the check_lib calls for vp9 in configure.From 0b5bbd7c30f3a76b2e0ab6ceae2bfaebe944b279 Mon Sep 17 00:00:00 2001 From: Felix Matouschek Date: Tue, 12 Dec 2017 10:42:40