Hi James,
On 19/02/2019 17:14, James Almer wrote:
On 2/11/2019 1:59 PM, Guillaume Desmottes wrote:
CDG doesn't ensure a constant framerate as we can have holes in the CDG
stream. So there is no guarantee of the duration of a single frame, it
will be displayed until a new packet with CDG instruc
On 2/11/2019 1:59 PM, Guillaume Desmottes wrote:
> CDG doesn't ensure a constant framerate as we can have holes in the CDG
> stream. So there is no guarantee of the duration of a single frame, it
> will be displayed until a new packet with CDG instruction arrives in the
> stream.
>
> Signed-off-by
On 13/02/2019 16:28, Carl Eugen Hoyos wrote:
Thanks for testing my patch. I wasn't aware of this specific test, sorry
about that.
What would be the proper way to address this? Should the fate reference
be updated?
Yes, unless the change is wrong.
Ok thanks. So, who should I ask to review this
2019-02-13 16:19 GMT+01:00, Guillaume Desmottes
:
> Thanks for testing my patch. I wasn't aware of this specific test, sorry
> about that.
>
> What would be the proper way to address this? Should the fate reference
> be updated?
Yes, unless the change is wrong.
Carl Eugen
___
On 11/02/2019 23:41, Michael Niedermayer wrote:
breaks fate-cdgraphics
Hi Michael,
Thanks for testing my patch. I wasn't aware of this specific test, sorry
about that.
What would be the proper way to address this? Should the fate reference
be updated?
The test file is still properly pla
On Mon, Feb 11, 2019 at 05:59:34PM +0100, Guillaume Desmottes wrote:
> CDG doesn't ensure a constant framerate as we can have holes in the CDG
> stream. So there is no guarantee of the duration of a single frame, it
> will be displayed until a new packet with CDG instruction arrives in the
> stream
CDG doesn't ensure a constant framerate as we can have holes in the CDG
stream. So there is no guarantee of the duration of a single frame, it
will be displayed until a new packet with CDG instruction arrives in the
stream.
Signed-off-by: Guillaume Desmottes
---
libavformat/cdg.c | 1 +
1 file c