Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-30 19:57 GMT+01:00 Martin Vignali : > > > >> >> > >> This broke several interlace fate tests, including the new checkasm >> one >> > >> you added. >> > >> > > > New patch in attach for AVX2 version > i add a process of only 1* mmsize, before the loop (who process 2 * mmsize > at each loop)

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

> > >> > > >> This broke several interlace fate tests, including the new checkasm > one > > >> you added. > > >> > > New patch in attach for AVX2 version i add a process of only 1* mmsize, before the loop (who process 2 * mmsize at each loop) Pass

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-19 22:57 GMT+01:00 James Almer : > On 12/19/2017 6:40 PM, Martin Vignali wrote: > > 2017-12-19 21:59 GMT+01:00 James Almer : > > > >> On 12/19/2017 5:16 PM, Martin Vignali wrote: > > LGTM, thanks. > > >>> > >>> Pushed, thanks > >> > >> This broke several interlace fate tests

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

On 12/19/2017 6:40 PM, Martin Vignali wrote: > 2017-12-19 21:59 GMT+01:00 James Almer : > >> On 12/19/2017 5:16 PM, Martin Vignali wrote: LGTM, thanks. >>> >>> Pushed, thanks >> >> This broke several interlace fate tests, including the new checkasm one >> you added. >> >> Sorry forg

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-19 21:59 GMT+01:00 James Almer : > On 12/19/2017 5:16 PM, Martin Vignali wrote: > >> > >> LGTM, thanks. > >> > > > > Pushed, thanks > > This broke several interlace fate tests, including the new checkasm one > you added. > > Sorry forget to run fate after AVX2 patch (only test with checkas

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

On 12/19/2017 5:16 PM, Martin Vignali wrote: >> >> LGTM, thanks. >> > > Pushed, thanks This broke several interlace fate tests, including the new checkasm one you added. http://fate.ffmpeg.org/report.cgi?time=20171219201300&slot=x86_64-archlinux-gcc-threads-2

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

> > LGTM, thanks. > Pushed, thanks Do you think, that the complex low pass filter could also be improved that > way? > > > Yes, probably. I will take a look. Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-18 11:34 GMT+01:00 Martin Vignali : > > > > > > > Please also add the changes you made in patch 1 and avx2 to > vf_tinterlace. > > > > > > > > For patch 1, IMHO, it's not necessary (the modification is mainly to make > checkasm test easier to write, and like vf_interlace and vf_tinterlace

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

> > > > Please also add the changes you made in patch 1 and avx2 to vf_tinterlace. > > > > For patch 1, IMHO, it's not necessary (the modification is mainly to make checkasm test easier to write, and like vf_interlace and vf_tinterlace use the same asm only one is useful for checkasm) In attach ne

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

Hi, 2017-12-16 18:35 GMT+01:00 Martin Vignali : > 2017-12-16 14:48 GMT+01:00 Carl Eugen Hoyos : > > > 2017-12-16 14:17 GMT+01:00 Martin Vignali : > > > > > 002 : Checkasm test for lowpass_line > > > > The change to checkasm.mak contains unexpected tabs iiuc. > > > > New patch in attach > Please

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

On 12/16/17, Martin Vignali wrote: > 2017-12-16 14:48 GMT+01:00 Carl Eugen Hoyos : > >> 2017-12-16 14:17 GMT+01:00 Martin Vignali : >> >> > 002 : Checkasm test for lowpass_line >> >> The change to checkasm.mak contains unexpected tabs iiuc. >> > > New patch in attach > > >> I can confirm that avx

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-16 14:48 GMT+01:00 Carl Eugen Hoyos : > 2017-12-16 14:17 GMT+01:00 Martin Vignali : > > > 002 : Checkasm test for lowpass_line > > The change to checkasm.mak contains unexpected tabs iiuc. > New patch in attach > I can confirm that avx is not faster than sse2 here. > > > Thanks for test

Re: [FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

2017-12-16 14:17 GMT+01:00 Martin Vignali : > 002 : Checkasm test for lowpass_line The change to checkasm.mak contains unexpected tabs iiuc. I can confirm that avx is not faster than sse2 here. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffm

[FFmpeg-devel] avfilter/vf_interlace : add checkasm for lowpass_line and AVX2 version

Hello, In attach patch to add a checkasm test, for lowpass_line (8 and 16) and AVX2 version for lowpass_line (8 and 16) 001 : Modify init part of vf_interlace (add ff_interlace_init and modify ff_interlace_init_x86) 002 : Checkasm test for lowpass_line can be test with ./tests/checkasm/checkasm