Re: [FFmpeg-devel] [PATCH] Add test for avpriv_get_trc_function_from_trc function

2016-03-03 Thread Michael Niedermayer
On Thu, Mar 03, 2016 at 10:01:28AM -0800, NagaChaitanya Vellanki wrote: > --- > libavutil/Makefile | 1 + > libavutil/color_utils.c| 29 + > tests/fate/libavutil.mak | 4 + > tests/ref/fate/color_utils | 285 > + > 4 files

Re: [FFmpeg-devel] [PATCH] Add test for avpriv_get_trc_function_from_trc function

2016-03-03 Thread NagaChaitanya Vellanki
Derek, I agree with you, checked this on ubuntu, mac os both x86_32, x86_64. On Thu, Mar 3, 2016 at 10:11 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 3/3/2016 6:01 PM, NagaChaitanya Vellanki wrote: > > + printf("AVColorTransferCharacteristic=%d calling func(%f) >

Re: [FFmpeg-devel] [PATCH] Add test for avpriv_get_trc_function_from_trc function

2016-03-03 Thread Michael Niedermayer
On Thu, Mar 03, 2016 at 06:11:19PM +, Derek Buitenhuis wrote: > On 3/3/2016 6:01 PM, NagaChaitanya Vellanki wrote: > > + printf("AVColorTransferCharacteristic=%d calling func(%f) > > expected=%f\n", > > + i, test_data[j], result); > > Comparing floats exactly

Re: [FFmpeg-devel] [PATCH] Add test for avpriv_get_trc_function_from_trc function

2016-03-03 Thread Derek Buitenhuis
On 3/3/2016 6:01 PM, NagaChaitanya Vellanki wrote: > + printf("AVColorTransferCharacteristic=%d calling func(%f) > expected=%f\n", > + i, test_data[j], result); Comparing floats exactly probably isn't a great idea, since floating point implementations differ

Re: [FFmpeg-devel] [PATCH] Add test for avpriv_get_trc_function_from_trc function

2016-03-01 Thread Michael Niedermayer
On Tue, Mar 01, 2016 at 09:11:21PM +0100, Michael Niedermayer wrote: > On Tue, Mar 01, 2016 at 11:37:37AM -0800, NagaChaitanya Vellanki wrote: > > --- > > libavutil/Makefile | 1 + > > libavutil/color_utils.c | 53 > > + > > 2 files changed,

Re: [FFmpeg-devel] [PATCH] Add test for avpriv_get_trc_function_from_trc function

2016-03-01 Thread Michael Niedermayer
On Tue, Mar 01, 2016 at 11:37:37AM -0800, NagaChaitanya Vellanki wrote: > --- > libavutil/Makefile | 1 + > libavutil/color_utils.c | 53 > + > 2 files changed, 54 insertions(+) to test avpriv_get_trc_function_from_trc(), one could for each

Re: [FFmpeg-devel] [PATCH] Add test for avpriv_get_trc_function_from_trc function

2016-03-01 Thread Clément Bœsch
On Tue, Mar 01, 2016 at 10:41:32AM -0800, NagaChaitanya Vellanki wrote: > --- > libavutil/Makefile | 1 + > libavutil/color_utils.c | 52 > + > 2 files changed, 53 insertions(+) > I'm afraid testing the result of a switch with an array has