Re: [FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c
On Thu, Nov 15, 2018 at 10:27 AM Shlomi Fish wrote: > > Hi Marton, > > On Wed, 7 Nov 2018 10:29:31 +0100 (CET) > Marton Balint wrote: > > > On Wed, 7 Nov 2018, Shlomi Fish wrote: > > > > > On Wed, 4 Jul 2018 23:10:46 +0300 > > > Shlomi Fish wrote: > > > > > > Ping/bump! Can this patch be reviewed already? > > > > Does your patch has any measureable speed difference for some streams? It > > seems like a very micro optimialization, because ff_metadata_conv bails > > out early as well. > > > > First of all note that I recall it being the case for several function calls > in succession there. Secondly, I didn't measure it, but see what I wrote at: > > https://en.wikibooks.org/wiki/Optimizing_Code_for_Speed/Factor_Optimizations#Are_%22Small%22_Optimizations_Desirable? > > non-inline function calls can be quite slow. > Theoretical optimizations are all nice and well, but numbers are the only reality in the world. :) - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c
Hi Marton, On Wed, 7 Nov 2018 10:29:31 +0100 (CET) Marton Balint wrote: > On Wed, 7 Nov 2018, Shlomi Fish wrote: > > > On Wed, 4 Jul 2018 23:10:46 +0300 > > Shlomi Fish wrote: > > > > Ping/bump! Can this patch be reviewed already? > > Does your patch has any measureable speed difference for some streams? It > seems like a very micro optimialization, because ff_metadata_conv bails > out early as well. > First of all note that I recall it being the case for several function calls in succession there. Secondly, I didn't measure it, but see what I wrote at: https://en.wikibooks.org/wiki/Optimizing_Code_for_Speed/Factor_Optimizations#Are_%22Small%22_Optimizations_Desirable? non-inline function calls can be quite slow. > Regards, > Marton > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- - Shlomi Fish http://www.shlomifish.org/ http://www.shlomifish.org/humour/bits/Can-I-SCO-Now/ - “Can I SCO Now?” You name it — COBOL does not have it. — http://is.gd/ClKAz5 Please reply to list if it's a mailing list post - http://shlom.in/reply . ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c
On Wed, 7 Nov 2018, Shlomi Fish wrote: On Wed, 4 Jul 2018 23:10:46 +0300 Shlomi Fish wrote: Ping/bump! Can this patch be reviewed already? Does your patch has any measureable speed difference for some streams? It seems like a very micro optimialization, because ff_metadata_conv bails out early as well. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c
On Wed, 4 Jul 2018 23:10:46 +0300 Shlomi Fish wrote: Ping/bump! Can this patch be reviewed already? -- - Shlomi Fish http://www.shlomifish.org/ http://www.shlomifish.org/humour/bits/facts/Emma-Watson/ The Zeroth Rule of Fight Club is that Chuck Norris can talk about Fight Club. No one tells Chuck Norris what not to do. — http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/ Please reply to list if it's a mailing list post - http://shlom.in/reply . ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c
On Fri, 20 Jul 2018 14:31:55 +0300 Shlomi Fish wrote: > On Wed, 11 Jul 2018 19:42:09 +0300 > Shlomi Fish wrote: > > > On Wed, 4 Jul 2018 23:10:46 +0300 > > Shlomi Fish wrote: > > > > Ping! Can this patch be reviewed please? > > > > Ping! bump / ping. -- - Shlomi Fish http://www.shlomifish.org/ My Aphorisms - http://www.shlomifish.org/humour.html Tomorrow never dies, unless Chuck Norris volunteers to take it out of its misery. — http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/ Please reply to list if it's a mailing list post - http://shlom.in/reply . ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c
On Wed, 11 Jul 2018 19:42:09 +0300 Shlomi Fish wrote: > On Wed, 4 Jul 2018 23:10:46 +0300 > Shlomi Fish wrote: > > Ping! Can this patch be reviewed please? > Ping! > -- - Shlomi Fish http://www.shlomifish.org/ Summer Glau Facts - http://shlom.in/sglau-facts He who reinvents the wheel, will understand much better how a wheel works. — http://www.shlomifish.org/humour.html Please reply to list if it's a mailing list post - http://shlom.in/reply . ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c
On Wed, 4 Jul 2018 23:10:46 +0300 Shlomi Fish wrote: Ping! Can this patch be reviewed please? -- - Shlomi Fish http://www.shlomifish.org/ Parody of "The Fountainhead" - http://shlom.in/towtf When Chuck Norris uses git, he takes a coffee break after initiating every git commit. And then he waits for the commit to finish. — http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/ Please reply to list if it's a mailing list post - http://shlom.in/reply . ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
