Re: [FFmpeg-devel] [PATCH] avcodec/webvttdec: Unescape HTML entities

On Thu, Oct 08, 2015 at 10:50:49PM +0100, Ricardo wrote: > That would probably be considered a broken WebVTT file, since "&" need to > be encoded as "". > What about "Clment" or any unsupported escape? [...] -- Clément B. signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] avcodec/webvttdec: Unescape HTML entities

I think those were needed when UTF-8 wasn't expected, but WebVTT makes it mandatory, according to https://w3c.github.io/webvtt/#file-structure Are you saying that and should be removed (like it was)? On 9 October 2015 at 13:50, Clément Bœsch wrote: > On Thu, Oct 08, 2015 at

Re: [FFmpeg-devel] [PATCH] avcodec/webvttdec: Unescape HTML entities

That would probably be considered a broken WebVTT file, since "&" need to be encoded as "". On 8 October 2015 at 20:46, Clément Bœsch wrote: > On Thu, Oct 08, 2015 at 05:20:52PM +0100, Ricardo Constantino wrote: > > Also fixes adjacent tags not being parsed correctly. > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/webvttdec: Unescape HTML entities

Even if not valid WebVTT, it should now work with something like "Ben". Sample: http://trac.ffmpeg.org/attachment/ticket/4915/htmlescapes.vtt Only issue left is CR-only endings not working, but since Apple stopped using that, it's probably not that important.

Re: [FFmpeg-devel] [PATCH] avcodec/webvttdec: Unescape HTML entities

On Thu, Oct 08, 2015 at 05:20:52PM +0100, Ricardo Constantino wrote: > Also fixes adjacent tags not being parsed correctly. > > Signed-off-by: Ricardo Constantino > --- > libavcodec/webvttdec.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff