Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le decadi 10 brumaire, an CCXXVI, Paul B Mahol a écrit : > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_tile.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/vf_tile.c b/libavfilter/vf_tile.c > index

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Nack. Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_tile.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/libavfilter/vf_tile.c b/libavfilter/vf_tile.c > index

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > No it doesn't work like that any more. > > Some folks commit to maintained code by someone else without prior review. > > Why I should not be one of them? Are you trying to derail the project on purpose? Now, please behave like a

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Paul B Mahol wrote: > On 10/28/17, Nicolas George wrote: >> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >>> I already posted another version which I will push shortly. >> >> No, you will wait until I approve the patch, since it is code

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> I already posted another version which I will push shortly. > > No, you will wait until I approve the patch, since it is code that I > maintain. That is how it works. No it doesn't

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > I already posted another version which I will push shortly. No, you will wait until I approve the patch, since it is code that I maintain. That is how it works. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> You still have not provided valid reason to block it. > > Your first patch was wrong. I have observed a possible flaw in the > second one. I thought I had a test case to show it,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > You still have not provided valid reason to block it. Your first patch was wrong. I have observed a possible flaw in the second one. I thought I had a test case to show it, maybe I was wrong. I need to check and test. Now, I might add,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Gonna apply this patch soonTM because of no valid reasons to block it. > > No, you will not. You still have not provided valid reason to block it. testsrc2 filter hang is unrelated

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > Gonna apply this patch soonTM because of no valid reasons to block it. No, you will not. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Paul B Mahol wrote: > On 10/28/17, Clement Boesch wrote: >> On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote: >>> On 10/28/17, Clement Boesch wrote: >>> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: >>> >>

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Clement Boesch wrote: > On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote: >> On 10/28/17, Clement Boesch wrote: >> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: >> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit :

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote: > On 10/28/17, Clement Boesch wrote: > > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: > >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : > >> > Signed-off-by: Paul B Mahol >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Clement Boesch wrote: > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> > Signed-off-by: Paul B Mahol >> > --- >> > libavfilter/vf_tile.c | 8 >> > 1 file changed,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: > Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit : > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/vf_tile.c | 8 > > 1 file changed, 8 deletions(-) > > Nack. > > ./ffmpeg_g -lavfi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Why? > > Because it is wrong. I wrote the test case by looking at your changes > and finding a flaw in them. No, your test is flawed. I have no longer obligations to communicate with

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > Why? Because it is wrong. I wrote the test case by looking at your changes and finding a flaw in them. -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> testsrc2 hangs here. > > So please rework your patch. Why? When it hangs without using tile filter at all. Do I need to write things out of blue moon now?

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > testsrc2 hangs here. So please rework your patch. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/27/17, Nicolas George wrote: > Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/vf_tile.c | 8 >> 1 file changed, 8 deletions(-) > > Nack. > > ./ffmpeg_g -lavfi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit : > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_tile.c | 8 > 1 file changed, 8 deletions(-) Nack. ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f framecrc - hangs instead of

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

On 10/27/17, Nicolas George wrote: > Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/vf_tile.c | 12 ++-- >> 1 file changed, 2 insertions(+), 10 deletions(-) > > Nack. > > This: > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit : > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_tile.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 deletions(-) Nack. This: ./ffmpeg_g -lavfi testsrc2=s=1024x32,tile=layout=65x1 -f framecrc - used to