On Fri, Sep 16, 2016 at 10:43:30AM +0800, Steven Liu wrote:
> From: Steven Liu
> Date: Fri, 16 Sep 2016 10:42:34 +0800
> Subject: [PATCH] avformat/http: will remove option user_agent
>
> add a FF_OPT_FLAG_DEPRECATED define for compile.
> add a new variable for user_agent to give a deprecated warn
2016-09-16 19:07 GMT+08:00 Carl Eugen Hoyos :
> 2016-09-16 4:43 GMT+02:00 Steven Liu :
>
> > +@item user-agent
> > +This is a deprecated option, you can use user_agent instead it.
>
> Sorry for the nitpicking: Why do you move the first, unchanged line?
>
> Carl Eugen
>
>
Because it will be remove,
2016-09-16 4:43 GMT+02:00 Steven Liu :
> +@item user-agent
> +This is a deprecated option, you can use user_agent instead it.
Sorry for the nitpicking: Why do you move the first, unchanged line?
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffm
2016-09-16 1:08 GMT+08:00 Clément Bœsch :
> On Fri, Sep 16, 2016 at 12:41:41AM +0800, Steven Liu wrote:
> [...]
> > update:
> >
>
> Please attach a git-format-patch or use git-send-email.
> Also, your mailer is mangling the inlined patch.
>
> >
> > add a FF_OPT_FLAG_DEPRECATED define for compile.
On Fri, Sep 16, 2016 at 12:41:41AM +0800, Steven Liu wrote:
[...]
> update:
>
Please attach a git-format-patch or use git-send-email.
Also, your mailer is mangling the inlined patch.
>
> add a FF_OPT_FLAG_DEPRECATED define for compile.
> add a new variable for user_agent to give a deprecated wa
2016-09-16 0:35 GMT+08:00 Steven Liu :
> ignore it please, i will fix some problem
>
> 2016-09-16 0:30 GMT+08:00 Steven Liu :
>
>>
>>
>> 2016-09-16 0:21 GMT+08:00 Clément Bœsch :
>>
>>> On Fri, Sep 16, 2016 at 12:04:34AM +0800, Steven Liu wrote:
>>> > 2016-09-15 23:42 GMT+08:00 Clément Bœsch :
>>>
ignore it please, i will fix some problem
2016-09-16 0:30 GMT+08:00 Steven Liu :
>
>
> 2016-09-16 0:21 GMT+08:00 Clément Bœsch :
>
>> On Fri, Sep 16, 2016 at 12:04:34AM +0800, Steven Liu wrote:
>> > 2016-09-15 23:42 GMT+08:00 Clément Bœsch :
>> >
>> > > On Thu, Sep 15, 2016 at 05:39:25PM +0200, N
2016-09-16 0:21 GMT+08:00 Clément Bœsch :
> On Fri, Sep 16, 2016 at 12:04:34AM +0800, Steven Liu wrote:
> > 2016-09-15 23:42 GMT+08:00 Clément Bœsch :
> >
> > > On Thu, Sep 15, 2016 at 05:39:25PM +0200, Nicolas George wrote:
> > > > Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit :
> > >
On Fri, Sep 16, 2016 at 12:04:34AM +0800, Steven Liu wrote:
> 2016-09-15 23:42 GMT+08:00 Clément Bœsch :
>
> > On Thu, Sep 15, 2016 at 05:39:25PM +0200, Nicolas George wrote:
> > > Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit :
> > > > Yes, surrounded by the #ifdefery so it will go aw
2016-09-15 18:04 GMT+02:00 Steven Liu :
> are you mean like this?
Imo, this is missing the (only relevant) change to doc/protocols.texi.
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-deve
2016-09-15 23:42 GMT+08:00 Clément Bœsch :
> On Thu, Sep 15, 2016 at 05:39:25PM +0200, Nicolas George wrote:
> > Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit :
> > > Yes, surrounded by the #ifdefery so it will go away with the option.
> > >
> > > Note: use av_strdup() to transfer from
On Thu, Sep 15, 2016 at 05:39:25PM +0200, Nicolas George wrote:
> Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit :
> > Yes, surrounded by the #ifdefery so it will go away with the option.
> >
> > Note: use av_strdup() to transfer from one field to the other
>
> Another possibility woul
Le decadi 30 fructidor, an CCXXIV, Clement Boesch a écrit :
> Yes, surrounded by the #ifdefery so it will go away with the option.
>
> Note: use av_strdup() to transfer from one field to the other
Another possibility would be to implement AV_OPT_FLAG_DEPRECATED and let the
options system itself p
On Thu, Sep 15, 2016 at 11:27:02PM +0800, Steven Liu wrote:
> 2016-09-15 23:03 GMT+08:00 Carl Eugen Hoyos :
>
> > 2016-09-15 16:40 GMT+02:00 Clément Bœsch :
> >
> > >> Carl Eugen's mean is apply this patch after the next release?
> > >
> > > You need to deprecate the option with at least the class
2016-09-15 23:03 GMT+08:00 Carl Eugen Hoyos :
> 2016-09-15 16:40 GMT+02:00 Clément Bœsch :
>
> >> Carl Eugen's mean is apply this patch after the next release?
> >
> > You need to deprecate the option with at least the classic #ifdefery
> dance
> > (git grep FF_API for examples), and ideally by al
2016-09-15 16:40 GMT+02:00 Clément Bœsch :
>> Carl Eugen's mean is apply this patch after the next release?
>
> You need to deprecate the option with at least the classic #ifdefery dance
> (git grep FF_API for examples), and ideally by also printing a warning
> when using the wrong option.
Imo, i
On Thu, Sep 15, 2016 at 10:34:37PM +0800, Steven Liu wrote:
> 2016-09-15 22:22 GMT+08:00 Carl Eugen Hoyos :
>
> > 2016-09-15 16:04 GMT+02:00 Steven Liu :
> > > double user-agent option, same option, remove one.
> >
> > Looking at the documentation, the patch is not ok as-is.
> >
> > I suggest to d
2016-09-15 22:22 GMT+08:00 Carl Eugen Hoyos :
> 2016-09-15 16:04 GMT+02:00 Steven Liu :
> > double user-agent option, same option, remove one.
>
> Looking at the documentation, the patch is not ok as-is.
>
> I suggest to deprecate the option now, and to remove it after
> the next release.
>
> Carl
2016-09-15 22:21 GMT+08:00 Clément Bœsch :
> On Thu, Sep 15, 2016 at 10:04:48PM +0800, Steven Liu wrote:
> > double user-agent option, same option, remove one.
> >
> > Signed-off-by: Steven Liu
> > ---
> > libavformat/http.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/libavform
2016-09-15 16:04 GMT+02:00 Steven Liu :
> double user-agent option, same option, remove one.
Looking at the documentation, the patch is not ok as-is.
I suggest to deprecate the option now, and to remove it after
the next release.
Carl Eugen
___
ffmpeg-
On Thu, Sep 15, 2016 at 10:04:48PM +0800, Steven Liu wrote:
> double user-agent option, same option, remove one.
>
> Signed-off-by: Steven Liu
> ---
> libavformat/http.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libavformat/http.c b/libavformat/http.c
> index adb3d92..f2bfb17 1006
21 matches
Mail list logo
