Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-06-25 Thread James Almer
On 6/25/2019 1:44 PM, Chris Cunningham wrote: > Friendly ping. > > On Thu, Jun 20, 2019 at 11:17 AM Chris Cunningham > wrote: > >> On Thu, Feb 28, 2019 at 9:13 AM James Almer wrote: >> >>> On 2/26/2019 10:18 PM, Chris Cunningham wrote: On Thu, Feb 21, 2019 at 4:46 PM Chris Cunningham

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-06-25 Thread Chris Cunningham
Friendly ping. On Thu, Jun 20, 2019 at 11:17 AM Chris Cunningham wrote: > On Thu, Feb 28, 2019 at 9:13 AM James Almer wrote: > >> On 2/26/2019 10:18 PM, Chris Cunningham wrote: >> > On Thu, Feb 21, 2019 at 4:46 PM Chris Cunningham >> > mailto:chcunning...@chromium.org>> wrote: >> > >> >

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-06-20 Thread Chris Cunningham
On Thu, Feb 28, 2019 at 9:13 AM James Almer wrote: > On 2/26/2019 10:18 PM, Chris Cunningham wrote: > > On Thu, Feb 21, 2019 at 4:46 PM Chris Cunningham > > mailto:chcunning...@chromium.org>> wrote: > > > > I'm fine to do either. James, do you still prefer to skip the later > > headers

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-28 Thread James Almer
On 2/26/2019 10:18 PM, Chris Cunningham wrote: > On Thu, Feb 21, 2019 at 4:46 PM Chris Cunningham > mailto:chcunning...@chromium.org>> wrote: > > I'm fine to do either. James, do you still prefer to skip the later > headers if this breaks some old ogm files? > > > James, friendly pingĀ 

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-26 Thread Chris Cunningham
On Thu, Feb 21, 2019 at 4:46 PM Chris Cunningham wrote: > I'm fine to do either. James, do you still prefer to skip the later > headers if this breaks some old ogm files? > James, friendly ping ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-21 Thread Chris Cunningham
I'm fine to do either. James, do you still prefer to skip the later headers if this breaks some old ogm files? On Sat, Feb 16, 2019 at 4:52 PM Michael Niedermayer wrote: > On Fri, Feb 15, 2019 at 02:56:18PM -0800, Chris Cunningham wrote: > > On Mon, Feb 11, 2019 at 1:55 PM Chris Cunningham < >

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-16 Thread Michael Niedermayer
On Fri, Feb 15, 2019 at 02:56:18PM -0800, Chris Cunningham wrote: > On Mon, Feb 11, 2019 at 1:55 PM Chris Cunningham > wrote: > > > On Fri, Feb 8, 2019 at 2:37 PM Michael Niedermayer > > wrote: > > > >> ogg allows chaining streams when they have differing serial numbers > >>

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-15 Thread Chris Cunningham
On Mon, Feb 11, 2019 at 1:55 PM Chris Cunningham wrote: > On Fri, Feb 8, 2019 at 2:37 PM Michael Niedermayer > wrote: > >> ogg allows chaining streams when they have differing serial numbers >> https://xiph.org/ogg/doc/oggstream.html >> >> i think ive seen actual files doing this >> >>

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-11 Thread Chris Cunningham
On Fri, Feb 8, 2019 at 2:37 PM Michael Niedermayer wrote: > ogg allows chaining streams when they have differing serial numbers > https://xiph.org/ogg/doc/oggstream.html > > i think ive seen actual files doing this > > ogg_replace_stream() might assign these into existing avstreams i think > If

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Michael Niedermayer
On Fri, Feb 08, 2019 at 05:07:03PM -0300, James Almer wrote: > On 2/8/2019 12:17 AM, Chris Cunningham wrote: > > On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: > > > >> Can a valid ogm stream contain more than one header packet? > > > > > > Looking at ogg_packet oggdec.c, we read headers

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread James Almer
On 2/8/2019 5:51 PM, Carl Eugen Hoyos wrote: > 2019-02-08 21:07 GMT+01:00, James Almer : >> On 2/8/2019 12:17 AM, Chris Cunningham wrote: >>> On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: >>> Can a valid ogm stream contain more than one header packet? >>> >>> >>> Looking at ogg_packet

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Carl Eugen Hoyos
2019-02-08 21:07 GMT+01:00, James Almer : > On 2/8/2019 12:17 AM, Chris Cunningham wrote: >> On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: >> >>> Can a valid ogm stream contain more than one header packet? >> >> >> Looking at ogg_packet oggdec.c, we read headers until hitting the first >>

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread James Almer
On 2/8/2019 12:17 AM, Chris Cunningham wrote: > On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: > >> Can a valid ogm stream contain more than one header packet? > > > Looking at ogg_packet oggdec.c, we read headers until hitting the first > non-header (counted in ogg stream field

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Chris Cunningham
I'll re-send with my full name. On Fri, Feb 8, 2019 at 4:57 AM Michael Niedermayer wrote: > Hi > > On Wed, Feb 06, 2019 at 05:13:03PM -0800, chcunningham wrote: > > From: chcunningham > > Is the name intended ? As this ends up as author name in git, and several > developers dislike this: >

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-08 Thread Michael Niedermayer
Hi On Wed, Feb 06, 2019 at 05:13:03PM -0800, chcunningham wrote: > From: chcunningham Is the name intended ? As this ends up as author name in git, and several developers dislike this: (and i cannot edit other authors names of course, that would be not right) (from IRC) Could you stop

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-07 Thread Chris Cunningham
On Wed, Feb 6, 2019 at 6:03 PM James Almer wrote: > Can a valid ogm stream contain more than one header packet? Looking at ogg_packet oggdec.c, we read headers until hitting the first non-header (counted in ogg stream field nb_headers), so multiple headers per stream is probably ok. But

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-06 Thread James Almer
On 2/6/2019 10:13 PM, chcunningham wrote: > Codec information may change while reading ogg packets. Update the > stream's internal avctx to match. > --- > libavformat/oggparseogm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/oggparseogm.c b/libavformat/oggparseogm.c >

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-02-06 Thread Chris Cunningham
This is a follow up to feedback in http://ffmpeg.org/pipermail/ffmpeg-devel/2019-February/239751.html On Wed, Feb 6, 2019 at 5:13 PM chcunningham wrote: > Codec information may change while reading ogg packets. Update the > stream's internal avctx to match. > --- > libavformat/oggparseogm.c |