Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-27 Thread Uoti Urpala
On Mon, 2019-01-28 at 00:04 +0100, Henrik Gramner wrote: > On Mon, Jan 21, 2019 at 9:54 PM James Almer wrote: > > There's also no good way to deprecate a define and replace it with > > another while informing the library user, so for something purely > > cosmetic like this i don't think it's

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-27 Thread Henrik Gramner
On Mon, Jan 21, 2019 at 9:54 PM James Almer wrote: > There's also no good way to deprecate a define and replace it with > another while informing the library user, so for something purely > cosmetic like this i don't think it's worth the trouble. Would it be possible to create a deprecated

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-26 Thread Peter Ross
On Sat, Jan 26, 2019 at 02:46:59PM -0500, FeRD wrote: > On Tue, Jan 22, 2019 at 8:15 AM Moritz Barsnick wrote: > > > On Mon, Jan 21, 2019 at 21:32:46 -0500, FeRD wrote: > > > Well... not *purely* cosmetic. See [1] for an example of one issue. > > Ruby's > > > > > `ruby/config.h` header also

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-26 Thread FeRD
On Tue, Jan 22, 2019 at 8:15 AM Moritz Barsnick wrote: > On Mon, Jan 21, 2019 at 21:32:46 -0500, FeRD wrote: > > Well... not *purely* cosmetic. See [1] for an example of one issue. > Ruby's > > > `ruby/config.h` header also defines an `RSHIFT` macro, with different > > semantics (it doesn't

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-22 Thread Moritz Barsnick
On Mon, Jan 21, 2019 at 21:32:46 -0500, FeRD wrote: > Well... not *purely* cosmetic. See [1] for an example of one issue. Ruby's > `ruby/config.h` header also defines an `RSHIFT` macro, with different > semantics (it doesn't round), so when building code which includes > both headers the macro

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-22 Thread Carl Eugen Hoyos
2019-01-22 12:03 GMT+01:00, Hendrik Leppkes : > On Tue, Jan 22, 2019 at 11:58 AM Carl Eugen Hoyos > wrote: >> >> 2019-01-21 21:47 GMT+01:00, James Almer : >> > On 1/21/2019 4:09 PM, FeRD (Frank Dana) wrote: >> >> The RSHIFT macro in libavutil/common.h does not actually perform >> >> a bitwise

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-22 Thread Hendrik Leppkes
On Tue, Jan 22, 2019 at 11:58 AM Carl Eugen Hoyos wrote: > > 2019-01-21 21:47 GMT+01:00, James Almer : > > On 1/21/2019 4:09 PM, FeRD (Frank Dana) wrote: > >> The RSHIFT macro in libavutil/common.h does not actually perform > >> a bitwise right-shift, but rather a rounded version of the same > >>

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-22 Thread Carl Eugen Hoyos
2019-01-21 21:47 GMT+01:00, James Almer : > On 1/21/2019 4:09 PM, FeRD (Frank Dana) wrote: >> The RSHIFT macro in libavutil/common.h does not actually perform >> a bitwise right-shift, but rather a rounded version of the same >> operation, as is noted by a comment above the macro. The rounded >>

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-21 Thread FeRD
On Mon, Jan 21, 2019 at 3:54 PM James Almer wrote: > On 1/21/2019 4:09 PM, FeRD (Frank Dana) wrote: > > diff --git a/libavutil/common.h b/libavutil/common.h > > index 8db0291170..0bff7f8f72 100644 > > --- a/libavutil/common.h > > +++ b/libavutil/common.h > > @@ -51,7 +51,7 @@ > > #endif > > > >

Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-21 Thread James Almer
On 1/21/2019 4:09 PM, FeRD (Frank Dana) wrote: > The RSHIFT macro in libavutil/common.h does not actually perform > a bitwise right-shift, but rather a rounded version of the same > operation, as is noted by a comment above the macro. The rounded > divsion macro on the very next line is named