Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-10-02 Thread Urvang Joshi
Hi, Max value for both the tile rows and tile columns is 64 (so the max log2 value would be 6). This is consistent in the public header: https://aomedia.googlesource.com/aom/+/master/aom/aomcx.h#291 and spec: https://aomediacodec.github.io/av1-spec/av1-spec.pdf (see page 7). On Fri, Aug 31, 2018

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-08-31 Thread James Zern
On Fri, Aug 31, 2018 at 9:40 AM James Almer wrote: > > On 8/31/2018 1:00 PM, Kagami Hiiragi wrote: > > On 31/08/18 18:18, James Almer wrote: > >> On 8/31/2018 11:52 AM, Kagami Hiiragi wrote: > >>> On 31/08/18 02:58, James Almer wrote: > On 8/20/2018 2:56 PM, Kagami Hiiragi wrote: > >

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-08-31 Thread James Almer
On 8/31/2018 1:00 PM, Kagami Hiiragi wrote: > On 31/08/18 18:18, James Almer wrote: >> On 8/31/2018 11:52 AM, Kagami Hiiragi wrote: >>> On 31/08/18 02:58, James Almer wrote: On 8/20/2018 2:56 PM, Kagami Hiiragi wrote: > These options are required for multithreaded encoding, because they

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-08-31 Thread Kagami Hiiragi
On 31/08/18 18:18, James Almer wrote: > On 8/31/2018 11:52 AM, Kagami Hiiragi wrote: >> On 31/08/18 02:58, James Almer wrote: >>> On 8/20/2018 2:56 PM, Kagami Hiiragi wrote: These options are required for multithreaded encoding, because they set to zero by default in av1_cx_iface.c.

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-08-31 Thread Derek Buitenhuis
On 31/08/2018 16:18, James Almer wrote: > The doxy in the public header: > https://aomedia.googlesource.com/aom/+/master/aom/aomcx.h#312 > > One shouldn't have to look at source code when there's documentation for > public API, but since the latter is apparently wrong... If it's like this, at

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-08-31 Thread James Almer
On 8/31/2018 11:52 AM, Kagami Hiiragi wrote: > On 31/08/18 02:58, James Almer wrote: >> On 8/20/2018 2:56 PM, Kagami Hiiragi wrote: >>> These options are required for multithreaded encoding, because they set >>> to zero by default in av1_cx_iface.c. >>> >>> Signed-off-by: Kagami Hiiragi >>> >>>

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-08-31 Thread Kagami Hiiragi
On 31/08/18 02:58, James Almer wrote: > On 8/20/2018 2:56 PM, Kagami Hiiragi wrote: >> These options are required for multithreaded encoding, because they set >> to zero by default in av1_cx_iface.c. >> >> Signed-off-by: Kagami Hiiragi >> >> diff --git a/libavcodec/libaomenc.c

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-08-30 Thread James Almer
On 8/20/2018 2:56 PM, Kagami Hiiragi wrote: > These options are required for multithreaded encoding, because they set > to zero by default in av1_cx_iface.c. > > Signed-off-by: Kagami Hiiragi > > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > index 9431179886..55cb7ff72e 100644