Re: [FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf.c The libvmaf filter tried to join on an invalid thread id

On 5/3/2018 8:38 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, May 3, 2018 at 4:41 AM, Kevin Wheatley > wrote: > >> Following up my own email with another question or so: >> >> Could somebody point me at a suitable method of testing this within >> the Fate framework?

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf.c The libvmaf filter tried to join on an invalid thread id

On Thu, May 3, 2018 at 12:38 PM, Ronald S. Bultje wrote: > Why? > > Your patch fixes a bug, I don't think we test bugs in fate, just features. I am perhaps making an incorrect assumption that the code has a bug because it is never tested and that by adding a test that simply

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf.c The libvmaf filter tried to join on an invalid thread id

Hi, On Thu, May 3, 2018 at 4:41 AM, Kevin Wheatley wrote: > Following up my own email with another question or so: > > Could somebody point me at a suitable method of testing this within > the Fate framework? Why? Your patch fixes a bug, I don't think we test bugs

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf.c The libvmaf filter tried to join on an invalid thread id

Following up my own email with another question or so: Could somebody point me at a suitable method of testing this within the Fate framework? I've started to try unpick how the fate tests are run, etc What I need is a prototypical example which presumably would need to factor in (what I