Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2021-05-31 Thread Anton Khirnov
Quoting James Almer (2021-05-24 19:20:19) > On 7/7/2019 5:15 PM, Michael Niedermayer wrote: > > On Fri, Jun 21, 2019 at 07:15:17AM -0700, Amir Pauker wrote: > >> set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is > >> set > >> after the call to

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2021-05-24 Thread James Almer
On 7/7/2019 5:15 PM, Michael Niedermayer wrote: On Fri, Jun 21, 2019 at 07:15:17AM -0700, Amir Pauker wrote: set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set after the call to ff_h264_execute_decode_slices. This allows the user to detect concealed decoding errors in

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-07-08 Thread Amir Z
Thanks On Sun, Jul 7, 2019 at 3:38 PM Michael Niedermayer wrote: > On Fri, Jun 21, 2019 at 07:15:17AM -0700, Amir Pauker wrote: > > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred > is set > > after the call to ff_h264_execute_decode_slices. This allows the user to >

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-07-07 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 07:15:17AM -0700, Amir Pauker wrote: > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set > after the call to ff_h264_execute_decode_slices. This allows the user to > detect > concealed decoding errors in the call to avcodec_receive_frame > >

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-07-06 Thread Amir Z
Michael hey, Could you please apply this patch as well. Thanks On Fri, Jun 21, 2019 at 9:15 AM Amir Pauker wrote: > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is > set > after the call to ff_h264_execute_decode_slices. This allows the user to > detect > concealed

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-14 Thread Amir Z
thanks Moritz i submitted two new patches On Fri, Jun 14, 2019 at 2:43 AM Moritz Barsnick wrote: > On Thu, Jun 13, 2019 at 08:52:22 -0700, Amir Pauker wrote: > > doc/APIchanges | 3 +++ > > libavcodec/h264dec.c | 5 + > > libavutil/frame.h| 1 + > > libavutil/version.h | 2 +-

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-14 Thread Moritz Barsnick
On Thu, Jun 13, 2019 at 08:52:22 -0700, Amir Pauker wrote: > doc/APIchanges | 3 +++ > libavcodec/h264dec.c | 5 + > libavutil/frame.h| 1 + > libavutil/version.h | 2 +- You should split the introduction of the API (libavutil and doc) and the use of the API (libavcodec) into two

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-12 Thread Amir Z
thanks, I will submit a new patch with the requested changes On Wed, Jun 12, 2019 at 3:00 PM Marton Balint wrote: > > > On Wed, 12 Jun 2019, Michael Niedermayer wrote: > > > On Wed, Jun 12, 2019 at 10:09:08AM +0200, Marton Balint wrote: > >> > >> > >> On Wed, 12 Jun 2019, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-12 Thread Marton Balint
On Wed, 12 Jun 2019, Michael Niedermayer wrote: On Wed, Jun 12, 2019 at 10:09:08AM +0200, Marton Balint wrote: On Wed, 12 Jun 2019, Michael Niedermayer wrote: On Tue, Jun 11, 2019 at 03:21:41PM -0500, Amir Z wrote: Thanks Michael Niedermayer for looking into this What I am trying to

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-12 Thread Amir Z
FF_DECODE_ERROR_CONCEALMENT_ACTIVE sounds right for the case that the ret variable is set to zero (i.e. indicate the fact that there was an error and it is concealed) ret = ff_h264_execute_decode_slices(h); if (ret < 0 && (h->avctx->err_recognition & AV_EF_EXPLODE)) goto end;

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-12 Thread Michael Niedermayer
On Wed, Jun 12, 2019 at 10:09:08AM +0200, Marton Balint wrote: > > > On Wed, 12 Jun 2019, Michael Niedermayer wrote: > > >On Tue, Jun 11, 2019 at 03:21:41PM -0500, Amir Z wrote: > >>Thanks Michael Niedermayer for looking into this > >> > >>What I am trying to solve is having a way to detect

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-12 Thread Marton Balint
On Wed, 12 Jun 2019, Michael Niedermayer wrote: On Tue, Jun 11, 2019 at 03:21:41PM -0500, Amir Z wrote: Thanks Michael Niedermayer for looking into this What I am trying to solve is having a way to detect concealed decoding errors by the caller to avcodec_receive_frame. Should I add a

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-12 Thread Michael Niedermayer
On Tue, Jun 11, 2019 at 03:21:41PM -0500, Amir Z wrote: > Thanks Michael Niedermayer for looking into this > > What I am trying to solve is having a way to detect concealed decoding > errors by the caller to avcodec_receive_frame. > > Should I add a general value e.g. #define >

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-11 Thread Amir Z
Thanks Michael Niedermayer for looking into this What I am trying to solve is having a way to detect concealed decoding errors by the caller to avcodec_receive_frame. Should I add a general value e.g. #define FF_DECODE_ERROR_DECODE_ERROR_OCCURRED 4 ? Thanks Amir On Tue, Jun 11, 2019 at 11:39

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-11 Thread Michael Niedermayer
On Sun, Jun 09, 2019 at 10:45:13PM -0700, Amir Pauker wrote: > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set > after the call to ff_h264_execute_decode_slices. This allows the user to > detect > concealed decoding errors in the call to avcodec_receive_frame > >

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread Amir Z
Sounds good, thanks I will submit a new patch On Sun, Jun 9, 2019 at 10:53 PM James Almer wrote: > On 6/10/2019 12:32 AM, Amir Z wrote: > > As far as I can tell FF_DECODE_ERROR_MISSING_REFERENCE is not used > > anywhere. > > > > Since the new flag DECODE_ERROR covers also missing reference

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread James Almer
On 6/10/2019 12:32 AM, Amir Z wrote: > As far as I can tell FF_DECODE_ERROR_MISSING_REFERENCE is not used > anywhere. > > Since the new flag DECODE_ERROR covers also missing reference case i > thought it will be more appropriate to replace it instead of adding a new > enum value. Removing a

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread Amir Z
As far as I can tell FF_DECODE_ERROR_MISSING_REFERENCE is not used anywhere. Since the new flag DECODE_ERROR covers also missing reference case i thought it will be more appropriate to replace it instead of adding a new enum value. Thanks On Sun, Jun 9, 2019 at 10:15 PM James Almer wrote:

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread James Almer
On 6/10/2019 12:03 AM, Amir Pauker wrote: > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set > after the call to ff_h264_execute_decode_slices. This allows the user to > detect > concealed decoding errors in the call to avcodec_receive_frame > > Signed-off-by: Amir