Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-07 Thread Michael Niedermayer
On Tue, Aug 05, 2014 at 09:59:13PM +0200, Carl Eugen Hoyos wrote: On Friday 01 August 2014 10:04:17 am Clément Bœsch wrote: On Fri, Aug 01, 2014 at 01:54:57AM +0200, Carl Eugen Hoyos wrote: When transcoding an input file with subtitles to mkv, ffmpeg by default tries to encode the

Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-07 Thread Carl Eugen Hoyos
Michael Niedermayer michaelni at gmx.at writes: should be ok Please merge from github. but why does dvb teletext not have a TEXT/BITMAP prop ? I believe this would break avcodec_decode_subtitle2() which sets the format depending on the properties. This should be fixed but I don't know the

Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-07 Thread Michael Niedermayer
On Thu, Aug 07, 2014 at 11:22:22AM +, Carl Eugen Hoyos wrote: Michael Niedermayer michaelni at gmx.at writes: should be ok Please merge from github. merged thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level

Re: [FFmpeg-devel] [PATCH]Do not select a default subtitle output stream with incorrect subtitle type

2014-08-01 Thread Clément Bœsch
On Fri, Aug 01, 2014 at 01:54:57AM +0200, Carl Eugen Hoyos wrote: Hi! When transcoding an input file with subtitles to mkv, ffmpeg by default tries to encode the subtitles even if the input contains bitmap subtitles. Attached patch should fix this issue reported in ticket #3819 (and before