Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2017-04-18 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 11:16:48AM +0200, Michael Niedermayer wrote: > On Tue, Oct 11, 2016 at 10:06:54AM +0200, Carl Eugen Hoyos wrote: > > 2016-09-05 11:12 GMT+02:00 Carl Eugen Hoyos : > > > 2016-09-05 10:26 GMT+02:00 Paul B Mahol : > > >> On 9/5/16, Carl Eugen Hoyos wrote: > > > > > >>> New pat

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2016-10-11 Thread Michael Niedermayer
On Tue, Oct 11, 2016 at 10:06:54AM +0200, Carl Eugen Hoyos wrote: > 2016-09-05 11:12 GMT+02:00 Carl Eugen Hoyos : > > 2016-09-05 10:26 GMT+02:00 Paul B Mahol : > >> On 9/5/16, Carl Eugen Hoyos wrote: > > > >>> New patch attached. > >> > >> It seems this patch disables check for all cases when expe

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2016-10-11 Thread Carl Eugen Hoyos
2016-09-05 11:12 GMT+02:00 Carl Eugen Hoyos : > 2016-09-05 10:26 GMT+02:00 Paul B Mahol : >> On 9/5/16, Carl Eugen Hoyos wrote: > >>> New patch attached. >> >> It seems this patch disables check for all cases when experimental is >> enabled, >> but check for overflow in only one case. > > I am no

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2016-09-05 Thread Carl Eugen Hoyos
2016-09-05 10:26 GMT+02:00 Paul B Mahol : > On 9/5/16, Carl Eugen Hoyos wrote: >> New patch attached. > > It seems this patch disables check for all cases when experimental is enabled, > but check for overflow in only one case. I am not sure I understand: Do you mean I missed a case where an ove

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2016-09-05 Thread Paul B Mahol
On 9/5/16, Carl Eugen Hoyos wrote: > 2016-09-05 9:21 GMT+02:00 Michael Niedermayer : >> On Sun, Sep 04, 2016 at 08:58:44PM +0200, Carl Eugen Hoyos wrote: > >>> @@ -159,6 +163,8 @@ static int pnm_decode_frame(AVCodecContext *avctx, >>> void *data, >>> } >>> }else{ >>>

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2016-09-05 Thread Carl Eugen Hoyos
2016-09-05 9:21 GMT+02:00 Michael Niedermayer : > On Sun, Sep 04, 2016 at 08:58:44PM +0200, Carl Eugen Hoyos wrote: >> @@ -159,6 +163,8 @@ static int pnm_decode_frame(AVCodecContext *avctx, void >> *data, >> } >> }else{ >> for (i = 0; i < avctx->height; i++) { >> +

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Do not fail by default for truncated pbm files

2016-09-05 Thread Michael Niedermayer
On Sun, Sep 04, 2016 at 08:58:44PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Some scanner - scannersoftware combination (HP_Officejet_Pro_X476dn_MFP > - sane) truncates trailing zeros in pbm files and FreeImage (a library > used in free and proprietary image software) reads such files. > Attached