Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-20 Thread Nicolas George
Le tridi 23 thermidor, an CCXXV, Marton Balint a écrit : > I suggest you push the patch series without this patch, Michael can fix the > overlay and blend/tblend parameter order. If later the needed additional > compatibility code becomes too much of a burden, we can discuss this > further. I will

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Alexander Strasser
Hi all, sorry for jumping into the discussion late. I think it is very important though. Please pardon me if I missed anything from the previous discussions on this topic. On 2017-08-11 23:34 +0200, Nicolas George wrote: > Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : [...] > >

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > That looks like it has a marginal effect in this particular case. I'd I would not have proposed something worse. > agree with just documenting it in the Changelog and still not making it > "the rule" (that is, NAK on the doc patch). A

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Clément Bœsch
On Fri, Aug 11, 2017 at 12:33:25PM +0200, Nicolas George wrote: > Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > > I'm afraid of the situation where a developer will feel like the order of > > the options is not ideal, or an option could be renamed for consistency > > with other fil

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > I'm afraid of the situation where a developer will feel like the order of > the options is not ideal, or an option could be renamed for consistency > with other filters, and will take the easy way out "oh well, we documented > it's unst

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Clément Bœsch
On Fri, Aug 11, 2017 at 11:12:32AM +0200, Nicolas George wrote: > Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > > I'd rather make such changes justified and documented as exceptional in > > the Changelog (or in APIchanges) when we can't get around it cleanly, than > > documenting a

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Clement Boesch a écrit : > I'd rather make such changes justified and documented as exceptional in > the Changelog (or in APIchanges) when we can't get around it cleanly, than > documenting a free for all area. > > You're saying documenting the risk or potential

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Clément Bœsch
On Thu, Aug 10, 2017 at 01:46:27PM +0200, Nicolas George wrote: > It does not mean that we intend to break the order of options > at a whim, but it gives us more freedom to make necessary > changes without extra unnecessary burden while giving stability > to users that require it. [...] I'd rather

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Paul B Mahol a écrit : > What about keeping old options intact? That requires glue code and more importantly testing. I do not intend to do it, and it blocks progress. Regards, -- Nicolas George ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le tridi 23 thermidor, an CCXXV, Marton Balint a écrit : > I suggest you push the patch series without this patch, Michael can fix the > overlay and blend/tblend parameter order. If later the needed additional > compatibility code becomes too much of a burden, we can discuss this > further. I coul

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Nicolas George
Le quartidi 24 thermidor, an CCXXV, Michael Niedermayer a écrit : > First, I dont think a single developer should declare a whole class of > interfaces spaning the areas other developers work on unstable against > one or more objections from them. Or if one has that right then everyone > else shoul

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-11 Thread Paul B Mahol
On 8/11/17, Michael Niedermayer wrote: > On Thu, Aug 10, 2017 at 04:15:55PM +0200, Nicolas George wrote: >> Le tridi 23 thermidor, an CCXXV, Michael Niedermayer a écrit : >> > Please limit the notes in filters.texi and Changelog to the filters and >> > options you intend to change. >> >> That woul

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-10 Thread Michael Niedermayer
On Thu, Aug 10, 2017 at 04:15:55PM +0200, Nicolas George wrote: > Le tridi 23 thermidor, an CCXXV, Michael Niedermayer a écrit : > > Please limit the notes in filters.texi and Changelog to the filters and > > options you intend to change. > > That would defeat the purpose. Doubly so: > > - Being

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-10 Thread Marton Balint
On Thu, 10 Aug 2017, Nicolas George wrote: Le tridi 23 thermidor, an CCXXV, Michael Niedermayer a écrit : Please limit the notes in filters.texi and Changelog to the filters and options you intend to change. That would defeat the purpose. Doubly so: - Being free to change the options as nee

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-10 Thread Nicolas George
Le tridi 23 thermidor, an CCXXV, Michael Niedermayer a écrit : > Please limit the notes in filters.texi and Changelog to the filters and > options you intend to change. That would defeat the purpose. Doubly so: - Being free to change the options as need requires. That means any filter and any o

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-10 Thread Michael Niedermayer
On Thu, Aug 10, 2017 at 01:46:27PM +0200, Nicolas George wrote: > It does not mean that we intend to break the order of options > at a whim, but it gives us more freedom to make necessary > changes without extra unnecessary burden while giving stability > to users that require it. > > Signed-off-b