Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-24 Thread Baptiste Coudurier
Hi Michael, I hope you are doing well, > On Apr 16, 2019, at 4:03 PM, Michael Niedermayer > wrote: > > Signed PGP part > On Wed, Apr 10, 2019 at 06:54:53PM -0300, James Almer wrote: >> On 4/10/2019 6:26 PM, Baptiste Coudurier wrote: On Apr 9, 2019, at 6:27 PM, James Almer wrote:

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-16 Thread Michael Niedermayer
On Wed, Apr 10, 2019 at 06:54:53PM -0300, James Almer wrote: > On 4/10/2019 6:26 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at 6:27 PM, James Almer wrote: > >> > >> On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: > >>> > On Apr 9, 2019, at 5:24 PM, James Almer wrote: > > On

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread James Almer
On 4/10/2019 6:26 PM, Baptiste Coudurier wrote: >> On Apr 9, 2019, at 6:27 PM, James Almer wrote: >> >> On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: >>> On Apr 9, 2019, at 5:24 PM, James Almer wrote: On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread Baptiste Coudurier
> On Apr 9, 2019, at 6:27 PM, James Almer wrote: > > On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: >> >>> On Apr 9, 2019, at 5:24 PM, James Almer wrote: >>> >>> On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: > On Apr 9, 2019, at 4:51 PM, James Almer wrote: > > On 4/9/2019

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread James Almer
On 4/10/2019 2:22 AM, Hendrik Leppkes wrote: > On Wed, Apr 10, 2019 at 3:28 AM James Almer wrote: >>> Two thirds of SPS is not hard to implement, so i really don't understand why you're so adamantly against it. >>> >>> I’m adamant about re-using code between libavcodec and libavformat.

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread Carl Eugen Hoyos
2019-04-10 2:40 GMT+02:00, Baptiste Coudurier : > >> On Apr 9, 2019, at 5:24 PM, James Almer wrote: >> More than one ffmpeg release will ship with libavcodec/libavformat >> sharing the same soname. Backwards compatibility is expected, hence the >> split between major, minor and micro, as you're

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-10 Thread Thomas Mundt
Hi Baptiste, Am Mi., 10. Apr. 2019 um 00:29 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > Hi Thomas, I hope you are doing well > > > On Apr 4, 2019, at 7:27 AM, Thomas Mundt wrote: > > > > Hi Baptiste, > > > > […] > > For RP2027 Class 100 1080/50i I still get the error:

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Hendrik Leppkes
On Wed, Apr 10, 2019 at 3:28 AM James Almer wrote: > > > >> Two thirds of SPS is not hard to implement, so i really don't understand > >> why you're so adamantly against it. > > > > I’m adamant about re-using code between libavcodec and libavformat. > > Re-using code is _good_ > > So lets do what

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread James Almer
On 4/9/2019 9:40 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at 5:24 PM, James Almer wrote: >> >> On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: >>> On Apr 9, 2019, at 4:51 PM, James Almer wrote: On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: > Hi James, > >>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
> On Apr 9, 2019, at 5:24 PM, James Almer wrote: > > On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: >> >>> On Apr 9, 2019, at 4:51 PM, James Almer wrote: >>> >>> On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: Hi James, > On Apr 9, 2019, at 4:09 PM, James Almer wrote: >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread James Almer
On 4/9/2019 8:59 PM, Baptiste Coudurier wrote: > >> On Apr 9, 2019, at 4:51 PM, James Almer wrote: >> >> On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: >>> Hi James, >>> On Apr 9, 2019, at 4:09 PM, James Almer wrote: > […] Ok so, the only fields you need from the sps are

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
> On Apr 9, 2019, at 4:51 PM, James Almer wrote: > > On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: >> Hi James, >> >>> On Apr 9, 2019, at 4:09 PM, James Almer wrote: >>> […] >>> >>> Ok so, the only fields you need from the sps are constraint_set_flags, >>> frame_mbs_only_flag,

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread James Almer
On 4/9/2019 8:22 PM, Baptiste Coudurier wrote: > Hi James, > >> On Apr 9, 2019, at 4:09 PM, James Almer wrote: >> >>> […] >> >> Ok so, the only fields you need from the sps are constraint_set_flags, >> frame_mbs_only_flag, bit_depth_luma, profile_idc, level_idc and sar, >> meaning you don't even

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
> On Apr 9, 2019, at 4:05 PM, Hendrik Leppkes wrote: > > On Wed, Apr 10, 2019 at 12:21 AM Baptiste Coudurier > wrote: >> +return 0; >> +} >> +init_get_bits(, tmp, tmp_size*8); >> +ret = avpriv_h264_decode_seq_parameter_set(, >>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
Hi James, > On Apr 9, 2019, at 4:09 PM, James Almer wrote: > >> […] > > Ok so, the only fields you need from the sps are constraint_set_flags, > frame_mbs_only_flag, bit_depth_luma, profile_idc, level_idc and sar, > meaning you don't even need to parse the sps until the very end (sar is > the

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread James Almer
On 4/9/2019 7:14 PM, Baptiste Coudurier wrote: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 32 +++ > libavformat/avc.h| 2 + > libavformat/hevc.c | 36 +--- > libavformat/mxf.h| 1 + > libavformat/mxfenc.c | 201

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Hendrik Leppkes
On Wed, Apr 10, 2019 at 12:21 AM Baptiste Coudurier wrote: > +return 0; > +} > +init_get_bits(, tmp, tmp_size*8); > +ret = avpriv_h264_decode_seq_parameter_set(, > (AVCodecContext*)s, , 0); The AVCodecContext cast looks like a recipe for

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-09 Thread Baptiste Coudurier
Hi Thomas, I hope you are doing well > On Apr 4, 2019, at 7:27 AM, Thomas Mundt wrote: > > Hi Baptiste, > > […] > For RP2027 Class 100 1080/50i I still get the error: frame size does not > match index unit size, 568832 != 0 > I used the following command: > ffmpeg -f lavfi -i

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mxfenc: support XAVC long gop

2019-04-04 Thread Thomas Mundt
Hi Baptiste, Am Mi., 3. Apr. 2019 um 11:23 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > --- > libavformat/mxf.h| 1 + > libavformat/mxfenc.c | 197 --- > 2 files changed, 147 insertions(+), 51 deletions(-) > > diff --git