Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-24 Thread Tomas Härdin
ons 2018-02-14 klockan 10:20 +0100 skrev Tomas Härdin: > tis 2018-02-13 klockan 11:48 +0100 skrev Tomas Härdin: > > fre 2018-02-09 klockan 11:29 +0100 skrev Carl Eugen Hoyos: > > > 2018-01-15 22:36 GMT+01:00 Tomas Härdin : > > > > > > > > +if (p->buf[4] >  

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-14 Thread Tomas Härdin
tis 2018-02-13 klockan 11:48 +0100 skrev Tomas Härdin: > fre 2018-02-09 klockan 11:29 +0100 skrev Carl Eugen Hoyos: > > 2018-01-15 22:36 GMT+01:00 Tomas Härdin : > > > > > > +if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -= > > > > AVPROBE_SCORE_MAX/5; > > > > +

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-13 Thread Tomas Härdin
fre 2018-02-09 klockan 11:29 +0100 skrev Carl Eugen Hoyos: > 2018-01-15 22:36 GMT+01:00 Tomas Härdin : > > > > +if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -= > > > AVPROBE_SCORE_MAX/5; > > > +if (p->buf[5] >  AVPRIV_CODEC2_MODE_MAX)score -= > > >

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-09 Thread Tomas Härdin
On 2018-02-09 11:29, Carl Eugen Hoyos wrote: 2018-01-15 22:36 GMT+01:00 Tomas Härdin : +if (p->buf[4] > EXPECTED_CODEC2_MINOR_VERSION) score -= AVPROBE_SCORE_MAX/5; +if (p->buf[5] > AVPRIV_CODEC2_MODE_MAX)score -= AVPROBE_SCORE_MAX/5; +if (p->buf[6] !=

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-09 Thread Carl Eugen Hoyos
2018-01-15 22:36 GMT+01:00 Tomas Härdin : >> +if (p->buf[4] > EXPECTED_CODEC2_MINOR_VERSION) score -= >> AVPROBE_SCORE_MAX/5; >> +if (p->buf[5] > AVPRIV_CODEC2_MODE_MAX)score -= >> AVPROBE_SCORE_MAX/5; >> +if (p->buf[6] != 0)

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-09 Thread Tomas Härdin
Ping? I'd maintain this of course. Plus I'd like to add some tests, but I need to know if this looks OK to everyone first /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-01-15 Thread Tomas Härdin
fre 2018-01-12 klockan 21:21 +0100 skrev Michael Niedermayer: > On Sat, Dec 23, 2017 at 11:15:35PM +0100, Tomas Härdin wrote: > > > > [...] > > +static int codec2_read_header_common(AVFormatContext *s, AVStream *st) > > +{ > > +int mode =

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-01-14 Thread Carl Eugen Hoyos
2017-12-23 23:15 GMT+01:00 Tomas Härdin : > +//check for 0xC0DEC2, return non-zero if it doesn't match > +static int check_magic(uint8_t *ptr) { > +return memcmp(ptr, avpriv_codec2_magic, 3); AV_RB24(), or do I miss something? > +static int codec2_probe(AVProbeData *p)

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-01-12 Thread Michael Niedermayer
On Sat, Dec 23, 2017 at 11:15:35PM +0100, Tomas Härdin wrote: > [...] > +static int codec2_read_header_common(AVFormatContext *s, AVStream *st) > +{ > +int mode = avpriv_codec2_mode_from_extradata(st->codecpar->extradata); > + > +st->codecpar->codec_type= AVMEDIA_TYPE_AUDIO; > +